summaryrefslogtreecommitdiff
path: root/source3/libsmb
AgeCommit message (Collapse)AuthorFilesLines
2009-01-26Decouple clistr_pull from struct cli_state->inbufVolker Lendecke7-32/+49
2009-01-25Fix an error path memleakVolker Lendecke1-0/+1
2009-01-25Make smb_bytes_push_str deal with a NULL buf returning NULLVolker Lendecke1-1/+6
2009-01-21Memory leaks and other fixes found by Coveritytodd stecher1-5/+5
2009-01-18Add a macro async_req_setup()Volker Lendecke1-25/+9
This streamlines setting up a multi-step async request a bit
2009-01-17Determine case sensitivity based on file system attributes.Derrell Lipman3-11/+78
- Most of the time, we can determine from the file system we're connecting to whether it supports case sensitivity. In those cases, we now set the internal case sensitivity flag automatically. For those cases where the request to retrieve file system attributes fails, we'll use the user-specified option value. Derrell
2009-01-16[Bug 6022] smbc_urlencode and smbc_urldecode were not exportedDerrell Lipman2-5/+5
- Since the revamp of libsmbclient, there has still been an external declaration for smbc_urlencode and smbc_urldecode in libsmbclient.h, yet those functions were renamed and made private. The two choices were to remove the function names from libsmbclient.h or to make them public again. The reported requested that they be public. This commit makes it so. Derrell
2009-01-16Treat file names in POSIX-like case-sensitive fashion by defaultDerrell Lipman3-0/+22
*** THIS COMMIT CAUSES A CHANGE OF DEFAULT BEHAVIOR IN libsmbclient!!! *** - libsmbclient now calls cli_set_case_sensitive() for a new CLI. By default, it requests case-sensitive, but the old behavior of case-insensitive can be requested with smbc_setOptionCaseSensitive(context, False); The change of behavior is considered a bug fix, as it was previously possible to accidentally overwrite a file that had the same case-insensitive name but a different case-sensitive name as a previously-existing file, while creating a new file. Derrell
2009-01-16Fix a segfault if ? is there but the options are NULL. This is the case if ↵Andreas Schneider1-1/+1
SMBC_parse_path is called by SMBC_stat_ctx.
2009-01-16s3: put netsamlogon_cache.tdb into cache_dir instead of lock_dirMichael Adam1-1/+1
Michael
2009-01-15s3: make better use of ccache by not including version.h in every C-file.Michael Adam2-2/+2
version.h changes rather frequently. Since it is included via includes.h, this means each C file will be a cache miss. This applies to the following situations: * When building a new package with a new Samba version * building in a git branch after calling mkversion.sh after a new commit (i.e. virtually always) This patch improves the situation in the following way: * remove inlude "version.h" from includes.h * Use samba_version_string() instead of SAMBA_VERSION_STRING in files that use no other macro from version.h instead of SAMBA_VERSION_STRING. * explicitly include "version.h" in those files that use more macros from "version.h" than just SAMBA_VERSION_STRING. Michael
2009-01-14Remove smbclient globals that bled into clidfs.c. Now we only haveJeremy Allison3-35/+30
the connections list and authentication structures to worry about. Jeremy
2009-01-14Remove another global from clidfs that is only used in client.c.Jeremy Allison1-11/+16
Jeremy.
2009-01-12s3:libsmb: handle the smb signing states the same in the krb5 and ntlmssp casesStefan Metzmacher1-16/+35
SMB signing works the same regardless of the used auth mech. We need to start with the temp signing ("BSRSPYL ") and the session setup response with NT_STATUS_OK is the first signed packet. Now we set the krb5 session key if we got the NT_STATUS_OK from the server and then recheck the packet. All this is needed to make the fallback from krb5 to ntlmssp possible. This commit also resets the cli->vuid value to 0, if the krb5 auth didn't succeed. Otherwise the server handles NTLMSSP packets as krb5 packets. The restructuring of the SMB signing code is needed to make sure the krb5 code only starts the signing engine on success. Otherwise the NTLMSSP fallback could not initialize the signing engine (again). metze
2009-01-11Move cli_api_pipe() to its only user cli_pipe.cVolker Lendecke1-23/+0
2009-01-08Fix bug #6021 - smbclient du command does not recuse properlyJeremy Allison1-1/+2
Jeremy.
2009-01-04Merge branch 'master' of ssh://git.samba.org/data/git/sambaJelmer Vernooij5-54/+118
2009-01-04Simulate the Windows behaviour to fire 445 and after a timeout 139Volker Lendecke1-14/+76
2009-01-04Async wrapper for open_socket_out_send/recvVolker Lendecke1-8/+15
2009-01-03open_socket_out is always used with SOCK_STREAM, remove argument "type"Volker Lendecke1-7/+5
2009-01-03struct async_req doesn't really need to carry an event_contextVolker Lendecke2-6/+6
2009-01-02Remove cli_cm_set_dest_ss() - removes the global dest_ssJeremy Allison1-15/+5
from libsmb/clidfs.c. Keep the '-I<address>' option in smbclient working. The intent is to remove all globals from libsmb/clidfs.c. Jeremy.
2009-01-01Remove a global variableVolker Lendecke1-13/+20
2009-01-01fix some nonempty blank linesVolker Lendecke1-5/+5
2009-01-01Add iconv_convenience argument to size functions.Jelmer Vernooij1-2/+2
2008-12-31Fix more asprintf and "ignoring return code" warnings from gcc 4.3.Jeremy Allison1-26/+52
Jeremy.
2008-12-31Make a CONST_DISCARD unnecessary by applying some constVolker Lendecke1-3/+2
Derrell, please check!
2008-12-29Attempt to fix bug 5953: Make cli_send_smb_direct_writeX use writevVolker Lendecke1-27/+13
It seems there are SMB servers around which can't cope with the write header being sent in a packet of its own. With writev we keep the advantage of direct writes, giving the kernel the chance to coalesce the write calls.
2008-12-19Add async cli_write_andx and cli_pullVolker Lendecke1-0/+406
2008-12-19Fix setting smb_len for huge write&x callsVolker Lendecke1-1/+14
2008-12-19Add the cli_wct_ofs routine to calculate the offset for write&xVolker Lendecke1-0/+31
2008-12-19Add a doxygen comment line I forgot to mergeVolker Lendecke1-0/+1
2008-12-19Convert cli_request->outbuf to uint8_tVolker Lendecke1-13/+15
2008-12-19For large smbwrite&x, we need more than 64k bccVolker Lendecke1-4/+4
2008-12-19Add some commentsVolker Lendecke1-0/+22
If it takes more than 10 seconds to understand the code you've written yourself less than a year ago, it's time for comments or refactoring. I couldn't find a way to refactor that cleanly, so add comments :-)
2008-12-19Fix the padding calculation in smb_splice_chain for "bytes_padding!=0"Volker Lendecke1-1/+1
2008-12-19Pass "bytes_alignment" up through cli_request_sendVolker Lendecke6-10/+13
This parameter makes smb_spice_chain add padding before the bytes field
2008-12-19Prefer network writes over readsVolker Lendecke1-32/+33
If we really want to keep the pipe busy, we need to write everything we have as early as possible, giving the kernel the chance to get rid of the buffers quickly :-)
2008-12-19Factor out cli_write_max_bufsizeVolker Lendecke1-25/+36
2008-12-19Remove two write-only variablesVolker Lendecke1-8/+0
If someone wants those stats, please don't use globals :-)
2008-12-19Make cli_negprot asyncVolker Lendecke1-50/+97
2008-12-19Make cli_negprot return NTSTATUS instead of boolVolker Lendecke4-21/+29
2008-12-19cli_negprot_send -> cli_negprot_sendsyncVolker Lendecke1-1/+1
2008-12-17Fix a valgrind errorVolker Lendecke1-1/+2
Reported by naga_kishore_kommuri@yahoo.com Derrel, please check! Thanks, Volker (cherry picked from commit 3356b95f72e26ede4ab16a12c334be90b8b1a639)
2008-12-16(Fixed) Final part of fix for bug #5953 - smbclient crashes: cli_list_new ↵Kai Blin1-4/+5
segmentation fault (with NAS-BASIC server).
2008-12-16Revert "Final part of fix for bug #5953 - smbclient crashes: cli_list_new ↵Jeremy Allison1-24/+683
segmentation fault (with NASBASIC server)." Error in commit ! This reverts commit bbd5824140992ea457d4270ee77018ebb367abc9.
2008-12-16Final part of fix for bug #5953 - smbclient crashes: cli_list_new ↵Kai Blin1-683/+24
segmentation fault (with NASBASIC server).
2008-12-16commit b520befe6f51644d20434add9864d7a2fa30aa2eSATOH Fumiyasu1-6/+4
Author: SATOH Fumiyasu <fumiyas@osstech.co.jp> Date: Wed Dec 17 00:42:25 2008 +0900 libsmbclient: Fix SIGBUS on non-x86 CPUs We must align the struct smbc_dirent in the struct SMBC_internal_data because the struct smbc_dirent has numeric values that require alignment. Signed-off-by: Derrell Lipman <derrell.lipman@unwireduniverse.com>
2008-12-14Remove the global "cmdline_auth_info" from source3/lib/util.cVolker Lendecke2-12/+19
This involves changing all our clients, that's why it's so large.
2008-12-13Remove a pointless static variableVolker Lendecke1-7/+7
Every sane compiler will only allocate "*SMBSERVER" once