Age | Commit message (Collapse) | Author | Files | Lines |
|
I did not test with a zero length file :-)
(This used to be commit 7d7a73944c2dcf078f7bc8de65d575f32f9aa851)
|
|
During my initial plans for, and the subsequent discussion of a more
significant change to the API for libsmbclient, I had removed the
AuthDataWithContext usage, in favor of a more generalized planned interface.
When the API returned to its original state, I neglected to reinsert this
code.
Use of an authentication function with the context can be tested using
examples/libsmbclient/testbrowse -C
Derrell
(This used to be commit 38eab68dfb2d8abe8ad00f5a86fc54c778d0d303)
|
|
(This used to be commit 44122f06d02492a7a0a37413d6f975c3b1e3c283)
|
|
Guenther
(This used to be commit 6363c383d6989d2dfb2ee488ffa7aeb128c5385b)
|
|
Guenther
(This used to be commit 6aad05f3f12fd6b3276486f60c10f5b3fd3fa17c)
|
|
Guenther
(This used to be commit 8216310e9f0d7dcccfe761a184a014b7b2ce03c5)
|
|
(This used to be commit f556c9e162e2bc0d16710e994a00edc33a146cd5)
|
|
In an error case, correctly discard the offending PDU
(This used to be commit 0aa195b5d623e1f26f2a1b9e91323a5ddd3ff282)
|
|
To me it was not clear what parts of struct packet_struct are actually used in
build_packet(). This makes it a bit more clear that only the specific parts are
used.
(This used to be commit eb8b6f2404e49d6a837935c5b411d78fb6ff23ef)
|
|
(This used to be commit cfa1b838144800c0758969921b8904fd62e46c07)
|
|
Derrell
(This used to be commit b7f34e7ef2907b498a0645ce68f2773ed7d60cdc)
|
|
(This used to be commit e473e6d50c56f52ef5e4853e4ca3b3548af06f51)
|
|
(This used to be commit 6f65390cec218a6aac4370ee381f30439617dcec)
|
|
(This used to be commit d69b20111a849152a7d9108763207c813bf9068b)
|
|
This is the big (and potentially controversial) one. It took a phone call to
explain to metze what is going on inside cli_pull_read_done, but I would really
like everybody to understand this function. It is a very good and reasonably
complex example of async programming. If we want more asynchronism in s3, this
is what we will have to deal with :-)
Make use of it in the smbclient "get" command.
Volker
(This used to be commit 76f9b360ee1d973630d82d401eeddce858189301)
|
|
(This used to be commit e2153301351559f30f2714345f4c1ca6c5f1a45f)
|
|
Fix Coverity ID 558, 559
(This used to be commit 8e33d19d93ef57a9438aad085aaf04b7c09fe09b)
|
|
- James suggested using gcc's "deprecated" attribute to mark the context
structure fields to generate warnings. This creates a scenario with the
best of all worlds. I'm able to move to an organization that more easily
allows future enhancements, while avoiding any mandatory changes by
applications. Thanks, James!
- Updated WHATSNEW.txt so that it accurately reflects the current state of
affairs.
Derrell
(This used to be commit a67f96fbe9683b46c2149f7cb439d13f7f0e6ecd)
|
|
(This used to be commit 23cb9c49e3724cecaa66655ef64c3111bf14c552)
|
|
- Ensured that all public functions have documentation in libsmbclient.h
- Reformatted for "proper" indentation
- Re-added temporarily-disabled alternate authentication function capability
Derrell
(This used to be commit 64b7150d92849a1e1e2416b9dcc12fae8d6bea99)
|
|
Given the tacit (if that) approval by some people, and clear disapproval by
others for my proposed clean-up and reorganization of libsmbclient, I've come
up with a slightly different approach. This commit changes back to the
original libsmbclient.h SMBCCTX structure which will maintain ABI
compatibility. I retain, here, the setter and getter functions which all new
code should use. Older programs already compiled should continue to work
fine. Older programs being recompiled will encounter compile-time errors
(intentionally!) so that the code can be corrected to use the setter/getter
interfaces.
Although this doesn't clean up the interface in the way I had wanted, the code
reorganization and requirement for new programs to use the setters and getters
allows future progress to be made on libsmbclient without further muddying up
the interface, while retaining the ABI compatibility that was the big issue
causing disapproval. I hope that this compromise is adequate.
Derrell
(This used to be commit 56429a3d60b2a48963342f6340b3c01469a892c6)
|
|
The libsmbclient interface has suffered from difficulty of improvement and
feature enrichment without causing ABI breakage. Although there were a number
of issues, the primary ones were:
(a) the user of the library would manually manipulate the context structure
members, meaning that nothing in the context structure could change other
than adding stuff at the end;
(b) there were three methods of setting options: setting bits in a flags field
within the context structure, setting explicit options variables within an
options structure in the context structure, and by calling the
smbc_option_set() function;
(c) the authentication callback did not traditionally provide enough
information to the callee which required adding an option for a callback
with a different signature, and now there are requests for even more
information at the callback, requiring yet a third signature and option to
set it (if we implement that feature).
This commit provides a reorganization of the code which fixes (a) and (b).
The context structure is now entirely opaque, and there are setter and getter
functions for manipulating it. This makes maintaining ABI consistency much,
much easier.
Additionally, the options setting/getting has been unified into a single
mechanism using smbc_option_set() and smbc_option_get().
Yet to be completed is a refactoring of the authentication callback (c).
The test programs in examples/libsmbclient have been modified (if necessary;
some applications require no changes at all) for the new API and a few have
been minimally tested.
Derrell
(This used to be commit d4b4bae8ded824d06ad5ab0e219f71187ee5c771)
|
|
This reverts commit f5356825698a02df2d400b51dd95d1f857c83e81.
(This used to be commit 5f53a62be8a21b8d92ac44b18d202882500356e8)
|
|
This reverts commit 844a163458c7585e4306a21ffdae5d08e03d6e4d.
(This used to be commit 5ab1cfda500de07ff3c712442ab2fc74eecc8886)
|
|
This reverts commit 719527f55e88f0c5fdceda5c807475aba299c79f.
(This used to be commit ac301fada257e2d3b50148109a3d44fa1421b0b4)
|
|
Jeremy, in 3.0 we allowed get_mydnsdomname and get_mydnsfullname to fail
without filling in anything useful. Worked fine. Without this patch and a empty
/etc/hosts and no DNS configured, session setup would return
NT_STATUS_BAD_NETWORK_NAME. This is confusing at best, BAD_NETWORK_NAME afaik
is only ever returned from tcon normally.
This restores the 3.0 behaviour.
Comments?
Volker
(This used to be commit 2bd3b7d474768f842921945d283eac10da2a1684)
|
|
(This used to be commit f2c67803792f1fd3929e922c1f626f8247e08992)
|
|
Guenther
(This used to be commit b736c77dc6c36dcdb601903fadf0ef7f163052a3)
|
|
(This used to be commit 719527f55e88f0c5fdceda5c807475aba299c79f)
|
|
This is the big (and potentially controversial) one. It took a phone call to
explain to metze what is going on inside cli_pull_read_done, but I would really
like everybody to understand this function. It is a very good and reasonably
complex example of async programming. If we want more asynchronism in s3, this
is what we will have to deal with :-)
Make use of it in the smbclient "get" command.
Volker
(This used to be commit 844a163458c7585e4306a21ffdae5d08e03d6e4d)
|
|
(This used to be commit f5356825698a02df2d400b51dd95d1f857c83e81)
|
|
KRB5.
Jeremy.
(This used to be commit d16c295642c3df49be02440427ded0cd9b4179f5)
|
|
This is == cli_setup_packet but takes an explicit buffer argument
(This used to be commit f64b46dc278899c3449cfd3dbb614aadcf5614d3)
|
|
(This used to be commit e69244a5c8c7c6b7c1897adc4b4b1cfdfc7a7999)
|
|
Guenther
(This used to be commit 74767be627d48eb1a8deea3784847159b536a0fb)
|
|
(This used to be commit ffc1c8cc03e6bad40ed2be91392074b4f038a1bf)
|
|
(This used to be commit db6ae9ed2326e6cd68475375d049084cf1d5a98c)
|
|
Guenther
(This used to be commit b1a4b21f8c35dc23e5c986ebe44d3806055eb39b)
|
|
OS/2 servers. OS/2 returns eclass == ERRDOS && ecode == ERRnofiles
for a zero entry directory listing.
Jeremy.
(This used to be commit b34da627053581a9584367e177566d4a2cef7e82)
|
|
Guenther
(This used to be commit d078a8757182d84dfd3307a2e1b751cf173aaa97)
|
|
Guenther
(This used to be commit 58cca9faf9db506bd2f6eab4a99ef85153797ab2)
|
|
(This used to be commit 6f5051b9c1405ab1dc3e697419ceedb3acac46d8)
|
|
(This used to be commit 7e5752812d6d9e3bcf9a545cbdcf3afe2175dbc4)
|
|
warning: ignoring return value of 'asprintf', declared with attribute warn_unused_result
(This used to be commit ad37b7b0aee265a3e4d8b7552610f4b9a105434d)
|
|
(This used to be commit 621db68f32f7007de8b2c4d7cf604a5778725615)
|
|
(This used to be commit ac027a9b2e84d319f961ac0e84654a0e48920138)
|
|
(This used to be commit 47dd0700b4320bf5ac9a80e71ae82d82d4554e6a)
|
|
Guenther
(This used to be commit 1dcb32424d16cff968a8713352c93c48dec58674)
|
|
Guenther
(This used to be commit 3b0135d57e1e70175a5eec49b603a2e5f700c770)
|
|
Guenther
(This used to be commit bf860ae1ac6765b1eb6e2ca9b667b19b4e661fda)
|