summaryrefslogtreecommitdiff
path: root/source3/libsmb
AgeCommit message (Collapse)AuthorFilesLines
2013-04-11libsmbclient: Avoid a data copyVolker Lendecke1-9/+5
spnego_parse_negTokenInit does a asn_load of that blob, which does a data copy itself. So we don't have to had it a copy as well. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2013-04-11libsmbclient: Fix a leak on talloc_tos()Volker Lendecke1-1/+3
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2013-04-09pylibsmb: Avoid a segfault if no credentials are passed to libsmb.Conn()Volker Lendecke1-5/+5
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com> Autobuild-User(master): Richard Sharpe <sharpe@samba.org> Autobuild-Date(master): Tue Apr 9 18:30:06 CEST 2013 on sn-devel-104
2013-04-03libsmbclient: Fix cli_session_setup_guest_sendVolker Lendecke1-1/+1
This worked fine so far, but for the wrong reason: We only ever called this through the sync wrapper. The tevent_req_nterror in the NT_STATUS_OK case does not call tevent_req_finish. So the tevent_loop_poll did call into the core send/receive smb code. This is a fix for the case when smb1cli_req_chain_submit fails for some reason. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Wed Apr 3 18:39:30 CEST 2013 on sn-devel-104
2013-03-20s3:libsmb: let cli_read_andx_create() accept any lengthStefan Metzmacher1-7/+0
It's up to the server to decide the allowed length. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2013-03-20s3:libsmb: make use of SMB_CAP_LEGACY_CLIENT_MASK instead of SMB_CAP_CLIENT_MASKStefan Metzmacher1-2/+6
This should allow smbclient to keep using large reads against older Samba versions (<= 3.6.x) and other servers that may also require this. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2013-02-28s3:pylibsmb: make sure we get tevent debug messagesStefan Metzmacher1-1/+8
Pair-Programmed-With: Michael Adam <obnox@samba.org> Signed-off-by: Stefan Metzmacher <metze@samba.org> Signed-off-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Thu Feb 28 14:34:24 CET 2013 on sn-devel-104
2013-02-22s3-libsmb: Don't leak memory on error.Andreas Schneider1-0/+1
Reviewed-by: Alexander Bokovoy <ab@samba.org>
2013-02-22libsmb: Fix possible null pointer dereference.Andreas Schneider1-2/+2
Reviewed-by: Alexander Bokovoy <ab@samba.org>
2013-02-19s3:libsmb: s/struct event_context/struct tevent_contextStefan Metzmacher13-175/+175
Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2013-02-19s3:libsmb: make use of samba_tevent_context_init()Stefan Metzmacher13-77/+77
Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2013-02-04s3: use generate_random_password() instead of generate_random_str()Stefan Metzmacher1-3/+4
Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2012-12-21s3-libsmb: Remove check if array is NULL.Andreas Schneider1-1/+2
rdata is an array with data. rdlength defines how big rdata is. So if rdlength is not set we have a big problem. Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
2012-12-21s3-libsmb: Fix a possible null pointer dereference.Andreas Schneider1-1/+1
Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
2012-12-12s3-libsmb: Fix possible comparsion problems.Andreas Schneider1-7/+21
This makes the code also easier to understand. Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
2012-12-06Clean up client timeout definitions [rev. 2]Scott Lovenberg1-1/+2
The definitions for default client timeout values have been moved to client.h. When initializing a client struct we use this value instead of the old hardcoded value. The timeout value remains 20 seconds. Signed-off-by: Scott Lovenberg <scott.lovenberg@gmail.com> Reviewed by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Thu Dec 6 03:25:58 CET 2012 on sn-devel-104
2012-12-02s3:libsmb: add cli_{query,set}_security_descriptor() which take sec_info flagsStefan Metzmacher2-16/+49
In order to set and get security_descriptors it's important to specify the sec_info flags. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2012-09-29s3:libsmb: use smbXcli_conn_remote_name() in smb2_tcon_send()Stefan Metzmacher1-4/+2
metze Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Sat Sep 29 11:52:43 CEST 2012 on sn-devel-104
2012-09-29s3:libsmb: make cli_echo* protocol independentStefan Metzmacher1-32/+23
metze
2012-09-26Fix bug #9213 - Bad ASN.1 NegTokenInit packet can cause invalid free.Jeremy Allison1-0/+4
Not the correct fix for the specific issue, but a general fix to make sure this can never happen again. Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Wed Sep 26 04:07:57 CEST 2012 on sn-devel-104
2012-09-24s3-pylibsmb: Use Py_RETURN_NONEVolker Lendecke1-9/+4
Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Mon Sep 24 08:09:53 CEST 2012 on sn-devel-104
2012-09-23s3-pylibsmb: Add get_oplock_breakVolker Lendecke1-0/+120
Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Sun Sep 23 18:01:28 CEST 2012 on sn-devel-104
2012-09-23s3-pylibsmb: Factor out py_tevent_cond_signalVolker Lendecke1-3/+9
2012-09-23s3-pylibsmb: Reduce the number of warningsVolker Lendecke1-14/+32
2012-09-23s3: Convert cli_oplock_break_waiter to smbXcliVolker Lendecke1-5/+18
2012-09-23s3: Add "readdir" to pylibsmbVolker Lendecke1-0/+72
2012-09-23s3: Fix some nonempty line endingsVolker Lendecke1-4/+4
2012-09-23s3-pylibsmb: move py_tevent_req_wait_exc up in the fileChristian Ambach1-19/+19
this is needed to be able to use it in other functions and spares the prototype Pair-Programmed-With: Volker Lendecke <vl@samba.org>
2012-09-23s3-pylibsmb: Factor out py_tevent_cond_waitVolker Lendecke1-14/+19
2012-09-17s3:libsmb fix a double free errorChristian Ambach1-1/+0
t refers to self->thread_state that is freed a few lines below Autobuild-User(master): Christian Ambach <ambi@samba.org> Autobuild-Date(master): Mon Sep 17 22:04:13 CEST 2012 on sn-devel-104
2012-09-16s3:libsmb fix a potential crashChristian Ambach1-9/+12
Signed-off-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Christian Ambach <ambi@samba.org> Autobuild-Date(master): Sun Sep 16 22:31:38 CEST 2012 on sn-devel-104
2012-09-12Avoid overriding default ccache for ads operations.Simo Sorce2-3/+3
Avoid overriding default ccache for ads operations. Nowadays various samba components may need to use GSSAPI and a default cred cache to perform their tasks. This code was completely overriding the whole process default ccache name, thus altering the current credentials and sometimes hijacking them (or getting preemptively hijaked). By using gss_krb5_import_cred we can instead use a private ccache (necessary sometimes to use a different set of credentials fromt he default cifs/fqdn@realm one, for example when contacting foreign DCs using trust credentials) that does not affect the rest of the process. For the kerberos versions which don't have gss_krb5_import_cred we fallback to temp override of KRB5CCNAME and gss_acquire_cred. Signed-off-by: Alexander Bokovoy <ab@samba.org> Signed-off-by: Günther Deschner <gd@samba.org> Autobuild-User(master): Alexander Bokovoy <ab@samba.org> Autobuild-Date(master): Wed Sep 12 21:18:09 CEST 2012 on sn-devel-104
2012-09-04s3: Fix memleaks in pylibsmb.cVolker Lendecke1-2/+2
Cut&Paste errors from the read&x routine Signed-off-by: Jeremy Allison <jra@samba.org>
2012-08-30s3:libsmb correctly set isFsctl for snapshot listChristian Ambach1-1/+1
FSCTL_GET_SHADOW_COPY_DATA is a FSCTL, so set the isFsctl marker otherwise smbclient allinfo will not report snapshots any more with the changes made for Bug #8311 Autobuild-User(master): Christian Ambach <ambi@samba.org> Autobuild-Date(master): Thu Aug 30 18:57:24 CEST 2012 on sn-devel-104
2012-08-22Fix bug in SMB_FIND_INFO_STANDARD parsing found by Volker.Jeremy Allison1-1/+3
The function align_string() is now broken as base_ptr no longer points at the start of the SMB data packet, but at the start of the returned TRANS2 data area. Replace it with a check for FLAGS2_UNICODE_STRINGS and a call to ucs2_align().
2012-08-16s3-libsmb: Add a python wrapperVolker Lendecke1-0/+671
Please note that this is not finished and only for internal use. Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-08-09Check error returns from strupper_m() (in all reasonable places).Jeremy Allison5-8/+23
2012-08-09Fix missing ads_destroy in error path.Jeremy Allison1-0/+1
2012-08-04s3:libsmb: add EXTENDED_SIGNATURE support in cli_tcon_andx*()Stefan Metzmacher1-0/+5
metze
2012-08-01s3:libsmb: add a optional_support helper variableStefan Metzmacher1-1/+6
metze
2012-08-01s3:libsmb: add a tcon_flags helper variableStefan Metzmacher1-1/+4
metze
2012-08-01s3:libsmb: remove unused cli_state->user_session_keyStefan Metzmacher2-21/+0
metze
2012-08-01s3:libsmb: make use of smb1cli_session_set_session_key()Stefan Metzmacher1-0/+24
metze
2012-07-31s3: Fix Coverity ID 710791 Resource leakVolker Lendecke1-0/+1
Signed-off-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Tue Jul 31 13:34:53 CEST 2012 on sn-devel-104
2012-07-29s3-libsmbclient: Add missing talloc_stackframe() callsAndrew Bartlett1-0/+16
These caused a panic with the new assertion on the talloc stackframe being in place. Andrew Bartlett Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Sun Jul 29 05:21:24 CEST 2012 on sn-devel-104
2012-07-27lib/param: Rename "socket address" to "nbt client socket address" to clarify ↵Andrew Bartlett1-2/+2
role This parameter is only used in our NBT client code and in nmbd as a fallback when we fail to select a better interface from "interfaces" to use directly. Andrew Bartlett Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Fri Jul 27 12:16:25 CEST 2012 on sn-devel-104
2012-07-25libcli/smb: pass smbXcli_session to smb2cli_tcon_set_values()Stefan Metzmacher1-0/+1
metze
2012-07-25libcli/smb: there's no PID field in the SMB2/3 header anymoreStefan Metzmacher1-2/+0
It's a reserved field... metze
2012-07-25libcli/smb: pass smbXcli_tcon to smb2cli_req_create/send()Stefan Metzmacher1-7/+2
metze
2012-07-25s3:libsmb: remove unused tcon specific elements from cli_state->smb2Stefan Metzmacher1-11/+13
metze