Age | Commit message (Collapse) | Author | Files | Lines |
|
Guenther
(This used to be commit 2fe416ffa5c7efd2e6a644e4c8bac756152881d9)
|
|
Guenther
(This used to be commit 82803186febfe6a55c1a598073657c2c4a513000)
|
|
Guenther
(This used to be commit dc165e1c80586664ddb4d3d68182598d02ba204a)
|
|
Guenther
(This used to be commit 91a55fc27dc100cf193cfa2613771312f018449e)
|
|
(This used to be commit 4f1d49615e1407b9c3ad5eeb50a248b8fee50e23)
|
|
Guenther
(This used to be commit eefd03d39b107598e9b0d1f35def7b17073d8ebc)
|
|
This patch is the first iteration of an inside-out conversion to cleanup
functions in charcnv.c returning size_t == -1 to indicate failure.
(This used to be commit 59124382d2894a1b194b48dd82bc5f956959eb48)
|
|
Guenther
(This used to be commit 882475f5566592b3a675d3609c3af8cf7d4e256d)
|
|
This allows to switch on the cli->fallback_after_kerberos switch.
Guenther
(This used to be commit 15ba45e567d910c1b2336dcc0c475e12b082f30f)
|
|
Ignore optional req_flags. Use the Kerberos mechanism OID negotiated
with the client rather than hardcoding OID_KERBEROS5_OLD.
(This used to be commit 59a2bcf30fef14ecc826271862b645dd3a61cb48)
|
|
bool to get the declarations picked up by the prototype parser.
(This used to be commit fd168e7b5065ba15b1cf56522b6810b8e6fdd7d5)
|
|
(This used to be commit 494b32197f0872b115f0cd1a35421d00a89360a6)
|
|
the space taken by the unicode password to be one byte too
long (as we're on an odd byte boundary here). Reduce the
count by 1 to cope with this. Fixes smbclient against NetApp
servers which can't cope. Fix from
bryan.kolodziej@allenlund.com in bug #3840.
Jeremy.
(This used to be commit 1e7e7d86a1ae1cd2c3cc3de9f36b7326ad249b82)
|
|
Not that I think it is of any importance...
Guenther
(This used to be commit 352f8440c74bc22416e21783e1dc5fecf5869902)
|
|
Guenther
(This used to be commit 9e15ce03ca66a0b5ffdb39dd2faaad6e0f967e31)
|
|
Guenther
(This used to be commit 8a1a9f967db25d3928f19e46d60af249f934f323)
|
|
In order to avoid receiving NT_STATUS_DOWNGRADE_DETECTED from a w2k8
netr_ServerAuthenticate2 reply, we need to start with the AD netlogon negotiate
flags everywhere (not only when running in security=ads). Only for NT4 we need
to do a downgrade to the returned negotiate flags.
Tested with w2k8, w2ksp4, w2k3r2 and nt4sp6.
Guenther
(This used to be commit 0970369ca0cb9ae465cff40e5c75739824daf1d0)
|
|
Jeremy.
(This used to be commit d090d25cb702965b3d5e4635a26a06f2b62d235d)
|
|
current_timestring used to return a string talloced to talloc_tos().
When called by DEBUG from a TALLOC_FREE, this produced messages
"no talloc stackframe around, leaking memory". For example when
used from net conf.
This also adds a temporary talloc context to alloc_sub_basic().
For this purpose, the exit strategy is slightly altered: a common
exit point is used for success and failure.
Michael
(This used to be commit 16b5800d4e3a8b88bac67b2550d14e0aaaa302a9)
|
|
(This used to be commit 8dd6458049d1b9d6849730ac19c39b049a68f302)
|
|
Guenther
(This used to be commit 2134d80c05fd7a37f44317335b40d7961c429c7b)
|
|
Guenther
(This used to be commit 34dd8f32e1b7fe256ab5dfde5ef5bb8abeec121a)
|
|
Guenther
(This used to be commit 7fa53911054a39681df3f08d19aad92f60d59e28)
|
|
In winbind, we're using the info3 struct to send it to the winbind client after
netsamlogon_cache_store. Without this info3->base.account_name.string was
prematurely freed.
(This used to be commit aa4377561b691e2c5108c18aeb34fff39d8775df)
|
|
Fix bug 5341, thanks a lot to Karoly Vegh for testing it!
Volker
(This used to be commit 19eb8c9316b10b1277121e90d0d3ef50ee562118)
|
|
Guenther
(This used to be commit 818044d877597ba5c11dc7f30bab929c4b41db89)
|
|
When reading from a pipe, Windows return STATUS_BUFFER_OVERFLOW which is *not*
an error.
(This used to be commit 24018d882d1b1cfece47c533fe5bbca91de124cc)
|
|
I did not test with a zero length file :-)
(This used to be commit 7d7a73944c2dcf078f7bc8de65d575f32f9aa851)
|
|
During my initial plans for, and the subsequent discussion of a more
significant change to the API for libsmbclient, I had removed the
AuthDataWithContext usage, in favor of a more generalized planned interface.
When the API returned to its original state, I neglected to reinsert this
code.
Use of an authentication function with the context can be tested using
examples/libsmbclient/testbrowse -C
Derrell
(This used to be commit 38eab68dfb2d8abe8ad00f5a86fc54c778d0d303)
|
|
(This used to be commit 44122f06d02492a7a0a37413d6f975c3b1e3c283)
|
|
Guenther
(This used to be commit 6363c383d6989d2dfb2ee488ffa7aeb128c5385b)
|
|
Guenther
(This used to be commit 6aad05f3f12fd6b3276486f60c10f5b3fd3fa17c)
|
|
Guenther
(This used to be commit 8216310e9f0d7dcccfe761a184a014b7b2ce03c5)
|
|
(This used to be commit f556c9e162e2bc0d16710e994a00edc33a146cd5)
|
|
In an error case, correctly discard the offending PDU
(This used to be commit 0aa195b5d623e1f26f2a1b9e91323a5ddd3ff282)
|
|
To me it was not clear what parts of struct packet_struct are actually used in
build_packet(). This makes it a bit more clear that only the specific parts are
used.
(This used to be commit eb8b6f2404e49d6a837935c5b411d78fb6ff23ef)
|
|
(This used to be commit cfa1b838144800c0758969921b8904fd62e46c07)
|
|
Derrell
(This used to be commit b7f34e7ef2907b498a0645ce68f2773ed7d60cdc)
|
|
(This used to be commit e473e6d50c56f52ef5e4853e4ca3b3548af06f51)
|
|
(This used to be commit 6f65390cec218a6aac4370ee381f30439617dcec)
|
|
(This used to be commit d69b20111a849152a7d9108763207c813bf9068b)
|
|
This is the big (and potentially controversial) one. It took a phone call to
explain to metze what is going on inside cli_pull_read_done, but I would really
like everybody to understand this function. It is a very good and reasonably
complex example of async programming. If we want more asynchronism in s3, this
is what we will have to deal with :-)
Make use of it in the smbclient "get" command.
Volker
(This used to be commit 76f9b360ee1d973630d82d401eeddce858189301)
|
|
(This used to be commit e2153301351559f30f2714345f4c1ca6c5f1a45f)
|
|
Fix Coverity ID 558, 559
(This used to be commit 8e33d19d93ef57a9438aad085aaf04b7c09fe09b)
|
|
- James suggested using gcc's "deprecated" attribute to mark the context
structure fields to generate warnings. This creates a scenario with the
best of all worlds. I'm able to move to an organization that more easily
allows future enhancements, while avoiding any mandatory changes by
applications. Thanks, James!
- Updated WHATSNEW.txt so that it accurately reflects the current state of
affairs.
Derrell
(This used to be commit a67f96fbe9683b46c2149f7cb439d13f7f0e6ecd)
|
|
(This used to be commit 23cb9c49e3724cecaa66655ef64c3111bf14c552)
|
|
- Ensured that all public functions have documentation in libsmbclient.h
- Reformatted for "proper" indentation
- Re-added temporarily-disabled alternate authentication function capability
Derrell
(This used to be commit 64b7150d92849a1e1e2416b9dcc12fae8d6bea99)
|
|
Given the tacit (if that) approval by some people, and clear disapproval by
others for my proposed clean-up and reorganization of libsmbclient, I've come
up with a slightly different approach. This commit changes back to the
original libsmbclient.h SMBCCTX structure which will maintain ABI
compatibility. I retain, here, the setter and getter functions which all new
code should use. Older programs already compiled should continue to work
fine. Older programs being recompiled will encounter compile-time errors
(intentionally!) so that the code can be corrected to use the setter/getter
interfaces.
Although this doesn't clean up the interface in the way I had wanted, the code
reorganization and requirement for new programs to use the setters and getters
allows future progress to be made on libsmbclient without further muddying up
the interface, while retaining the ABI compatibility that was the big issue
causing disapproval. I hope that this compromise is adequate.
Derrell
(This used to be commit 56429a3d60b2a48963342f6340b3c01469a892c6)
|
|
The libsmbclient interface has suffered from difficulty of improvement and
feature enrichment without causing ABI breakage. Although there were a number
of issues, the primary ones were:
(a) the user of the library would manually manipulate the context structure
members, meaning that nothing in the context structure could change other
than adding stuff at the end;
(b) there were three methods of setting options: setting bits in a flags field
within the context structure, setting explicit options variables within an
options structure in the context structure, and by calling the
smbc_option_set() function;
(c) the authentication callback did not traditionally provide enough
information to the callee which required adding an option for a callback
with a different signature, and now there are requests for even more
information at the callback, requiring yet a third signature and option to
set it (if we implement that feature).
This commit provides a reorganization of the code which fixes (a) and (b).
The context structure is now entirely opaque, and there are setter and getter
functions for manipulating it. This makes maintaining ABI consistency much,
much easier.
Additionally, the options setting/getting has been unified into a single
mechanism using smbc_option_set() and smbc_option_get().
Yet to be completed is a refactoring of the authentication callback (c).
The test programs in examples/libsmbclient have been modified (if necessary;
some applications require no changes at all) for the new API and a few have
been minimally tested.
Derrell
(This used to be commit d4b4bae8ded824d06ad5ab0e219f71187ee5c771)
|
|
This reverts commit f5356825698a02df2d400b51dd95d1f857c83e81.
(This used to be commit 5f53a62be8a21b8d92ac44b18d202882500356e8)
|