summaryrefslogtreecommitdiff
path: root/source3/locking
AgeCommit message (Collapse)AuthorFilesLines
2010-09-27Change to using TDB_INCOMPATIBLE_HASH (the jenkins hash) on allJeremy Allison2-2/+2
TDB_CLEAR_IF_FIRST tdb's. For tdb's like gencache where we open without CLEAR_IF_FIRST and then with CLEAR_IF_FIRST if corrupt this is still safe to use as if opening an existing tdb the new hash will be ignored - it's only used on creating a new tdb not opening an old one. Jeremy.
2010-08-26s3-build: use dbwrap.h only where needed.Günther Deschner3-0/+3
Guenther
2010-08-07s3: Remove smbd_messaging_context() from send_stat_cache_delete_message()Volker Lendecke1-1/+2
2010-07-05s3: Remove procid_self() from brl_close_fnum()Volker Lendecke1-1/+2
2010-07-05s3: Remove procid_self() from fill_deferred_open_entry()Volker Lendecke1-6/+9
2010-07-05s3: Remove procid_self() from do_lock_cancel()Volker Lendecke1-1/+1
2010-07-05s3: Remove procid_self() from do_unlock()Volker Lendecke1-1/+1
2010-07-05s3: Remove procid_self() from do_lock()Volker Lendecke1-1/+1
2010-07-05s3: Remove procid_self() from query_lock()Volker Lendecke1-1/+1
2010-07-05s3: Remove procid_self() from fill_share_mode_entry()Volker Lendecke1-1/+1
2010-07-05s3: Remove procid_self() from init_strict_lock_struct()Volker Lendecke1-1/+2
2010-05-07This patch looks bigger than it is. It does 2 things. 1). Renames smbpid -> ↵Jeremy Allison2-41/+41
smblctx in our locking code. 2). Widens smblctx to 64-bits internally. Preparing to use the SMB2 handle as the locking context. Jeremy.
2010-05-07Make us pass all SMB2 lock tests except MULTIPLE-UNLOCK and CONTEXT. Them ↵Jeremy Allison1-2/+3
next :-). Jeremy.
2010-05-06Fix SMB2 lock tests up to cancel-by-close.Jeremy Allison1-0/+4
Jeremy.
2010-05-05Move to MS-FSA algorithm when checking for invalid lock range.Jeremy Allison1-7/+6
Satisfies SMB and SMB2. Jeremy.
2010-05-06s3: only include gen_ndr headers where needed.Günther Deschner2-0/+2
This shrinks include/includes.h.gch by the size of 7 MB and reduces build time as follows: ccache build w/o patch real 4m21.529s ccache build with patch real 3m6.402s pch build w/o patch real 4m26.318s pch build with patch real 3m6.932s Guenther
2010-04-30smbd: move printfile_offset() within write_file()Simo Sorce1-0/+6
2010-04-12Move to using 64-bit mid values in our internal open file database.Jeremy Allison1-7/+8
This will allow us to share logic much easier between SMB1 and SMB2 servers. Jeremy
2010-03-15We don't need to treat the token differently in the conn->admin_user case, ↵Jeremy Allison1-11/+0
it should already be pointing to a token with uid == 0. Jeremy.
2010-03-15Rever e80ceb1d7355c8c46a2ed90d5721cf367640f4e8 "Remove more uses of "extern ↵Jeremy Allison1-0/+10
struct current_user current_user;"." As requested by Volker, split this into smaller commits. Jeremy.
2010-03-12Remove more uses of "extern struct current_user current_user;".Jeremy Allison1-10/+0
Use accessor functions to get to this value. Tidies up much of the user context code. Volker, please look at the changes in smbd/uid.c to familiarize yourself with these changes as I think they make the logic in there cleaner. Cause smbd/posix_acls.c code to look at current user context, not stored context on the conn struct - allows correct use of these function calls under a become_root()/unbecome_root() pair. Jeremy.
2010-03-10s3: Fix a long-standing problem with recycled PIDsVolker Lendecke2-2/+2
When a samba server process dies hard, it has no chance to clean up its entries in locking.tdb, brlock.tdb, connections.tdb and sessionid.tdb. For locking.tdb and brlock.tdb Samba is robust by checking every time we read an entry from the database if the corresponding process still exists. If it does not exist anymore, the entry is deleted. This is not 100% failsafe though: On systems with a limited PID space there is a non-zero chance that between the smbd's death and the fresh access, the PID is recycled by another long-running process. This renders all files that had been locked by the killed smbd potentially unusable until the new process also dies. This patch is supposed to fix the problem the following way: Every process ID in every database is augmented by a random 64-bit number that is stored in a serverid.tdb. Whenever we need to check if a process still exists we know its PID and the 64-bit number. We look up the PID in serverid.tdb and compare the 64-bit number. If it's the same, the process still is a valid smbd holding the lock. If it is different, a new smbd has taken over. I believe this is safe against an smbd that has died hard and the PID has been taken over by a non-samba process. This process would not have registered itself with a fresh 64-bit number in serverid.tdb, so the old one still exists in serverid.tdb. We protect against this case by the parent smbd taking care of deregistering PIDs from serverid.tdb and the fact that serverid.tdb is CLEAR_IF_FIRST. CLEAR_IF_FIRST does not work in a cluster, so the automatic cleanup does not work when all smbds are restarted. For this, "net serverid wipe" has to be run before smbd starts up. As a convenience, "net serverid wipedbs" also cleans up sessionid.tdb and connections.tdb. While there, this also cleans up overloading connections.tdb with all the process entries just for messaging_send_all(). Volker
2010-02-14s3-locking: convert brlock to TYPESAFE_QSORT()Andrew Tridgell1-3/+2
2010-02-10s3-locking: update to use DLIST_ADD_AFTER()Andrew Tridgell1-5/+1
(cherry picked from commit 6c6df527e14514027cbcaa6deac25adf04363926)
2010-01-12Fix bug #6876 - Delete of an object whose parent folder does not have delete ↵Jeremy Allison1-0/+3
rights fails even if the delete right is set on the object. Final fix for the vfs_acl_xattr and vfs_acl_tdb code. Ensure we can delete a file even if the underlying POSIX permissions don't allow it, if the Windows permissions do. Jeremy.
2009-12-04Make Samba3 pass the RAW-LOCK test as Windows.Jeremy Allison1-0/+5
Implement the win7 NT_STATUS_INVALID_LOCK_RANGE. Make smbd behave as Windows does in canceling locks. Jeremy.
2009-12-02Remove unneeded argument from can_set_delete_on_close(). EnsureJeremy Allison1-9/+2
can_set_delete_on_close() is correctly called before any setting of the disposition bit (clean up the do_unlink() call). Jeremy.
2009-11-21s3: Remove a pointless memsetVolker Lendecke1-1/+0
We are assigning the complete structure now (we used to assign individual fields), so this is obsolete.
2009-11-21s3: Cache brlock.tdb entries for the fast read&write strict locking code pathVolker Lendecke2-15/+65
For a netbench run this gains around 2% user-space CPU, fetching a 100MB file takes around 4% less.
2009-11-03s3: Remove debug_ctx()Volker Lendecke2-7/+7
smbd just crashed on me: In a debug message I called a routine preparing a string that itself used debug_ctx. The outer routine also used it after the inner routine had returned. It was still referencing the talloc context that the outer debug_ctx() had given us, which the inner DEBUG had already freed.
2009-10-05Fix bug 6776 - Running overlapping Byte Lock test will core dump Samba daemon.Jeremy Allison1-148/+219
Re-write core of POSIX locking logic. Jeremy.
2009-09-07s3:smbd: Add the ntstatus to the smb_panic in share_mode_lock_destructorVolker Lendecke1-2/+18
This might help finding why bug 6518 happens
2009-07-24Make the smbd VFS typesafeVolker Lendecke2-0/+46
2009-07-20s3: Change fsp->fsp_name to be an smb_filename struct!Tim Prouty3-29/+41
2009-07-08s3: Change the share_mode_lock struct to store a base_name and stream_nameTim Prouty1-29/+64
2009-07-08s3: Make some arguments to (parse|unparse)_share_modes() constTim Prouty1-2/+2
2009-07-07s3: Remove unnecessary const qualifiersTim Prouty1-2/+1
2009-07-06s3 sticky write time: Removed unused args and tighten up a function by ↵Tim Prouty1-1/+2
making an arg const
2009-05-06Fix Coverity ID 897: REVERSE_INULLVolker Lendecke1-1/+1
2009-04-03Use procid_str in debug messages for better cluster-debuggabilityVolker Lendecke1-2/+2
2009-03-26Fix a scary "fill_share_mode_lock failed" messageVolker Lendecke1-1/+2
To me "fill_share_mode_lock failed" is a "can't happen" alert. There is however a perfectly valid case in get_file_infos() when the file is not open. Change the corresponding debug message to level 10 and explain more.
2009-03-13s3: Add strict lock/unlock calls to the vfs layer to replace is_lockedDave Richards1-35/+55
2009-03-05Last part of fix for #6154 - zfs does not honor admin users.Jeremy Allison1-4/+15
Jeremy.
2009-02-20s3 BRL: Add more clarifying comments and add implied logic to make ↵Zack Kirsch1-2/+6
conditional more clear
2009-02-19s3: Add extid to the dev/inode pairTim Prouty1-3/+3
This extends the file_id struct to add an additional generic uint64_t field: extid. For backwards compatibility with dev/inodes stored in xattr_tdbs and acl_tdbs, the ext id is ignored for these databases. This patch should cause no functional change on systems that don't use SMB_VFS_FILE_ID_CREATE to set the extid. Existing code that uses the smb_share_mode library will need to be updated to be compatibile with the new extid.
2009-02-13s3: Fix uninitialized variable warning (and bug).Zack Kirsch1-2/+0
2009-02-13Add VFS ops for Windows BRL: Lock, Unlock and Cancel:Zack Kirsch2-52/+95
This patch adds 3 new VFS OPs for Windows byte range locking: BRL_LOCK_WINDOWS, BRL_UNLOCK_WINDOWS and BRL_CANCEL_WINDOWS. Specifically: * I renamed brl_lock_windows, brl_unlock_windows and brl_lock_cancel to *_default as the default implementations of the VFS ops. * The blocking_lock_record (BLR) is now passed into the brl_lock_windows and brl_cancel_windows paths. The Onefs implementation uses it - future implementations may find it useful too. * Created brl_lock_cancel to do what brl_lock/brl_unlock do: set up a lock_struct and call either the Posix or Windows lock function. These happen to be the same for the default implementation. * Added helper functions: increment_current_lock_count() and decrement_current_lock_count(). * Minor spelling correction in brl_timeout_fn: brl -> blr. * Changed blocking_lock_cancel() to return the BLR that it has cancelled. This allows us to assert its the lock that we wanted to cancel. If this assert ever fires, this path will need to take in the BLR to cancel, rather than choosing on its own. * Adds a small helper function: find_blocking_lock_record_by_id(). Used by the OneFS implementation, but could be useful for others.
2009-02-10Fix an uninitialized variable. Tim, please check!Volker Lendecke1-1/+1
2009-02-09s3 oplocks: Make the level2 oplock contention API more granularTim Prouty1-11/+74
This replaces release_level2_oplocks_on_change with contend_level2_oplock_begin/end in order to contend level2 oplocks throughout an operation rather than just at the begining. This is necessary for some kernel oplock implementations, and also lays the groundwork for better correctness in Samba's standard level2 oplock handling. The next step for non-kernel oplocks is to add additional state to the share mode lock struct that prevents any new opens from granting oplocks while a contending operation is in progress. All operations that contend level 2 oplocks are now correctly spanned except for aio and synchronous writes. The two write paths both have non-trivial error paths that need extra care to get right. RAW-OPLOCK and the rest of 'make test' are still passing with this change.
2008-12-23Fix more asprintf warnings and some error path errors.Jeremy Allison1-7/+6
Jeremy.