Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
|
|
This patch introduces two new temporary helper functions
vfs_stat_smb_fname and vfs_lstat_smb_fname. They basically allowed me
to call the new smb_filename version of stat, while avoiding plumbing
it through callers that are still too inconvenient. As the conversion
moves along, I will be able to remove callers of this, with the goal
being to remove all callers.
There was also a bug in create_synthetic_smb_fname_split (also a
temporary utility function) that caused it to incorrectly handle
filenames with ':'s in them when in posix mode. This is now fixed.
|
|
This was a little messy because of all of the vfs modules I had to
touch. Most of them were pretty straight forward, but the streams
modules required a little attention to handle smb_filename. Since the
use of smb_filename enables the vfs modules to access the raw,
over-the-wire stream, a little bit of the handling that was being done
by split_ntfs_stream_name has now been shifted into the individual
stream modules. It may be a little more code, but overall it gives
more flexibility to the streams modules, while also allowing correct
stream handling.
|
|
This patch introduces
struct stat_ex {
dev_t st_ex_dev;
ino_t st_ex_ino;
mode_t st_ex_mode;
nlink_t st_ex_nlink;
uid_t st_ex_uid;
gid_t st_ex_gid;
dev_t st_ex_rdev;
off_t st_ex_size;
struct timespec st_ex_atime;
struct timespec st_ex_mtime;
struct timespec st_ex_ctime;
struct timespec st_ex_btime; /* birthtime */
blksize_t st_ex_blksize;
blkcnt_t st_ex_blocks;
};
typedef struct stat_ex SMB_STRUCT_STAT;
It is really large because due to the friendly libc headers playing macro
tricks with fields like st_ino, so I renamed them to st_ex_xxx.
Why this change? To support birthtime, we already have quite a few #ifdef's at
places where it does not really belong. With a stat struct that we control, we
can consolidate the nanosecond timestamps and the birthtime deep in the VFS
stat calls.
At this moment it is triggered by a request to support the birthtime field for
GPFS. GPFS does not extend the system level struct stat, but instead has a
separate call that gets us the additional information beyond posix. Without
being able to do that within the VFS stat calls, that support would have to be
scattered around the main smbd code.
It will very likely break all the onefs modules, but I think the changes will
be reasonably easy to do.
|
|
Jeremy.
|
|
I'm not certain if the dummy pointer is needed in struct vfs_fsp_data,
but I added it to be consistent with the comment below.
|
|
This allows module implementors to customize what allocation size is
returned to the client.
|
|
|
|
Handling of error codes when renaming a file to a stream and a stream
to a file is now done in rename_internals_fsp.
The NTRENAME stream path only passes in the stream name, so the new
base can now be different from the old base.
|
|
The behavior of stat and fstat should be the same.
metze
|
|
metze
|
|
metze
|
|
caused us to
run into kernel oplocks on an open for a stream inside a file with stream_xattr module. On
opening the base_fsp we must break existing oplocks." as it broke make test.
Jeremy.
|
|
stream inside a file with stream_xattr module. On opening the base_fsp we must break existing oplocks.
Jeremy.
|
|
kernel oplock bug).
Jeremy.
|
|
the file
(also fix a bad merge of the previous patch from 3.3).
Jeremy.
|
|
Now all those redundant fd's have vanished from the VFS API.
Michael
(This used to be commit 14294535512a7f191c5008e622b6708e417854ae)
|
|
(This used to be commit e9bb3d5067b74a29beb778f85687829778e42b5b)
|
|
It turns out that this is a necessary operation, separate from statvfs. statvfs
can fail during tcon, so conn->fs_capabilities would never see that we support
streams on a particular share.
James, can you check that I got the darwin variant right? Thanks!
(This used to be commit 3ad798d803b3b023533bb48e6993885f22b96095)
|
|
(This used to be commit 4a6dadc5178f4861e9c032321939db3b639734b5)
|
|
(This used to be commit d7e6ec2258350c564053371361c8f1d7d0f775b1)
|
|
(This used to be commit 023b313d0d4ed3beb8d77177bc8141cadeb86658)
|
|
These bugs haven't shown up when I did my tests with real xattrs, not with the
xattr_tdb backend. It worked because the stream fsp does has the base file as
fd.
(This used to be commit b7022f8f7bf83c9c5e73e98d1477b7da766e8c5f)
|
|
(This used to be commit 8db25aba63b1dffb0dfbc74012c7ebd0ce4d5682)
|
|
(This used to be commit d481dddc81699aba79e48bca79bfb10e586b5cbb)
|
|
This must have been lost somewhere in my patch-mangling
(This used to be commit c1794375d1fa27d72ec32946bb4bd7b9f96e59fc)
|
|
Store streams in posix xattrs. A kludge, as xattrs are limited in many ways,
but it might be a help for some situations.
(This used to be commit 83a805220e52742119546c76a054d50582e33a24)
|