summaryrefslogtreecommitdiff
path: root/source3/modules
AgeCommit message (Collapse)AuthorFilesLines
2012-12-21s3-vfs: Fix a null pointer deferference in vfs_media_harmony.Andreas Schneider1-1/+3
Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
2012-12-21s3-vfs: Fix typo in readonly_connect().Andreas Schneider1-1/+1
Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
2012-12-12vfs: Make sure we don't call talloc_free on an uninitialized pointer.Andreas Schneider1-1/+1
Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
2012-12-04s3:smbd:vfs_acl: fix a PANIC when setting an ACL fails with ACCESS_DENIEDMichael Adam1-0/+1
Omission to free the talloc frame causes a panic (at least in developer mode) in the next main event loop due to "Frame not freed in order." (Freed frame ../source3/smbd/process.c:3617, expected ../source3/modules/vfs_acl_common.c:534.) Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Tue Dec 4 09:03:25 CET 2012 on sn-devel-104
2012-11-28s3:vfs_gpfs: add no memory check in gpfs2smb_acl()Stefan Metzmacher1-0/+5
Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Wed Nov 28 14:06:27 CET 2012 on sn-devel-104
2012-11-28s3:vfs_gpfs: make sure we return the correct errno in gpfs2smb_acl()Stefan Metzmacher1-1/+1
TALLOC_FREE() could overwrite errno. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-28s3:vfs_aixacl2: make use of vfs_aixacl_util.hStefan Metzmacher1-3/+1
This should fix the build. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-17s3:modules:nfs4_acls remove unused mem_ctx parameter to smbacl4_fill_ace4Christian Ambach1-3/+1
Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Sat Nov 17 01:11:07 CET 2012 on sn-devel-104
2012-11-16s3:modules:nfs4_acls fix memory hierarchy in smb_create_smb4aclChristian Ambach1-2/+1
the ACEs should be talloc children of the ACL itself and not be placed on talloc_tos() Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2012-11-16s3:vfs_gpfs fix a memory leak in gpfsacl_get_posix_aclChristian Ambach1-0/+3
Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2012-11-16s3:vfs_gpfs fix memory corruption in gpfs2smb_aclChristian Ambach1-0/+2
sys_acl_init returns a SMB_ACL_T with zero entries in the acl array reallocate the array to proper size before filling it, otherwise we overwrite memory This one is a result of a improper fixing in 7a6182962966e5edb42728c8 Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2012-11-16s3:vfs_gpfs fix memory leak in gpfs_get_nfs4_aclChristian Ambach1-0/+1
Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2012-11-16s3:vfs_gpfs fix memory leaks in gpfs_getacl_allocChristian Ambach1-2/+4
Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2012-11-05s3:vfs_default: optimize vfswrap_asys_finished() and read as much as we canStefan Metzmacher1-16/+33
Signed-off-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Mon Nov 5 19:01:13 CET 2012 on sn-devel-104
2012-11-02vfs_acl_common: In add_directory_inheritable_components allocate on psd as ↵Andrew Bartlett1-4/+16
parent When we add a new DACL to the security descriptor, we need to use the SD as the memory context, so we can talloc_move() it as a tree to a new parent. Andrew Bartlett Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Fri Nov 2 22:16:14 CET 2012 on sn-devel-104
2012-10-23vfs: Fix compilation of ACL support on solarisAndrew Bartlett1-2/+4
2012-10-12s3:vfs_gpfs re-indent run-away linesChristian Ambach1-4/+10
some lines added by the acl_blob additions were longer than 80 chars
2012-10-12s3:vfs_gpfs fix the buildChristian Ambach1-5/+11
make it compile again after the recent (untested) additions of the acl_blob functions
2012-10-12s3:vfs_gpfs remove a trailing spaceChristian Ambach1-1/+1
2012-10-12s3:vfs_gpfs skip local flock when gpfs sharemodes are disabledChristian Ambach1-2/+5
no sense in calling local flock when clustered sharemodes should be disabled
2012-10-11vfs: Remove irixacl module (all the fucntions in it are unimplemented)Andrew Bartlett3-145/+0
2012-10-11vfs: Fix alternative posix and no-op sys acl implementations to take a mem_ctxAndrew Bartlett3-9/+13
These were missed with the initial conversion to use a talloc context. Andrew Bartlett
2012-10-11vfs: Improve formatting of vfs_fake_aclsAndrew Bartlett1-2/+2
This avoids this bad style being copied into new modules. Andrew Bartlett Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Thu Oct 11 05:10:16 CEST 2012 on sn-devel-104
2012-10-11vfs: Improve formatting of vfs_defaultAndrew Bartlett1-23/+23
This avoids this bad style being copied into new modules. Andrew Bartlett
2012-10-11vfs: Use a blocking function in vfs_zfsacl for system ACL blobsAndrew Bartlett1-0/+12
This is so we do not query some other module for the ACL blob, as zfs ACLs are not posix ACLs. We may add a linearisation later. Andrew Bartlett
2012-10-11vfs: Use posix_sys_acl_blob_get_file in vfs_tru64acl for posix ACLsAndrew Bartlett1-0/+2
2012-10-11vfs: Use posix_sys_acl_blob_get_file in vfs_solarisacl for posix ACLsAndrew Bartlett1-0/+2
2012-10-11vfs: Use posix_sys_acl_blob_get_file in vfs_posixacl for posix ACLsAndrew Bartlett1-0/+2
2012-10-11vfs: Use posix_sys_acl_blob_get_file in vfs_irix for posix ACLsAndrew Bartlett1-0/+2
2012-10-11vfs: Use posix_sys_acl_blob_get_file in vfs_hpux for posix ACLsAndrew Bartlett1-0/+2
2012-10-11vfs: Use posix_sys_acl_blob_get_file in vfs_gpfs for posix ACLsAndrew Bartlett1-0/+58
2012-10-11vfs: Use posix_sys_acl_blob_get_file in vfs_fake_acls for posix ACLsAndrew Bartlett1-67/+2
2012-10-11vfs: Use posix_sys_acl_blob_get_file in vfs_default for posix ACLsAndrew Bartlett1-0/+2
2012-10-11vfs: Use posix_sys_acl_blob_get_file in vfs_aixacl2 for posix ACLsAndrew Bartlett1-0/+38
2012-10-11vfs: Use posix_sys_acl_blob_get_file in vfs_aixaclAndrew Bartlett1-0/+2
2012-10-11vfs: Use a blocking function in vfs_afsacl for system ACL blobsAndrew Bartlett1-1/+17
This is important, as we need to avoid asking any lower module for a possible libear ACL blob. We may implement a linearisation in the future. Andrew Bartlett
2012-10-11vfs: Remove type parameter from sys_acl_blob_get_{fd,file}Andrew Bartlett2-4/+2
This interface actually needs to match the get_nt_acl interface in that the system ACL implmenetation may not be posix ACLs, and the blob is not meant to be enforced to be of a particular system ACL structure. Andrew Bartlett
2012-10-11smbd: Add mem_ctx to {f,}get_nt_acl VFS callAndrew Bartlett13-68/+139
This makes it clear which context the returned SD is allocated on, as a number of callers do not want it on talloc_tos(). As the ACL transformation allocates and then no longer needs a great deal of memory, a talloc_stackframe() call is used to contain the memory that is not returned further up the stack. Andrew Bartlett
2012-10-11smbd: Add mem_ctx to sys_acl_init() and all callersAndrew Bartlett16-73/+104
This changes from allocation on NULL to allocation on the supplied memory context. Currently that supplied context is talloc_tos() at the the final consumer of the ACL. Andrew Bartlett
2012-10-11build: Add vfs_media_harmony to the waf buildAndrew Bartlett1-0/+9
2012-10-09s3: Pass down smb_filename to smbacl4_fill_ace4Volker Lendecke1-6/+6
A full fsp is a bit overkill here Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Tue Oct 9 13:38:49 CEST 2012 on sn-devel-104
2012-10-01s3: vfs_streams_depot: add delete_lost optionBjörn Baumbach1-23/+42
With this option lost stream directories will be removed instead of renamed. Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Mon Oct 1 18:47:30 CEST 2012 on sn-devel-104
2012-09-28vfs: check full_audit enum->str mapping on startupDavid Disseldorp1-3/+4
Signed-off-by: Jim McDonough <jmcd@samba.org> Autobuild-User(master): David Disseldorp <ddiss@samba.org> Autobuild-Date(master): Fri Sep 28 19:28:49 CEST 2012 on sn-devel-104
2012-09-28vfs: add missing pwrite ops to full_auditDavid Disseldorp1-0/+2
The op enum is used by audit_opname() as an index into the vfs_op_names array, so any decrepencies cause bogus audit log entries. Signed-off-by: Jim McDonough <jmcd@samba.org>
2012-09-27s3:nfs4acls filter away inheritance flags on filesChristian Ambach1-0/+11
While it is possible to define inheritance flags on files on Windows, this will be denied by GPFS and UFS (and potentially others). So it will be better to strip of these bits when being set for files instead of failing to set the ACL completely (this is current behavior). Users that want to retain the full SD will have to use acl_xattr (acl_tdb), as other pieces of the SD are also lost when translating to NFSv4. So this should not be a too intrusive change, but allow users to migrate data with such flags instead of failing to migrate the ACL completely.
2012-09-27s3:nfs4acls pass down fsp instead of just the filenameChristian Ambach1-4/+6
2012-09-23s3:vfs_fake_acls fix a compiler warningChristian Ambach1-1/+1
about acl being potentially uninitialized Autobuild-User(master): Christian Ambach <ambi@samba.org> Autobuild-Date(master): Sun Sep 23 01:08:39 CEST 2012 on sn-devel-104
2012-09-20vfs: fix acl_blob_get* in vfs_full_auditDavid Disseldorp1-9/+11
Plumb-in functions and use correct return types. Autobuild-User(master): David Disseldorp <ddiss@samba.org> Autobuild-Date(master): Thu Sep 20 20:42:09 CEST 2012 on sn-devel-104
2012-09-20vfs: fix lock logging in vfs_full_auditDavid Disseldorp1-4/+4
2012-09-16s3:vfs_gpfs: fix buildChristian Ambach1-5/+5
after recent VFS changes