summaryrefslogtreecommitdiff
path: root/source3/nmbd
AgeCommit message (Collapse)AuthorFilesLines
2012-12-12s3-nmbd: Cleanup code to make it more readable.Andreas Schneider1-3/+7
Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
2012-08-23param: Add startup checks for valid server role/binary combinationsAndrew Bartlett1-0/+10
This should eliminate confusion from our users about what they can expect to successfully run. Andrew Bartlett
2012-08-17Fix bug #9085 - NMB registration for a duplicate workstation fails with ↵S Hargagan1-1/+1
registration refuse Signed-off-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Fri Aug 17 04:15:21 CEST 2012 on sn-devel-104
2012-08-09Check error returns from strupper_m() (in all reasonable places).Jeremy Allison9-15/+54
2012-08-08s3:nmbd: log a failure in get_domain_master_name_node_status_success() as ↵Stefan Metzmacher1-1/+1
level 1 metze Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Wed Aug 8 20:14:29 CEST 2012 on sn-devel-104
2012-08-08s3:nmbd: don't log get_domain_master_name_node_status_fail at level 0Stefan Metzmacher1-1/+1
metze
2012-07-27lib/param: Rename "socket address" to "nbt client socket address" to clarify ↵Andrew Bartlett1-1/+1
role This parameter is only used in our NBT client code and in nmbd as a fallback when we fail to select a better interface from "interfaces" to use directly. Andrew Bartlett Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Fri Jul 27 12:16:25 CEST 2012 on sn-devel-104
2012-07-19Move everything to use the common pidfile functions.Jeremy Allison1-2/+3
The extra code in source3/lib/pidfile.c is no longer needed.
2012-07-19Make the s3 pidfile use the common code inside lib/util/pidfile.cJeremy Allison1-1/+1
2012-07-19Move source4/smbd/pidfile into lib/util in preparation for making it in common.Jeremy Allison1-2/+2
2012-07-18loadparm: make the source3/ lp_ functions take an explicit TALLOC_CTX *.Rusty Russell5-8/+9
They use talloc_tos() internally: hoist that up to the callers, some of whom don't want to us talloc_tos(). A simple patch, but hits a lot of files. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2012-05-31Forward port of Richard Sharpe's <realrichardsharpe@gmail.com> fix for bug ↵Jeremy Allison1-1/+2
#8970 - Possible memory leaks in the samba master process.
2012-05-30s3-param: Rename lp_dns_proxy() -> lp_wins_dns_proxy() for clarityAndrew Bartlett2-2/+2
This avoids some confusion now we have a DNS server as well. Andrew Bartlett
2012-05-28s3:libsmb: get rid of cli_negprotLuk Claes1-1/+3
Signed-off-by: Luk Claes <luk@debian.org> Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-04-19s3: Fix Coverity ID 2686 -- RESOURCE_LEAKVolker Lendecke1-0/+1
2012-03-24lib/util: Remove obsolete sys_getpid() and sys_fork().Jelmer Vernooij5-6/+6
The performance of these is minimal (these days) and they can return invalid results when used as part of applications that do not use sys_fork(). Autobuild-User: Jelmer Vernooij <jelmer@samba.org> Autobuild-Date: Sat Mar 24 21:55:41 CET 2012 on sn-devel-104
2012-03-15s3:smbd: let smbd/nmbd/winbindd child processes terminate if the parent ↵Michael Adam1-0/+11
process died. This applies to all child processes making use of reinit_after_fork(). It is implemented by establishing a pipe between parent and child. The child watches for EOF on the read end of the pipe, indidcating an exited parent. Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
2012-03-07s3: piddir creation fix part 2.Ira Cooper1-0/+4
Since the piddir got moved from the lockdir by default, the default piddir wasn't getting created, stopping some configurations from running. Signed-off-by: Jeremy Allison <jra@samba.org>
2012-03-06s3: Fix some format string warningsVolker Lendecke1-9/+13
We were printing nmb->header.name_trn_id with %hu, which denotes a short. However, header.name_trn_id is an int for the better or worse.
2012-03-04s3-nmbd: Add stdin handler for nmbdAndrew Bartlett1-0/+33
This will help avoid runaway processes in the test env, particularly when the whole selftest.pl is killed. Andrew Bartlett
2012-02-16lib/util: Remove sys_poll as it is no longer neededAndrew Bartlett1-1/+1
sys_poll() is only needed if the signal pipe is set up and used, but as no signal handler ever writes to the pipe, this can all be removed. signal based events are now handled via tevent. Andrew Bartlett Signed-off-by: Jeremy Allison <jra@samba.org>
2012-02-16Rename obscure defined constants.Christopher R. Hertel (crh)1-1/+1
Replaced the undescriptive SMB_PORT1 and SMB_PORT2 defined constants with the slightly more descriptive names NBT_SMB_PORT and TCP_SMB_PORT. Also replaced several hard-coded references to the well-known port numbers (139 and 445, respectively) as appropriate. Small changes to clarify some comments regarding the two transport types. Signed-off-by: Simo Sorce <idra@samba.org> Autobuild-User: Simo Sorce <idra@samba.org> Autobuild-Date: Thu Feb 16 08:29:41 CET 2012 on sn-devel-104
2012-02-16s3-nmbd: Initialise newly non-static variablesAndrew Bartlett1-4/+4
Found by testing with wintest. When the variables were made non-static in c21f6a1c6869a5086634bb830d6c3689dea539a3 the implicit initialisation to 0 was lost. Andrew Bartlett
2012-02-03s3-nmbd: don't discard DGRAM frames from local addresses when we are a DCMatthieu Patou1-15/+17
Winbind use netbios to locate the DC, if samba is also a DC then nmbd receive request from Winbind that are from a local address, those requests must not be discarded otherwise winbind can't find the DC and won't try another method. Autobuild-User: Matthieu Patou <mat@samba.org> Autobuild-Date: Fri Feb 3 11:09:29 CET 2012 on sn-devel-104
2011-12-14s3: Remove a call to procid_self()Volker Lendecke1-1/+1
2011-12-14s3: Remove nmbd_messaging_context()Volker Lendecke1-31/+18
2011-12-14s3: Fix some pointless staticsVolker Lendecke1-5/+5
2011-12-14s3: Remove a call to procid_self()Volker Lendecke1-6/+8
Pass messaging_context through the SIGHUP handler
2011-12-14s3: Remove a call to procid_self()Volker Lendecke1-7/+10
Pass messaging_context through the SIGTERM handler
2011-12-14s3: Pass messaging_context to nmbd/process()Volker Lendecke1-4/+3
2011-12-14s3: Make nmbd_messaging_context staticVolker Lendecke2-2/+1
2011-12-14s3: Centralize nmbd_messaging_context in nmbd.cVolker Lendecke4-13/+12
2011-12-14s3: Fix some nonempty blank linesVolker Lendecke1-4/+4
2011-12-13s3: Fix some nonempty blank linesVolker Lendecke1-10/+10
2011-12-12s3: Remove a bunch of calls to procid_self()Volker Lendecke2-2/+2
All callers to messaging_[re]init only used procid_self()
2011-11-24s3:nmbd: make use of cli_tree_connect()Stefan Metzmacher1-1/+1
metze
2011-11-17s3-nmbd Remove AD netlogon response from s3 nmbd serverAndrew Bartlett1-92/+15
I do not want users with misconfigurations to have nmbd respond with this partially correct packet. For example, it hardcodes the site as Default-First-Site-Name. If nmbd wishes to return this information, it would need to query the AD database using the same APIs that the source4/ nbt server does. Andrew Bartlett Autobuild-User: Andrew Bartlett <abartlet@samba.org> Autobuild-Date: Thu Nov 17 02:10:54 CET 2011 on sn-devel-104
2011-11-17s3-param remove lp_domain_logons(), always use IS_DCAndrew Bartlett2-2/+2
This makes the code internally consistant. Andrew Bartlett Pair-Programmed-With: Amitay Isaacs <amitay@samba.org>
2011-11-03s3:nmbd: s/Undefined/SMB_SIGNING_DEFAULT/Stefan Metzmacher1-2/+2
metze
2011-10-10libcli/cldap: don't pass tevent_context to cldap_socket_init()Stefan Metzmacher1-2/+1
metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Mon Oct 10 23:23:07 CEST 2011 on sn-devel-104
2011-10-10libcli/cldap: pass tevent_context to cldap_netlogon_send()Stefan Metzmacher1-1/+1
metze
2011-09-15s3:libsmb: pass max_protocol to cli_negprot()Stefan Metzmacher1-1/+1
metze
2011-09-08s3:libsmb: pass CLI_FULL_CONNECTION_* flags via cli_connect_nb()Stefan Metzmacher1-1/+1
metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Thu Sep 8 10:21:50 CEST 2011 on sn-devel-104
2011-08-25s3: Fix some nonempty blank linesVolker Lendecke1-3/+3
2011-08-11s3-messaging: Fix messaging classes.Simo Sorce1-1/+3
This has been broken since ff0ac5b0 (May 2007). Basically all messages were belonging to the General class except for CTDB messages. This fixed the message_send_all() function to correctly compute the class, and fixes registrations to include all they need to cope with the fact not all messages are of calss general (registrations rotted a bit because as long as FLAG_MSG_GENERAL was defined the process woould receive all messages). Signed-off-by: Andreas Schneider <asn@samba.org>
2011-08-04s3-nmbd: fix talloc/malloc mismatch in create_listen_pollfds().Günther Deschner1-1/+1
Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Thu Aug 4 19:06:39 CEST 2011 on sn-devel-104
2011-07-28s3:nmbd: use the lp_load_global() wrapper of lp_load()Michael Adam1-1/+1
2011-07-20debug: log early messages to stdout, and keep it openAndrew Bartlett1-1/+4
The --log-stdout option was compromised by the log file descriptors being closed once the file process forked. Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-07-03S3: Fix some nonempty blank linesVolker Lendecke1-26/+26
2011-07-02param: Finish conversion from lp_wins_support() -> lp_we_are_a_wins_server()Andrew Bartlett1-1/+1
Jermey started this in 1997 with 0aa493cc0303aa4177f289b9e4c797c8fa180672 (avoiding the duplicate function makes it easier to generate the struct loadparm_globals). Andrew Bartlett