Age | Commit message (Collapse) | Author | Files | Lines |
|
The done: part could access uninitialized memory if intermediate
BAIL_ON_WBC_ERROR fire.
Jerry, please check!
Thanks,
Volker
(cherry picked from commit 31f4c33dcc744e81be54389756378e25aa2bb75e)
(This used to be commit 5b12d8aa510689114e5413be5afe6aeb6ec2d9db)
|
|
If the BAIL_ON_WBC_ERROR directly after wbcRequestResponse kicks in, *domain
and *name have not been initialized yet. So the cleanup routine in the done:
part of the routine (which did not check for domain!=NULL etc) would access
uninitialized memory.
Jerry, please check!
Thanks,
Volker
(cherry picked from commit 3d7e0cc40b1992f4555807acec4f00450e30e2de)
(This used to be commit ac5ba26bb0488c3fb95072d84898c02b72c5b819)
|
|
(This used to be commit 9c1f334af3111e93bb8dceb661e1bc5519aa94c6)
|
|
(cherry picked from commit 72b381689af9cae83ab08532cffd0188f2da4807)
(This used to be commit 20110ee5f181168dc1cbc08b7c22820d68204960)
|
|
BAIL_ON_PTR_ERROR jumps to done: which will access extra_data before it's
initialized.
Stefan, please check!
Volker
(cherry picked from commit b59636f78d351ed6d52c4a9fdccdb7850388526c)
(This used to be commit 5663587e5e4703f9e3ff6d78d1f3248053ccd4c0)
|
|
This (also) fixes a flaw pointed out by the IBM checker. When verifying that I
found out that the parsing was not working as I would have expected it to.
Jerry, please check!
(cherry picked from commit c2c7790155ab02e1e351caf2bed192ce72913663)
(This used to be commit 26c05a52b73763dad5ad0525dab6e20014c3f8d6)
|
|
Guenther
(This used to be commit 83c4a278dfefcef14a9640d319ddf5c7392cd16e)
|
|
metze
(cherry picked from commit b68916328e935e61840cb03560ebeeee15bb2c6f)
(This used to be commit 196d9017627220786d8b726dc0d02e16e96c4c05)
|
|
metze
(cherry picked from commit 04d465c622c614bec29f24793ae897a73bcb51f4)
(This used to be commit e7dcbf56aef836e1b4be70b21064f65338221b5a)
|
|
Guenther
(This used to be commit e90a4ce3c24ab2a33e34da5a9052a3b3ec4db962)
|
|
Add new APIs calls for WINBINDD_PAM_LOGOFF and WINBINDD_DSGETDCNAME
ops.
(This used to be commit cb5e8f60ac3313aec726c01687a040e6e0e42c10)
|
|
Use the existing domain_flags fiueld in wbcDomainInfo to set a bit if the
domain is marked as offline by Winbind.
(This used to be commit 59cfba2c3d6d4594f08cbe3b7295ab36a7cfb044)
|
|
Better consistency with the othre classes of WBC_DOMINDO_XXX_YYYY flags.
(This used to be commit 1cb2305fc96be0c190621f7c86c0476e4ea1fff7)
|
|
char **
Fix a compile warning. This seems the right thing since the data is created
by talloc_strdup...
Michael
(This used to be commit f81da8e8ed8e2d75c77bd8b5e7fdd7c53bab7e49)
|
|
This fixes a compile warning and seems the correct thing to me as
the returned data is talloc_strdup't, so not const anyways.
Michael
(This used to be commit 13cfa7f48a541a934a129fab0544cbf66029c4c7)
|
|
(This used to be commit fea52dc46048ff869299267f7596b93a8c5c8b3d)
|
|
(This used to be commit 5c454e77cf664fee65fcb03e5811764c92e73696)
|
|
s/WBC_INVALID_RESPONSE/WBC_ERR_INVALID_RESPONSE/
(This used to be commit d91ce012b0afb30cd22b373412d17de27c55ca86)
|
|
This only accepts NULL as domain for now,
because winbindd doesn't support checking
trust passwords as a domain controller.
metze
(This used to be commit c084ccd70f42ce29ce24565969a9f440dde254e1)
|
|
metze
(This used to be commit 57ba71140fbf6b4a5a917fa3248fa76536be883b)
|
|
metze
(This used to be commit 364e146805bb74b46da4d3c187e9a684d4b99a01)
|
|
(This used to be commit cbdb79b7a1044945e515a294f487e4c1a9c91be5)
|
|
metze
(This used to be commit 596d030b976102e7476a2460fce355914c4e8210)
|
|
(This used to be commit 3130fb7b32285b8501f5ee8cbc62b478c09cccd3)
|
|
metze
(This used to be commit fee3806326b9ba214e35868271e6481c0c8b9c4b)
|
|
metze
(This used to be commit de2e8d5db93d32e5ebf04a2018a08f766eb9a233)
|
|
metze
(This used to be commit 7a4de23aa318bd24948e576a5582a5c74d335154)
|
|
metze
(This used to be commit df127f0b40d36ea8ee605c24ea88558c7d40a7fe)
|
|
metze
(This used to be commit 38007a387a1f1b53877ef9ea518f83ecf026f4f3)
|
|
I leave the more explicit error path in the "if (cmd == 0)" block.
Michael
(This used to be commit 2ae19b5fb89e0a992962af14a81b641bf13b7892)
|
|
Guenther
(This used to be commit 79f7a519f8f61a31d84467c5b5975cae13db1c29)
|
|
(This used to be commit d993b4c3cea6ead74ff1e031ee9a42f2aa39a9f1)
|
|
v3-2-test
(This used to be commit 847874ca757ac8ca32082305c8caed5abc7fed1d)
|
|
metze
(This used to be commit 237c2e9738ae29ca7046d6f886d6f777a6206045)
|
|
metze
(This used to be commit 423f139fd37496db2e690f20399357496367ed7c)
|
|
metze
(This used to be commit 491ba9c0c9d479bc686c75242a3749f14d103fcd)
|
|
Jeremy.
(This used to be commit 58b0f022ffce7fda531f6f8ea7392a963e8ec0c5)
|
|
This function will be used by auth_winbind.c.
metze
(This used to be commit 72af96a320a97ce1a730d6e33d01950123d6a97c)
|
|
metze
(This used to be commit 97a8069075d820c43c17e761b1186d4f0b3c785d)
|
|
Guenther
(This used to be commit a3417be934e34af2525ddb731af288034d51432b)
|
|
response.extra_data.data is not initialized on the first error path
Found by the IBM checker
(This used to be commit e9b3115c85e3d04eeaa04bfa71972d393272afca)
|
|
wbcRequestResponse().
This is a valid parameter set for things like setpwent() and ping().
(This used to be commit c1cdf6085329d55cf29ccc8c980fc853a03a695e)
|
|
Jeremy.
(This used to be commit f5ca241e2c1adf2ae836fae33a4adac916f46416)
|
|
metze
(This used to be commit 0b85f7173d0770f8d9a0bac9e43355eb45bc181f)
|
|
This makes the installed wbclient.h header usable.
metze
(This used to be commit 7dd65599a15bf1d164fcfa554c8057d43c51eb6d)
|
|
Guenther
(This used to be commit 338baf96cb957fa52e312d42fbf0fa227d7dafda)
|
|
(This used to be commit 518168410c49ac25085714c73e76dcf358fc4b68)
|
|
Follows existing convention that all returned memory should be freed with
wbcFreeMemory() and not directly with free(). Noticed by Volker. Txs.
(This used to be commit 39c2059f66ee9eb471a503b9c776807b91c2a8f8)
|
|
wbcRequestResponse() returns a wbcErr, not NSS_STATUS
(This used to be commit 1bbdbdef991408af07afaba7bc0b4da55f06aed8)
|
|
Without request and response, wbcRequestResponse() will always return
WBC_ERR_INVALID_PARAM, so the ping will never reach winbind.
(This used to be commit 9a24753d35a4b1a283a65c60088d82e4b80f14c8)
|