| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
(This used to be commit b880602c4c1b13fbb5931b8e00c22209a722e0d5)
|
|
(This used to be commit 56dc19879c6514cbdd0b1fd186c8bdeb61bf151a)
|
|
Jeremy.
(This used to be commit 7f3ace5481e55ef845da28b9c0613a2ea0de0de4)
|
|
checking for
!= NULL. Coverity #149.
Volker
(This used to be commit d38e05329a77650d8fbb8611ca148964f62c9ba4)
|
|
realloc can return NULL in one of two cases - (1) the realloc failed,
(2) realloc succeeded but the new size requested was zero, in which
case this is identical to a free() call.
The error paths dealing with these two cases should be different,
but mostly weren't. Secondly the standard idiom for dealing with
realloc when you know the new size is non-zero is the following :
tmp = realloc(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
However, there were *many* *many* places in Samba where we were
using the old (broken) idiom of :
p = realloc(p, size)
if (!p) {
return error;
}
which will leak the memory pointed to by p on realloc fail.
This commit (hopefully) fixes all these cases by moving to
a standard idiom of :
p = SMB_REALLOC(p, size)
if (!p) {
return error;
}
Where if the realloc returns null due to the realloc failing
or size == 0 we *guarentee* that the storage pointed to by p
has been freed. This allows me to remove a lot of code that
was dealing with the standard (more verbose) method that required
a tmp pointer. This is almost always what you want. When a
realloc fails you never usually want the old memory, you
want to free it and get into your error processing asap.
For the 11 remaining cases where we really do need to keep the
old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR,
which can be used as follows :
tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the
pointer p, even on size == 0 or realloc fail. All this is
done by a hidden extra argument to Realloc(), BOOL free_old_on_error
which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR
macros (and their array counterparts).
It remains to be seen what this will do to our Coverity bug count :-).
Jeremy.
(This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
|
|
(This used to be commit 705d8118081784e9907648fd1daaaa5ec0285972)
|
|
Volker
(This used to be commit ae9614ce019e25fb29dad8429d93f3140c2f84ad)
|
|
(This used to be commit a374546c7e8dfc17eb2346c518d1d89f28c32feb)
|
|
a user since we no longer pay any attention to the value.
(This used to be commit 085c6859ee5b97efe9ec06e95877d500822d3c82)
|
|
(This used to be commit c13af58f6322104a45d0e620cc26f522a47af2ab)
|
|
upgrade it calls tdbsam_convert() which calls tdbsam_open()
deep inside the init_sam_from_buffer_vX call.
If the ref count hasn't been set yet then we will close
the tdbsam reference in tdbsam_getsampwsid().
smbpasswd -a was core-dumping again :-).
Jeremy
(This used to be commit 993069eb87c190ba8ee92224340c8f9ffb3ade74)
|
|
(This used to be commit 2afcbbfb6f2efcc2e10106b10a87365556013787)
|
|
(This used to be commit 59f95ea752d932b00d4a4ff37311b830d65c8a03)
|
|
(This used to be commit 76c100834d125b889d29d0fc38934bed4cc77e19)
|
|
* Fix a couple of related parsing issues.
* in the info3 reply in a samlogon, return the ACB-flags (instead of
returning zero)
Guenther
(This used to be commit 5b89e8bc24f0fdc8b52d5c9e849aba723df34ea7)
|
|
Jeremy
-------------
Slightly smaller version of pdb_get_methods() patch. Turns out that
callers to initialize_password_db() use the reload parameter so this
has turned in to a smaller cleanup than I thought.
(This used to be commit 7e243104eb57d656adf7b5a322fc8dde9e3c2868)
|
|
(This used to be commit 7c098ca0ae4c7e11c7100fb09b42ce716beffb56)
|
|
Volker
(This used to be commit dbdb8bdb9993b0136322530f0b8462bb9477dbf1)
|
|
* ignore the primary group SID attribute from struct samu*
* generate the primary group SID strictlky from the Unix
primary group when dealing with passdb users
* Fix memory leak in original patch caused by failing to free a
talloc *
* add wrapper around samu_set_unix() to prevent exposing the create
BOOL to callers. Wrappers are samu_set_unix() and samu-allic_rid_unix()
(This used to be commit bcf269e2ec6630b78d909010fabd3b69dd6dda84)
|
|
(This used to be commit faf1d832a1b4c59e36814d560bdc5e9838309ca2)
|
|
"rename user script" to do the rename of the posix machine account (this
might be changed later). Fixes #2331.
Guenther
(This used to be commit b2eac2e6eb6ddd1bcb4ed5172e7cd64144c18d16)
|
|
* Add a 'struct passwd *' to the struct samu for later reference
(I know this may be controversial but its easily reverted which is
is why I'm checking this is as a seaparate patch before I get
too deep).
* Remove unix_homedir from struct samu {} and update the pdb wrapper
functions associated with it.
(This used to be commit 92c251fdf0f1f566cfeca3c75ba2284b644aef5d)
|
|
(This used to be commit e3489f7eddb21981bb74cd8792aca869ae6790e1)
|
|
was the only place it was called from.
(This used to be commit 6568c9cb03ca378ea7d08190ca3cfcc3e380ee4e)
|
|
* replace all pdb_{init,fill}_sam_pw() calls with samu_set_unix()
(This used to be commit 6f1afa4acc93a07d0ee9940822d7715acaae634f)
|
|
have a valid pwent list from a setsampwent(). Fixes a bug with the
reference count on the open tdb.
(This used to be commit 77332f0738423d16a2b5e21af6aaf92b029da0ef)
|
|
to make full use of the new talloc() interface. Discussed with Volker
and Jeremy.
* remove the internal mem_ctx and simply use the talloc()
structure as the context.
* replace the internal free_fn() with a talloc_destructor() function
* remove the unnecessary private nested structure
* rename SAM_ACCOUNT to 'struct samu' to indicate the current an
upcoming changes. Groups will most likely be replaced with a
'struct samg' in the future.
Note that there are now passbd API changes. And for the most
part, the wrapper functions remain the same.
While this code has been tested on tdb and ldap based Samba PDC's
as well as Samba member servers, there are probably still
some bugs. The code also needs more testing under valgrind to
ensure it's not leaking memory.
But it's a start......
(This used to be commit 19b7593972480540283c5bf02c02e5ecd8d2c3f0)
|
|
macro which sets the freed pointer to NULL.
(This used to be commit b65be8874a2efe5a4b167448960a4fcf6bd995e2)
|
|
(This used to be commit db575c764127d7bea92fc12e5aa73c96c9ee5e2f)
|
|
for the creds store. This should fix the problems
Jerry reported (but I have still to run tests :-).
Jeremy.
(This used to be commit 43f095a38d66caa774d80fe32e1b96ec25dd1f07)
|
|
this more but it gets around the primary group issue.
* don't map a SID to a name from the group mapping code if
the map doesn't have a valid gid. This is only an issue
in a tdb setup
* Always allow S-1-$DOMAIN-513 to resolve (just like Windows)
* if we cannot resolve a users primary GID to a SID, then set
it to S-1-$DOMAIN-513
* Ignore the primary group SID inside pdb_enum_group_memberships().
Only look at the Unix group membersip.
Jeremy, this fixes a fresh install startup for smbd as far as my tests
are concerned.
(This used to be commit f79f4dc4c58a6172bf69d37469fdd8de05a812df)
|
|
Jeremy.
(This used to be commit e755155b0e665cb6d10c28fe7fc6c1f6699d18e6)
|
|
key and delete records that are old. We will need this
for the full 16 byte session key support.
Jeremy.
(This used to be commit cef240d571f9ba1cdf596cd4cab4ec0790f943a0)
|
|
I mean it this time :-).
Jeremy.
(This used to be commit 80f4868944d349015d2b64c2414b06466a8194aa)
|
|
on the tdb file. This allow recusive calls to succeed
without complaining about failed opens since a tdb can
only be opened once per process. We probably still need to backport
the transaction support from Samba 4 here though.
(This used to be commit 94c37e06522bfc1753cc8f3c6c7bd4329587007e)
|
|
Volker
(This used to be commit bb40e544de68f01a6e774753f508e69373b39899)
|
|
error.
Volker
(This used to be commit 5a92df31d69ff7b0f2de6564d644949c2906c8f1)
|
|
* remove pdb_context data structure
* set default group for DOMAIN_RID_GUEST user as RID 513 (just
like Windows)
* Allow RID 513 to resolve to always resolve to a name
* Remove auto mapping of guest account primary group given the
previous 2 changes
(This used to be commit 7a2da5f0cc05c1920c664c9a690a23bdf854e285)
|
|
makes fixes much easier to port. Fix the size of dc->sess_key to
be 16 bytes, not 8 bytes - only store 8 bytes in the inter-smbd
store in secrets.tdb though. Should fix some uses of the dc->sess_key
where we where assuming we could read 16 bytes.
Jeremy.
(This used to be commit 5b3c2e63c73fee8949108abe19ac7a448a033a7f)
|
|
(This used to be commit d3b66fb8712e41a331ccfb0f52f187382769b41e)
|
|
(This used to be commit a3bc4f51144bcd711ae1869d60a15d24be6ad992)
|
|
Sync with trunk as off r13315
(This used to be commit 17e63ac4ed8325c0d44fe62b2442449f3298559f)
|
|
(This used to be commit 6c3480f9aecc061660ad5c06347b8f1d3e11a330)
|
|
Volker
(This used to be commit e747ea7250b3ff19aee49072a2cf95840ff50b85)
|
|
access free'd memory.
Jerry please pick up for 3.0.21b !
Jeremy.
(This used to be commit c0ba64297a00d75cd537693425c6b544e70578c1)
|
|
file create the file.
Jeremy.
(This used to be commit 31b3201f537220ec82d6fecbb4c457bfe3dbb9c9)
|
|
Jeremy.
(This used to be commit e5f19ad5ac1b728de4ca5a6c37c0d79b0752f536)
|
|
(This used to be commit 77575c64e4e961f37ccf5b2dd17e41c74678ea45)
|
|
Guenther
(This used to be commit f78c7f8abea4cb598eca78fa3beacee8a3caee20)
|
|
(This used to be commit 3ee6b732f4210e6de6716364ec166f44f29f4463)
|
