summaryrefslogtreecommitdiff
path: root/source3/printing/printing.c
AgeCommit message (Collapse)AuthorFilesLines
2010-06-13s3: Remove the pointless PRINTERNAME macroVolker Lendecke1-6/+6
2010-06-10s3:misc make use of server_[event/messaging]_context directlyAndreas Schneider1-6/+7
Untangle these functions from smbd specific dependencies so they can be freely used in multiple servers.
2010-05-28s3:auth use info3 in auth_serversupplied_infoSimo Sorce1-1/+1
Signed-off-by: Günther Deschner <gd@samba.org>
2010-05-06s3: only include gen_ndr headers where needed.Günther Deschner1-0/+1
This shrinks include/includes.h.gch by the size of 7 MB and reduces build time as follows: ccache build w/o patch real 4m21.529s ccache build with patch real 3m6.402s pch build w/o patch real 4m26.318s pch build with patch real 3m6.932s Guenther
2010-04-28s3-spoolss: add support for SetJobInfo level 1 (for jobfile rename).Günther Deschner1-1/+23
Guenther
2010-04-28s3-lanman: remove unsupported print_job_set_place().Günther Deschner1-10/+0
Guenther
2010-03-25Second part of bug #7288 - SMB job IDs in CUPS job names wrong.Jeremy Allison1-2/+0
Forgot to delete the overload of the smbjob bool. Jeremy.
2010-03-25Fix bug #7288 - SMB job IDs in CUPS job names wrong.Jeremy Allison1-19/+0
Based on a patch from Michael Karcher <samba@mkarcher.dialup.fu-berlin.de>. I think this is the correct fix. It causes cups_job_submit to use print_parse_jobid(), which I've moved into printing/lpq_parse.c (to allow the link to work). It turns out the old print_parse_jobid() was *broken*, in that the pjob filename was set as an absolute path - not relative to the sharename (due to it not going through the VFS calls). This meant that the original code doing a strncmp on the first part of the filename would always fail - it starts with a "/", not the relative pathname of PRINT_SPOOL_PREFIX ("smbprn."). This fix could fix some other mysterious printing bugs - probably the ones Guenther noticed where job control fails on non-cups backends. Guenther PLEASE CHECK ! Jeremy.
2010-03-10Try and fix bug #7233 - print fails with jobs >4GB from Win7 clients.Jeremy Allison1-1/+1
Remove an arbitrarty 4G B limit that *doesn't need to be there* ! Jeremy.
2010-03-10s3: Fix a long-standing problem with recycled PIDsVolker Lendecke1-2/+4
When a samba server process dies hard, it has no chance to clean up its entries in locking.tdb, brlock.tdb, connections.tdb and sessionid.tdb. For locking.tdb and brlock.tdb Samba is robust by checking every time we read an entry from the database if the corresponding process still exists. If it does not exist anymore, the entry is deleted. This is not 100% failsafe though: On systems with a limited PID space there is a non-zero chance that between the smbd's death and the fresh access, the PID is recycled by another long-running process. This renders all files that had been locked by the killed smbd potentially unusable until the new process also dies. This patch is supposed to fix the problem the following way: Every process ID in every database is augmented by a random 64-bit number that is stored in a serverid.tdb. Whenever we need to check if a process still exists we know its PID and the 64-bit number. We look up the PID in serverid.tdb and compare the 64-bit number. If it's the same, the process still is a valid smbd holding the lock. If it is different, a new smbd has taken over. I believe this is safe against an smbd that has died hard and the PID has been taken over by a non-samba process. This process would not have registered itself with a fresh 64-bit number in serverid.tdb, so the old one still exists in serverid.tdb. We protect against this case by the parent smbd taking care of deregistering PIDs from serverid.tdb and the fact that serverid.tdb is CLEAR_IF_FIRST. CLEAR_IF_FIRST does not work in a cluster, so the automatic cleanup does not work when all smbds are restarted. For this, "net serverid wipe" has to be run before smbd starts up. As a convenience, "net serverid wipedbs" also cleans up sessionid.tdb and connections.tdb. While there, this also cleans up overloading connections.tdb with all the process entries just for messaging_send_all(). Volker
2010-02-14s3: convert registry and printing code to TYPESAFE_QSORT()Andrew Tridgell1-3/+2
2009-11-29s3: "print_job_end" only looks at the sizeVolker Lendecke1-2/+1
2009-11-29s3: Pass the "fake dir create times" parameter to sys_*statVolker Lendecke1-1/+2
Step 0 to restore it as a per-share paramter
2009-06-22s3: forward MSG_DEBUG from smbd parent to all childrenAravind Srinivasan1-0/+19
Before 3.3, an smbcontrol debug message sent to the target "smbd" would actually be sent to all running processes including nmbd and winbindd. This behavior was changed in 3.3 so that the "smbd" target would only send a message to the process found in smbd.pid, while the "all" target would send a message to all processes. The ability to set the debug level of all processes within a single daemon, without specifying each pid is quite useful. This was implemented in winbindd in 065760ed. This patch does the same thing for smbd. Upon receiving a MSG_DEBUG the parent smbd will rebroadcast it to all of its children. The printing process has been added to the list of smbd child processes, and we now always track the number of smbd children regardless of the "max smbd processes" setting.
2009-05-27s3: Allow child processes to exit gracefully if we are out of fdsMarc VanHeyningen1-2/+3
When we run out of file descriptors for some reason, every new connection forks a child that immediately panics causing smbd to coredump. This seems unnecessarily harsh; with this code change we now catch that error and merely log a message about it and exit without the core dump. Signed-off-by: Tim Prouty <tprouty@samba.org>
2009-05-26Introduce "struct stat_ex" as a replacement for SMB_STRUCT_STATVolker Lendecke1-1/+1
This patch introduces struct stat_ex { dev_t st_ex_dev; ino_t st_ex_ino; mode_t st_ex_mode; nlink_t st_ex_nlink; uid_t st_ex_uid; gid_t st_ex_gid; dev_t st_ex_rdev; off_t st_ex_size; struct timespec st_ex_atime; struct timespec st_ex_mtime; struct timespec st_ex_ctime; struct timespec st_ex_btime; /* birthtime */ blksize_t st_ex_blksize; blkcnt_t st_ex_blocks; }; typedef struct stat_ex SMB_STRUCT_STAT; It is really large because due to the friendly libc headers playing macro tricks with fields like st_ino, so I renamed them to st_ex_xxx. Why this change? To support birthtime, we already have quite a few #ifdef's at places where it does not really belong. With a stat struct that we control, we can consolidate the nanosecond timestamps and the birthtime deep in the VFS stat calls. At this moment it is triggered by a request to support the birthtime field for GPFS. GPFS does not extend the system level struct stat, but instead has a separate call that gets us the additional information beyond posix. Without being able to do that within the VFS stat calls, that support would have to be scattered around the main smbd code. It will very likely break all the onefs modules, but I think the changes will be reasonably easy to do.
2009-05-11Hopefully fix the buildfarm. Add some debug level 10 messagesJeremy Allison1-1/+7
I used to track down the vlp problem, change the vlp test printer not to use a static path of /tmp/vlp.tdb for the virtual print database (as this will eventually fill up). Cause it to use a virtual print database inside the cachepath. Jeremy.
2009-05-06s3-printing: simplify print_queue helper functions and return WERROR.Günther Deschner1-17/+10
Guenther
2009-04-20Remove smb_mkstemp() - libreplace will now provide a secure mkstemp() ifJelmer Vernooij1-1/+1
the system one is broken.
2009-03-18s3:printing: use tevent_loop_wait() instead of manual loopingStefan Metzmacher1-50/+6
metze
2009-03-18s3:printing: use a fd event to monitor the pipe to the parentStefan Metzmacher1-3/+23
metze
2009-03-12s3-spoolss: make jobname a const char * in print_job_start().Günther Deschner1-1/+1
Guenther
2009-03-01Only copy sharename up from rap_to_pjobidVolker Lendecke1-1/+3
Why?? :-) Another one of the little micro-optimizations that I just came across: If you allocate a variable in a sub-block like the "fstring sharename" in write_file(), gcc even with -O3 will allocate this variable unconditionally on the stack at the beginning of the routine. So with eliminating this fstring we cut 256 bytes of stack in a very hot code path writing to a file. It might make us a bit more cache-friendly. This would probably not be worth a second look if it involved larger code changes, but this one was just too simple to let it pass :-)
2009-02-26s3: fix the build JOB_STATUS_BLOCKED -> JOB_STATUS_BLOCKED_DEVQMichael Adam1-1/+1
Günther, please check... Michael
2009-02-18S3: Stop creating SMBD cores when failing to create a pipe.todd stecher1-3/+7
This was uncovered when the MAX FD limit was hit, causing an instant core and invoking error reporting. This fix causes SMBD to exit, but without building a core.
2009-02-10s3-spoolss: remove more whitespace.Günther Deschner1-135/+135
Guenther
2009-01-27s3:smbd: use signal events for SIGTERM, SIGHUP and SIGCHLDStefan Metzmacher1-15/+3
metze
2009-01-22s3:printing: handle tevent_context events in the sys_select() callStefan Metzmacher1-16/+42
metze
2009-01-16s3: put printing/ under cache_dir, not lock_dirMichael Adam1-2/+2
Michael
2009-01-05clean event context after child is forked.Bo Yang1-1/+2
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2008-12-09Fix bug #5688 LPQ process is orphaned if socket address parameter is invalidSATOH Fumiyasu1-6/+33
2008-12-07Fix nonempty blank linesVolker Lendecke1-5/+5
2008-10-14Use {u,}int64_t instead of SMB_BIG_{U,}INT.Jelmer Vernooij1-2/+2
2008-07-16Allow %u parameters for print job username - use advanced subJim McDonough1-3/+5
Based on 3.0 and 3.2 patch from Bo Yang <boyang@novell.com> Bo, please verify this version works for you. (This used to be commit 9e6760cfeaf77e80df3b84004090d934f3c2d574)
2008-06-26Change print_access_check to take auth_serversupplied_info instead of ↵Volker Lendecke1-45/+48
current_user Reason: This is the main user of p->current_user which I would like to remove (This used to be commit fd43059b3dfa8cdac9814de1c76f963ba5de9bcb)
2008-05-05Remove "userdom_struct user" from "struct user_struct"Volker Lendecke1-3/+6
(This used to be commit 420de035237bb08bc470c9eb820f3da2edaa6805)
2008-04-23Fix CLEAR_IF_FIRST handling of messages.tdbVolker Lendecke1-1/+1
We now open messages.tdb even before we do the become_daemon. become_daemon() involves a fork and an immediate exit of the parent, thus the parent_is_longlived argument must be set to false in this case. The parent is not really long lived :-) (This used to be commit 4f4781c6d17fe2db34dd5945fec52a7685448aec)
2008-04-18printing: call reinit_after_fork() in the backgroundqueue processStefan Metzmacher1-0/+5
metze (This used to be commit 9adb675a86e81c90e2bddfe984b5ac8f201fec75)
2008-04-09Fix typos.Karolin Seeger1-1/+1
Karolin (This used to be commit 6cee34703503fbf3629057345fe221b866560648)
2008-03-26use tdb_wipe_all() instead of tdb_wipe() - it is faster...Michael Adam1-1/+1
Michael (This used to be commit 3d2fdcd50fdbfb66a14360516836445d47eceeb0)
2008-03-25util_tdb: add a wrapper tdb_wipe() for traverse with tdb_traverse_delete_fn().Michael Adam1-1/+1
Replace all callers of traverse with this tdb_traverse_delete_fn() and don't export tdb_traverse_delete_fn() anymore. Michael (This used to be commit d4be4e30cd8c3bdc303da30e42280f892a45a8c9)
2008-02-08Fix some typos.Karolin Seeger1-1/+1
Karolin (This used to be commit 2bec0a1fb7857e6fb8ec15e5f597b2d4125f105b)
2007-12-28Remove a globalVolker Lendecke1-9/+15
(This used to be commit 515f6a8cff7e28b0e98136f3214ef52512cfaf37)
2007-12-10Tiny simplificationsVolker Lendecke1-1/+1
locking.c:open_read_only was unused don't export the silly boolean flag locking_init(bool read_only) (This used to be commit 2f3c865707010bc7c463a02782dbee3dc2479da1)
2007-12-10remove a staticVolker Lendecke1-12/+18
(This used to be commit 0006b14d38b80562458b37f616c9b68a3168fe64)
2007-12-03Change tdb_unpack "P" to return a malloc'ed string ratherJeremy Allison1-3/+7
than expect a pstring space to put data into. Fix the (few) callers. Jeremy. (This used to be commit 7722a7d2c63f84b8105aa775b39f0ceedd4ed513)
2007-11-20Remove pstrcpy I missed.Jeremy Allison1-1/+0
Jeremy. (This used to be commit f5701756154e4e113414d8dd6c850685a2594801)
2007-11-19Remove more pstring. Unify talloc_sub functions to makeJeremy Allison1-30/+51
them a better match for replacing string_sub. Remove more unused code. Jeremy. (This used to be commit ae7885711f504f1442335f09088cbe149a7e00f9)
2007-10-18RIP BOOL. Convert BOOL -> bool. I found a few interestingJeremy Allison1-37/+37
bugs in various places whilst doing this (places that assumed BOOL == int). I also need to fix the Samba4 pidl generation (next checkin). Jeremy. (This used to be commit f35a266b3cbb3e5fa6a86be60f34fe340a3ca71f)
2007-10-10r25399: Excise uint - > uint32 (where appropriate) or unsigned int.Jeremy Allison1-1/+1
Jeremy. (This used to be commit b4ee924000f4a21b16a70e08e58331d209c4d114)