summaryrefslogtreecommitdiff
path: root/source3/printing/printing.c
AgeCommit message (Collapse)AuthorFilesLines
2007-10-10r13915: Fixed a very interesting class of realloc() bugs found by Coverity.Jeremy Allison1-6/+2
realloc can return NULL in one of two cases - (1) the realloc failed, (2) realloc succeeded but the new size requested was zero, in which case this is identical to a free() call. The error paths dealing with these two cases should be different, but mostly weren't. Secondly the standard idiom for dealing with realloc when you know the new size is non-zero is the following : tmp = realloc(p, size); if (!tmp) { SAFE_FREE(p); return error; } else { p = tmp; } However, there were *many* *many* places in Samba where we were using the old (broken) idiom of : p = realloc(p, size) if (!p) { return error; } which will leak the memory pointed to by p on realloc fail. This commit (hopefully) fixes all these cases by moving to a standard idiom of : p = SMB_REALLOC(p, size) if (!p) { return error; } Where if the realloc returns null due to the realloc failing or size == 0 we *guarentee* that the storage pointed to by p has been freed. This allows me to remove a lot of code that was dealing with the standard (more verbose) method that required a tmp pointer. This is almost always what you want. When a realloc fails you never usually want the old memory, you want to free it and get into your error processing asap. For the 11 remaining cases where we really do need to keep the old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR, which can be used as follows : tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size); if (!tmp) { SAFE_FREE(p); return error; } else { p = tmp; } SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the pointer p, even on size == 0 or realloc fail. All this is done by a hidden extra argument to Realloc(), BOOL free_old_on_error which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR macros (and their array counterparts). It remains to be seen what this will do to our Coverity bug count :-). Jeremy. (This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
2007-10-10r13622: Allow to rename machine accounts in a Samba Domain. This still uses theGünther Deschner1-2/+4
"rename user script" to do the rename of the posix machine account (this might be changed later). Fixes #2331. Guenther (This used to be commit b2eac2e6eb6ddd1bcb4ed5172e7cd64144c18d16)
2007-10-10r13293: Rather a big patch I'm afraid, but this should fix bug #3347Jeremy Allison1-7/+8
by saving the UNIX token used to set a delete on close flag, and using it when doing the delete. libsmbsharemodes.so still needs updating to cope with this change. Samba4 torture tests to follow. Jeremy. (This used to be commit 23f16cbc2e8cde97c486831e26bcafd4ab4a9654)
2007-10-10r10656: BIG merge from trunk. Features not copied overGerald Carter1-46/+113
* \PIPE\unixinfo * winbindd's {group,alias}membership new functions * winbindd's lookupsids() functionality * swat (trunk changes to be reverted as per discussion with Deryck) (This used to be commit 939c3cb5d78e3a2236209b296aa8aba8bdce32d3)
2007-10-10r10555: a few compile warnings from jason MaderGerald Carter1-3/+3
(This used to be commit 88998fa0b919fec4966d171a9c7b4f875bc1e26a)
2007-10-10r10371: Adding iPrint printing backend written by Joel J. Smith @ Novell.Jeremy Allison1-0/+6
Jeremy. (This used to be commit 155dc2d52a971bfb8d7565c06f3efc637e130b11)
2007-10-10r9244: Fix bugs found by Coverity.Jeremy Allison1-3/+21
Jeremy. (This used to be commit bf80edeea70cb4ed90f9e1e7adeedeb9cf3b38c1)
2007-10-10r8686: Revert %LOGONSERVER%-substitution. The substition is done on the client,Günther Deschner1-1/+1
not on the server. We now preserve this windows variable (important for vampired setups) and correctly substitute only the "%L"s in strings like: "%LOGONSERVER% %L %lOgOnSeRvEr% %L". Guenther (This used to be commit dccf777f42ce1d3f788548842fb8a606bed5708c)
2007-10-10r8506: BUG 2853: don't strip out characters like '$' from printer namesGerald Carter1-16/+8
when substituting for the lpq command. (This used to be commit 2f5de718a98e56fe55d8905b12505dfc3e432544)
2007-10-10r7829: fix unitialized printer status field that was breaking migration of ↵Gerald Carter1-0/+2
print queues (This used to be commit ada1d326aeef4a2f33a360a8ea4a874e59fcfee6)
2007-10-10r6890: Refactor printing interface to take offset into job. Fixes bugJeremy Allison1-2/+3
where large print jobs can have out-of-order offsets. Bug found by Arcady Chernyak <Arcady.Chernyak@efi.com> Jeremy. (This used to be commit 482f7e0e3706098b71aa0b31a134994acb1e9fcf)
2007-10-10r6490: BUG 1998: patch from Olaf Imig <Olaf.Imig@bifab.de>; fix byte ↵Gerald Carter1-3/+9
ordering bug when storing 16-bit RAP print job ids (This used to be commit 2c66a4098a3c9ca0a12160d4193d65085ece1dfe)
2007-10-10r5993: compiler warning fixGerald Carter1-1/+1
(This used to be commit 4e8b868e6e29513a0c4c1b8992a502d5b6cf2c3d)
2007-10-10r5950: more compiler warning's from Jason MaderGerald Carter1-2/+2
(This used to be commit 27c6e85ad59a86ab45ae3297c7445c4ff15546c8)
2007-10-10r5807: fix segfault after compiler warning clean up (and cleanup another ↵Gerald Carter1-4/+4
warning) (This used to be commit 2dae527e217ff9da2ad9f434bf1280744e93fad7)
2007-10-10r5770: Get rid of some compiler warningsVolker Lendecke1-28/+17
(This used to be commit 96a0f7d60c973e9f74ac90e3c79f94a01770f681)
2007-10-10r5691: wrapping the pause/resume/purge printer commands inGerald Carter1-53/+62
{become,unbecome}_root() blocks. We've already done a print_access_check() to ensure the user is admin. The means that non-root users can pause and manage printers. I really don't see how this worked before without setuid binaries on the server. Also update print_queue_update() interface to allow an smbd to update the print queue cache locally rather than going through the bg lpq daemon. This is needed for things like pjob_delete() to ensure the cache is current for the specific client. (This used to be commit f75369ec865f4ba1ae8201ae750c0f45158ed536)
2007-10-10r4662: Fix from "Jerome Borsboom" <j.borsboom@erasmusmc.nl> to fixJeremy Allison1-0/+1
missing release reference for printer tdb. Jeremy. (This used to be commit 5942bb7737fe8efc452d59cda0d6e35e309c97b7)
2007-10-10r4539: patch from Rob -- adding real printcap name cache function to speed ↵Gerald Carter1-1/+1
up printcap reloads (This used to be commit 1cad5250932b963c2eb9b775221b13db386d601b)
2007-10-10r4094: BUG 2107: fix memory bloating caused by large numbers of ↵Gerald Carter1-35/+136
print_queue_updates() requests sent via messages.tdb (This used to be commit 56b1110c71b17eeb2ebdb7d506d86deb6b81f0d5)
2007-10-10r4088: Get medieval on our ass about malloc.... :-). Take control of all our ↵Jeremy Allison1-4/+4
allocation functions so we can funnel through some well known functions. Should help greatly with malloc checking. HEAD patch to follow. Jeremy. (This used to be commit 620f2e608f70ba92f032720c031283d295c5c06a)
2007-10-10r4028: * prevent the background LPQ daemon from updatingGerald Carter1-63/+85
the print queue cache just because multiple smbd processes sent a message that it was out of date. * add some extra debug messages while trying to track down down jobs being left in the queue after printing has completed. (This used to be commit a64505d52fcb23374711e22b3df328c9a7848b84)
2007-10-10r3867: Fix from david.hu@hp.com - make a copy of an incoming messageJeremy Allison1-5/+5
rather than indirecting into it as a struct (may not be on an even byte boundary). Bug #2052. Jeremy. (This used to be commit 8a91a69961622a31851f2394c591ddaa61a36000)
2007-10-10r3067: patch based on volker's initial work in trunk that fixes the queu ↵Gerald Carter1-211/+301
update problem when using the background daemon (This used to be commit de7af09e727e744aa27af85ef7c0f73ed5c1550a)
2007-10-10r2569: Patch from Rob Foehl <rwf@loonybin.net>:Gerald Carter1-4/+0
- fix typo in libads/ldap_printer.c:39, ads_find_printer_on_server() (originally libads-typo.patch) - fix leak in printing/nt_printing.c, is_printer_published() (originally is_printer_published-leak.patch) - fix double print_backend_init() calls, now only called from main() - restructuring in printing/nt_printing.c - replaced (un)publish_it() with ads-specific functions - moved common code to nt_printer_publish() - improved error handling in several places - added check_published_printers() in printing/nt_printing.c, to verify that each published printer is actually in the directory at startup - changed calling semantics of mod_a_printer, dump_a_printer, and update_driver_init to be more consistent with the rest of the api and reduce some copying (This used to be commit 50a5a3dbd02acb0d09133b6e42cc37d091ea901d)
2007-10-10r2191: ensure that we assign our pid to print jobs (and not our parent's ↵Gerald Carter1-17/+8
pid); ensures that spooling jobs from dead smbds are removed from the tdb (This used to be commit 9e42d016e1fee9ac999dadc383eb5db45ed79b00)
2007-10-10r2133: Several fixes:Gerald Carter1-14/+15
* BUG 1627: fix for NIS compiles on HPUX 11.00, AIX 4.3 and 5.1 patch from Olaf Flebbe <o.flebbe@science-computing.de>. Will need to watch this one in the build farm. * Fix bug found by rwf@loonybin.net where the PRINT_ATTRIBUTE_PUBLISHED was getting reset by attempts to sanitize the defined attributes (PRINTER_ATTRIBUTE_SAMBA) * Resolve name conflict on DEC OSF-5.1 (inspired by patch from Adharsh Praveen <rprav@india.hp.com>) * Work around parsing error in the print change notify code (not that the alignment bug is still there but reording the entries in the array works around it). * remove duplicate declaration of getprintprocdir from rpcclient. (This used to be commit 7474c6a446037f3ca2546cb6984d800bfc524029)
2007-10-10r1885: tighten the cache consistency with the ntprinters.tdb entry an the in ↵Gerald Carter1-1/+1
memory cache associated with open printer handles; also make sure that register_messages_flags() doesn't overwrite the originally registers flags (This used to be commit 540daf71d8ad189af5dd6d45aa1ce2b3d67da752)
2007-10-10r1384: ensure we remove the tdb entry for a job in the spooling stateGerald Carter1-3/+0
(This used to be commit bc8cf6c852617b266f6dabed84bbd912a188f3a3)
2007-10-10r1295: To be able to send a message to the background queue updated, we need ↵Volker Lendecke1-3/+7
to be root. Otherwise the USR1 signal will not be delivered. Volker (This used to be commit c66be874d8ce1f381518e07025305222bac1ab3a)
2007-10-10r1230: (merges from HP PSA) fixing a couple of caching bugs in the printing ↵Gerald Carter1-0/+1
code. (a) make sure to clear jobs_changed list when deleting a job and, (b) invalidate the printer handle cache when we get a notification that something has changed on that printer (This used to be commit e3d4fea7808abc77bfdb1a540ab18afe04af5030)
2007-10-10r925: add changes frpm trunk (r841 and r842) -- enable background queue ↵Gerald Carter1-1/+87
update process and allow printers to have different sharenames from printernames (This used to be commit 066b9c4276a968788a03709a00d4f672ac032df7)
2007-10-10r560: Fix bugzilla 1279: cannot control individual print jobs using cupsJim McDonough1-3/+3
Store the print job using a little-endian key. (This used to be commit e0491dae989ea289438de3bdf29d8810d409a01b)
2007-10-10r555: Fix big-endian storage of jobids in jobs_changed list. Found duringJim McDonough1-1/+3
debugging of 1279 (This used to be commit 7c1cfb16c0b2f0128afca0b01036567253a3f92a)
2004-03-16merging print change notify fix from HP appliance. Also might address some ↵Gerald Carter1-2/+16
one the issues in BUG 1007 (This used to be commit 17ecea4152fb0883acde675b01f19d3e19ff1d64)
2004-03-15fix byte ordering problem when storing the updating pid for the lpq cache; ↵Gerald Carter1-2/+5
was causing an abort in process_exists() on solaris (This used to be commit 26681cd2a1567d90cc7d344e8aca6e6a686053f5)
2004-03-05fix compiler warningGerald Carter1-1/+1
(This used to be commit df19b6066e1f4e200adcd80f9526aa1a68509580)
2004-03-02allow the 'printing' parameter to be set on a per share basis.Gerald Carter1-7/+29
The problem was that the current_printif struct was set during print_backend_init() based on the 'printcap name'. So you could not use cups and then override the setting for a specific printer by setting 'printing = bsd' (a common setup for pdf generation print services. There is a subtle change in behavior in that the print interface functions are selecting on the basis of lp_printing() and not lp_printcap_name(), but the new behavior seems more intuitive IMHO. (This used to be commit 14de9c065787bd1675021a6cd6555f81ea965f17)
2004-03-01BUG 1147; bad pointer case in get_stored_queue_info() causing seg faultGerald Carter1-1/+1
(This used to be commit 91af1fb73a2e86a343c085128aaed2ef0c26de57)
2004-01-14bug 770; correct fix this time; Make sure that we send the SMBjobid for ↵Gerald Carter1-9/+17
unix jobs back to the client. Allows windows client to remove print jobs submitted from lpr (This used to be commit 514561118860f982c458930c34763dac9ce0554e)
2004-01-14bug 660; using byte order safe macros (or tdb_unpack) when reading 2 or 4 ↵Gerald Carter1-16/+18
byte values from a tdb buffer (This used to be commit be9f25bea94415af6b631a9c6e7af28d9d6e6565)
2003-12-01don't mistake pre-existing UNIX jobs for smb jobs; patch from SATOH Fumiyasu ↵Gerald Carter1-3/+5
bug 770 (This used to be commit 3a55788dca537248d0aea9973a84075e142b7736)
2003-11-25allow users to delete jobs with cups printing backendGerald Carter1-0/+2
The changes the name of the job passed off to cups from "Test Page" to "smbprn.00000033 Test Page" so that we can get the smb jobid back from lpq. Working on bug 770. (This used to be commit 5979f4d645e84fb22223e6cbf0043f2fa21acb2f)
2003-11-13* Fix from SATOH Fumiyasu for bug 660 (failing to view printGerald Carter1-2/+2
jobs) by only enforce the 'max reported print jobs' parameter when it is non-zero. * Fixed bug 338 by making sure that data values are written out when we are marshalling an EnumPrinterDataEx() reply. This probably fixes other bugs reported against point-n-print feature in 3.0.0 (This used to be commit fd98af75d655449a677360f6991da5caabc88b4d)
2003-11-12a small include file rearrangement that doesn't affect normalAndrew Tridgell1-0/+1
compilation, but that allows Samba3 to take advantage of pre-compiled headers in gcc if available. (This used to be commit b3e024ce1da7c7e24fcacd8a2964dd2e4562ba39)
2003-09-11fix unitiailized timestamp where merging print_jobs and lpq listingGerald Carter1-0/+1
(This used to be commit 8382cd6796992e55bf10f381089cb740052a0bca)
2003-07-10i guess i'm the only one this ever annyoed...Gerald Carter1-2/+2
fix the confusion when we tdb_lock_bystring() but we retrieve an entry using tdb_fetch_by_string. It's now always tdb.*bystring() (This used to be commit 66359531b89368939f0e8f584a45844b5f2f99e7)
2003-07-01fix typos in log messages and comments.Gerald Carter1-1/+1
(This used to be commit fd24183ec30688f3699e466bd4d908b24918e328)
2003-04-16Fix mem leak. Spotted by tpot (thanks Tim).Jeremy Allison1-0/+1
Jeremy. (This used to be commit 03a1f46e3448913cc21ed89aafaa22818d4026d0)
2003-04-10Grr. Get rid of one of the extra NULL's that crept in from app-head.Jeremy Allison1-1/+1
Spotted by Andrew Esh. Jeremy. (This used to be commit 9e6e6c3f50844cf4322d6dd193c4e24b76bae9ba)
generated by cgit (git 2.34.1) at 2024-12-26 12:46:09 +0000