summaryrefslogtreecommitdiff
path: root/source3/printing
AgeCommit message (Collapse)AuthorFilesLines
2009-03-01Only copy sharename up from rap_to_pjobidVolker Lendecke2-3/+4
Why?? :-) Another one of the little micro-optimizations that I just came across: If you allocate a variable in a sub-block like the "fstring sharename" in write_file(), gcc even with -O3 will allocate this variable unconditionally on the stack at the beginning of the routine. So with eliminating this fstring we cut 256 bytes of stack in a very hot code path writing to a file. It might make us a bit more cache-friendly. This would probably not be worth a second look if it involved larger code changes, but this one was just too simple to let it pass :-)
2009-02-27s3-spoolss: use DSPRINT flags instead of SPOOLS_DS flags.Günther Deschner1-6/+6
Guenther
2009-02-26s3: fix the build JOB_STATUS_BLOCKED -> JOB_STATUS_BLOCKED_DEVQMichael Adam1-1/+1
Günther, please check... Michael
2009-02-25Fix some NetBSD warnings.Jeremy Allison1-2/+4
Jeremy.
2009-02-24s3-spoolss: use marshall/unmarshall_sec_desc_buf in nt_printing_setsec/getsec.Günther Deschner1-45/+35
Guenther
2009-02-24s3-spoolss: fix notify_printer_status_byname.Günther Deschner1-1/+3
This took me almost a week to find, so here a little longer explanation: When a windows client registers printer *status* change notifies using spoolss_RemoteFindFirstChangeNotify, it registers them to a print server handle, not a printer handle. We were then correctly monitoring the printer status changes but were sending out the spoolss_RouterReplyPrinterEx via the back-channel connection with job_id set to 0 (which we only may do for monitored printer change status notifies on printer handlers, not print server handles). Windows was then showing a new empty dummy printer icon in the explorer as it cannot route the notify event to the approriate local handle. It also discarded the content of the notify event message of course. With this, printer change notify for pausing, resuming and purging printers nicely works again here. Jerry, Tim and all other printing gurus, please check. Guenther
2009-02-19Fix printf warnings found on systems where time_t <> long int.Jeremy Allison1-1/+1
Jeremy.
2009-02-18S3: Stop creating SMBD cores when failing to create a pipe.todd stecher1-3/+7
This was uncovered when the MAX FD limit was hit, causing an instant core and invoking error reporting. This fix causes SMBD to exit, but without building a core.
2009-02-13Fix Coverity ID 740 (RESOURCE_LEAK)Volker Lendecke1-0/+2
2009-02-10s3-spoolss: remove more whitespace.Günther Deschner1-135/+135
Guenther
2009-02-09s3-spoolss: remove whitespace in printing code.Günther Deschner1-322/+322
Guenther
2009-02-09s3-spoolss: restore delete_a_form().Günther Deschner1-10/+1
Guenther
2009-02-09s3-spoolss: use pidl for _spoolss_SetForm.Günther Deschner1-12/+10
Guenther
2009-02-09s3-spoolss: use pidl for spoolss_AddForm.Günther Deschner1-15/+13
Guenther
2009-02-07s3-spoolss: rework some form functions and add form_by_string functions.Günther Deschner1-10/+21
Guenther
2009-01-27s3:smbd: use signal events for SIGTERM, SIGHUP and SIGCHLDStefan Metzmacher1-15/+3
metze
2009-01-22s3:printing: make some functions static and use tevent functionsStefan Metzmacher1-8/+12
metze
2009-01-22s3:printing: handle tevent_context events in the sys_select() callStefan Metzmacher1-16/+42
metze
2009-01-16s3: put printing/ under cache_dir, not lock_dirMichael Adam3-4/+4
Michael
2009-01-05Attempt to fix crash seen with new CUPS async printcap loading code.Jeremy Allison1-0/+3
Jeremy.
2009-01-05Merge branch 'master' of ssh://git.samba.org/data/git/sambaJelmer Vernooij3-4/+5
2009-01-05s3:events: change event_add_timed() prototype to match samba4Stefan Metzmacher1-2/+1
metze
2009-01-05clean event context after child is forked.Bo Yang2-2/+4
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2009-01-01Add iconv_convenience argument to size functions.Jelmer Vernooij1-3/+4
2008-12-31Fix an ancient uninitialized variable readVolker Lendecke1-5/+5
The callers of open_file_ntcreate expect *psbuf to be filled correctly
2008-12-30Fix a memory leak in cups_pull_comment_locationVolker Lendecke1-0/+4
We allocated "request" with ippNew, so we also should ippDelete it.
2008-12-30Fix a spinning smbd when printingVolker Lendecke1-1/+1
Without this, we end up adding more than one timed event. In the event handler print_notify_event_send_messages() only one event will be deleted, all others will fire indefinitely.
2008-12-23Fix more asprintf warnings and some error path errors.Jeremy Allison2-12/+14
Jeremy.
2008-12-23Fix more asprintf errors and error code paths.Jeremy Allison1-3/+5
Jeremy.
2008-12-09Fix bug #5688 LPQ process is orphaned if socket address parameter is invalidSATOH Fumiyasu1-6/+33
2008-12-07Fix nonempty blank linesVolker Lendecke1-5/+5
2008-12-03s3: Change SMB_VFS_CREATE_FILE to take a create_file_flags argumentTim Prouty1-3/+3
This replaces the is_dos_path bool with a more future-proof argument. The next step is to plumb INTERNAL_OPEN_ONLY through this flag instead of overridding the oplock_request.
2008-12-03s3: Modify direct callers of open_file_ntcreate and open_directory to call ↵Tim Prouty1-24/+54
SMB_VFS_CREATE_FILE
2008-11-24Convert delete_driver_files to use create_conn_structVolker Lendecke1-30/+32
Jerry, please check!
2008-11-24Convert get_correct_cversion to use create_conn_structVolker Lendecke1-45/+50
Jerry, please check!
2008-11-24Convert move_driver_to_download_area to use create_conn_structVolker Lendecke1-33/+23
This removes a use of struct current_user and the vuid The become_user() here is unnecessary, within the spoolss handling code we have switched to the authenticated pipe user anyway. Jerry, please check!
2008-11-21First part of fix for bug #5903 - vfs_streams_xattr breaks contents of the file.Jeremy Allison1-13/+2
Restructures parts of open code so that fsp must be allocated before calling open_file_ntcreate(_internal). Also fix up file ref-counting inside files.c. Jeremy.
2008-11-02Remove an unused variableVolker Lendecke1-1/+0
2008-11-01Rename dos_errstr() to win_errstr() for consistency with Samba 4.Jelmer Vernooij1-2/+2
2008-10-31Unify se_access_check with the S4 code. Will makeJeremy Allison1-5/+5
calculation of SEC_FLAG_MAXIMUM_ALLOWED much easier for files. Jeremy.
2008-10-29Allow a new file to inherit the Windows ACL from its parent.Jeremy Allison1-3/+3
Now to do the same for directories. Jeremy.
2008-10-19vlp: Move closer to the code tested.Kai Blin2-0/+450
2008-10-19Remove silly safe_free() function which is a wrapper around SAFE_FREE().Jelmer Vernooij3-10/+9
Since it's a function it just sets the local pointer to NULL and basically is an equivalent to free(). It also claims it's being used for callbacks but isn't used that way anywhere.
2008-10-14Use GUID_from_string.Jelmer Vernooij1-1/+1
2008-10-14Use GUID_string rather than smb_uuid_string().Jelmer Vernooij1-2/+2
2008-10-14Use {u,}int64_t instead of SMB_BIG_{U,}INT.Jelmer Vernooij1-2/+2
2008-10-13Pass struct smb_request to file_freeVolker Lendecke2-7/+7
on the way to get rid of chain_fsp
2008-10-13Pass struct smb_request to file_newVolker Lendecke1-2/+3
Goal is to remove the chain_fsp global variable
2008-10-12Use common util_file code.Jelmer Vernooij3-11/+11
2008-10-12Fix the buildVolker Lendecke1-1/+1