summaryrefslogtreecommitdiff
path: root/source3/registry/reg_api.c
AgeCommit message (Collapse)AuthorFilesLines
2009-04-21s3-secdesc: move all winreg access bits to IDL.Günther Deschner1-14/+14
Guenther
2009-04-17s3:registry: Prevent creation of keys containing the '/' character.Michael Adam1-0/+10
This creates a broken registry that can only be fixed with tdbtool, since the '/' sign is used as a key separator after normalization at a lower level. This makes e.g. "net conf setparm abc/def comment xyz" fail with WERR_INVALID_PARAM, which is much more desirable than a broken registry.tdb. Michael
2009-02-26s3:registry: tighten the subkey loop in reg_deletekey_recursive()Michael Adam1-16/+13
and loop from the end to the beginning so that we don't need to rehash the subkeys... This gets "net conf drop" with 2000 shares down to 14 seconds on my box. Michael
2009-02-26s3:registry: use delete_reg_subkey() in reg_deletekey()Michael Adam1-15/+1
This further speeds up net conf drop. Michael
2009-02-26s3:registry: streamline reg_deletekey() somewhat.Michael Adam1-25/+19
use W_ERROR_... macros and separate assignments from checks Michael
2009-02-26s3:registry: use create_reg_subkey() in reg_createkey().Michael Adam1-8/+2
Instead of calling store_reg_keys() On my box, importing 2000 shares into an empty smbconf key now takes some 32 seconds. Michael
2009-02-26s3:registry: hash the list of subkeys in the regsubkey_ctrMichael Adam1-5/+5
This removes many loops over all the arrays (from regsubkey_ctr_key_exists) and thus reduces "net conf drop" from 1m55 to 48seconds and "net conf import" from 1m55 to 58 seconds for 2000 shares on my box. Michael
2009-02-26s3:registry: use regsubkey_ctr_init() in reg_api.cMichael Adam1-13/+10
instead of using talloc on struct regsubkey_ctr. Michael
2009-02-26s3:registry: don't directly access key->subkeys->subkeys[] in reg_api.cMichael Adam1-2/+5
Use the reg_objects accessor regsubkey_ctr_specific_key() instead. Michael
2009-02-26s3:registry: don't directly access key->subkeys->num_subkeys in reg_api.cMichael Adam1-5/+5
Use the reg_objects api instead. Michael
2009-02-26s3:registry: replace typedef "REGSUBKEY_CTR" by "struct regsubkey_ctr"Michael Adam1-8/+8
This paves the way for hiding the typedef and the implementation from the surface. Michael
2009-02-26s3:registry: wrap deletekey_recursive in one big transaction.Michael Adam1-2/+38
This speeds up "net conf drop" with 2000 shares on my box from 4m40s to 1m50s, leaving virtually only cpu load. Michael
2009-01-01Add iconv_convenience argument to size functions.Jelmer Vernooij1-1/+1
2008-11-01Rename dos_errstr() to win_errstr() for consistency with Samba 4.Jelmer Vernooij1-1/+1
2008-04-13registry: honour the WERROR that regsubkey_ctr_addkey gives us in reg_load_tree.Michael Adam1-1/+5
Michael (This used to be commit c2d9baa29edb2356f32ca19aea828184e9ac7b93)
2008-04-13registry: remove the REGISTRY_HOOKS layer from the reghook cache.Michael Adam1-8/+8
There is no need to save the keyname again, we only need to get the REGISTRY_OPS out of the pathtree. Furthermore, this makes life easier, since we can now pass in keynames as temporarily allocated strings. Michael (This used to be commit 2f9ee2f782c77ed99669af5ac2ba40cb0978f0da)
2008-03-31registry: reg_deletevalue should return error, when the value does not exist.Michael Adam1-0/+18
Michael (This used to be commit 04b48984bbf84c55bb41a74a11cbcc7358377fed)
2008-02-18Remove (now) unused function make_default_reg_sd().Michael Adam1-48/+0
Michael (This used to be commit 2c66413de284fb4cb9dc7def0ee4eb07b986c9ca)
2008-02-18Grab secdesc for key from registry for reg_savekey()Michael Adam1-10/+9
instead of construction another default secdesc. Michael (This used to be commit 194e00822c349aa0c11641672b35b0e0c021da08)
2008-02-15Reformat copied reg_savekey/reg_restorekey code.Michael Adam1-86/+119
Sticking to coding rules. Michael (This used to be commit 2c54ef2d07ab440f1c163b666caedcb9c061543b)
2008-02-15Move the implementation of _winreg_RestoreKey to reg_api.cMichael Adam1-1/+125
This removes the internals of reg_api from srv_winreg_nt.c entirely, only reg_api is used there, now. This enlarges the dependencies of reg_api somewhat now since it adds regfio. But this can be separated out later. The current goal is to achieve a complete use of reg_api. Michael (This used to be commit 2222acbac955cd6d5bd48d1ce5cf4b4c7c067093)
2008-02-15Move implementation of _winreg_SaveKey() from srv_winreg_nt.c to reg_api.cMichael Adam1-1/+167
This gives a new function reg_savekey() and hides a piece of the backend code from srv_winreg_nt.c. One step towards using reg_api throughout samba code. Michael (This used to be commit bf6340d00dd631fdc909c20632250977a3a112c4)
2008-02-15Adapt a comment to current circumstances.Michael Adam1-3/+1
Michael (This used to be commit 84ec89ab9f7837e8a9830a0236fddc2d00d1c0d6)
2008-01-20Fix some "set but never used" warningsVolker Lendecke1-6/+0
(This used to be commit 4a6dadc5178f4861e9c032321939db3b639734b5)
2008-01-18Fix typo in debug message.Michael Adam1-1/+1
Michael (This used to be commit d7a8d7ffbd724a59aa3fc4bdeca6be5d5a0e7258)
2008-01-17Add a reg_getversion() function to reg_api and use it in srv_winreg_nt.c.Michael Adam1-1/+11
Michael (This used to be commit 903223b160eef6ba6ff19a8bfef19e5fe7008631)
2008-01-17Add my (C) to reg_api.c - MichaelMichael Adam1-0/+1
(This used to be commit 81d6a1fbed5e685376637af8e8bcd70ab2701aa0)
2008-01-17Add a comment header comparing winreg.idl and reg_api.c.Michael Adam1-0/+42
Michael (This used to be commit 15163926a8ae1116a0f0986f35fc16bcf9ce6ce2)
2008-01-17Add reg_api functions reg_getkeysecurity() and reg_setkeysecurity().Michael Adam1-0/+11
These are wrappers around the lower level functions regkey_get_secdesc() and regkey_set_secdesc(). Next step towards hiding reg_frontend from the surface. Michael (This used to be commit 7251a24b489a008243091279d96157cacec35b62)
2008-01-17Comment out unused reg_create_path() and reg_delete_path().Michael Adam1-1/+5
These functions are unused. Comment them out for now. Michael (This used to be commit 0cb8399d7c6f228b38c918f8c6c77fd31c346f89)
2008-01-17Move reg_create_path() and reg_delete_path() to reg_api.cMichael Adam1-0/+95
Michael (This used to be commit 4d82cc586c089a16d1d2db214f5e198062890b58)
2008-01-17Add some sectioning comments to reg_api.cMichael Adam1-0/+15
Michael (This used to be commit d3c9c273740b42e5da101f53d4df3aee70cdacf7)
2008-01-17Make utility function reg_deletekey_recursive_internal() static.Michael Adam1-4/+4
Michael (This used to be commit 3e661273229bcf021276cc0b71350acf8d8fed7c)
2008-01-15Use the proper boolean functions.Michael Adam1-3/+3
Michael (This used to be commit beaa83f32bd367f1b6ec72ef80a8a258d662f523)
2008-01-15Remove some trailing spaces.Michael Adam1-10/+9
Michael (This used to be commit 1941c365b50d48fc90f0f98059b8cccf6c7a1a06)
2008-01-14Add detection for need of update to the registry db.Michael Adam1-2/+6
This only detects if the tdb sequence number has changed since the data has last been read. Michael (This used to be commit 3f081ebeadf30a7943723703ecae479e0412c60c)
2007-12-31Fix a permissions error in reg_deletekey_recursive().Michael Adam1-1/+1
Michael (This used to be commit 4a56d3d7075bd8bbd5e139c9433789ab29f6a70e)
2007-12-29Remove tiny code duplicationVolker Lendecke1-1/+1
ndr_size_security_descriptor does the same as sec_desc_size (This used to be commit bc3bd7a8e7c6e9e27acb195c86abb92c0f53112f)
2007-11-06When deleting a key from the registry make sure the non-defaultGünther Deschner1-4/+7
security descriptor gets deleted as well. Guenther (This used to be commit d140d68537225b6a6a99be3d9b09354e3f6ad8c9)
2007-10-18RIP BOOL. Convert BOOL -> bool. I found a few interestingJeremy Allison1-1/+1
bugs in various places whilst doing this (places that assumed BOOL == int). I also need to fix the Samba4 pidl generation (next checkin). Jeremy. (This used to be commit f35a266b3cbb3e5fa6a86be60f34fe340a3ca71f)
2007-10-10r25417: Use DBGC_REGISTRY class.Günther Deschner1-0/+3
Guenther (This used to be commit 43ca04918a5a1b2379083dc624b346ceb8476a38)
2007-10-10r25370: Allow to delete registry keys recursively without deleting the final ↵Günther Deschner1-10/+31
key. Guenther (This used to be commit e9922cd8aeb70aebb162ad598fda76ad69226b94)
2007-10-10r24418: Adding reg_deleteallvalues().Günther Deschner1-0/+24
Guenther (This used to be commit f7457c6173107f1730ae2e31c5377df3dbd2454e)
2007-10-10r23801: The FSF has moved around a lot. This fixes their Mass Ave address.Andrew Tridgell1-2/+1
(This used to be commit 87c91e4362c51819032bfbebbb273c52e203b227)
2007-10-10r23779: Change from v2 or later to v3 or later.Jeremy Allison1-1/+1
Jeremy. (This used to be commit 407e6e695b8366369b7c76af1ff76869b45347b3)
2007-10-10r23584: Use a while loop instead of a for loop without increment... :-)Michael Adam1-9/+2
Michael (This used to be commit fb4ade3b4d203eead7798b8d98938cff2abb9c29)
2007-10-10r23583: Add a utility function to recursively delete a RegistryMichael Adam1-0/+56
key with all its subkeys. (reg_deletekey will refuse to delete a key with subkeys with WERR_ACCESS_DENIED). Michael (This used to be commit 41c3ff6e277601a9c7ac29009fd89ff9c961ca46)
2007-10-10r23581: Move regkey_open_onelevel from reg_frontend to reg_api,Michael Adam1-2/+110
where it actually belongs, and make it static. Michael (This used to be commit aa702e53a7416b5599ed114089327aef8a4e35b8)
2007-10-10r23578: When calling DeleteKey for a key that has subkey(s), WindowsMichael Adam1-4/+17
returns WERR_ACCESS_DENIED. This adapts reg_deletekey to behave the same way. Michael (This used to be commit 0c9cb69b45e8c51b8c3fa0b0d034a6cad2374055)
2007-10-10r22496: reg_enumvalue should return WERR_NO_MORE_ITEMS instead ofMichael Adam1-1/+1
WERR_BAD_FILE when all items have been successfully enumerated. Besides seeming the reasonable code to return, this is what I have seen from w2k3, w2k, wxp. (This used to be commit e09e0d642d98165257c7c43ca2634a430772dcee)
generated by cgit (git 2.34.1) at 2024-12-25 00:40:43 +0000