summaryrefslogtreecommitdiff
path: root/source3/registry
AgeCommit message (Collapse)AuthorFilesLines
2007-10-10r20626: Fix a memleak found by the IBM checker -- not on 3.0.24Volker Lendecke1-0/+1
(This used to be commit 9d0a789e32e6a6501421edb25bc8197c9e06846d)
2007-10-10r20269: merge -r20264:20267 from SAMBA_3_0_24Herb Lewis1-0/+2
more no previous prototype warnings (This used to be commit 41be182f78762372ae13759ede5d2bd40a71d7f5)
2007-10-10r20210: registry_fetch_values is not needed anymore, fix typoVolker Lendecke2-58/+1
(This used to be commit 77e556f4a358fec0d754e50417097bf5a874c500)
2007-10-10r20209: Fix two memleaksVolker Lendecke1-4/+7
(This used to be commit 92bc870768a2ff839b3b10897a4f09a3ece92704)
2007-10-10r20037: Reduce code size slightly by shuffling stuff aroundVolker Lendecke2-116/+68
(This used to be commit 0742faaacd496f9cc4581a1fad74217024383661)
2007-10-10r20020: Arglll... eventlogadm links against reg_db but not the rest of the ↵Volker Lendecke2-106/+91
registry stuff. Revert the last change. This needs better fixing. Volker (This used to be commit ad1e00430bf5c4130023d30e9c8266ecdc640d2b)
2007-10-10r20019: Replace one set of tricky code by calls to another set of tricky code:Volker Lendecke2-91/+106
Initializing the reg_db now uses reg_createkey and reg_setvalue. Volker (This used to be commit cab5ccbbe484795f13531726d68b978073262e33)
2007-10-10r20018: Fix a memleak in reg_createkeyVolker Lendecke1-2/+4
(This used to be commit 281640823bfe25f513f44f6c6d7022a11b957fa5)
2007-10-10r20016: Add two utility functions for easy opening/creating registry keysVolker Lendecke1-1/+95
(This used to be commit ad22a467185e871d893e8133741b525889c2aa6f)
2007-10-10r20005: reg_open_path should become the replacement for regkey_open_internal.Volker Lendecke1-0/+58
(This used to be commit a6039eb46c6506b4e55e816d50edb618e800007f)
2007-10-10r20004: Remove a const, "name" is allocated anywayVolker Lendecke1-2/+1
(This used to be commit dc0300ec70ff67aaec9b0bab6a1dd4d0e6fde5ac)
2007-10-10r19991: Sorry for this 2000-liner...Volker Lendecke2-33/+541
The main thing here is a rewrite of srv_winreg_nt.c. The core functionality has moved to registry/reg_api.c which is then usable by the rest of Samba as well. On that way it fixes creating keys with more than one element in the path. This did not work before. Two things that sneaked in (sorry :-) is the change of some routines from NTSTATUS to WERROR the removed "parent" argument to regkey_open_internal. Volker (This used to be commit fea52801de8c7b85c578d200c599475680c5339f)
2007-10-10r19990: Fix commentVolker Lendecke1-1/+1
(This used to be commit 8b3d860f27d166f1a0b8019f9c9c91355c6becdf)
2007-10-10r19963: Add 'registry shares = yes' and registry key security descriptors.Volker Lendecke5-58/+334
(This used to be commit 6cab254c49e07b11c170511ec613f0f33914c3e6)
2007-10-10r19948: Fix a memleakVolker Lendecke1-1/+3
(This used to be commit fd429c8c06e01452f04700518c93ecfaa51c3140)
2007-10-10r19947: Change regkey_open_internal to take the parent key and a talloc_ctx asVolker Lendecke1-35/+49
arguments. This also replaces regkey_close_internal by TALLOC_FREE. Volker (This used to be commit a177bbb2d5611f03cec25b7577c2e6a542f94a69)
2007-10-10r19913: Fix a const warningVolker Lendecke1-1/+1
(This used to be commit a660993d140b860691c3ed0b71d3e8023e5a7c57)
2007-10-10r19912: Move the subkey cache to srv_winreg_nt.cVolker Lendecke1-57/+0
(This used to be commit 01a53590a6325413551016effe302585a3a1e656)
2007-10-10r19872: Move the value cache to srv_winreg_nt.c. Fix some minor issues found ↵Volker Lendecke1-54/+0
while playing with regedit.exe. Volker (This used to be commit 81bd816fa2afe89261aff2f395e8d056b73e515c)
2007-10-10r19858: Fix a memleak, add a constVolker Lendecke1-1/+2
(This used to be commit ed4dc405127cefd1c222e1bdd63fcaaae8e83f13)
2007-10-10r19853: Update a linkVolker Lendecke1-0/+4
(This used to be commit ce44158dde64cb65a3f51dfe1734f3c3d7f1bfd9)
2007-10-10r19841: Wrap regdb_store_keys and regdb_store_values in tdb transactionsVolker Lendecke1-18/+52
(This used to be commit 5ec737922041b723b9e60c08049ace5fa2fa5dec)
2007-10-10r19839: Fix the build, we are not there yet :-)Volker Lendecke1-1/+0
(This used to be commit ff4123c8f2e07e282800c166a4e00b1015ddd45c)
2007-10-10r19838: We have to delete the value record as well, otherwise the old values ↵Volker Lendecke1-0/+4
pop up again if the key is re-created. Volker (This used to be commit f722f3341f65f8737c10eb59048c1263a58afd44)
2007-10-10r19837: Some reformatting (Jerry, I hope you do not mindVolker Lendecke1-4/+9
(This used to be commit 6639f8c1190419e183d92ed0322e1026375717e6)
2007-10-10r19828: Add a helper function to pull *and* unparse local registry valuesVolker Lendecke1-0/+56
(This used to be commit 969eb9cda6eba93068472e952e27138b9384c364)
2007-10-10r19780: Ok, regkey_open_internal needs a regkey_close_internal. Giving a ↵Volker Lendecke1-3/+2
talloc ctx is misleading here. This needs fixing properly :-) Volker (This used to be commit f808182346aa16bb2f3a9383e28d318099a5e14e)
2007-10-10r19779: Fail properly on talloc_strdup failureVolker Lendecke1-3/+5
(This used to be commit b57e446789530cb7e18e107478ca8b59a19d990f)
2007-10-10r19778: Make regkey_open_internal take a talloc ctxVolker Lendecke1-2/+3
(This used to be commit cb7f4211b8441642dce9594522dc9588475a7719)
2007-10-10r19777: Make regsubkey_ctr_addkey return WERROR. Nobody checks this so far, ↵Volker Lendecke1-20/+22
but this will change. Volker (This used to be commit 17c7c337f64b082c1bf1045a4093c279deeec958)
2007-10-10r18745: Use the Samba4 data structures for security descriptors and security ↵Jelmer Vernooij1-2/+2
descriptor buffers. Make security access masks simply a uint32 rather than a structure with a uint32 in it. (This used to be commit b41c52b9db5fc4a553b20a7a5a051a4afced9366)
2007-10-10r18605: sync dlinklist.h with samba4, that means DLIST_ADD_END()Stefan Metzmacher1-2/+1
and DLIST_DEMOTE() now take the type of the tmp pointer not the tmp pointer itself anymore. metze (This used to be commit 2f58645b7094e81dff3734f11aa183ea2ab53d2d)
2007-10-10r17878: Fix possible null deref found by Stanford checker.Jeremy Allison1-0/+4
Jeremy. (This used to be commit ae20201494f44cb98e58ba98531a79feeeb82b47)
2007-10-10r17867: Fix null deref in error code path. Found by theJeremy Allison1-0/+1
Stanford checker. Jeremy. (This used to be commit 09652dc71ce13bd305e653557e43731378398dd6)
2007-10-10r17333: Some C++ warningsVolker Lendecke6-14/+19
(This used to be commit be9aaffdaccae06c8c035eaf31862e34b7cfbe38)
2007-10-10r17047: Fix a typo and a possible NULL dereferenceVolker Lendecke1-2/+4
(This used to be commit c0d9114706345c6bc1fa392bbf9ee81b146cba85)
2007-10-10r16945: Sync trunk -> 3.0 for 3.0.24 code. Still needJeremy Allison1-3/+1
to do the upper layer directories but this is what everyone is waiting for.... Jeremy. (This used to be commit 9dafb7f48ca3e7af956b0a7d1720c2546fc4cfb8)
2007-10-10r16650: Fix bug #3890 reported by jason@ncac.gwu.edu.Jeremy Allison1-3/+7
Jeremy. (This used to be commit 590b58cb507e5a6e459ff0c975beb9056336f233)
2007-10-10r16636: Fix bug #3884 reported by jason@ncac.gwu.eduJeremy Allison1-18/+9
Jeremy. (This used to be commit 7580eb947cdeb786be00efa5da727e32b28c99d6)
2007-10-10r16634: Fix bug #3883 reported by jason@ncac.gwu.edu.Jeremy Allison1-2/+1
Jeremy. (This used to be commit d04462f1d8cf009985b9112f093306a64689af64)
2007-10-10r16603: Klockwork #2028. Fix null deref on error path.Jeremy Allison1-12/+38
Jeremy. (This used to be commit 067feef34388e93ded8db7fd3b4a6a4b752a3059)
2007-10-10r16490: Fix a memleak and two typosVolker Lendecke1-0/+1
(This used to be commit 8cf364e602eea408fd9cd6acd12f2b72971361ae)
2007-10-10r16424: Fix possible null deref and a memory leak found byJeremy Allison1-1/+5
examining Klockwork #1519. get_printer_subkeys() could return zero without initializing it's return pointer arg. Fixed this. Added free of subkey pointer return in registry/reg_printing.c (interesting that neithe Coverity or Klocwork found this one). Jeremy. (This used to be commit 4fbeae1a3ac3499e5d9f566655cbafccd9d691cb)
2007-10-10r16409: Fix Klocwork ID's.Volker Lendecke2-8/+39
1177 In reg_perfcount.c: 1200 1202 1203 1204 In regfio.c: 1243 1245 1246 1247 1251 Jerry, the reg_perfcount and regfio.c ones, can you take a look please? This is really your code, and I'm not sure I did the right thing to return an error. smbcacls.c: 1377 srv_eventlog_nt.c: 1415 1416 1417 srv_lsa_nt.c: 1420 1421 srv_netlog_nt.c: 1429 srv_samr_nt: 1458 1459 1460 Volker Volker (This used to be commit d6547d12b1c9f9454876665a5bdb010f46b9f5ff)
2007-10-10r15104: Implement Samba4's tdb_name().Volker Lendecke1-1/+1
Volker (This used to be commit d52002c1c9d28e637ca4d1553e800b0b97790f36)
2007-10-10r14768: Fix potential null deref coverity bugs #255, #256.Jeremy Allison1-17/+25
Jeremy. (This used to be commit a40c7a0cd888dcee3cac1a41602863f54c51ef17)
2007-10-10r14766: Fix possible NULL deref. Coverity #254.Jeremy Allison1-8/+9
Jeremy. (This used to be commit e2e2d8b939dd425a97b36102c6a541e3cf6236ad)
2007-10-10r14247: Fix Coverity bug # 136Volker Lendecke1-1/+3
(This used to be commit 1b247ff2ed380f5b7d28917d74d6ef5609330a45)
2007-10-10r13978: Here is why it's essential to use SAFE_FREE instead of free.Jeremy Allison1-6/+6
If we use free(data.dptr) and then the subsequent tdb_open fails in _reg_perfcount_get_counter_data() then data.dptr is left as a non-zero pointer that has been freed. This would cause it to be reused later on. Coverity bug #162. Jeremy. (This used to be commit 053efc20981e0280c6af0ebb9e17cea07da85fe8)
2007-10-10r13915: Fixed a very interesting class of realloc() bugs found by Coverity.Jeremy Allison3-40/+20
realloc can return NULL in one of two cases - (1) the realloc failed, (2) realloc succeeded but the new size requested was zero, in which case this is identical to a free() call. The error paths dealing with these two cases should be different, but mostly weren't. Secondly the standard idiom for dealing with realloc when you know the new size is non-zero is the following : tmp = realloc(p, size); if (!tmp) { SAFE_FREE(p); return error; } else { p = tmp; } However, there were *many* *many* places in Samba where we were using the old (broken) idiom of : p = realloc(p, size) if (!p) { return error; } which will leak the memory pointed to by p on realloc fail. This commit (hopefully) fixes all these cases by moving to a standard idiom of : p = SMB_REALLOC(p, size) if (!p) { return error; } Where if the realloc returns null due to the realloc failing or size == 0 we *guarentee* that the storage pointed to by p has been freed. This allows me to remove a lot of code that was dealing with the standard (more verbose) method that required a tmp pointer. This is almost always what you want. When a realloc fails you never usually want the old memory, you want to free it and get into your error processing asap. For the 11 remaining cases where we really do need to keep the old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR, which can be used as follows : tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size); if (!tmp) { SAFE_FREE(p); return error; } else { p = tmp; } SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the pointer p, even on size == 0 or realloc fail. All this is done by a hidden extra argument to Realloc(), BOOL free_old_on_error which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR macros (and their array counterparts). It remains to be seen what this will do to our Coverity bug count :-). Jeremy. (This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
generated by cgit (git 2.34.1) at 2024-11-05 04:35:43 +0000