Age | Commit message (Collapse) | Author | Files | Lines |
|
Upon failure to allocate one of the arrays, further down the TALLOC_FREE would
have looked at the variables given to it without initizalizing.
(This used to be commit 6cac3127312acaac65fcd54280605605765787ad)
|
|
Guenther
(This used to be commit d078a8757182d84dfd3307a2e1b751cf173aaa97)
|
|
Guenther
(This used to be commit b62eddbc4e302d3849525d8f6af24b112a4fe483)
|
|
Guenther
(This used to be commit 5c0a2d697f6a173e9627d7bc5567308a24613f46)
|
|
Guenther
(This used to be commit 80e39330bf15cc57f2780a5b900d8a2b14d92fa9)
|
|
Guenther
(This used to be commit 34c0e64026b7f5f223c7d7f1d7e162b5659f3bd3)
|
|
Guenther
(This used to be commit 15b97d1aafd6c8ad936944b611188154b191167f)
|
|
Guenther
(This used to be commit 8125d8557fb4b27873f8eabc6ad1019491d18cce)
|
|
Guenther
(This used to be commit 004598bc1322b6e2deb62115713768682fee988e)
|
|
Guenther
(This used to be commit 8c476ad51622f76bf8f03f6255369b8e19f24a72)
|
|
Guenther
(This used to be commit 90b07714ddb16ef87865cdf4f9c64c0372200e42)
|
|
Guenther
(This used to be commit d853f4f2634a3273c193cc52e7aaa4e7234a827c)
|
|
equivalents.
Guenther
(This used to be commit 4ca3b1c02ee44ddcab8d1b100497939de62558e6)
|
|
Guenther
(This used to be commit 793e5a608b1a40174088db6fbfcfc8cc6263a0da)
|
|
Guenther
(This used to be commit bb8e77eb74c9d178a6c77f2f9c69eb1778fb5e10)
|
|
Guenther
(This used to be commit c9a8baf5077a4e93cca241a5ec73f6ade97af607)
|
|
Guenther
(This used to be commit f193d7d944e89f94b968a369d6566d13a4fbef5c)
|
|
Guenther
(This used to be commit 0fac016d9d0018c983576d5cc8c3e06f40360b73)
|
|
Guenther
(This used to be commit 08888e3773fa9f92c1d0d4662983bd44bea69a6c)
|
|
Guenther
(This used to be commit 9b2aeeb36903591ea55cfdfe22f32d69703daaf1)
|
|
rpccli_lsa_query_info_policy2().
Guenther
(This used to be commit 7a3fe68bef7acde9d9f8a7a44ce7e9432f3c5a95)
|
|
Guenther
(This used to be commit b37b2b77edec72fc3f53b3461aa1c210e4366c1b)
|
|
(rpccli_lsa_open_trusted_domain,
rpccli_lsa_query_trusted_domain_info,
cli_lsa_query_domain_info_policy).
Guenther
(This used to be commit 5bfb33f1c5a16d10f77cb76962df4a949626a062)
|
|
rpccli_lsa_open_trusted_domain_by_name,
rpccli_lsa_query_trusted_domain_info_by_sid and
rpccli_lsa_query_trusted_domain_info_by_name).
Guenther
(This used to be commit f2fb3473455f20e7314a9d33f5a1c923d3057d97)
|
|
Jeremy.
(This used to be commit 0002a9e96b0ef78316295a6eb94ff29b64e2f988)
|
|
Jeremy.
(This used to be commit 15074de938539e7a9c527d9a6d81792adc2ac3d0)
|
|
uint32 instead of enum lsa_SidType.
Jeremy.
(This used to be commit 2df8252ff76406bfe57cd76e9927b5056e89e6ae)
|
|
bugs in various places whilst doing this (places that assumed
BOOL == int). I also need to fix the Samba4 pidl generation
(next checkin).
Jeremy.
(This used to be commit f35a266b3cbb3e5fa6a86be60f34fe340a3ca71f)
|
|
(This used to be commit 5c6c8e1fe93f340005110a7833946191659d88ab)
|
|
(This used to be commit 3246be8cf05a867b74b4b96697c99cc62f13c2a9)
|
|
rpccli_lsa_lookup_sids()
and remove the old rpccli_lsa_lookup_sids() function. The old function would
fail due to server limits when requesting to resolve too many sids at once
(20480 for W2k3). The new version passes the list of sids in hunks to the
server. It has up to now been used (and tested) in the winbindd_ads
lookup_groupmem() function, and I think the time has come to replace the actual
function with this correct version.
Michael
(This used to be commit 1194d4f36ef720747e62dde31881c295e44e4a76)
|
|
(This used to be commit aa603bcc6c848de67ea07d6028ab841a8401d9ad)
|
|
Michael
(This used to be commit 7238884c2cb25dd9279703004ffab6618715a275)
|
|
uninitialized data.
Michael
(This used to be commit b4fff6d09d17a18eae61e8ca789f128cd094ba09)
|
|
rpccli_lsa_lookupsids_noalloc() returns an error for one hunk
of SIDs: free all allocated arrays and return the error code
returned by the hunk lookup.
Michael
(This used to be commit 2c68ebd6934206186dc6e635401f66c2fd1e1234)
|
|
Thanks to Volker for the hint!
Michael
(This used to be commit 3b7ed3ea881dc59b77a067d5d3738e9e03b6c538)
|
|
(This used to be commit b0132e94fc5fef936aa766fb99a306b3628e9f07)
|
|
Jeremy.
(This used to be commit 407e6e695b8366369b7c76af1ff76869b45347b3)
|
|
Guenther
(This used to be commit e9a7512a9f630340004913f1379452eea8a9b6ae)
|
|
in a lookup_sidX reply isn't optional - like the
lookup_sidX query it needs to be defined in the
struct.
All this will go away with PIDL (thank goodness....).
Jerry - I think this is a showstopper to be merged
for 3.0.25b.
I'll be watching the build farm to see if anything broke.
Jeremy.
(This used to be commit 9300b92f7a51eb80fdc039d8dad23ea9ce82aa8f)
|
|
Before comitting that, I have to verify that it does not
break anything...
Michael
(This used to be commit 55ea93d47e72d13b7e6d6900eea5da1e9a49ff8d)
|
|
sense...
(This used to be commit 374dea8c6f5192224ee46e0c3c9b63221028858e)
|
|
talloc context for use with the actual rpc query and response.
So the the parent context does not get flooded by the posslibly
large amount of response data (when looking up a lot of sids).
Note: It not possible, to simply use the names and domains arrays
as talloc contexts for the talloc_strdup calls, because from
rpccli_lsa_lookup_sids_all, this is called with names + offset
and domains + offset where names and domains are talloced
arraye for the complete response.
(This used to be commit 8e60900c5c5fccbe1718b805b6b1628d32b920d0)
|
|
looked up at one time. This limit is at 20480 for w2k3.
Our rpccli_lsa_lookup_sids function ignores this limit, so when
we give the server too long a list of SIDs, then we will get
nothing back. Since typically rpccli_lsa_lookup_sids is given
one SID (or a small number of SIDS), this did not do harm
up to now. But since I want to use lsa_lookup_sids in a subsequent
modification to winbindd_ads.c:lookup_groupmem to get rid of
a vast number of dn_lookup calls to the server, I had to make
sure we do it correctly.
I have added a function rpccli_lsa_lookup_sids_all function
that has the same prototype but internally splits the list
of SIDs up into hunks of a (conservative, hard coded) 1000
SIDs each for a first go.
If this approach is agreed upon, the new function could replace
the original rpccli_lsa_lookup_sids function.
Michael
(This used to be commit 66ff0bc6c39f86a9830dc508cd891e33638b475d)
|
|
Jeremy.
(This used to be commit 8968808c3b5b0208cbad9ac92eaf948f2c546dd9)
|
|
(This used to be commit 2eec760154a4126df616a3c078b7741c57239c86)
|
|
(This used to be commit 50d74ce0488a9bd0980cdc6d523a210f6238ef74)
|
|
(This used to be commit 5de76767e857e9d159ea46e2ded612ccd6d6bf19)
|
|
make rpccli_lsa_close() a real one line wrapper for
rpccli_lsa_Close().
I'm still keeping the wrapper for now because I'm not sure
what we will do about a usable client API. I don't think
calling the autogenerated client code directly is a good idea
as the IDL is still evolving.
(This used to be commit 47f0c71218ade18cb94b48661f064e8956e06096)
|
|
* move OUR_HANDLE macro to include/rpc_misc.h
(This used to be commit 2b37079af2f569df7a58878150a61980c6fe06ee)
|