Age | Commit message (Collapse) | Author | Files | Lines |
|
This patch makes Samba compile cleanly with -Wwrite-strings.
- That is, all string literals are marked as 'const'. These strings are
always read only, this just marks them as such for passing to other functions.
What is most supprising is that I didn't need to change more than a few lines of code (all
in 'net', which got a small cleanup of net.h and extern variables). The rest
is just adding a lot of 'const'.
As far as I can tell, I have not added any new warnings - apart from making all
of tdbutil.c's function const (so they warn for adding that const string to
struct).
Andrew Bartlett
(This used to be commit 92a777d0eaa4fb3a1c7835816f93c6bdd456816d)
|
|
(This used to be commit f56ce473b6964302ba51fc9796ee919738731065)
|
|
Change a int* to a uint32* in the cli_spoolss_enum_ports() function.
(This used to be commit 4663d79d3e9dcfef49f7cef1f6205efe58edbdc1)
|
|
decode_port_info and decode_printerdriver functions.
(This used to be commit bf2d9dd5ba2ecc7e0e1bd17049adee6dd80d807c)
|
|
(This used to be commit d30da51956accfc4ea4662cece00d4df223421cd)
|
|
know how to decode a printer driver into a DRIVER_INFO_6 structure.
(This used to be commit 1338f623c2a1e539ee9ee5fedbaf16baf3eb171e)
|
|
Return WERR_UNKNOWN_LEVEL if we can't decode the returned buffer.
(This used to be commit 0379a32d825e036c7f0dcabef46547cd678a2a1d)
|
|
one jerry!
(Hey I thought I checked this in already?)
(This used to be commit f0c6303bebe0f494d70ac5371d7f6727413fe482)
|
|
pointers.
Implemented client function for deleteprinterdataex.
(This used to be commit f7641c8fd1079c2ef444d4bca5b97b1285733d10)
|
|
(This used to be commit 1f629aa54ea3733c356c21f9f707b7f6075f6429)
|
|
- getprinterdataex(), setprinterdataex(), enumprinterdataex()
Pass data type down to setprinterdata() fn instead of hardcoding REG_SZ
(This used to be commit 62a60782533851b3380aa0db300fa16dfe6ca72e)
|
|
(This used to be commit e09007dd5d17d5f84aea3c2fed16ce79ba7be1f2)
|
|
server name and everything works as advertised. See the MSDN doco for details.
(This used to be commit d6b10fe9691bfc96d5933c029990c60fd292bdc9)
|
|
(This used to be commit cb946b5dadf3cfd21bf584437c6a8e9425f6d5a7)
|
|
(This used to be commit 897e64d2e0c1d04ab93441ccaffe369bf43be46e)
|
|
(This used to be commit 1f007d3ed41c1b71a89fa6be7d173e67e927c302)
|
|
Changed "SMB/Netbios" to "SMB/CIFS" in file header.
(This used to be commit 6a58c9bd06d0d7502a24bf5ce5a2faf0a146edfa)
|
|
(This used to be commit 2d0922b0eabfdc0aaf1d0797482fef47ed7fde8e)
|
|
(This used to be commit 1d36250e338ae0ff9fbbf86019809205dd97d05e)
|
|
According to the incorruptible judges find and grep, the latter won.
Mmm - procrastination. (-:
(This used to be commit 2e339403605177b15d5185a8fdd1b06f3f043168)
|
|
can't redefine them. damn.
(This used to be commit c41fc06376d1a2b83690612304e85010b5e5f3cf)
|
|
(This used to be commit 0feaac00a1847af41464d4ce35821ff851cded9c)
|
|
enumprinters so that it works as well. Couple of other
misc fixes while we're working on rpcclient.
(This used to be commit 83d6bc4454f0cda581d26de32a4fcaad42431b34)
|
|
We were reading the endainness in the RPC header and then never propagating
it to the internal parse_structs used to parse the data.
Also removed the "align" argument to prs_init as it was *always* set to
4, and if needed can be set differently on a case by case basis.
Now ready for AS/U testing when Herb gets it set up :-).
Jeremy.
(This used to be commit 0cd37c831d79a12a10e479bf4fa89ffe64c1292a)
|
|
code :-(.
Jeremy.
(This used to be commit 70beabf73bdaad7b6a60e24b7a11798a411bed02)
|
|
security descriptors and pointers. Syncup with 2.2 tree.
Jeremy.
(This used to be commit 14d5997dc841e78a619e865288486d50c245896d)
|
|
We now use our own vfs layer to do get/set acl calls (hurrah!).
Jeremy.
(This used to be commit dfe77c7046cbd65ee52aea7439f21503c1eac41d)
|
|
driver information.
Will merge into TNG.
jerry
(This used to be commit ae7dd77c2495d5e17f6e8da94afbe8cab3e773bb)
|
|
(This used to be commit 2d23607bb0fe3d93809b3a194f9976b01ece8768)
|
|
j-
(This used to be commit facef51be4e3f3be75613f39c8dfedfa7410552c)
|
|
jerry
(This used to be commit ce2d20395ae3d41d55030427f4b7b44ce87c605e)
|
|
on a Samba host. Also needed to add an option to pass the share
name (printer name) on the command line.
And fixed the checking of the return code for spoolss_r_addprinterex()
jerry
(This used to be commit 880e81161640cd38540b06d982c592cbada51d40)
|
|
Also fixed init_unistr() to deal with a NULL source character string.
-jerry
(This used to be commit 8ecd5dd52a6bd867f5d117352048ee43ce7254d9)
|
|
- cleaned up some code
- Fixed a few memory leaks of my own making
- Add AddPrinterDriver(); I'm missing some of the semantics
here as the call is done correctly, but I'm not getting all
the information right in the DRIVER_INFO_3 struct I think.
Will work on it tomorrow some more...
--jerry
(This used to be commit 3bf9a29f34ee4ade5180c5a0b0b9ff4aca7f0f08)
|
|
correct handle, but was deleting the connection to the server.
Doh!!
--jerry
(This used to be commit 8e5e929561a1ae954bd60f7bd745d697438f835c)
|
|
that the call failed, but the printer shows up on the remote NT client.
(note this is the client side call). I've botched the return value
somewhere and will fix that today.
jerry
(This used to be commit e15d9befd24cf5f3410c4be819b2a1fcf68048fb)
|
|
* Fixed to work with Jeremy's recent changes re: dunamic
memory allocation when unmarshalling unistr[2]
* included EnumPorts level 1
* more work on AddPrinterEx
--jerry
(This used to be commit 45fbf31b698d6e754630590034cff712c0a716b1)
|
|
So fixed enumprinterdatas in rpcclient to debug the server code,
and found that the parsing code was missing 2 prs_align().
We are not crashing NT anymore. :-)
J.F.
(This used to be commit 883f7402d495182aeff85152216cc8b3cfc18bef)
|
|
* Fixed an off-by-one bug noticed by JF in GetPrinterDriverDirectory()
jerry
(This used to be commit a9522f560da64045d928dabedeacdef0a6c3db51)
|
|
functions work now:
- spoolenum
- spoolopen
- spoolgetprinter
- spoolgetprinterdriver
Items todo:
- track down memory bug with spoolenumdata
- fix spoolgetprinterdriverdir
- fix spoolgetdata
- fix display_job_info_ctr in spooljobs
All part of the rpcclient work.
Jeremy, this check includes emthods for associating
POLICY_HNDs and client states. See the RpcHndList_...()
function calls (implemented in lib/util_list.c)
--jerry
(This used to be commit 84349394a988213724ca138e9692b3bc44fa0cb8)
|
|
prs_free_data() => prs_mem_free
prs_realloc_data => prs_grow
--jerry
(This used to be commit 3d00e969df1800dadbb91fd8c410e9ce87188551)
|
|
* fixes some readline bugs from the merge
* first attempt at commands (spoolenum almost works)
* no changes to existing functions in HEAD; only additions
of new functions. I'll weed out what I can as I go.
--jerry
(This used to be commit 61d2aad5dc2b212b11c981f1eca47efa627e9fc8)
|
|
that were in the head branch but weren't in SAMBA_2_0
(This used to be commit d7b208786590b5a28618590172b8d523627dda09)
|
|
done a minimal amout of clean-up in the Makefile, removing unnecessary
modules from the link stage. this is not complete, yet, and will
involve some changes, for example to smbd, to remove dependencies on
the password database API that shouldn't be there. for example,
smbd should not ever call getsmbpwXXX() it should call the Samr or Lsa
API.
this first implementation has minor problems with not reinstantiating
the same services as the caller. the "homes" service is a good example.
(This used to be commit caa50525220b0d0250fa139367593c2de2c12135)
|
|
specify \PIPE\spoolss instead of \PIPE\lsarpc...
(This used to be commit 4e92090016badc78ae6532f0eb57af6bbdb789bd)
|
|
(This used to be commit 7a696330586b9ad5157b0c1ab249cc66e9accef7)
|
|
to mention, there's a spooljobs <printer name> command, and it uses
command-line completion? prints out NT print jobs really nicely, too.
(This used to be commit e6e5caf16c8d120f0c11fa63061f2786098e3357)
|
|
(This used to be commit 0f9d661ca2560e88a04bc529ba41ac4cf1579fa4)
|
|
(This used to be commit 681cbb9ec1310fa81f4da40ef0cfed92500b5f4e)
|
|
(This used to be commit 6947f8fac7d6d643a265fdcb56b2a390b9a9a1c0)
|