summaryrefslogtreecommitdiff
path: root/source3/rpc_client
AgeCommit message (Collapse)AuthorFilesLines
2010-07-05s3-rpc_client: Use the right memory context for array elements.Andreas Schneider1-3/+3
2010-06-21s3: Remove an unreachable line of codeVolker Lendecke1-2/+0
2010-06-18Second part of fix converting prs_XX struct and functions to talloc. Remove ↵Jeremy Allison1-47/+0
unneeded prs_mem_free calls. Jeremy. Signed-off-by: Simo Sorce <idra@samba.org>
2010-06-18Convert the prs_XXX struct and functions to use talloc instead of malloc. ↵Jeremy Allison2-16/+10
Passes valgrind and make tests for client and server. Second version of this patch after splitting up at Simo's request. Patch to follow will delete extraneous prs_mem_free() calls. Jeremy. Signed-off-by: Simo Sorce <idra@samba.org>
2010-06-03s3-spoolss: add and use spoolss_printerinfo2_to_setprinterinfo2().Günther Deschner2-0/+31
This fixes some invalid typecasts. Guenther
2010-06-03s3-build: only include generated spoolss headers (not ndr headers).Günther Deschner1-0/+1
Guenther
2010-05-31s3:ntlmssp Use a TALLOC_CTX for ntlmssp_sign_packet() and ntlmssp_seal_packet()Andrew Bartlett1-5/+10
This ensures the results can't be easily left to leak. Andrew Bartlett Signed-off-by: Stefan Metzmacher <metze@samba.org> Signed-off-by: Günther Deschner <gd@samba.org>
2010-05-31ntlmssp: Make the ntlmssp.h from source3/ a common headerAndrew Bartlett1-1/+1
The code is not yet in common, but I hope to fix that soon. Andrew Bartlett Signed-off-by: Stefan Metzmacher <metze@samba.org> Signed-off-by: Günther Deschner <gd@samba.org>
2010-05-28s3-rpc_client: move protos to init_netlogon.hGünther Deschner3-0/+7
Guenther
2010-05-21s3:dom_sid Global replace of DOM_SID with struct dom_sidAndrew Bartlett2-15/+15
This matches the structure that new code is being written to, and removes one more of the old-style named structures, and the need to know that is is just an alias for struct dom_sid. Andrew Bartlett Signed-off-by: Günther Deschner <gd@samba.org>
2010-05-18s3-rpc_client: move protos to init_samr.hGünther Deschner2-0/+10
Guenther
2010-05-18s3-rpc_client: move protos to init_spoolss.hGünther Deschner2-0/+15
Guenther
2010-05-18s3-rpc_client: move protos to cli_spoolss.hGünther Deschner2-0/+125
Guenther
2010-05-18s3-rpc_client: move protos to cli_lsarpc.hGünther Deschner2-0/+45
Guenther
2010-05-18s3-rpc_client: move protos to cli_netlogon.hGünther Deschner3-0/+50
Guenther
2010-05-18s3-rpc_client: move protos to cli_samr.hGünther Deschner2-0/+34
Guenther
2010-05-18s3: Remove use of iconv_convenience.Jelmer Vernooij3-5/+5
2010-05-18s3-crypto: only include crypto headers when crypto is done.Günther Deschner3-0/+4
Guenther
2010-05-09s3-spoolss: Make spoolss_Time_to_time_t public.Simo Sorce1-0/+15
Signed-off-by: Günther Deschner <gd@samba.org>
2010-05-06s3: only include gen_ndr headers where needed.Günther Deschner1-0/+16
This shrinks include/includes.h.gch by the size of 7 MB and reduces build time as follows: ccache build w/o patch real 4m21.529s ccache build with patch real 3m6.402s pch build w/o patch real 4m26.318s pch build with patch real 3m6.932s Guenther
2010-03-29s3:rpc_client: remove more unused codeStefan Metzmacher3-59/+0
metze
2010-03-29s3:rpc_client: remove unused code, we handle transport failures in the ↵Stefan Metzmacher1-14/+0
transport layer now metze
2010-03-29s3:rpc_client: return at least 10 sec as old timeout in rpccli_set_timeout() ↵Stefan Metzmacher1-3/+12
instead of 0 metze
2010-03-29s3:rpc_client: add set_timeout hook to rpc_cli_transportStefan Metzmacher4-20/+63
metze
2010-03-29s3:rpc_client: add rpccli_is_connected()Stefan Metzmacher4-18/+171
metze
2010-03-29s3:rpc_client: don't mix layers and keep a reference to cli_state in the callerStefan Metzmacher1-8/+17
We should not rely on the backend to have a reference to the cli_state. This will make it possible for the backend to set its cli_state reference to NULL, when the transport is dead. metze
2010-03-29s3:rpc_transport_np: add comment about bad usage in a destructorStefan Metzmacher1-1/+2
metze
2010-03-29s3:rpc_transport_np: use cli_state_is_connected() helperStefan Metzmacher1-1/+1
metze
2010-03-24s3:ntlmssp: pass names and use_ntlmv2 to ntlmssp_client_start() and store themStefan Metzmacher1-1/+5
Inspired by the NTLMSSP merge work by Andrew Bartlett. metze Signed-off-by: Günther Deschner <gd@samba.org>
2010-03-05s3-rpcclient: fix rpcclient after spoolss_GetPrinterData{Ex} IDL change.Günther Deschner1-3/+13
Guenther
2010-02-24s3:rpc_transport_np: handle trans rdata like the output of a normal readStefan Metzmacher1-0/+17
Inspired by bug #7159. metze
2010-02-23s3:cli_netlogon: keep the the correct negotiate_flags on the cli->dc structureStefan Metzmacher1-2/+6
This should fix the rpccli_netlogon_set_trust_password() against DC's without netr_ServerPasswordSet2 support. This fixes bug #7160. metze
2010-02-19Second part of fix for bug #7159 - client rpc_transport doesn't cope with ↵Jeremy Allison1-0/+6
bad server data returns. If server returns zero on a NP read. Report pipe broken. Prevents client from looping if it thinks there should be more data. Jeremy.
2010-02-19First part of fix for bug #7159 - client rpc_transport doesn't cope with bad ↵Jeremy Allison2-0/+16
server data returns. Ensure that subreq is *always* talloc_free'd in the _done function, as it has an event timeout attached. If the read requests look longer than the cli->timeout, then the timeout fn is called with already freed data. Jeremy.
2010-02-17Fix bug #7146 - Samba miss-parses authenticated RPC packets.Jeremy Allison1-15/+47
Parts of the Samba RPC client and server code misinterpret authenticated packets. DCE authenticated packets actually look like this : +--------------------------+ |header | | ... frag_len (packet len)| | ... auth_len | +--------------------------+ | | | Data payload | ... .... | | +--------------------------+ | | | auth_pad_len bytes | +--------------------------+ | | | Auth footer | | auth_pad_len value | +--------------------------+ | | | Auth payload | | (auth_len bytes long) | +--------------------------+ That's right. The pad bytes come *before* the footer specifying how many pad bytes there are. In order to read this you must seek to the end of the packet and subtract the auth_len (in the packet header) and the auth footer length (a known value). The client and server code gets this right (mostly) in 3.0.x -> 3.4.x so long as the pad alignment is on an 8 byte boundary (there are some special cases in the code for this). Tridge discovered there are some (DRS replication) cases where on 64-bit machines where the pad alignment is on a 16-byte boundary. This breaks the existing S3 hand-optimized rpc code. This patch removes all the special cases in client and server code, and allows the pad alignment for generated packets to be specified by changing a constant in include/local.h (this doesn't affect received packets, the new code always handles them correctly whatever pad alignment is used). This patch also works correctly with rpcclient using sign+seal from the 3.4.x and 3.3.x builds (testing with 3.0.x and 3.2.x to follow) so even as a server it should still work with older libsmbclient and winbindd code. Jeremy
2010-01-10s3: Remove some unused variablesVolker Lendecke1-7/+0
2010-01-06s3: Fix infinite loop in NCACN_IP_TCP asa there is no timeout. Assume ↵Bo Yang5-4/+112
lsa_pipe_tcp is ok but network is down, then send request is ok, but select() on writeable fds loops forever since there is no response. Signed-off-by: Bo Yang <boyang@samba.org>
2009-12-22s3:ntlmssp: only include ntlmssp.h where actually neededAndrew Bartlett1-0/+1
Andrew Bartlett
2009-12-22s3:ntlmssp: remove the typedef NTLMSSP_STATEAndrew Bartlett1-1/+1
Andrew Bartlett
2009-12-10s3-spoolss: fix enumprinter key client and server.Günther Deschner1-2/+5
Guenther
2009-12-02samba-spoolss: use spoolss_StringArray2 in spoolss_EnumPrinterKey.Günther Deschner1-20/+4
This should finally resolve the endian issues we were seeing on sparc and is much cleaner for spoolss clients and servers. Guenther
2009-11-27s3-kerberos: only use krb5 headers where required.Günther Deschner1-0/+1
This seems to be the only way to deal with mixed heimdal/MIT setups during merged build. Guenther
2009-11-26s3-rpc: running minimal_includes.pl on rpc_client and rpc_server.Günther Deschner1-2/+0
Guenther
2009-11-26s3-rpc: Avoid including every pipe's client and server stubs everywhere in ↵Günther Deschner4-1/+4
samba. Guenther
2009-11-24s3-spoolss: fixes for _spoolss_EnumPrinterKey client and server.Günther Deschner1-2/+2
Thanks Metze for review! Guenther
2009-11-23s3-spoolss: fix spoolss_EnumPrinterKey client and server code.Günther Deschner1-3/+21
Guenther
2009-11-14s3: Add min_setup, min_param and min_data to cli_trans_recvVolker Lendecke1-2/+2
Every caller that expects to receive something needs to check if enough was sent. Make this check mandatory for everyone. Yes, this makes the parameter list for cli_trans a bit silly, but that's just the way it is: A silly protocol request :-) While there, convert some _done functions to tevent_req_simple_finish_ntstatus.
2009-11-13fix bogus "out of memory" winbind msgVolker Lendecke1-1/+2
Signed-off-by: Michael Adam <obnox@samba.org>
2009-11-12Remove erroneous 'presult = NULL' changes. Now presult only gets setJeremy Allison1-9/+2
if NTSTATUS == OK. Jeremy.
2009-11-12Revert "Ensure every return path initializes presult as NULL."Jeremy Allison1-40/+0
Vl is correct, this is the wrong way to fix this. This reverts commit 83c2c177a5e86d04da37384f1f04230c8274e1e6.