summaryrefslogtreecommitdiff
path: root/source3/rpc_parse
AgeCommit message (Collapse)AuthorFilesLines
2002-10-19This fixes some bugs for NT4 usrmgr.exeVolker Lendecke1-1/+11
Volker (This used to be commit 32d6bcf3acefc77873a7241cc0c7e26241a65301)
2002-10-17When unmarshalling a relstr, don't unmarshall the string data if theTim Potter1-0/+3
offset is zero. Previously we were jumping to the start of the parse buffer (i.e offset zero) and reading string data until we hit a terminating NULL. Test case: in a PRINTER_INFO_0 structure, the servername field may be NULL when doing an enumprinters with flags = PRINTER_ENUM_LOCAL. (This used to be commit e62c6bf066c2242aae605ba707c9775b37bcaca3)
2002-10-12Nice *big* patch from metze.Andrew Bartlett1-3/+3
The actual design change is relitivly small however: It all goes back to jerry's 'BOOL store', added to many of the elements in a SAM_ACCOUNT. This ensured that smb.conf defaults did not get 'fixed' into ldap. This was a great win for admins, and this patch follows in the same way. This patch extends the concept - we don't store values back into LDAP unless they have been changed. So if we read a value, but don't update it, or we read a value, find it's not there and use a default, we will not update ldap with that value. This reduced clutter in our LDAP DB, and makes it easier to change defaults later on. Metze's particular problem was that when we 'write back' an unchanged value, we would clear any muliple values in that feild. Now he can still have his mulitivalued 'uid' feild, without Samba changing it for *every* other operation. This also applies to many other attributes, and helps to eliminate a nasty race condition. (Time between get and set) This patch is big, and needs more testing, but metze has tested usrmgr, and I've fixed some pdbedit bugs, and tested domain joins, so it isn't compleatly flawed ;-). The same system will be introduced into the SAM code shortly, but this fixes bugs that people were coming across in production uses of Samba 3.0/HEAD, hence it's inclusion here. Andrew Bartlett (This used to be commit 7f237bde212eb188df84a5d8adb598a93fba8155)
2002-10-05missing prs_align()'sGerald Carter1-0/+9
(This used to be commit f149a5a54722fe05c8e30cb217cc72cec6f34e18)
2002-10-04merge of working dsrolegetprimdominfo() client code from APP_HEADGerald Carter2-2/+115
(This used to be commit f70caa25e4ee198151b915cf2bc0a26b2d0e243d)
2002-10-04merge of new client side support the Win2k LSARPC UUID in rpcbindGerald Carter1-10/+25
from APP_HEAD (This used to be commit 38c9e4299845fd77cc8629945ce2d259489f7437)
2002-09-27HEAD and APP-HEAD spoolss parsing was out of sync. This MUST NOT HAPPEN !Jeremy Allison1-20/+17
Jeremy. (This used to be commit e42b76337b9a01fee84bc95d6899a724b2fdab29)
2002-09-26Patch from "Stefan (metze) Metzmacher" <metze@metzemix.de> to do a *much*Andrew Bartlett1-1/+44
better job of working with usrmgr. Previously we were blanking out entires, and all sort of mischif. The new patch (which I've now had a chance to test/modify) also takes care not to expand % values (ie we go \\%L\%U -> \\server\user, we don't want to store \\server\user back) and to correctly notice 'not set' compared to 'null string' etc. Andrew Bartlett (This used to be commit ab878b6cc4132594fc33f78aeebf0d8b7266c150)
2002-09-22Change parsing of policy and privs delta to what Ethereal says.Volker Lendecke1-70/+66
Volker (This used to be commit 8c41b5cd1b8b0c2639def9552bd20b8aca39785c)
2002-09-13wrong alignment size calculationSimo Sorce1-1/+3
spot by Florian Weimer <Weimer@CERT.Uni-Stuttgart.DE> (This used to be commit eda0e7589f2591edc29e6c1eef44aa21628977be)
2002-09-06Display debug data we are marshalling/unmarshalling a UNISTR in aTim Potter1-1/+7
similar format to UNISTR2. (This used to be commit 2d227bdce26674affad87ad6d118e77604fb210a)
2002-09-05A netshareenum reply always contains an enum_hnd. win2k returns zeroTim Potter1-4/+2
total entries on an error whereas nt4 must send uninitialised data so we didn't catch this one before. (This used to be commit 88653130bc1e380b7d8dc6c62492f3bbc6f1c707)
2002-09-04Fix typo in comment.Tim Potter1-1/+1
(This used to be commit 47b8ec632e20aa86c34f6a0a82d886fcc76f3000)
2002-09-03Implemented client function for deleteprinterdataex.Tim Potter1-0/+15
(This used to be commit 6d792c683df3a4f97e1a04a57bf4890aab35aecd)
2002-09-02Implemented some more client side spoolss functions:Tim Potter1-7/+96
- getprinterdataex(), setprinterdataex(), enumprinterdataex() Pass data type down to setprinterdata() fn instead of hardcoding REG_SZ. Did some trickyness to get enumprinterdataex replies unmarshalled properly. The code seems to have been written to require the number of entries returned before unpacking said entries. Skip to the end of the response and read the number of entries then jump back and process the printer data. (This used to be commit 6a1953f2431cc848abf210bdecd7080738991296)
2002-08-31Avoid writing unitialised bytes to the wire (and consequent valgrind warnings)Andrew Bartlett1-1/+5
by zeroing them out if they don't have meaning. Andrew Bartlett (This used to be commit 52db44b5c01e16923393b0ec9a8d0f530be7bb2d)
2002-08-30fix up print portion of registry. Merge from APP_HEAD.Gerald Carter1-72/+2
(This used to be commit ec37633548ed329c05b93499f75883d987b78f1e)
2002-08-30merge of phant0m key fix from APP_HEADGerald Carter1-2/+6
(This used to be commit cb13d334a53f27713665570d85607d57eb407f9f)
2002-08-30removed a debug lineAndrew Tridgell1-2/+0
(This used to be commit 5185f495d055cee609872db9e59edbe3220dc5bd)
2002-08-29There's more work to be done on samsync. Intermediate commit, nowVolker Lendecke1-1/+1
I get all the groups at least. Volker (This used to be commit 23a4f6991e93797afad0043689737a1b20c67f60)
2002-08-27fix 2 byte alignment/offset bug that prevented Win2k/XP clientsGerald Carter1-9/+16
from receiving all the printer data in EnumPrinterDataEx(). (This used to be commit 901769acc3258b6f8f33d36b0d5e3468a30ba1b0)
2002-08-23some cleanup while working on the NETLOGON pipe.Jean-François Micouleau2-40/+4
smb_io_chal() did a prs_align() but a challenge is an array of bytes. and all code calling smb_io_chal() played with the alignment to not align ! I'm confident in my change, but I would *really* like if jeremy could look at that. J.F. (This used to be commit 23501ea971f8cc0799515e0d51ad8619221a31e1)
2002-08-22Added some new delta types discovered by Ronnie from ethereal"Tim Potter1-16/+23
- SAM_DELTA_RENAME{USER,GROUP,ALIAS} - SAM_DELTA_DELETE{USER,GROUP} Renamed some of the unknown delta types and their unmarshalling functions: - SAM_DELTA_TRUST_DOMS - SAM_DELTA_SECRET_INFO (This used to be commit 1f29276c2ff450c4ca3705c27fb0be71ddcda4ad)
2002-08-22added a 'net rpc samdump' command for dumping the whole sam viaAndrew Tridgell1-3/+6
samsync operations (as a BDC) (This used to be commit e4cb106d2e3e6a41529369545a7a6ce5fe6d8986)
2002-08-21NETLOGON NetServerAuthenticate3 include and parser fileJean-François Micouleau1-1/+80
J.F. (This used to be commit 2f68d6f5ec925f07a387f784db6de0cfbaa53278)
2002-08-17* the printing code should now be back to the working state it wasGerald Carter1-1/+1
before the swap from NT_PRINTER_PARAM to REGISTRY_VALUE. * XxxPrinterDataEx() functions have not been expanded to support keys other than SPOOL_PRINTERDATA_KEY yet * fixed apparent long standing bug regarding the dependentfiles list in the DRIVER_INFO struct (This used to be commit d59b0eb1236cf5bb9371030a94eb60d4131c15fb)
2002-08-16Fairly large change to printing code.Gerald Carter1-36/+0
* removed support for PHANTOM_DEVMODE printer data * s/NT_PRINTER_PARAM/REGISTRY_VALUE/g - This was a good bit of work. Everything seems stable, but is not complete. * support for printer data keys other than PrinterDriverData in the store and fetch routines. Still needs to be plugged into the XxxPrinterDataEx() calls. Tested against NT4.0 & 2k. Like I said, it's not done, but doesn't crash so it shouldn't upset anyone (unless you're trying to build a Samba printer server off of HEAD). More work to come. Should settle by Monday. jerry (This used to be commit 7ba7c04c0e961618c82c2112b9627af114c6cc42)
2002-08-15Rename unknown_0 field in create_user2 reply in the actual struct.Tim Potter1-1/+1
(This used to be commit 482d873c26bf02e27ffcd92042b476eda765a5ff)
2002-08-15The unknown_0 field in a CREATE_USER2 reply is the access granted.Tim Potter1-1/+1
(This used to be commit 8bca3085836255536794444248e7ff3a2460c045)
2002-08-14added comment about a new specversion seen from client.Gerald Carter1-0/+2
Device mode size is still the same though. jerry (This used to be commit fb822e97cb832361062fbb2aa239d949cc83efed)
2002-08-12Add lsa 0x2e (queryinfo2) client sideJim McDonough1-0/+13
(This used to be commit c3b05b21a0340d8ff02a79401399e3d43d9e759a)
2002-08-12Add client side support for samr connect4 (0x3e). Seems to have oneJim McDonough1-0/+22
additional parm compared to samr connect, but I've only seen 0x00000002 in that field... (This used to be commit ed2370b91f7f6a36efdf6b65340a5b29a26e7e7a)
2002-08-08printing change notification merge from APPLIANCE_HEADGerald Carter1-2/+17
(This used to be commit 11ddfd9cfa550dcd3186c8aaf0cc038ce7f1791f)
2002-08-08Merge of incomplete rffpcnex testing code from APPLIANCE_HEAD.Tim Potter1-0/+28
(This used to be commit fe43c2ac2d2e1dd3b3a25c807d4dd379c5ac4960)
2002-08-06Add SAMR 0x3e, which is samr_connect4. Seems to be the same as ourJim McDonough1-2/+60
existing connect (which I've been told is really connect2), with one extra dword. We've only seen 0x00000002 there... (This used to be commit 266344634944dff30f56453f9d86c490e7ac7a55)
2002-08-05Spelling fix.Tim Potter1-1/+1
(This used to be commit 28ba237a9e02e284fb541562270db758612e425a)
2002-07-31Winbind updates!Andrew Bartlett1-1/+1
This updates the 'winbind' authentication module and winbind's 'PAM' (actually netlogon) code to allow smbd to cache connections to the DC. This is particulary relevent when we need mutex locks already - there is no parallelism to be gained anyway. The winbind code authenticates the user, and if successful, passes back the 'info3' struct describing the user. smbd then interprets that in exactly the same way as an 'ntdomain' logon. Also, add parinoia to winbind about null termination. Andrew Bartlett (This used to be commit 167f122b670d4ef67d78e6f79a2bae3f6e8d67df)
2002-07-30Add LSA RPC 0x2E, lsa_query_info2. Only level implemented is 0x0c, whichJim McDonough1-2/+108
is netbios and dns domain info. Also add code to set/fetch the domain GUID from secrets.tdb (although set is not yet called by anyone). (This used to be commit 31d7168530ccce2c5e9e7f96464b47f4d9771a25)
2002-07-29add another registry rpc (opnum 0x14). Have no idea what it's real nameGerald Carter1-4/+56
is. I'm calling it REG_SAVE_KEY, because 2k preps a regedt32.exe Registry->Save Key with this call. Done in the process of tracking down a PrinterDriverData issue. (This used to be commit 66104a361424f10cc986c597b91afa6f12b3cd8a)
2002-07-29passing -1 for the src length in rpcstr_pull results in onlyGerald Carter1-1/+1
converting the first character of the unicode string., See convert_string() for why. uniarray_2_dosarray() passes 0 for the src length now which works. (This used to be commit 0793612cca3bba55d5e5e2970308f95839f208b4)
2002-07-27A very long time ago (actually 6 months ago) I promised to commit this codeAndrew Bartlett1-66/+634
to the Samba tree. Originally written by Nigel Williams" <nigel@veritas.com>, I've been trying to keep it in some form of shape for the last 6 months. In particular I think some of the code got committed a few months ago, and others have made changes to the CVS version over time. anyway, its finally in - and doesn't appear to have broken anything. Now to try the client-side patches :-) Andrew Bartlett (This used to be commit f9bac7c5c2c4ddf0bf39d596a7b922fbb17c6b16)
2002-07-263 things:Gerald Carter1-1/+7
* normalize all registry key strings before storing or looking up paths in the registry tdb * return the current buffer size for REG_INFO even when not returning actual data * fix a segfault report by metze on #samba-technical so that the user/group object picker works again (was the "ProductType" key lookup that was failing). (This used to be commit 5640e6cdb213502d95fff33e06eaeed5ce3aeb76)
2002-07-24several changes in this checkinGerald Carter1-21/+153
* added REG_OPEN_HKCR for supporting regedit.exe * All data n a REGISTRY_VALUE is stored to a pointer now * fixed REG_INFO to correctly display data when double clicking on and entry in the registry editor * Will now enumerate installed driver_info_3 data * fixed numerous bugs related to pointer offsets, memory issues, etc.. in the registry routines * added a simple caching mechanism to fetch_reg_[keys|values]_specific() All that is left now is to enumerate PrinterData and I will have finished what I started out to do.... (This used to be commit 419d7208e8384e4ad2c4dd328ad5e630971bc76c)
2002-07-23* changed structure of REG_R_ENUM_VALUE structure since the BUFFER2Gerald Carter2-4/+39
is not and [in/out] buffer * registry value enumeration is working now for the Print\Forms key. The format of the binary data is not quite right yet but all installed forms are listed (This used to be commit 998eb9c7312c3c9a9ed1e9ec294593503c0304bf)
2002-07-21Name get and set dir drive functions consistently.Tim Potter1-1/+1
(This used to be commit 290a304d2c1b70d20129236e20a0ff664179023e)
2002-07-20Try to fix up warnings - particularly on the IRIX 64 bit compiler (which had aAndrew Bartlett1-1/+2
distinction between uchar and char). Lots of const etc. Andrew Bartlett (This used to be commit 8196ee908e10db2119e480fe1b0a71b31a16febc)
2002-07-15fixed a number of real bugs found by warnings on the 64 bit irix compilerAndrew Tridgell1-2/+2
(This used to be commit 04de6bbc8055e5547af41b10e284b722f40e726d)
2002-07-12The changes in make_sec_desc to make us match W2K broke the ↵Jeremy Allison1-19/+24
marshalling/unmarshalling of security descriptors. We need to calculate the maximum offset and set the offset back after reading/writing every field in the SEC_DESC. This was *nasty* to find.... Jeremy. (This used to be commit 175d43980e57c25582d8ab859f5730283e82f3b2)
2002-07-11all that is left to do is to actually perform theGerald Carter1-0/+4
file deletion now. I have the file list. One more commit should do it. (This used to be commit 7207662504f585352b0ceeb99f8998ef58db7f15)
2002-07-098-byte alignment needed for beginning driver_info_level_6.Gerald Carter2-22/+36
Verified by looking at NT4 and 2k servers. First time for everything I guess. (This used to be commit f57640720e4758176116bc2e1b578cf0e867f95f)