summaryrefslogtreecommitdiff
path: root/source3/rpc_server/spoolss
AgeCommit message (Collapse)AuthorFilesLines
2012-03-13s3-spoolss: Consistently fail OpenPrinterEx with "" printernameAndrew Bartlett1-0/+4
samba3.rpc.spoolss.printserver has become a flakey test recently, and this papers over the real problem. Andrew Bartlett Signed-off-by: Günther Deschner <gd@samba.org> Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Tue Mar 13 17:51:00 CET 2012 on sn-devel-104
2012-03-03s3: Fix a bogus if (client_len < 0)Volker Lendecke1-1/+1
On some platforms socklen_t might be unsigned, so comparing for <0 always returns true. Also, tsocket_address_bsd_sockaddr returns ssize_t. Autobuild-User: Volker Lendecke <vl@samba.org> Autobuild-Date: Sat Mar 3 23:38:31 CET 2012 on sn-devel-104
2012-01-22s3-spoolss: fix incorrect error check typeDavid Disseldorp1-1/+1
NT_STATUS_IS_OK used to check WERROR type. Autobuild-User: David Disseldorp <ddiss@samba.org> Autobuild-Date: Sun Jan 22 05:03:36 CET 2012 on sn-devel-104
2012-01-20s3-spoolss: fix printer_driver_files_in_use() call orderingDavid Disseldorp1-8/+10
printer_driver_files_in_use() performs two tasks: it returns whether any of the files in the to-be-deleted driver overlap with other drivers, it also trims such files from the info structure passed in. In processing a DeletePrinterDataEx request with DPD_DELETE_UNUSED_FILES set, printer_driver_files_in_use() must be called to ensure files in use by other drivers are not removed. https://bugzilla.samba.org/show_bug.cgi?id=4942 Signed-off-by: Andreas Schneider <asn@samba.org>
2012-01-20s3-spoolss: fix printer driver version deletionDavid Disseldorp1-167/+111
Spoolss delete printer driver code currently makes invalid version assumptions based on the architecture requested by the client. Ugly hacks are in place to cover removal of other versions (2 and 3). This change wraps multi version deletion in a simple for loop. Signed-off-by: Andreas Schneider <asn@samba.org>
2012-01-11spoolss: fix DPD_DELETE_ALL_FILES error returnDavid Disseldorp1-2/+1
If DeletePrinterDriverEx is called with DPD_DELETE_ALL_FILES and files assigned to the to-be-deleted driver overlap with other drivers then an error is returned. Change the error code here to match Windows 2k8r2. Signed-off-by: David Disseldorp <ddiss@samba.org> Signed-off-by: Andreas Schneider <asn@samba.org>
2011-12-15s3:smbd: pass smbd_server_connection and a snumused function pointer to ↵Stefan Metzmacher1-1/+11
reload_services() metze
2011-12-15s3:rpc_server/spoolss: remove reload_services check from delete_printer_hook()Stefan Metzmacher1-8/+0
As the spoolss code can run embedded or external relative to the smbd file server process, it's very tricky to verify if a share is still in use. Checking the result of the "deleteprinter command" command should be enough to check for success. We should not return WERR_ACCESS_DENIED if the share is still in use, by the current client, as the primary printer definition is already deleted. metze
2011-11-04Properly fix bug #8384 - Windows XP clients seem to crash smbd process every ↵Henry Wong1-0/+1
once in a while. Ensure we correctly null out the referenced pointer when we decrease the ref. count. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Fri Nov 4 21:12:13 CET 2011 on sn-devel-104
2011-10-26Second attempt to fix bug #8384 - Windows XP clients seem to crash smbd ↵Jeremy Allison1-1/+1
process every once in a while. Don't just use the first entry in back_channels as a talloc context to allocate a long-lived chan entry on - must be NULL. It's already correctly deleted when the last reference goes away. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Wed Oct 26 02:42:35 CEST 2011 on sn-devel-104
2011-10-24Try and fix bug #8384 - Windows XP clients seem to crash smbd process every ↵Jeremy Allison1-6/+17
once in a while. Remove the copy of the binding handle from struct notify_back_channel, use the direct pointer in struct rpc_pipe_client instead. Ensure we can't call the functions with a NULL binding handle. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Mon Oct 24 22:56:40 CEST 2011 on sn-devel-104
2011-09-03s3-spoolss: Fix bug #8236 empty notify servername.Andreas Schneider1-0/+9
Signed-off-by: Andreas Schneider <asn@samba.org> Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Sat Sep 3 02:58:42 CEST 2011 on sn-devel-104
2011-08-11s3-messaging: Remove obsolete class.Simo Sorce1-13/+0
The FLAG_MSG_PRINT_NOTIFY class is actually obsolete and never used, as the only message belonging to it is not used either. Signed-off-by: Andreas Schneider <asn@samba.org>
2011-08-02s3:spoolss: make use of cli_state_protocol()Stefan Metzmacher1-1/+1
metze
2011-07-28s3-spoolss: Use existing handle in printer_driver_files_in_use().Andreas Schneider1-4/+2
Autobuild-User: Andreas Schneider <asn@cryptomilk.org> Autobuild-Date: Thu Jul 28 16:20:11 CEST 2011 on sn-devel-104
2011-07-28s3-spoolss: Use existing handle in printer_driver_in_use().Andreas Schneider1-4/+2
2011-07-27s3-spoolss: Use get_session_info_system().Andreas Schneider1-19/+2
Autobuild-User: Andreas Schneider <asn@cryptomilk.org> Autobuild-Date: Wed Jul 27 10:38:34 CEST 2011 on sn-devel-104
2011-07-27s3-spoolss: Free the info2 structure in _spoolss_GetPrinter.Andreas Schneider1-0/+1
2011-07-27s3-spoolss: Use tmp_ctx everywhere in _spoolss_DeletePrinterDriverEx.Andreas Schneider1-6/+6
2011-07-27s3-spoolss: Use tmp_ctx in winreg_enum_printer_key_internal.Andreas Schneider1-7/+20
2011-07-27s3-spoolss: Use tmp_ctx in winreg_printer_deleteform1_internal.Andreas Schneider1-4/+17
2011-07-27s3-spoolss: Use tmp_ctx in winreg_printer_setform1_internal.Andreas Schneider1-5/+18
2011-07-27s3-spoolss: Use tmp_ctx in winreg_printer_addform1_internal.Andreas Schneider1-4/+17
2011-07-27s3-spoolss: Use tmp_ctx in winreg_printer_getform1_internal.Andreas Schneider1-5/+18
2011-07-27s3-spoolss: Use tmp_ctx in winreg_printer_enumforms1_internal.Andreas Schneider1-5/+18
2011-07-27s3-spoolss: Use tmp_ctx in winreg_set_printer_secdesc_internal.Andreas Schneider1-5/+18
2011-07-27s3-spoolss: Use tmp_ctx in winreg_get_printer_secdesc_internal.Andreas Schneider1-5/+18
2011-07-27s3-spoolss: Use tmp_ctx in winreg_add_driver_internal.Andreas Schneider1-6/+19
2011-07-27s3-spoolss: Use tmp_ctx in winreg_del_driver_internal.Andreas Schneider1-5/+18
2011-07-27s3-spoolss: Use tmp_ctx in winreg_get_driver_list_internal.Andreas Schneider1-7/+20
2011-07-27s3-spoolss: Use tmp_ctx in winreg_get_driver_internal.Andreas Schneider1-7/+20
2011-07-27s3-spoolss: Use tmp_ctx in winreg_delete_printer_dataex_internal.Andreas Schneider1-6/+19
2011-07-27s3-spoolss: Use tmp_ctx in winreg_get_printer_dataex_internal.Andreas Schneider1-9/+22
2011-07-27s3-spoolss: Use tmp_ctx in winreg_enum_printer_dataex_internal.Andreas Schneider1-7/+20
2011-07-27s3-spoolss: Use tmp_ctx in winreg_set_printer_dataex_internal.Andreas Schneider1-9/+22
2011-07-27s3-spoolss: Use tmp_ctx in winreg_update_printer_internal.Andreas Schneider1-8/+21
2011-07-27s3-spoolss: Use tmp_ctx in winreg_create_printer_internal.Andreas Schneider1-4/+17
2011-07-27s3-spoolss: Use tmp_ctx in winreg_get_printer_internal.Andreas Schneider1-5/+17
2011-07-27s3-spoolss: Use tmp_ctx in winreg_printer_get_changeid_internal.Andreas Schneider1-5/+18
2011-07-27s3-spoolss: Use tmp_ctx in winreg_printer_update_changeid_internal.Andreas Schneider1-4/+17
2011-07-27s3-spoolss: Use tmp_ctx in winreg_delete_printer_key_internal.Andreas Schneider1-5/+18
2011-07-27s3-spoolss: Free local in winreg_printer_binding_handle.Andreas Schneider1-0/+1
2011-07-27s3-spoolss: Improve memory efficiency.Simo Sorce1-158/+242
p->mem_ctx is a relatively long lived context as it will not be freed until a full request is served. In spoolss we do a lot of operations including opening new pipes to connect to winreg. Use more shortlived temporary contexts to avoid leaking a lot of memory on p->mem_ctx and carrying it around untill all the operations in the current call are done. Signed-off-by: Andreas Schneider <asn@samba.org>
2011-07-20s3-auth Use the common auth_session_infoAndrew Bartlett3-69/+69
This patch finally has the same structure being used to describe the authorization data of a user across the whole codebase. This will allow of our session handling to be accomplished with common code. Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-07-20s3-auth use auth_user_info not netr_SamInfo3 in auth3_session_infoAndrew Bartlett1-6/+6
This makes auth3_session_info identical to auth_session_info The logic to convert the info3 to a struct auth_user_info is essentially moved up the stack from the named pipe proxy in source3/rpc_server to create_local_token(). Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-07-20s3-auth Use *unix_token rather than utok in struct auth3_session_infoAndrew Bartlett1-13/+13
This brings this structure one step closer to the struct auth_session_info. A few SMB_ASSERT calls are added in some key places to ensure that this pointer is initialised, to make tracing any bugs here easier in future. NOTE: Many of the users of this structure should be reviewed, as unix and NT access checks are mixed in a way that should just be done using the NT ACL. This patch has not changed this behaviour however. Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-07-20s3-auth Use struct auth3_session_info outside the auth subsystemAndrew Bartlett3-69/+69
This seperation between the structure used inside the auth modules and in the wider codebase allows for a gradual migration from struct auth_serversupplied_info -> struct auth_session_info (from auth.idl) The idea here is that we keep a clear seperation between the structure before and after the local groups, local user lookup and the session key modifications have been processed, as the lack of this seperation has caused issues in the past. Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-07-07s3-printing: safe a ton of roundtrips by reusing existing winreg ↵Günther Deschner1-148/+191
binding_handles. Guenther Pair-Programmed-With: David Disseldorp <ddiss@suse.de>
2011-07-07s3-printing: use winreg_internal functions.Günther Deschner1-73/+73
Guenther Pair-Programmed-With: David Disseldorp <ddiss@suse.de>
2011-07-07s3-printing: add winreg_internal functions.Günther Deschner3-1/+540
Guenther Pair-Programmed-With: David Disseldorp <ddiss@suse.de>
generated by cgit (git 2.34.1) at 2024-12-11 11:15:10 +0000