summaryrefslogtreecommitdiff
path: root/source3/rpc_server/spoolss
AgeCommit message (Collapse)AuthorFilesLines
2013-10-17s3-spoolss: do not use rpc_pipe_np_smb_conn()Gregor Beck1-10/+10
Signed-off-by: Gregor Beck <gbeck@sernet.de> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-11Raise the level of a debug.Korobkin1-1/+1
Bug #10118 - Samba is chatty about being unable to open a printer Reviewed-by: Guenther Deschner <gd@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Wed Sep 11 03:10:08 CEST 2013 on sn-devel-104
2013-09-05lib: Use "mem_ctx" arg in gencache_getVolker Lendecke1-3/+3
Signed-off-by: Volker Lendecke <vl@samba.org> Signed-off-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Thu Sep 5 20:09:21 CEST 2013 on sn-devel-104
2013-09-05lib: Add a "mem_ctx" arg to gencache_get (unused so far)Volker Lendecke1-1/+2
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2013-08-05s3-rpc_cli: pass down ndr_interface_table to cli_rpc_pipe_open_noauth().Günther Deschner1-1/+1
Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
2013-06-03Fix bug 9900: is_printer_published GUID retrievalDavid Disseldorp1-7/+33
Samba currently always responds to GetPrinter(level = 7) requests with DSPRINT_UNPUBLISH, regardless of the AD publish status tracked via the PRINTER_ATTRIBUTE_PUBLISHED flag. This is due to erroneous "objectGUID" unmarshalling in is_printer_published(). This change splits "objectGUID" retrieval into a separate function, and adds a pull_reg_sz() call to correctly unmarshall the GUID. Signed-off-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
2013-05-20spoolss: add idl for spoolss_RpcSendRecvBidiData.Günther Deschner1-3/+3
Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
2013-02-22s3-spoolss: Don't leak memory.Andreas Schneider1-1/+3
Reviewed-by: Alexander Bokovoy <ab@samba.org>
2013-01-24s3-spoolss: Make it easier to manipulate the returned OSVersion at runtime.Günther Deschner1-3/+11
Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
2013-01-24spoolss: make spoolss deal with ndr64 StartDocPrinter by using proper ↵Günther Deschner1-2/+2
container object. Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
2013-01-21BUG 9474: Downgrade v4 printer driver requests to v3.Günther Deschner1-1/+8
Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Mon Jan 21 16:11:02 CET 2013 on sn-devel-104
2013-01-21BUG 9574: Fix a possible null pointer dereference in spoolss.Andreas Schneider1-1/+2
If the the client enumerates the printers and didn't specify a servername we have a null pointer dereference, so the process serving the connection crashes. Reviewed-by: David Disseldorp <ddiss@samba.org> Autobuild-User(master): David Disseldorp <ddiss@samba.org> Autobuild-Date(master): Mon Jan 21 13:30:11 CET 2013 on sn-devel-104
2013-01-17s3-spoolss: use configurable spoolss architecture in ↵Günther Deschner1-1/+5
compose_spoolss_server_path(). Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org> Autobuild-User(master): David Disseldorp <ddiss@samba.org> Autobuild-Date(master): Thu Jan 17 18:53:47 CET 2013 on sn-devel-104
2013-01-17spoolss: make spoolss deal with ndr64 SetForm by using proper container object.Günther Deschner1-1/+10
Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
2013-01-17spoolss: make spoolss deal with ndr64 AddForm by using proper container object.Günther Deschner1-1/+10
Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
2013-01-16spoolss: Make OpenPrinterEx work with NDR64 by using UserInfo Container.Günther Deschner1-6/+8
Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
2013-01-07spoolss: add stubs for new JobNamedProperty dcerpc calls.Günther Deschner1-0/+44
Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Mon Jan 7 19:06:25 CET 2013 on sn-devel-104
2012-12-21s3-rpc_server: Fix a possible null pointer dereference.Andreas Schneider1-1/+2
This variable can be set to NULL in an earlier function call. Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
2012-11-29spoolss: fix segfault when "default devmode" is disabledDavid Disseldorp1-18/+34
Currently when "default devmode" is explicitly disabled, and a printer is added with a null device mode, spoolssd crashes in copy_devicemode(). Both construct_printer_info2() and construct_printer_info8() code paths currently unconditionally attempt to copy a printers device mode, without checking whether one is present. This change fixes this regression such that construct_printer_info*() functions check for a null device mode before copying. https://bugzilla.samba.org/show_bug.cgi?id=9433 Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Thu Nov 29 13:03:05 CET 2012 on sn-devel-104
2012-07-18loadparm: make the source3/ lp_ functions take an explicit TALLOC_CTX *.Rusty Russell1-20/+20
They use talloc_tos() internally: hoist that up to the callers, some of whom don't want to us talloc_tos(). A simple patch, but hits a lot of files. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2012-07-06s3-rpc_server: Make it possible to use more rpc exceptions.Andreas Schneider1-56/+56
2012-07-03s3-printing: Remove deprecated lp_printer_admin().Andreas Schneider1-42/+14
2012-06-26s3-printing: pass a talloc ctx to unpack_pjobDavid Disseldorp1-1/+1
Rather than allocating the devicemode on a null context.
2012-06-26s3-printing: clean up print_job_pause/resume interfaceDavid Disseldorp1-8/+4
Currently both return a bool and sometimes set a werr pointer argument, always return werror instead.
2012-06-26s3-printing: rename queue->job sysjobDavid Disseldorp1-8/+8
Print jobs maintain two job identifiers, the jobid allocated by the spoolss layer (pj->jobid), and the job identifier defined by the printing backend (pj->sysjob). Printer job queues currently only contain a single job identifier variable (queue->job), the variable is sometimes representative of the spoolss layer job identifier, and more often representative of the printing backend id. This change renames the queue job identifier from queue->job to queue->sysjob, in preparation for a change to only store the printing backend identifier.
2012-06-19s3-spoolss: delete_drivers should be called as the connecting user.Andreas Schneider1-1/+1
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-05-28s3:libsmb: get rid of cli_state_protocolLuk Claes1-1/+2
Signed-off-by: Luk Claes <luk@debian.org> Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-05-09s3-spoolss: Set DWORD values correctly.Andreas Schneider1-9/+9
Autobuild-User: Andreas Schneider <asn@cryptomilk.org> Autobuild-Date: Wed May 9 11:13:00 CEST 2012 on sn-devel-104
2012-04-25s3:registry: remove usage of reg_objects from srv_spoolss_nt.cGregor Beck1-1/+0
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-03-24use usleep rather than sys_usleep in various places, in anticipation of ↵Jelmer Vernooij1-1/+1
usleep moving to libreplace.
2012-03-14s3-spoolss: Check return type of update_dsspooler().Andreas Schneider1-12/+18
Autobuild-User: Andreas Schneider <asn@cryptomilk.org> Autobuild-Date: Wed Mar 14 19:38:45 CET 2012 on sn-devel-104
2012-03-14s3-spoolss: Check return codes in update_dsspooler.Andreas Schneider1-40/+170
2012-03-13s3-spoolss: Consistently fail OpenPrinterEx with "" printernameAndrew Bartlett1-0/+4
samba3.rpc.spoolss.printserver has become a flakey test recently, and this papers over the real problem. Andrew Bartlett Signed-off-by: Günther Deschner <gd@samba.org> Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Tue Mar 13 17:51:00 CET 2012 on sn-devel-104
2012-03-03s3: Fix a bogus if (client_len < 0)Volker Lendecke1-1/+1
On some platforms socklen_t might be unsigned, so comparing for <0 always returns true. Also, tsocket_address_bsd_sockaddr returns ssize_t. Autobuild-User: Volker Lendecke <vl@samba.org> Autobuild-Date: Sat Mar 3 23:38:31 CET 2012 on sn-devel-104
2012-01-22s3-spoolss: fix incorrect error check typeDavid Disseldorp1-1/+1
NT_STATUS_IS_OK used to check WERROR type. Autobuild-User: David Disseldorp <ddiss@samba.org> Autobuild-Date: Sun Jan 22 05:03:36 CET 2012 on sn-devel-104
2012-01-20s3-spoolss: fix printer_driver_files_in_use() call orderingDavid Disseldorp1-8/+10
printer_driver_files_in_use() performs two tasks: it returns whether any of the files in the to-be-deleted driver overlap with other drivers, it also trims such files from the info structure passed in. In processing a DeletePrinterDataEx request with DPD_DELETE_UNUSED_FILES set, printer_driver_files_in_use() must be called to ensure files in use by other drivers are not removed. https://bugzilla.samba.org/show_bug.cgi?id=4942 Signed-off-by: Andreas Schneider <asn@samba.org>
2012-01-20s3-spoolss: fix printer driver version deletionDavid Disseldorp1-167/+111
Spoolss delete printer driver code currently makes invalid version assumptions based on the architecture requested by the client. Ugly hacks are in place to cover removal of other versions (2 and 3). This change wraps multi version deletion in a simple for loop. Signed-off-by: Andreas Schneider <asn@samba.org>
2012-01-11spoolss: fix DPD_DELETE_ALL_FILES error returnDavid Disseldorp1-2/+1
If DeletePrinterDriverEx is called with DPD_DELETE_ALL_FILES and files assigned to the to-be-deleted driver overlap with other drivers then an error is returned. Change the error code here to match Windows 2k8r2. Signed-off-by: David Disseldorp <ddiss@samba.org> Signed-off-by: Andreas Schneider <asn@samba.org>
2011-12-15s3:smbd: pass smbd_server_connection and a snumused function pointer to ↵Stefan Metzmacher1-1/+11
reload_services() metze
2011-12-15s3:rpc_server/spoolss: remove reload_services check from delete_printer_hook()Stefan Metzmacher1-8/+0
As the spoolss code can run embedded or external relative to the smbd file server process, it's very tricky to verify if a share is still in use. Checking the result of the "deleteprinter command" command should be enough to check for success. We should not return WERR_ACCESS_DENIED if the share is still in use, by the current client, as the primary printer definition is already deleted. metze
2011-11-04Properly fix bug #8384 - Windows XP clients seem to crash smbd process every ↵Henry Wong1-0/+1
once in a while. Ensure we correctly null out the referenced pointer when we decrease the ref. count. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Fri Nov 4 21:12:13 CET 2011 on sn-devel-104
2011-10-26Second attempt to fix bug #8384 - Windows XP clients seem to crash smbd ↵Jeremy Allison1-1/+1
process every once in a while. Don't just use the first entry in back_channels as a talloc context to allocate a long-lived chan entry on - must be NULL. It's already correctly deleted when the last reference goes away. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Wed Oct 26 02:42:35 CEST 2011 on sn-devel-104
2011-10-24Try and fix bug #8384 - Windows XP clients seem to crash smbd process every ↵Jeremy Allison1-6/+17
once in a while. Remove the copy of the binding handle from struct notify_back_channel, use the direct pointer in struct rpc_pipe_client instead. Ensure we can't call the functions with a NULL binding handle. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Mon Oct 24 22:56:40 CEST 2011 on sn-devel-104
2011-09-03s3-spoolss: Fix bug #8236 empty notify servername.Andreas Schneider1-0/+9
Signed-off-by: Andreas Schneider <asn@samba.org> Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Sat Sep 3 02:58:42 CEST 2011 on sn-devel-104
2011-08-11s3-messaging: Remove obsolete class.Simo Sorce1-13/+0
The FLAG_MSG_PRINT_NOTIFY class is actually obsolete and never used, as the only message belonging to it is not used either. Signed-off-by: Andreas Schneider <asn@samba.org>
2011-08-02s3:spoolss: make use of cli_state_protocol()Stefan Metzmacher1-1/+1
metze
2011-07-28s3-spoolss: Use existing handle in printer_driver_files_in_use().Andreas Schneider1-4/+2
Autobuild-User: Andreas Schneider <asn@cryptomilk.org> Autobuild-Date: Thu Jul 28 16:20:11 CEST 2011 on sn-devel-104
2011-07-28s3-spoolss: Use existing handle in printer_driver_in_use().Andreas Schneider1-4/+2
2011-07-27s3-spoolss: Use get_session_info_system().Andreas Schneider1-19/+2
Autobuild-User: Andreas Schneider <asn@cryptomilk.org> Autobuild-Date: Wed Jul 27 10:38:34 CEST 2011 on sn-devel-104
2011-07-27s3-spoolss: Free the info2 structure in _spoolss_GetPrinter.Andreas Schneider1-0/+1
generated by cgit (git 2.34.1) at 2024-11-18 19:35:36 +0000