summaryrefslogtreecommitdiff
path: root/source3/rpc_server/srv_spoolss_nt.c
AgeCommit message (Collapse)AuthorFilesLines
2003-08-23it never amazes me when some new things crawls out of the windowsGerald Carter1-0/+6
spooler. :-( When installing the Adobe PS driver onto a Samba printer via cupsaddsmb, I noticed a WIN2k client sending DeletePrinterData("DependentFiles") pver and over. I also noticed that we never checked to see if the value was valid. No now we do and return WERR_BADFILE which I think is correct. Next, I noticed that we never wrote the updated printer out to disk after a succesfully DeletePrinterData[Ex](). Finally, I found a driver (Canon BJC 1000 using the Adobe PS drivers and foomatic PPD file) that was destroying the device name string in the devmode. So now get_a_printer_2() always writes out the device name in \\server\share form. I think these changes might fix bug 294. (This used to be commit deb25780874b66e68ac597db24fbc50e7f7458b5)
2003-08-15possible fix for bug 288 to repcent using an uninitialized cli_state structGerald Carter1-0/+2
(This used to be commit d09dc91c024d718a8ddb6b7f08c7fe84716beda4)
2003-08-15get rid of some sompiler warnings on IRIXHerb Lewis1-14/+3
(This used to be commit a6a39c61e8228c8b3b7552ab3c61ec3a6a639143)
2003-08-08RPC fix from Ronan Waide <waider@waider.ie>. Tested with rpcecho.Jeremy Allison1-1/+0
Jeremy. (This used to be commit 68590b9e2266cf76b46a68cca0acaa47733811fe)
2003-07-25fix some error returns and strings; patch from metzeGerald Carter1-6/+14
(This used to be commit 948b1b138cf1fce18c93645fbdf948e589b19dc5)
2003-07-25More printf portability fixes. Got caught out by some gcc'isms lastTim Potter1-6/+6
time. )-: (This used to be commit 59dae1da66a5eb7e128263bd578f167d8746e9f0)
2003-07-24More printf fixes - size_t is long on some architectures.Tim Potter1-5/+5
(This used to be commit ba4d334b822248d8ab929c9568533431603d967e)
2003-07-22Use %p for a pointer type in a printf-style format string. Also castingTim Potter1-1/+1
a pointer to a uint32 value is incorrect on a 64-bit architecture. (This used to be commit afed2cbbcc07de9e453156972250f5f9d22e8e83)
2003-07-14fix cache coherency bug in print handle print_info_2 cache.Gerald Carter1-1/+28
Needs to be rewritten to use a reference counter, but this will work for now. also the memory allocation in the printing code needs to be cleaned up to use talloc exclusively. (This used to be commit 3d293027563b36411b7f84ed9d8f47f926271c6f)
2003-07-03Removed strupper/strlower macros that automatically map to ↵Jeremy Allison1-2/+2
strupper_m/strlower_m. I really want people to think about when they're using multibyte strings. Jeremy. (This used to be commit ff222716a08af65d26ad842ce4c2841cc6540959)
2003-07-03Fix for bug #199 (xp driver uploads). Needed to supportGerald Carter1-6/+14
the "OSVersion" print server data value. (This used to be commit 02bc7be1ac6b75bf6559ea684bbc89ab3e19402e)
2003-06-13Rename some uuid functions so as not to conflict with systemTim Potter1-1/+1
versions. Fixes bug #154. (This used to be commit 986eae40f7669d15dc75aed340e628aa7efafddc)
2003-06-03Merge DEBUG message on usleep on open.Jeremy Allison1-0/+1
Jeremy. (This used to be commit 063a210448d57e08db6d47a584c591f20645c80a)
2003-05-15Ensure sys_adminlog code won't coredump with incorrect client params.Jeremy Allison1-4/+11
Jeremy. (This used to be commit b754089a2660975c593a6651e5e72b7360a0aba1)
2003-04-23Merge the 'safe' parts of my StrnCpy patch - many of the users really wantedAndrew Bartlett1-12/+12
a pstrcpy/fstrcpy or at most a safe_strcpy(). These have the advantage of being compiler-verifiable. Get these out of the way, along with a rewrite of 'get_short_archi' in the spoolss client and server. (This pushes around const string pointers, rather than copied strings). Andrew Bartlett (This used to be commit 32fb801ddc035e8971e9911ed4b6e51892e9d1cc)
2003-04-15Merge of comment typo.Tim Potter1-3/+3
Whitespace syncup. (This used to be commit c69237edf2bfdb426447d808fbd1dc6eb5cffabe)
2003-04-14Fix typosJelmer Vernooij1-2/+2
(This used to be commit 21166e87bfeeaa5079dfbcac3df9232d73986532)
2003-04-11* We must return 0x2 as the majorversion for nt4 to upload driversGerald Carter1-1/+11
* fix bug found by clobber_region() (This used to be commit b2e29c7bd45f8f33d9ed58fe75bbf5ffc78350f5)
2003-04-11simple fix to hopefully speed up srv_spoolss_replyopenprinter().Gerald Carter1-22/+36
Use the client address from the pipe->conn->client_address instead of trying to resolve the name in the _spoolss_rffpcn() request. Should make us more robust as well when the clients are not registered in DNS or WINS. (This used to be commit 23f0fcf6421b1e8dd6ed6ab14af14ea7eb380c1c)
2003-04-10Ensure we're not filtering our essential delete messages.Jeremy Allison1-2/+2
Added jobid debug when unpacking message. Jeremy. (This used to be commit 8a6f3313e69c6d47e20838f42ebc9f8a2ce9ddc4)
2003-04-09another forgotten merge sitting on my laptop from app_head; only stall ↵Gerald Carter1-3/+6
open_printer when 2k client opens with admin privs & fix reply for ChangeId printer data reply (This used to be commit 12eb3e993788eb8bc0e9eb62e60a8b55079df5ad)
2003-04-08fixup extra SAFE_FREE()'s noticed by abartletGerald Carter1-2/+0
(This used to be commit 51d330dcf3bd74367fc18f4229a9cfa0392f0b36)
2003-04-02Subtle changes to message handling after ENUMJOBS.Jeremy Allison1-8/+95
Jeremy. (This used to be commit e5e83544dc0acf812bfa5ea17960b5a6be954ca1)
2003-04-01fix potential handle leak in _spoolss_open_printer_ex(); final fix for ↵Gerald Carter1-1/+3
CR2102; reviewed by jra (This used to be commit 50c25e54ff05bfb01a93e84afd2ad92e90d5a5c2)
2003-03-31fix potential smbd crash when we fail to alloacte a policy handle for a ↵Gerald Carter1-6/+7
printer open; CR 2102 (reviewed by jreilly) (This used to be commit 26478158bc03fdf019589ce68062100a39149b52)
2003-03-31add a few error checks in EnumPrinterData()Gerald Carter1-4/+5
(This used to be commit 6cd74dea086aa6e0936719f6e2829494c4688ea6)
2003-03-20lib/messages.c: Check return from chainlock before modifying message queue.Jeremy Allison1-6/+0
Apply the job returned limit across all requests for job queues. Jeremy. (This used to be commit bf795b684e608f82db822e0759e7b69afd451b65)
2003-03-03* always report ourselves as a Windows 2000 print server (evenGerald Carter1-8/+29
without ADS support) * add "MinorVersion" print server data key and comment on "OSVersion" (This used to be commit e1383368169faa50b9e612c9f71f92f790698b48)
2003-03-03* CR1868: only send a change notify message if we have somethingGerald Carter1-3/+15
that changed that the client is monitoring. * couple of comments abnout how we need to validate driver names on SetPrinter() and AddPrinter() * up the debug level on some overly verbose dev mode parsing messages (This used to be commit e8939165b77c9e2ea8b3cef2e85885b9812c7184)
2003-03-01Added limit to number of jobs enumerated. Set to 0 (means no limit).Jeremy Allison1-0/+6
Yes I will add the docs.... Jeremy. (This used to be commit e1b0001c8df9e9823b42a372ca675188570b252a)
2003-02-27additional fix for CR 601Gerald Carter1-0/+6
* distinguish WinXP from Win2k * add a 1/3 of a second delay in OpenPrinter in order to trigger a LAN/WAN optimization in 2k clients. (This used to be commit c7712fa054d21b4884a78b7ea6c0fb8b3d637c6b)
2003-02-25Progress on CR 601Gerald Carter1-155/+122
cache the printer_info_2 with the open printer handle. cache is invalidated on a mod_a_printer() call **on that smbd**. Yes, this means that the window for admins to step on each other from different clients just got larger, but since handles a generally short lived this is probably ok. (This used to be commit 31272d3b6bb9ec62fd666301c7adfa0c1720a99b)
2003-02-24Merge of server-side authentication changes to 3.0:Andrew Bartlett1-3/+3
- user_ok() and user_in_group() now take a list of groups, instead of looking for the user in the members of all groups. - The 'server_info' returned from the authentication is now kept around - in future we won't copy the sesion key, username etc, we will just referece them directly. - rhosts upgraded to use the SAM if possible, otherwise fake up based on getpwnam(). - auth_util code to deal with groups upgraded to deal with non-winbind domain members again. Andrew Bartlett (This used to be commit 74b5436c75114170ce7c780c19226103d0df9060)
2003-02-21s/unistr2_to_dos/unistr2_to_ascii/ to fix compileGerald Carter1-1/+1
(This used to be commit de6a2d154e0e863a7628f18cca8fdcaa49d9c0ff)
2003-02-21couple of merges from APP_HEADGerald Carter1-4/+25
* performance optimization in enumprinterdataex() when keyname is empty * fix a few typos in comments * reload services after addprinter_command() dump registry data in ascii when the key is REG_SZ or REG_MULTI_SZ (This used to be commit 3fc90ea1d9b11186f26484516a4dd8502b6d7323)
2003-02-18set the various DsSpooler keys that are linked to PRINTER_INFO_2 fields; CR 985Gerald Carter1-10/+57
(This used to be commit 9efaef4a96a14bd1ffabf12326ff6f6903f663b2)
2003-02-15* set PRINTER_ATTRIBUTE_RAW_ONLY; CR 1736Gerald Carter1-1/+1
* never save a pointer to an automatic variable (they go away) implement a deep copy for SPOOLSS_NOTIFY_MSG to correct messages being sent that have junk for strings; fix in response to changes for CR 1504 (This used to be commit ffda9e2480414c7ed6156958f516e0d1f3c61350)
2003-02-14Ensure that only parse_prs.c access internal members of the prs_struct.Jeremy Allison1-3/+2
Needed to move to disk based i/o later. Jeremy. (This used to be commit a823fee5b41a5b6cd4ef05aa1f85f7725bd272a5)
2003-02-13Removed unused variable.Jeremy Allison1-1/+0
Jeremy. (This used to be commit a29f1aa85f23fa82795a06ad81b26895b025954b)
2003-02-13Merge JohnR's patch.Jeremy Allison1-3/+1
Removed extra copy of server name in the printername field (it was mangling the the name to be \\server\\\server\printer ... yes, there were 3 backslashes) reported by get & enum jobs level 2. Jeremy. (This used to be commit 2d63f3a13d2cea794eb413023b83c4a1071eaea0)
2003-02-05Fixed type.Jeremy Allison1-1/+1
Jeremy. (This used to be commit 76c3ccf6ed258b43d7cf1222524d8e5d2bdc8c82)
2003-01-14Merge from HEAD:Andrew Bartlett1-4/+4
- fstring/pstring mixups - the detection code that found them (disabled) - a bit of whitespace - a static Andrew Bartlett (This used to be commit 9b70fa868e7d9481f584c83fc4046174e1dedfd9)
2003-01-11[merge] make sure to update print queue cache during timeout_processing() to ↵Gerald Carter1-9/+40
send notify events; CR 1491 (This used to be commit f8a915b14d63e4fdb99235053eeb896ef9492068)
2003-01-09a 0 length printer data value is not a memory allocation error; fix CR601Gerald Carter1-2/+10
(This used to be commit 47c1709425e0c8c1e57d95dd4441b1424a5b914c)
2003-01-03Merge from HEAD - make Samba compile with -Wwrite-strings without additionalAndrew Bartlett1-15/+15
warnings. (Adds a lot of const). Andrew Bartlett (This used to be commit 3a7458f9472432ef12c43008414925fd1ce8ea0c)
2002-12-20Forward port the change to talloc_init() to make all talloc contextsJeremy Allison1-1/+1
named. Ensure we can query them. Jeremy. (This used to be commit 09a218a9f6fb0bd922940467bf8500eb4f1bcf84)
2002-12-20Whitespace syncup.Tim Potter1-1/+1
(This used to be commit 7a4a2cb8e86ae8ed0bd877f0cfa324e23b96593a)
2002-12-17* fix memory leak when constructing an driver_level_6 structureGerald Carter1-1/+7
and no dependent files (working on smbd memory leak). No CR# yet. (This used to be commit 416fd947da4463f5d4dc336dfddf5ce35f50fae9)
2002-12-13Store printer guid in the dsspooler registry key so we don't have toJim McDonough1-34/+9
query the directory server every time someone asks (This used to be commit dd81003bddc17522041e1cd2f0484e1760493e4a)
2002-12-13More printer publishing code.Jim McDonough1-5/+41
- Add published attribute to info2, needed for win clients to work properly - Return proper info on getprinter 7 This means you can now look at the sharing tab of a printer and get correct info about whether it is published or not, and change it. (This used to be commit d57bddc9b22e809c79294c7eacbd5d0f115fe990)