summaryrefslogtreecommitdiff
path: root/source3/rpc_server/srv_spoolss_nt.c
AgeCommit message (Collapse)AuthorFilesLines
2007-12-15Replace sid_string_static by sid_string_dbg in DEBUGsVolker Lendecke1-10/+4
(This used to be commit bb35e794ec129805e874ceba882bcc1e84791a09)
2007-12-10Fix return values for invalid printers. Found by kblinJeremy Allison1-5/+14
spoolss test. Jeremy. (This used to be commit bb8c044d425cf62b76e487103c8fb0b6cd4c83c2)
2007-11-29Remove the explicit TALLOC_CTX * from cli_struct.Jeremy Allison1-3/+9
Make us very explicit about how long a talloc ctx should last. Jeremy. (This used to be commit ba9e2be2b5a59684e854609f9d82ea1633448c62)
2007-11-27Remove pstring from srv_spoolss_nt.c. All gone from rpc_server/*.cJeremy Allison1-232/+306
Jeremy. (This used to be commit b5a2a1e3f82a0d319fc9a1d76f5166150680f4d4)
2007-11-27Fix old cut-and-paste bug where the wrong field was being written to.Jeremy Allison1-2/+2
Jerry please check. Jeremy. (This used to be commit 6a556fd73ac8c247c15df664f7910f8688abfdbc)
2007-11-27Whitespace cleanup.Jeremy Allison1-1037/+1035
Jeremy. (This used to be commit 3052172d2bfe9d787777525e90816394aac2dd54)
2007-11-27Remove some staticsVolker Lendecke1-1/+2
(This used to be commit 1fab16ffb888cd4ec18e52d9da33976a67a5d104)
2007-11-08Remove more fstring/pstring bad useage. Go talloc !Jeremy Allison1-6/+6
Jeremy. (This used to be commit 2a0173743d2cf615d52278f3dd87cc804abe2d16)
2007-10-24This is a large patch (sorry). Migrate from struct in_addrJeremy Allison1-12/+18
to struct sockaddr_storage in most places that matter (ie. not the nmbd and NetBIOS lookups). This passes make test on an IPv4 box, but I'll have to do more work/testing on IPv6 enabled boxes. This should now give us a framework for testing and finishing the IPv6 migration. It's at the state where someone with a working IPv6 setup should (theorecically) be able to type : smbclient //ipv6-address/share and have it work. Jeremy. (This used to be commit 98e154c3125d5732c37a72d74b0eb5cd7b6155fd)
2007-10-18RIP BOOL. Convert BOOL -> bool. I found a few interestingJeremy Allison1-40/+40
bugs in various places whilst doing this (places that assumed BOOL == int). I also need to fix the Samba4 pidl generation (next checkin). Jeremy. (This used to be commit f35a266b3cbb3e5fa6a86be60f34fe340a3ca71f)
2007-10-10Add start of IPv6 implementation. Currently most of this is avoidingJeremy Allison1-2/+2
IPv6 in winbindd, but moves most of the socket functions that were wrongly in lib/util.c into lib/util_sock.c and provides generic IPv4/6 independent versions of most things. Still lots of work to do, but now I can see how I'll fix the access check code. Nasty part that remains is the name resolution code which is used to returning arrays of in_addr structs. Jeremy. (This used to be commit 3f6bd0e1ec5cc6670f3d08f76fc2cd94c9cd1a08)
2007-10-10[GLUE] Rsync SAMBA_3_2_0 SVN r25598 in order to create the v3-2-test branch.Gerald (Jerry) Carter1-174/+87
(This used to be commit 5c6c8e1fe93f340005110a7833946191659d88ab)
2007-10-10r25534: Apply some constVolker Lendecke1-1/+1
Why? It moves these structs from the data into the text segment, so they will never been copy-on-write copied. Not much, but as in German you say "Kleinvieh macht auch Mist...." (This used to be commit 0141e64ad4972232de867137064d0dae62da22ee)
2007-10-10r25294: Tidy up callers of unistr2_to_ascii() to pass sizeof(target_area) toMichael Adam1-27/+27
the maxeln parameter instead of sizeof(target_area) - 1 (or even sizeof(fstring) - 1 in some places. I hope these were really all there were. Michael (This used to be commit 9a28be220df622322857dfe102fa35e108f932dc)
2007-10-10r24809: Consolidate the use of temporary talloc contexts.Volker Lendecke1-3/+3
This adds the two functions talloc_stackframe() and talloc_tos(). * When a new talloc stackframe is allocated with talloc_stackframe(), then * the TALLOC_CTX returned with talloc_tos() is reset to that new * frame. Whenever that stack frame is TALLOC_FREE()'ed, then the reverse * happens: The previous talloc_tos() is restored. * * This API is designed to be robust in the sense that if someone forgets to * TALLOC_FREE() a stackframe, then the next outer one correctly cleans up and * resets the talloc_tos(). The original motivation for this patch was to get rid of the sid_string_static & friends buffers. Explicitly passing talloc context everywhere clutters code too much for my taste, so an implicit talloc_tos() is introduced here. Many of these static buffers are replaced by a single static pointer. The intended use would thus be that low-level functions can rather freely push stuff to talloc_tos, the upper layers clean up by freeing the stackframe. The more of these stackframes are used and correctly freed the more exact the memory cleanup happens. This patch removes the main_loop_talloc_ctx, tmp_talloc_ctx and lp_talloc_ctx (did I forget any?) So, never do a tmp_ctx = talloc_init("foo"); anymore, instead, use tmp_ctx = talloc_stackframe() :-) Volker (This used to be commit 6585ea2cb7f417e14540495b9c7380fe9c8c717b)
2007-10-10r24316: Fix an uninitialized readVolker Lendecke1-0/+1
Jerry, please check this! Thanks, Volker (This used to be commit db1b89072c3f214c3cb4be844cd7b417e5361615)
2007-10-10r23801: The FSF has moved around a lot. This fixes their Mass Ave address.Andrew Tridgell1-2/+1
(This used to be commit 87c91e4362c51819032bfbebbb273c52e203b227)
2007-10-10r23779: Change from v2 or later to v3 or later.Jeremy Allison1-1/+1
Jeremy. (This used to be commit 407e6e695b8366369b7c76af1ff76869b45347b3)
2007-10-10r23758: Fix Coverity id 385Volker Lendecke1-2/+7
(This used to be commit 4d9f627cc8081307da3f84f784602533bd20c1e6)
2007-10-10r23055: Rewrite messages.c to use auto-generated marshalling in the tdb. I'mVolker Lendecke1-2/+2
doing this because for the clustering the marshalling is needed in more than one place, so I wanted a decent routine to marshall a message_rec struct which was not there before. Tridge, this seems about the same speed as it used to be before, the librpc/ndr overhead in my tests was under the noise. Volker (This used to be commit eaefd00563173dfabb7716c5695ac0a2f7139bb6)
2007-10-10r23015: Make message_(de)register static to messages.cVolker Lendecke1-10/+14
(This used to be commit a8082a3c7c3d1e68c27fc3bf42f3d44402cc6f9f)
2007-10-10r22954: More messaging_registerVolker Lendecke1-8/+16
(This used to be commit 9b8df24107ffe3016031e5257c5680689f061886)
2007-10-10r22911: Pass a messaging_context to message_send_allVolker Lendecke1-2/+4
(This used to be commit cc92ce665dcfe9054d09429219883b18a4cab090)
2007-10-10r22895: Convert some more calls from message_send_buf to messaging_send_bufVolker Lendecke1-4/+6
(This used to be commit c8b98273406242a89a7e5d1fb5d79120ebe5822a)
2007-10-10r22761: This introduces lib/conn_tdb.c with two main functions: ↵Volker Lendecke1-2/+2
connections_traverse and connections_forall. This centralizes all the routines that did individual tdb_open("connections.tdb") and direct tdb_traverse. Volker (This used to be commit e43e94cda1ad8876b3cb5d1129080b57fa6ec214)
2007-10-10r22736: Start to merge the low-hanging fruit from the now 7000-line cluster ↵Volker Lendecke1-3/+3
patch. This changes "struct process_id" to "struct server_id", keeping both is just too much hassle. No functional change (I hope ;-)) Volker (This used to be commit 0ad4b1226c9d91b72136310d3bbb640d2c5d67b8)
2007-10-10r22593: Finish doing the same for raw TALLOC.Jeremy Allison1-109/+172
Jeremy. (This used to be commit aef3c262b724d1283187e732833519c4e6fb088c)
2007-10-10r22588: Make all uses of TALLOC_MEMDUP consistent.Jeremy Allison1-4/+8
Jeremy. (This used to be commit 8ad13718af0ba1fcb10a6f1631b1ed3cb8d11175)
2007-10-10r22587: Ensure TALLOC_ZERO_ARRAY is consistent.Jeremy Allison1-3/+2
Jeremy. (This used to be commit c3df5d08dd6a983f9d53dc6628a50e571d322e8d)
2007-10-10r22542: Move over to using the _strict varients of the tallocJeremy Allison1-1/+1
calls. No functional changes. Looks bigger than it is :-). Jeremy. (This used to be commit f6fa3080fee1b20df9f1968500840a88cf0ee592)
2007-10-10r22062: Fix the parsing of info level 3. Flags is not a flagsJeremy Allison1-2/+0
field, but an offset. Fixed 64-bit display of ACLs on printers. Jeremy. (This used to be commit 0c8949ff5d742dbe59f2af0f57a289f238e3592c)
2007-10-10r22009: change TDB_DATA from char * to unsigned char *Stefan Metzmacher1-4/+4
and fix all compiler warnings in the users metze (This used to be commit 3a28443079c141a6ce8182c65b56ca210e34f37f)
2007-10-10r22001: change prototype of dump_data(), so that it takes unsigned char * now,Stefan Metzmacher1-1/+1
which matches what samba4 has. also fix all the callers to prevent compiler warnings metze (This used to be commit fa322f0cc9c26a9537ba3f0a7d4e4a25941317e7)
2007-10-10r21569: Fix bug reported by Martin Zielinski <mz@seh.de>Jeremy Allison1-1/+1
where return value was incorrectly initialized. Jeremy. (This used to be commit 8d45f1f3b524031a34cfba21b677be8a09fc192c)
2007-10-10r21164: Fix from Martin Zielinski <mz@seh.de> for EnumprinterdataEXJeremy Allison1-9/+9
on Vista. Jeremy. (This used to be commit b16707a8615e1d00839d31e7a3061fb111336691)
2007-10-10r21129: Fix from Martin Zielinski <mz@seh.de> - ensureJeremy Allison1-0/+10
the hand marshalled container size is a multiple of 4 bytes for RPC alignment. Jeremy. (This used to be commit 0e9ad2b29f1c05dc3f5d5e9659fe0557fa077d2e)
2007-10-10r21099: Protect ourselves from null pointer deref. This isn'tJeremy Allison1-0/+6
the correct fix for the Vista bug, but it needed as protection against invalid RPC. Thanks to Martin Zielinski <mz@seh.de> for pointing this out. Jeremy. (This used to be commit fbab8e4ba93325f68353ee345a257a5445d78e67)
2007-10-10r21064: The core of this patch isVolker Lendecke1-4/+7
void message_register(int msg_type, void (*fn)(int msg_type, struct process_id pid, - void *buf, size_t len)) + void *buf, size_t len, + void *private_data), + void *private_data) { struct dispatch_fns *dfn; So this adds a (so far unused) private pointer that is passed from message_register to the message handler. A prerequisite to implement a tiny samba4-API compatible wrapper around our messaging system. That itself is necessary for the Samba4 notify system. Yes, I know, I could import the whole Samba4 messaging system, but I want to do it step by step and I think getting notify in is more important in this step. Volker (This used to be commit c8ae60ed65dcce9660ee39c75488f2838cf9a28b)
2007-10-10r19156: Make enumprinters use the share iterators.Volker Lendecke1-25/+29
Volker (This used to be commit 9b1759617ce7841a78d9f792254a9e4fa814858f)
2007-10-10r19154: Trivial logic simplification: Get rid of two indentation levels. ↵Volker Lendecke1-32/+51
Survives the consistency checks just checked into Samba4. Volker (This used to be commit c48bb4b37b32fac9d01d243290532641d3701ec7)
2007-10-10r19028: Implement getprinterinfo level 6 (only the status) and get rid of ↵Volker Lendecke1-80/+214
snum in the getprinter calls. Survives the RPC-SAMBA3-SPOOLSS test which I will activate when the Samba4 build farm has picked it up. Volker (This used to be commit d7248b6cfa4d6e639d92afdd092136d900d90e19)
2007-10-10r18898: Fix for bug #4100 from Udo Eberhardt <udo.eberhardt@thesycon.de>.Jeremy Allison1-0/+3
Ensure we initialize values for smb_io_notify_info_data_strings to fix crash. Jeremy. (This used to be commit ceefb8dd3ca67449d5afbf556e9879abb37830ac)
2007-10-10r18745: Use the Samba4 data structures for security descriptors and security ↵Jelmer Vernooij1-13/+13
descriptor buffers. Make security access masks simply a uint32 rather than a structure with a uint32 in it. (This used to be commit b41c52b9db5fc4a553b20a7a5a051a4afced9366)
2007-10-10r18654: Rename "struct uuid" => "struct GUID" for consistency.Jelmer Vernooij1-1/+1
(This used to be commit 5de76767e857e9d159ea46e2ded612ccd6d6bf19)
2007-10-10r18404: * swap from POLICY_HND to the struct policy_handle from ndr/misc.hGerald Carter1-4/+0
* move OUR_HANDLE macro to include/rpc_misc.h (This used to be commit 2b37079af2f569df7a58878150a61980c6fe06ee)
2007-10-10r18188: merge 3.0-libndr branchJelmer Vernooij1-2/+1
(This used to be commit 1115745caed3093c25d6be01ffee21819fb0a675)
2007-10-10r17386: fix inverted logic pointed out by Volker. When deleting a printer ↵Gerald Carter1-1/+1
return access denied if the printer still exists after the delete_printer_hook() is called (This used to be commit c05e2bdc0c068eb832035daea7962ab1a9e787b2)
2007-10-10r17348: Some C++ warningsVolker Lendecke1-8/+12
(This used to be commit ae6b9b34e59167e3958bfdb9997fa25340b9a0a3)
2007-10-10r17245: Second part of fix for #3962. Don't do a doubleJeremy Allison1-14/+8
free in the infolevel2 case. Free both queue and NT_PRINTER_INFO_LEVEL in the same place. Jeremy. (This used to be commit 6ac3a4ce78f42949013ae7bd675ff292fb0383ca)
2007-10-10r17244: There were several error paths where NT_PRINTER_INFO_LEVELJeremy Allison1-6/+17
wasn't being freed - also one enum jobs case where the NT_PRINTER_INFO_LEVEL and queue weren't being freed. Strange that Coverity or Klokwork didn't pick these up. Hopefully will fix #3962. Jeremy. (This used to be commit bb264123872bfec42ad85ec0c8afa3a8c7d1811e)