summaryrefslogtreecommitdiff
path: root/source3/rpc_server/srv_spoolss_nt.c
AgeCommit message (Collapse)AuthorFilesLines
2003-04-15Typo in comment.Tim Potter1-1/+1
(This used to be commit 0a87d668a07b840c2e0ac9f6caad04e542422d40)
2003-04-14Fix typosJelmer Vernooij1-2/+2
(This used to be commit 7bd80376cc6aa70996a61882e1376cb6a0679836)
2003-04-11* We must return 0x2 as the majorversion for nt4 to upload driversGerald Carter1-1/+11
* fix bug found by clobber_region() (This used to be commit ad2765bb5e0c1c4d8f12583e49df5b1bc7ffc389)
2003-04-11simple fix to hopefully speed up srv_spoolss_replyopenprinter().Gerald Carter1-22/+36
Use the client address from the pipe->conn->client_address instead of trying to resolve the name in the _spoolss_rffpcn() request. Should make us more robust as well when the clients are not registered in DNS or WINS. (This used to be commit 78b2c1be7d9923716841627044c4e1578a5b9546)
2003-04-10Ensure we're not filtering our essential delete messages.Jeremy Allison1-2/+2
Added jobid debug when unpacking message. Jeremy. (This used to be commit 8bab6e32069e1636a52efa31ca55b49f1b3fa768)
2003-04-09another forgotten merge sitting on my laptop from app_head; only stall ↵Gerald Carter1-3/+6
open_printer when 2k client opens with admin privs & fix reply for ChangeId printer data reply (This used to be commit c7c3d42cd5954b040ee7027886ea8d9d0f2da9a5)
2003-04-09forgotten merge left on disk; remove extra SAFE_FREE()Gerald Carter1-2/+0
(This used to be commit 4d42067cb89220a1b275bc8408c9c1ba2ef7766a)
2003-04-02Subtle changes to message handling after ENUMJOBS.Jeremy Allison1-8/+95
Jeremy. (This used to be commit 48f3bf0ea51b9fd09dfb017870e32ca4a8cc4b8c)
2003-04-01fix potential handle leak in _spoolss_open_printer_ex(); final fix for ↵Gerald Carter1-1/+3
CR2102; reviewed by jra (This used to be commit 3d37e1ece913707f346c3c2459c3c42192a3a1a7)
2003-03-31fix potential smbd crash when we fail to alloacte a policy handle for a ↵Gerald Carter1-8/+9
printer open; CR 2102 (reviewed by jreilly) (This used to be commit a179c2cefb15b1b8869a83fe5f14a85d1eb96114)
2003-03-31add a few error checks in EnumPrinterData()Gerald Carter1-4/+5
(This used to be commit 453813ec6e2c25a3f6a664212aedcad15cfd6000)
2003-03-20lib/messages.c: Check return from chainlock before modifying message queue.Jeremy Allison1-6/+0
Apply the job returned limit across all requests for job queues. Jeremy. (This used to be commit dee1326a1d8a0bf8977df22a0fe014dd5d8dc769)
2003-03-03* always report ourselves as a Windows 2000 print server (evenGerald Carter1-8/+29
without ADS support) * add "MinorVersion" print server data key and comment on "OSVersion" (This used to be commit 342734e3de71c7dc8e3d24fd66dae58cf647a569)
2003-03-03* CR1868: only send a change notify message if we have somethingGerald Carter1-1/+13
that changed that the client is monitoring. * couple of comments abnout how we need to validate driver names on SetPrinter() and AddPrinter() * up the debug level on some overly verbose dev mode parsing messages (This used to be commit 7377d671e8a95ac2ab0452f564b18b2a098699cb)
2003-03-01Added limit to number of jobs enumerated. Set to 0 (means no limit).Jeremy Allison1-0/+6
Yes I will add the docs.... Jeremy. (This used to be commit 4a739d914bb87a3c8d071dfd0f275a9aab1cf90a)
2003-02-27additional fix for CR 601Gerald Carter1-0/+6
* distinguish WinXP from Win2k * add a 1/3 of a second delay in OpenPrinter in order to trigger a LAN/WAN optimization in 2k clients. (This used to be commit 96570699d1b715f47c35aa211da6ec18f6fc4109)
2003-02-25Progress on CR 601Gerald Carter1-155/+122
cache the printer_info_2 with the open printer handle. cache is invalidated on a mod_a_printer() call **on that smbd**. Yes, this means that the window for admins to step on each other from different clients just got larger, but since handles a generally short lived this is probably ok. (This used to be commit 33c7b7522504fb15989f32add8e9a087c8d9d0fa)
2003-02-21i patched the wrong branch! s/unistr2_to_dos/unistr2_to_ascii/Gerald Carter1-1/+1
(This used to be commit 513fb2ddd85a74de7684a6cb09d57011af69161f)
2003-02-21couple of merges from APP_HEADGerald Carter1-3/+24
* performance optimization in enumprinterdataex() when keyname is empty * fix a few typos in comments * reload services after addprinter_command() dump registry data in ascii when the key is REG_SZ or REG_MULTI_SZ (This used to be commit fde6ef7cc62c58d512dc8053b214f0a3c59a78ab)
2003-02-18set the various DsSpooler keys that are linked to PRINTER_INFO_2 fields; CR 985Gerald Carter1-10/+57
(This used to be commit 9a4b7a86fdaab04328b5017c1dd42480753a9a10)
2003-02-17This patch fixes one of my longest-standing pet hates with Samba :-).Andrew Bartlett1-2/+2
When we look see if a user is in a list, and we try to 'expand' an @group, we should lookup the user's own list of groups, rather than looking for all the members of a group. I'm sure this will fix some nasty performance issues, particularly on large domains etc. In particular, this avoids contacting winbind at all, if the group is not a winbind group. (This caused a deadlock on my winbind-on-PDC setup). The groups list always includes the user's primary group, as per the getgrouplist manpage, and my recent changes to our implementation. Andrew Bartlett (This used to be commit 9be21976f7662ebe6eb92fff7cecbdb352eca334)
2003-02-15* set PRINTER_ATTRIBUTE_RAW_ONLY; CR 1736Gerald Carter1-1/+1
* never save a pointer to an automatic variable (they go away) implement a deep copy for SPOOLSS_NOTIFY_MSG to correct messages being sent that have junk for strings; fix in response to changes for CR 1504 (This used to be commit 043b9dff22e909fc290c34d879cad8b4c980fc13)
2003-02-14Ensure that only parse_prs.c access internal members of the prs_struct.Jeremy Allison1-3/+2
Needed to move to disk based i/o later. Jeremy. (This used to be commit 4c3ee228fcdb089eaeead95e79532a9cf6cb0de6)
2003-02-13Removed unused variable.Jeremy Allison1-1/+0
Jeremy. (This used to be commit c9654c8ec71903c59ff5f66c3fd6ea1baa599133)
2003-02-13Merge JohnR's patch.Jeremy Allison1-3/+1
Removed extra copy of server name in the printername field (it was mangling the the name to be \\server\\\server\printer ... yes, there were 3 backslashes) reported by get & enum jobs level 2. Jeremy. (This used to be commit d079edf7327acba7f00b5868e7e6ce91ddc1eb14)
2003-02-05Fixed type.Jeremy Allison1-1/+1
Jeremy. (This used to be commit ae635bb6ec05ded8a36d7876be8f3e1b8475e35b)
2003-01-17reverted this patch till I sort out the craziness with UNIHDRAndrew Tridgell1-1/+1
(This used to be commit e3d00fa47d38cd214f5e350e1d6b30d90ed8a52c)
2003-01-17This removes the 3rd argument from init_unistr2(). There were 240Andrew Tridgell1-1/+1
calls to init_unistr2() in the code and every one of them got the 3rd argument incorrect, so I thought it best just to remove the argument. The incorrect usage was caused by callers using strlen() to determine the length of the string. The 3rd argument to init_unistr2() was supposed to be the character length, not the byte length of the string, so for non-english this could come out wrong. I also removed the bogus 'always allocate at least 256 bytes' hack. There may be some code that relies on this, but if there is then the code is broken and needs fixing. (This used to be commit b9eff31b1433c81fbff733e194914a40f25e3bda)
2003-01-14The last of the fstring/pstring mixups, and an extra 'static'.Andrew Bartlett1-2/+2
(This used to be commit b328b67fd8fd605636ed58ffd33cf5be3d480672)
2003-01-11typo from mergeGerald Carter1-1/+1
(This used to be commit 1f33b4acb32c5461b9249d3786ea5fc6898e5f18)
2003-01-11[merge] make sure to updatre print queue cache during timeout_processing() ↵Gerald Carter1-11/+42
to send notify events; CR 1491 (This used to be commit 142c5029c701e7a82074e301278846c02843f46f)
2003-01-09a 0 length printer data value is not a memory allocation error; fix CR601Gerald Carter1-2/+10
(This used to be commit 3442c270f1bc67890f4e2de3386fcfdec610170d)
2003-01-02BIG patch...Andrew Bartlett1-15/+15
This patch makes Samba compile cleanly with -Wwrite-strings. - That is, all string literals are marked as 'const'. These strings are always read only, this just marks them as such for passing to other functions. What is most supprising is that I didn't need to change more than a few lines of code (all in 'net', which got a small cleanup of net.h and extern variables). The rest is just adding a lot of 'const'. As far as I can tell, I have not added any new warnings - apart from making all of tdbutil.c's function const (so they warn for adding that const string to struct). Andrew Bartlett (This used to be commit 92a777d0eaa4fb3a1c7835816f93c6bdd456816d)
2002-12-20Forward port the change to talloc_init() to make all talloc contextsJeremy Allison1-1/+1
named. Ensure we can query them. Jeremy. (This used to be commit 842e08e52a665ae678eea239759bb2de1a0d7b33)
2002-12-17* fix memory leak when constructing an driver_level_6 structureGerald Carter1-1/+7
and no dependent files (working on smbd memory leak). No CR# yet. (This used to be commit f017fa7c478f87165b7b6aa83059fe6fad29ac15)
2002-12-13Store printer guid in the dsspooler registry key so we don't have toJim McDonough1-34/+9
query the directory server every time someone asks (This used to be commit f0fc4e30f6284565de404a20450a587cd3fe00a5)
2002-12-13More printer publishing code.Jim McDonough1-5/+41
- Add published attribute to info2, needed for win clients to work properly - Return proper info on getprinter 7 This means you can now look at the sharing tab of a printer and get correct info about whether it is published or not, and change it. (This used to be commit adda04379ee46f105436262663652f3f576fa3cf)
2002-12-04Automatic printer publishing when using APW or choosing 'list in the ↵Jim McDonough1-18/+119
directory' in printer settings. Currently very little is published, and you cannot unpublish because of a bug in win2k clients. (This used to be commit bbd7c8071a095c4e410f92489050b677a0f0ace1)
2002-12-04[merge from app_head]Gerald Carter1-2/+15
XP sends GetPrinterData("ChangeId"). So we now respond accordingly. Possible fix for CR 1147. (This used to be commit 42a2e7d701fd342f2553660eb5094af8723fb50e)
2002-11-18formatting fixGerald Carter1-35/+35
(This used to be commit 6ce20a61a85f129d42c06844d51f4b2b35b41869)
2002-11-12Removed global_myworkgroup, global_myname, global_myscope. Added liberalJeremy Allison1-3/+1
dashes of const. This is a rather large check-in, some things may break. It does compile though :-). Jeremy. (This used to be commit 82b8f749a36b42e22186297482aad2abb04fab8a)
2002-11-11fix for CR 601. Only call addprinter command when the port, driver, ↵Gerald Carter1-2/+8
comment, or location field changed (This used to be commit c6d45216f6d3573fb2342f4d3aa3a50415924674)
2002-11-10First cut of fix for changenotify on a print server handle. Use the ↵Jeremy Allison1-11/+29
connections tdb with an snum of -1 and a special printername. Jeremy. (This used to be commit 940b04ddfa87acc939911e3fe76496e3c4675632)
2002-11-09deldriver fixGerald Carter1-0/+6
(This used to be commit f20de1f9b0dcac15fbf968e6d5d5af2fdd5fbda1)
2002-11-09re-enable ffpcn on print server handleGerald Carter1-1/+1
(This used to be commit e87829b4942237de542d21051092fee069a9c73d)
2002-11-07Merge of scalable printing code fix... Needs testing.Jeremy Allison1-7/+31
Also tidied up some of Richard's code (I don't think he uses the compiler flags -g -Wall -Wshadow -Wstrict-prototypes -Wpointer-arith -Wcast-qual like I do :-) :-). Jeremy. (This used to be commit 10024ed06e9d91f24fdc78d59eef2f76bf395438)
2002-10-25PURGE_PRINTER fix from APP_HEADGerald Carter1-2/+0
(This used to be commit 8af12875b0608b83187e4156843e37097de4cd13)
2002-10-16fix from APP_HEAD to commit a re-init'd printer to diskGerald Carter1-0/+6
(This used to be commit 64a159144483457887df2c6d779e6a139dfc6d1f)
2002-10-15merge from app_head to use GMT in job submission notificationGerald Carter1-1/+1
(This used to be commit b130c681d2e8e6dcabe8cfd85dd718a294b04233)
2002-10-09print job properties fix from APP_HEAD. a null devmode is not a failure.Gerald Carter1-11/+5
(This used to be commit b507dba452ecbd96ec95242f761501d0c5e0d7b5)