Age | Commit message (Collapse) | Author | Files | Lines |
|
spooler. :-(
When installing the Adobe PS driver onto a Samba printer via cupsaddsmb,
I noticed a WIN2k client sending DeletePrinterData("DependentFiles")
pver and over. I also noticed that we never checked to see if the
value was valid. No now we do and return WERR_BADFILE which I think
is correct.
Next, I noticed that we never wrote the updated printer out to disk
after a succesfully DeletePrinterData[Ex]().
Finally, I found a driver (Canon BJC 1000 using the Adobe PS drivers
and foomatic PPD file) that was destroying the device name string
in the devmode. So now get_a_printer_2() always writes out the
device name in \\server\share form.
I think these changes might fix bug 294.
(This used to be commit deb25780874b66e68ac597db24fbc50e7f7458b5)
|
|
(This used to be commit d09dc91c024d718a8ddb6b7f08c7fe84716beda4)
|
|
(This used to be commit a6a39c61e8228c8b3b7552ab3c61ec3a6a639143)
|
|
Jeremy.
(This used to be commit 68590b9e2266cf76b46a68cca0acaa47733811fe)
|
|
(This used to be commit 948b1b138cf1fce18c93645fbdf948e589b19dc5)
|
|
time. )-:
(This used to be commit 59dae1da66a5eb7e128263bd578f167d8746e9f0)
|
|
(This used to be commit ba4d334b822248d8ab929c9568533431603d967e)
|
|
a pointer to a uint32 value is incorrect on a 64-bit architecture.
(This used to be commit afed2cbbcc07de9e453156972250f5f9d22e8e83)
|
|
Needs to be rewritten to use a reference counter, but this
will work for now.
also the memory allocation in the printing code needs to be cleaned
up to use talloc exclusively.
(This used to be commit 3d293027563b36411b7f84ed9d8f47f926271c6f)
|
|
strupper_m/strlower_m.
I really want people to think about when they're using multibyte strings.
Jeremy.
(This used to be commit ff222716a08af65d26ad842ce4c2841cc6540959)
|
|
the "OSVersion" print server data value.
(This used to be commit 02bc7be1ac6b75bf6559ea684bbc89ab3e19402e)
|
|
versions. Fixes bug #154.
(This used to be commit 986eae40f7669d15dc75aed340e628aa7efafddc)
|
|
Jeremy.
(This used to be commit 063a210448d57e08db6d47a584c591f20645c80a)
|
|
Jeremy.
(This used to be commit b754089a2660975c593a6651e5e72b7360a0aba1)
|
|
a pstrcpy/fstrcpy or at most a safe_strcpy().
These have the advantage of being compiler-verifiable.
Get these out of the way, along with a rewrite of 'get_short_archi' in the
spoolss client and server. (This pushes around const string pointers, rather
than copied strings).
Andrew Bartlett
(This used to be commit 32fb801ddc035e8971e9911ed4b6e51892e9d1cc)
|
|
Whitespace syncup.
(This used to be commit c69237edf2bfdb426447d808fbd1dc6eb5cffabe)
|
|
(This used to be commit 21166e87bfeeaa5079dfbcac3df9232d73986532)
|
|
* fix bug found by clobber_region()
(This used to be commit b2e29c7bd45f8f33d9ed58fe75bbf5ffc78350f5)
|
|
Use the client address from the pipe->conn->client_address
instead of trying to resolve the name in the _spoolss_rffpcn()
request. Should make us more robust as well when the clients
are not registered in DNS or WINS.
(This used to be commit 23f0fcf6421b1e8dd6ed6ab14af14ea7eb380c1c)
|
|
Added jobid debug when unpacking message.
Jeremy.
(This used to be commit 8a6f3313e69c6d47e20838f42ebc9f8a2ce9ddc4)
|
|
open_printer when 2k client opens with admin privs & fix reply for ChangeId printer data reply
(This used to be commit 12eb3e993788eb8bc0e9eb62e60a8b55079df5ad)
|
|
(This used to be commit 51d330dcf3bd74367fc18f4229a9cfa0392f0b36)
|
|
Jeremy.
(This used to be commit e5e83544dc0acf812bfa5ea17960b5a6be954ca1)
|
|
CR2102; reviewed by jra
(This used to be commit 50c25e54ff05bfb01a93e84afd2ad92e90d5a5c2)
|
|
printer open; CR 2102 (reviewed by jreilly)
(This used to be commit 26478158bc03fdf019589ce68062100a39149b52)
|
|
(This used to be commit 6cd74dea086aa6e0936719f6e2829494c4688ea6)
|
|
Apply the job returned limit across all requests for job queues.
Jeremy.
(This used to be commit bf795b684e608f82db822e0759e7b69afd451b65)
|
|
without ADS support)
* add "MinorVersion" print server data key and comment on "OSVersion"
(This used to be commit e1383368169faa50b9e612c9f71f92f790698b48)
|
|
that changed that the client is monitoring.
* couple of comments abnout how we need to validate driver names
on SetPrinter() and AddPrinter()
* up the debug level on some overly verbose dev mode parsing messages
(This used to be commit e8939165b77c9e2ea8b3cef2e85885b9812c7184)
|
|
Yes I will add the docs....
Jeremy.
(This used to be commit e1b0001c8df9e9823b42a372ca675188570b252a)
|
|
* distinguish WinXP from Win2k
* add a 1/3 of a second delay in OpenPrinter
in order to trigger a LAN/WAN optimization in
2k clients.
(This used to be commit c7712fa054d21b4884a78b7ea6c0fb8b3d637c6b)
|
|
cache the printer_info_2 with the open printer handle.
cache is invalidated on a mod_a_printer() call **on that smbd**.
Yes, this means that the window for admins to step on each other
from different clients just got larger, but since handles a generally
short lived this is probably ok.
(This used to be commit 31272d3b6bb9ec62fd666301c7adfa0c1720a99b)
|
|
- user_ok() and user_in_group() now take a list of groups, instead of
looking for the user in the members of all groups.
- The 'server_info' returned from the authentication is now kept around
- in future we won't copy the sesion key, username etc, we will just
referece them directly.
- rhosts upgraded to use the SAM if possible, otherwise fake up based on
getpwnam().
- auth_util code to deal with groups upgraded to deal with non-winbind domain
members again.
Andrew Bartlett
(This used to be commit 74b5436c75114170ce7c780c19226103d0df9060)
|
|
(This used to be commit de6a2d154e0e863a7628f18cca8fdcaa49d9c0ff)
|
|
* performance optimization in enumprinterdataex() when keyname is empty
* fix a few typos in comments
* reload services after addprinter_command()
dump registry data in ascii when the key is REG_SZ or REG_MULTI_SZ
(This used to be commit 3fc90ea1d9b11186f26484516a4dd8502b6d7323)
|
|
(This used to be commit 9efaef4a96a14bd1ffabf12326ff6f6903f663b2)
|
|
* never save a pointer to an automatic variable (they go away)
implement a deep copy for SPOOLSS_NOTIFY_MSG to correct
messages being sent that have junk for strings;
fix in response to changes for CR 1504
(This used to be commit ffda9e2480414c7ed6156958f516e0d1f3c61350)
|
|
Needed to move to disk based i/o later.
Jeremy.
(This used to be commit a823fee5b41a5b6cd4ef05aa1f85f7725bd272a5)
|
|
Jeremy.
(This used to be commit a29f1aa85f23fa82795a06ad81b26895b025954b)
|
|
Removed extra copy of server name in the printername field (it was
mangling the the name to be \\server\\\server\printer ... yes, there
were 3 backslashes) reported by get & enum jobs level 2.
Jeremy.
(This used to be commit 2d63f3a13d2cea794eb413023b83c4a1071eaea0)
|
|
Jeremy.
(This used to be commit 76c3ccf6ed258b43d7cf1222524d8e5d2bdc8c82)
|
|
- fstring/pstring mixups
- the detection code that found them (disabled)
- a bit of whitespace
- a static
Andrew Bartlett
(This used to be commit 9b70fa868e7d9481f584c83fc4046174e1dedfd9)
|
|
send notify events; CR 1491
(This used to be commit f8a915b14d63e4fdb99235053eeb896ef9492068)
|
|
(This used to be commit 47c1709425e0c8c1e57d95dd4441b1424a5b914c)
|
|
warnings. (Adds a lot of const).
Andrew Bartlett
(This used to be commit 3a7458f9472432ef12c43008414925fd1ce8ea0c)
|
|
named. Ensure we can query them.
Jeremy.
(This used to be commit 09a218a9f6fb0bd922940467bf8500eb4f1bcf84)
|
|
(This used to be commit 7a4a2cb8e86ae8ed0bd877f0cfa324e23b96593a)
|
|
and no dependent files (working on smbd memory leak). No CR# yet.
(This used to be commit 416fd947da4463f5d4dc336dfddf5ce35f50fae9)
|
|
query the directory server every time someone asks
(This used to be commit dd81003bddc17522041e1cd2f0484e1760493e4a)
|
|
- Add published attribute to info2, needed for win clients to work properly
- Return proper info on getprinter 7
This means you can now look at the sharing tab of a printer and get correct
info about whether it is published or not, and change it.
(This used to be commit d57bddc9b22e809c79294c7eacbd5d0f115fe990)
|