summaryrefslogtreecommitdiff
path: root/source3/rpc_server/srv_spoolss_nt.c
AgeCommit message (Collapse)AuthorFilesLines
2003-02-17This patch fixes one of my longest-standing pet hates with Samba :-).Andrew Bartlett1-2/+2
When we look see if a user is in a list, and we try to 'expand' an @group, we should lookup the user's own list of groups, rather than looking for all the members of a group. I'm sure this will fix some nasty performance issues, particularly on large domains etc. In particular, this avoids contacting winbind at all, if the group is not a winbind group. (This caused a deadlock on my winbind-on-PDC setup). The groups list always includes the user's primary group, as per the getgrouplist manpage, and my recent changes to our implementation. Andrew Bartlett (This used to be commit 9be21976f7662ebe6eb92fff7cecbdb352eca334)
2003-02-15* set PRINTER_ATTRIBUTE_RAW_ONLY; CR 1736Gerald Carter1-1/+1
* never save a pointer to an automatic variable (they go away) implement a deep copy for SPOOLSS_NOTIFY_MSG to correct messages being sent that have junk for strings; fix in response to changes for CR 1504 (This used to be commit 043b9dff22e909fc290c34d879cad8b4c980fc13)
2003-02-14Ensure that only parse_prs.c access internal members of the prs_struct.Jeremy Allison1-3/+2
Needed to move to disk based i/o later. Jeremy. (This used to be commit 4c3ee228fcdb089eaeead95e79532a9cf6cb0de6)
2003-02-13Removed unused variable.Jeremy Allison1-1/+0
Jeremy. (This used to be commit c9654c8ec71903c59ff5f66c3fd6ea1baa599133)
2003-02-13Merge JohnR's patch.Jeremy Allison1-3/+1
Removed extra copy of server name in the printername field (it was mangling the the name to be \\server\\\server\printer ... yes, there were 3 backslashes) reported by get & enum jobs level 2. Jeremy. (This used to be commit d079edf7327acba7f00b5868e7e6ce91ddc1eb14)
2003-02-05Fixed type.Jeremy Allison1-1/+1
Jeremy. (This used to be commit ae635bb6ec05ded8a36d7876be8f3e1b8475e35b)
2003-01-17reverted this patch till I sort out the craziness with UNIHDRAndrew Tridgell1-1/+1
(This used to be commit e3d00fa47d38cd214f5e350e1d6b30d90ed8a52c)
2003-01-17This removes the 3rd argument from init_unistr2(). There were 240Andrew Tridgell1-1/+1
calls to init_unistr2() in the code and every one of them got the 3rd argument incorrect, so I thought it best just to remove the argument. The incorrect usage was caused by callers using strlen() to determine the length of the string. The 3rd argument to init_unistr2() was supposed to be the character length, not the byte length of the string, so for non-english this could come out wrong. I also removed the bogus 'always allocate at least 256 bytes' hack. There may be some code that relies on this, but if there is then the code is broken and needs fixing. (This used to be commit b9eff31b1433c81fbff733e194914a40f25e3bda)
2003-01-14The last of the fstring/pstring mixups, and an extra 'static'.Andrew Bartlett1-2/+2
(This used to be commit b328b67fd8fd605636ed58ffd33cf5be3d480672)
2003-01-11typo from mergeGerald Carter1-1/+1
(This used to be commit 1f33b4acb32c5461b9249d3786ea5fc6898e5f18)
2003-01-11[merge] make sure to updatre print queue cache during timeout_processing() ↵Gerald Carter1-11/+42
to send notify events; CR 1491 (This used to be commit 142c5029c701e7a82074e301278846c02843f46f)
2003-01-09a 0 length printer data value is not a memory allocation error; fix CR601Gerald Carter1-2/+10
(This used to be commit 3442c270f1bc67890f4e2de3386fcfdec610170d)
2003-01-02BIG patch...Andrew Bartlett1-15/+15
This patch makes Samba compile cleanly with -Wwrite-strings. - That is, all string literals are marked as 'const'. These strings are always read only, this just marks them as such for passing to other functions. What is most supprising is that I didn't need to change more than a few lines of code (all in 'net', which got a small cleanup of net.h and extern variables). The rest is just adding a lot of 'const'. As far as I can tell, I have not added any new warnings - apart from making all of tdbutil.c's function const (so they warn for adding that const string to struct). Andrew Bartlett (This used to be commit 92a777d0eaa4fb3a1c7835816f93c6bdd456816d)
2002-12-20Forward port the change to talloc_init() to make all talloc contextsJeremy Allison1-1/+1
named. Ensure we can query them. Jeremy. (This used to be commit 842e08e52a665ae678eea239759bb2de1a0d7b33)
2002-12-17* fix memory leak when constructing an driver_level_6 structureGerald Carter1-1/+7
and no dependent files (working on smbd memory leak). No CR# yet. (This used to be commit f017fa7c478f87165b7b6aa83059fe6fad29ac15)
2002-12-13Store printer guid in the dsspooler registry key so we don't have toJim McDonough1-34/+9
query the directory server every time someone asks (This used to be commit f0fc4e30f6284565de404a20450a587cd3fe00a5)
2002-12-13More printer publishing code.Jim McDonough1-5/+41
- Add published attribute to info2, needed for win clients to work properly - Return proper info on getprinter 7 This means you can now look at the sharing tab of a printer and get correct info about whether it is published or not, and change it. (This used to be commit adda04379ee46f105436262663652f3f576fa3cf)
2002-12-04Automatic printer publishing when using APW or choosing 'list in the ↵Jim McDonough1-18/+119
directory' in printer settings. Currently very little is published, and you cannot unpublish because of a bug in win2k clients. (This used to be commit bbd7c8071a095c4e410f92489050b677a0f0ace1)
2002-12-04[merge from app_head]Gerald Carter1-2/+15
XP sends GetPrinterData("ChangeId"). So we now respond accordingly. Possible fix for CR 1147. (This used to be commit 42a2e7d701fd342f2553660eb5094af8723fb50e)
2002-11-18formatting fixGerald Carter1-35/+35
(This used to be commit 6ce20a61a85f129d42c06844d51f4b2b35b41869)
2002-11-12Removed global_myworkgroup, global_myname, global_myscope. Added liberalJeremy Allison1-3/+1
dashes of const. This is a rather large check-in, some things may break. It does compile though :-). Jeremy. (This used to be commit 82b8f749a36b42e22186297482aad2abb04fab8a)
2002-11-11fix for CR 601. Only call addprinter command when the port, driver, ↵Gerald Carter1-2/+8
comment, or location field changed (This used to be commit c6d45216f6d3573fb2342f4d3aa3a50415924674)
2002-11-10First cut of fix for changenotify on a print server handle. Use the ↵Jeremy Allison1-11/+29
connections tdb with an snum of -1 and a special printername. Jeremy. (This used to be commit 940b04ddfa87acc939911e3fe76496e3c4675632)
2002-11-09deldriver fixGerald Carter1-0/+6
(This used to be commit f20de1f9b0dcac15fbf968e6d5d5af2fdd5fbda1)
2002-11-09re-enable ffpcn on print server handleGerald Carter1-1/+1
(This used to be commit e87829b4942237de542d21051092fee069a9c73d)
2002-11-07Merge of scalable printing code fix... Needs testing.Jeremy Allison1-7/+31
Also tidied up some of Richard's code (I don't think he uses the compiler flags -g -Wall -Wshadow -Wstrict-prototypes -Wpointer-arith -Wcast-qual like I do :-) :-). Jeremy. (This used to be commit 10024ed06e9d91f24fdc78d59eef2f76bf395438)
2002-10-25PURGE_PRINTER fix from APP_HEADGerald Carter1-2/+0
(This used to be commit 8af12875b0608b83187e4156843e37097de4cd13)
2002-10-16fix from APP_HEAD to commit a re-init'd printer to diskGerald Carter1-0/+6
(This used to be commit 64a159144483457887df2c6d779e6a139dfc6d1f)
2002-10-15merge from app_head to use GMT in job submission notificationGerald Carter1-1/+1
(This used to be commit b130c681d2e8e6dcabe8cfd85dd718a294b04233)
2002-10-09print job properties fix from APP_HEAD. a null devmode is not a failure.Gerald Carter1-11/+5
(This used to be commit b507dba452ecbd96ec95242f761501d0c5e0d7b5)
2002-10-09add_printer_hook() fix from APP_HEADGerald Carter1-6/+17
(This used to be commit 94201672a5c3cffd145e9f04a3ddd0d17a57e73b)
2002-10-08merge from APP_HEADGerald Carter1-7/+1
* s/driverlocation/comment * detect native mode domain and enumerate local groups Also * Added sendfile stats from SAMBA_2_2 (This used to be commit 764b58e2c0b3179cffe157c0ab58761b156b8423)
2002-10-04merge of new client side support the Win2k LSARPC UUID in rpcbindGerald Carter1-1/+1
from APP_HEAD (This used to be commit 38c9e4299845fd77cc8629945ce2d259489f7437)
2002-10-02Missing break meant getprintprocessordirectory always returned UNKNOWN_LEVEL.Jeremy Allison1-0/+1
Jeremy. (This used to be commit 1b283b649f68890b0aa450aa1ac90f1e8031a6fd)
2002-09-27It turns out that Windows allows delete printer on a handleJeremy Allison1-0/+14
opened by an admin user, then used on a pipe handle created by an anonymous user..... but they're working on security.... riiight ! Jeremy. (This used to be commit 322d8b4c83439261cfd2ff79b557bddb1e784660)
2002-09-27Check for security on delete printer was reversed...Jeremy Allison1-5/+5
Jeremy. (This used to be commit 0d27cc909b4489b54e57481bd8a9494fb077dc3d)
2002-09-25merge from APP_HEADGerald Carter1-0/+2
(This used to be commit 930c6710fe076b52ad21addf5fcda834f85e15a9)
2002-09-18printjob merge from APP_HEAD regarding device modesGerald Carter1-63/+93
(This used to be commit aa52351384abace54a89c9fbfa5e4c31a8464c91)
2002-09-11merge from APP_HEAD for GetJob()Gerald Carter1-15/+23
(This used to be commit 3524a4a348686ae5144a744696606123e4a66622)
2002-09-11DelPrinterDrvEx() fix from APP_HEADGerald Carter1-10/+12
(This used to be commit 7841753a03f7fdbd2f7f22e1b184dc1891118283)
2002-09-11Merge the cli_shutdown change from 2_2. All except one call toVolker Lendecke1-0/+1
attempt_netbios_... assumed that cli_shutdown was _not_ called on error anyway... Volker (This used to be commit f0c741594f0dad2da16b1d5692dd56a48b4157f1)
2002-09-10removed warning about shadowed globalsGerald Carter1-5/+5
(This used to be commit 8021bbbd0c5fad6db45a4c862848ea667cad0b79)
2002-09-10AbortPrinter() fix merged from APP_HEAD.Gerald Carter1-3/+21
(This used to be commit 97ede49e1271fa00c6ffdf9e6e3c2330ea935461)
2002-09-10change notify merge from APP_HEADGerald Carter1-75/+265
(This used to be commit b5227f0a645fdf2358fcb880f22e4662efdfe8e3)
2002-09-09Actually, I think Jerrys patch was incorrect as it didn't everJeremy Allison1-40/+8
add the printing msg flag, only remove it. Also, we already refcount the printer backchannel connection to add the connection tdb flag just before after we register/deregister the notification message handler. Jerry please check ! Jeremy. (This used to be commit c45364ae82e06364cbb11545d1262032e12a21b1)
2002-09-07merge of printer change notify fix from APP_HEADGerald Carter1-8/+40
(This used to be commit 6a53a9cb7c56927423dea125c65d66605fae566f)
2002-09-05Revert the "reverse" change to rpc_server/srv_spoolss_nt.c, simplyJeremy Allison1-30/+3
add then entries to the end of the list in printing/notify.c using DLIST_ADD_END. Jeremy. (This used to be commit 047d6a05fb60172a2607bb7d7d03dda5403c61fa)
2002-09-05Delivery notify messages over the back channel in *reverse* order inTim Potter1-3/+30
which they are sent in the message. This is because a DLIST_ADD is used by the message sender which results in the first (post!) message being at the end of the list. Notify messages must be delivered in the order the events occur in otherwise the port monitor gets confused. (This used to be commit d41ff1f1a6cfad71ef35698d45e9fb97d9100898)
2002-09-05Roussed on Jeremy for not putting in enough debugs in the new printTim Potter1-0/+2
notify stuff. (-: (This used to be commit 87c156704f5d8913cf7bf3134ec5ba6403d36cca)
2002-09-04Added better error code on out of space. Removed total jobs check - notJeremy Allison1-0/+7
applicable any more. Jeremy. (This used to be commit 8828e2ea3c668aab6cda1b4be9a7e4ce1c23ca81)
generated by cgit (git 2.34.1) at 2024-09-07 19:25:03 +0000