summaryrefslogtreecommitdiff
path: root/source3/rpc_server/srv_winreg_nt.c
AgeCommit message (Collapse)AuthorFilesLines
2008-07-22Fix warnings on FreeBSD-based platformsZach Loafman1-4/+4
Fix two shadowed declaration warnings on FreeBSD-based platform: 'reboot' is a 4.0BSD syscall in unistd.h and 'tcp_seq' is a typedef in netinet/tcp.h. (This used to be commit 14d2a4da1da38d6f69c63505d35990322f253e5d)
2008-06-13Fix a crash in _winreg_QueryValueVolker Lendecke1-0/+4
Coverity ID 474, value_length and type are both unique, not ref pointers and can thus be NULL. Karolin, please merge this to -stable. Thanks, Volker (cherry picked from commit 999533c0ccced59141d8baff5bc248d63e2a966f) (This used to be commit 7e07ec68f15908a998f83d615a1b4d1349935a54)
2008-03-28srv_winreg: add a debug message to _winreg_CreateKey().Michael Adam1-0/+3
Michael (This used to be commit 971f6749ed23523f6eafe5136f6d4c920c20aec4)
2008-03-25Fix _winreg_QueryValue().Günther Deschner1-7/+7
Guenther (This used to be commit b217dd674e22b6a7cc492f1a84a37ddc4ddca663)
2008-03-17Coverity fixesMarc VanHeyningen1-2/+4
(This used to be commit 3fc85d22590550f0539215d020e4411bf5b14363)
2008-03-05Fix Coverity ID 565Volker Lendecke1-2/+0
This would crash safely (This used to be commit 0f14357c86aee9a76ffbb45ea6419f4cc4106d62)
2008-02-18Fix a comment. REGISTRY_KEY has vanished from srv_winreg_nt.cMichael Adam1-1/+1
(It is reg_api time) Michael (This used to be commit d94998e46ba0faac3fa625e8292d452ad52b8e55)
2008-02-15Move the implementation of _winreg_RestoreKey to reg_api.cMichael Adam1-121/+1
This removes the internals of reg_api from srv_winreg_nt.c entirely, only reg_api is used there, now. This enlarges the dependencies of reg_api somewhat now since it adds regfio. But this can be separated out later. The current goal is to achieve a complete use of reg_api. Michael (This used to be commit 2222acbac955cd6d5bd48d1ce5cf4b4c7c067093)
2008-02-15Move implementation of _winreg_SaveKey() from srv_winreg_nt.c to reg_api.cMichael Adam1-170/+1
This gives a new function reg_savekey() and hides a piece of the backend code from srv_winreg_nt.c. One step towards using reg_api throughout samba code. Michael (This used to be commit bf6340d00dd631fdc909c20632250977a3a112c4)
2008-01-17Add a reg_getversion() function to reg_api and use it in srv_winreg_nt.c.Michael Adam1-3/+1
Michael (This used to be commit 903223b160eef6ba6ff19a8bfef19e5fe7008631)
2008-01-17Use reg_[gs]etkeysecurity() instead of regkey_[gs]et_secdes().Michael Adam1-2/+2
Rationale: Use reg_api instead of backend functions. Michael (This used to be commit f986a708be15dd9b9fc28b9862f64f2d0f94accc)
2007-12-21Some C++ fixesVolker Lendecke1-1/+3
(This used to be commit 5c392c4c6e277a24d0d477902dc7856b2b46ee53)
2007-12-21Some C++ warningsVolker Lendecke1-1/+1
(This used to be commit 5ab82d4f574f2a2e2761e9e414c66a70aeffb05d)
2007-11-27Fixed obvious typo.Jeremy Allison1-1/+1
Jeremy. (This used to be commit 9755c5311416f17bac0a848d027cafb3fd487618)
2007-11-27Remove pstring from everything in rpc_server exceptJeremy Allison1-109/+147
srv_spoolss_nt.c and srv_srvsvc_nt.c. They're next :-). Jeremy. (This used to be commit 55b4f9d003b036af69085f7b64e0df08c5ba440d)
2007-11-15More pstring removal. This one was tricky. I had to addJeremy Allison1-13/+14
one horror (pstring_clean_name()) which will have to remain until I've removed all pstrings from the client code. Jeremy. (This used to be commit 1ea3ac80146b83c2522b69e7747c823366a2b47d)
2007-10-18RIP BOOL. Convert BOOL -> bool. I found a few interestingJeremy Allison1-5/+5
bugs in various places whilst doing this (places that assumed BOOL == int). I also need to fix the Samba4 pidl generation (next checkin). Jeremy. (This used to be commit f35a266b3cbb3e5fa6a86be60f34fe340a3ca71f)
2007-10-10r25534: Apply some constVolker Lendecke1-1/+1
Why? It moves these structs from the data into the text segment, so they will never been copy-on-write copied. Not much, but as in German you say "Kleinvieh macht auch Mist...." (This used to be commit 0141e64ad4972232de867137064d0dae62da22ee)
2007-10-10r23801: The FSF has moved around a lot. This fixes their Mass Ave address.Andrew Tridgell1-2/+1
(This used to be commit 87c91e4362c51819032bfbebbb273c52e203b227)
2007-10-10r23779: Change from v2 or later to v3 or later.Jeremy Allison1-1/+1
Jeremy. (This used to be commit 407e6e695b8366369b7c76af1ff76869b45347b3)
2007-10-10r23633: Fix a couple of crash bugs pointed out by Volker caused by an oldGerald Carter1-1/+6
change from a pstring to a char* and still trying use pstrcpy(). (This used to be commit 21dc46a2bad6fee720f0f591e1051aa7675c77c8)
2007-10-10r23434: Coorect a comment.Michael Adam1-1/+1
(This used to be commit c9f38fa30e9b784a56f08d0ab4765e9c7a42aa7d)
2007-10-10r23433: remove superfluous semicolon.Michael Adam1-1/+1
(This used to be commit b8269f454338c8b20b90451f3866fc193871e9af)
2007-10-10r23432: Remove superfluous comment.Michael Adam1-2/+0
(A relict from regkey_open_internal days.) Michael (This used to be commit 4025cbc2024acf36e96d7236225b439dbd3e4df0)
2007-10-10r21462: Fix EnumValue (?)Jelmer Vernooij1-2/+2
(This used to be commit e73a418b5b0100936efb4c1133da3cfe3fcb61cd)
2007-10-10r21385: Regenerate IDL after pidl changes, sync winreg.idl from samba4.Jelmer Vernooij1-6/+6
(This used to be commit b84370513fbf790e599c33f177fb271a2a992b72)
2007-10-10r20875: Pass DCE/RPC server call arguments as a struct rather than as ↵Jelmer Vernooij1-175/+149
separate arguments. This makes it a bit more similar to the Samba4 code. (This used to be commit 0596badb410a58e7a715e2b17bc0bef0489a2448)
2007-10-10r20832: Remove extra pointers previously added to unique [out] pointers. ↵Jelmer Vernooij1-1/+1
Instead, add [ref] pointers where necessary (top-level [ref] pointers, by spec, don't appear on the wire). This brings us closer to the DCE/RPC standard again. (This used to be commit 580f2a7197b1bc9db14a643fdd112b40ef37aaef)
2007-10-10r20015: We have to zero out handle on key_close, otherwise the NT4 regedit ↵Volker Lendecke1-0/+2
will re-use the handle (This used to be commit 0afd696f88ed04f562ef64201ac2e58cef372a90)
2007-10-10r20007: Fix a const warning just introducedVolker Lendecke1-1/+1
(This used to be commit 3da37287cadfe251491bcefea4ca9d407048868b)
2007-10-10r19991: Sorry for this 2000-liner...Volker Lendecke1-549/+154
The main thing here is a rewrite of srv_winreg_nt.c. The core functionality has moved to registry/reg_api.c which is then usable by the rest of Samba as well. On that way it fixes creating keys with more than one element in the path. This did not work before. Two things that sneaked in (sorry :-) is the change of some routines from NTSTATUS to WERROR the removed "parent" argument to regkey_open_internal. Volker (This used to be commit fea52801de8c7b85c578d200c599475680c5339f)
2007-10-10r19963: Add 'registry shares = yes' and registry key security descriptors.Volker Lendecke1-3/+35
(This used to be commit 6cab254c49e07b11c170511ec613f0f33914c3e6)
2007-10-10r19947: Change regkey_open_internal to take the parent key and a talloc_ctx asVolker Lendecke1-18/+1
arguments. This also replaces regkey_close_internal by TALLOC_FREE. Volker (This used to be commit a177bbb2d5611f03cec25b7577c2e6a542f94a69)
2007-10-10r19930: Revert the winreg idl changes. At least enumkey does not work ↵Volker Lendecke1-12/+7
anymore today. With more than 5 different trees I can't swear that I did test this properly yesterday. Sorry for the noise. Volker (This used to be commit 978a6196bf0a2280c7f74b4a6d9fa7941c3aa049)
2007-10-10r19929: Fix indentationVolker Lendecke1-1/+1
(This used to be commit 2369ad08529d31bb77b9cb5378d0114669cdf8a8)
2007-10-10r19919: Convert winreg_EnumKey to use ref ** instead of a unique *.Volker Lendecke1-4/+9
Volker (This used to be commit b714b51884af0d79de8568410676d4889f23ffb6)
2007-10-10r19918: Convert winreg_CreateKey to use a ref ** instead of a unique *. W2k3 ↵Volker Lendecke1-3/+3
can still create keys on Samba and vice versa. Jelmer, please check. Thanks, Volker (This used to be commit 1b460d6cdfe0cadd915a5299e6ca9bb359bf0075)
2007-10-10r19915: Fix two type-punned warningsVolker Lendecke1-2/+2
(This used to be commit f1266475daa3687e0b0dc5333a6fbd12a9640c3a)
2007-10-10r19914: The "default" value with the name "" need different 0-length ↵Volker Lendecke1-9/+1
treatment as the other StringBufs, otherwise clicking on a key with this value being set leads to regedit.exe on w2k3 chew all memory. (This used to be commit b148cde7f39859102288a87b6f0bd2b250947a85)
2007-10-10r19912: Move the subkey cache to srv_winreg_nt.cVolker Lendecke1-13/+28
(This used to be commit 01a53590a6325413551016effe302585a3a1e656)
2007-10-10r19872: Move the value cache to srv_winreg_nt.c. Fix some minor issues found ↵Volker Lendecke1-69/+100
while playing with regedit.exe. Volker (This used to be commit 81bd816fa2afe89261aff2f395e8d056b73e515c)
2007-10-10r19867: Introduce struct regkey_info in srv_winreg_nt.c to be able to re-add theVolker Lendecke1-91/+130
QueryValue and later the QueryKey cache independent of the backend. Volker (This used to be commit 0ed3a21fccd9c05f1db40f8e20376a76583a81b6)
2007-10-10r19860: Streamline _winreg_QueryValue a bit. We've been pushing around memoryVolker Lendecke1-105/+86
considerably here. This temporarily removes a cache for the tdb based registry, I'll re-add that in srv_winreg_nt.c in the next step. This fixes creating/renaming values from the windows regedit.exe, as "New Value #1" was not entering the cache after being created. Volker (This used to be commit c8c81f0e86256f769765c142e4f1e4c45cb74296)
2007-10-10r19824: Fix the max value calculation in QueryInfoKeyVolker Lendecke1-9/+10
(This used to be commit cd14b7f05234f540601cd2c5841a52dd047c965d)
2007-10-10r19819: Windows returns an empty string instead of NULL hereVolker Lendecke1-1/+1
(This used to be commit c1083216c83f4236edb78484c6333ff1d1646c40)
2007-10-10r19803: Fix problem reported by Chetan S: QueryInfoKey needs to report the ↵Volker Lendecke1-1/+1
max name length in *bytes* for UTF-16, not the string length. This got lost during the conversion. This took a while to figure out :-) Thanks to Chetan! Volker (This used to be commit 8df6544fa855d2d07b1b69c8d448a1362e41733c)
2007-10-10r19780: Ok, regkey_open_internal needs a regkey_close_internal. Giving a ↵Volker Lendecke1-3/+1
talloc ctx is misleading here. This needs fixing properly :-) Volker (This used to be commit f808182346aa16bb2f3a9383e28d318099a5e14e)
2007-10-10r19778: Make regkey_open_internal take a talloc ctxVolker Lendecke1-1/+3
(This used to be commit cb7f4211b8441642dce9594522dc9588475a7719)
2007-10-10r19689: Fix a NULL dereference found by coverity (the call to strlen).Volker Lendecke1-1/+3
Jerry, please check this. The way I understood alpha_strcpy the last arg needs to be the size of the target, not of the source. Thanks, Volker (This used to be commit 287d68daab89c78748b90849c9782473784b6a84)
2007-10-10r19292: Avoid some potential segfaults: In winreg_EnumValue all pointers are ↵Volker Lendecke1-9/+21
unique pointers and can thus be independently NULL. Thanks, Volker (This used to be commit d48ac0726a931a7200c47a87f771b74826ab9c96)