summaryrefslogtreecommitdiff
path: root/source3/rpc_server
AgeCommit message (Collapse)AuthorFilesLines
2009-02-21s3-spoolss: fix _spoolss_GetPrinterDriverDirectory and ↵Günther Deschner1-2/+2
spoolss_GetPrintProcessorDirectory. Both calls need to return NULL in the error case to avoid ndr encoding problems. (found by smbtorture spoolss test). Guenther
2009-02-21s3-eventlog: fix rpcclient and server stub for eventlog_GetLogInformation.Günther Deschner1-1/+1
Guenther
2009-02-21Remove the static "chal" from ntlmssp.c:get_challenge()Volker Lendecke1-2/+2
2009-02-19s3-spoolss: fix vista fallback in _spoolss_AddPrinterDriverEx.Günther Deschner1-2/+1
Martin Zielinski, if you're reading this, please have a look. Vista nicely takes just a WERR_UNKNOWN_LEVEL here and retries with a level 6 add. Guenther
2009-02-19s3-spoolss: use pidl for _spoolss_AddPrinterDriver{Ex}.Günther Deschner2-128/+218
Guenther
2009-02-19s3-spoolss: use pidl for _spoolss_GetPrintProcessorDirectory.Günther Deschner2-82/+46
Guenther.
2009-02-19s3-spoolss: fix _spoolss_GetPrinterDriverDirectory.Günther Deschner1-1/+6
treat architecture correctly as it is a [unique] pointer, and newer Windows versions sometimes send in an empty string. Guenther
2009-02-19s3-spoolss: _spoolss_OpenPrinterEx needs to wipe out policy handle upon failure.Günther Deschner1-0/+10
Guenther
2009-02-19s3-spoolss: _spoolss_AddPrinterEx needs to wipe out policy handle upon failure.Günther Deschner1-0/+1
Guenther
2009-02-19s3-spoolss: use pidl for _spoolss_GetPrinterDriverDirectory.Günther Deschner2-94/+38
Guenther
2009-02-19s3-spoolss: add support for "AddPort" via _spoolss_XcvData for Vista.Günther Deschner1-9/+68
Guenther
2009-02-18s3-spoolss: use pidl for _spoolss_XcvData.Günther Deschner2-83/+113
Guenther
2009-02-17s3-spoolss: use pidl for _spoolss_ResetPrinter.Günther Deschner2-38/+10
Guenther
2009-02-17Fix an invalid typecastingVolker Lendecke1-1/+7
entry->num_of_strings is a uint16_t. Casting it with (int *)&entry->num_of_strings is wrong, because it gives add_string_to_array the illusion that the object "num" points to is an int, which it is not. In case we are running on a machine where "int" is 32 or 64 bits long, what happens with that cast? "add_string_to_array" interprets the byte field that starts where "num_of_strings" starts as an int. Under very particular circumstances this might work in a limited number of cases: When the byte order of an int is such that the lower order bits of the int are stored first, the subsequent bytes which do not belong to the uint16_t anymore happen to be 0 and the result of the increment still fits into the first 2 bytes of that int, i.e. the result is < 65536. The correct solution to this problem is to use the implicit type conversion that happens when an assignment is done. BTW, this bug is found if you compile with -O3 -Wall, it shows up as a warning: rpc_server/srv_eventlog_lib.c:574: warning: dereferencing type-punned pointer will break strict-aliasing rules Thanks, Volker
2009-02-16Fix bug 5920Yasuma Takeda1-1/+1
The length of the memcpy was calculated wrong, r->out.return_authenticator is a pointer
2009-02-16s3:netlogon: implement _netr_LogonGetCapabilities() with ↵Stefan Metzmacher1-4/+3
NT_STATUS_NOT_IMPLEMENTED This hopefully fixes bug #6100. metze
2009-02-15Attempt to fix bug #6099. According to MicrosoftJeremy Allison1-17/+26
Windows 7 looks at the negotiate_flags returned in this structure *even if the call fails with access denied ! So in order to allow Win7 to connect to a Samba NT style PDC we set the flags before we know if it's an error or not. Jeremy.
2009-02-13s3: Fix uninitialized const char *Tim Prouty1-0/+1
2009-02-14s3-spoolss: remove unused convert_printer_info.Günther Deschner1-31/+0
Guenther
2009-02-14s3-spoolss: use pidl for _spoolss_SetPrinter.Günther Deschner2-60/+31
Guenther
2009-02-14s3-spoolss: use pidl for _spoolss_AddPrinterEx.Günther Deschner2-63/+31
Guenther
2009-02-14s3-spoolss: add printer_info2_to_nt_printer_info2 and convert_printer_info_new.Günther Deschner1-0/+67
Guenther
2009-02-14s3-netlogon: some more appropriate debug messages.Günther Deschner1-13/+31
Guenther
2009-02-13Parameterize in local.h the MAX_RPC_DATA_SIZE, and ensureJeremy Allison2-1/+53
that "offered" read from the rpc packet in spoolss is under that size. Tidyup from analysis from Veracode. Jeremy.
2009-02-13s3-netlogon: implement _netr_ServerAuthenticate3.Günther Deschner1-23/+56
Guenther
2009-02-12s3-spoolss: use pidl for _spoolss_SetPrinterDataEx.Günther Deschner2-55/+23
Guenther
2009-02-12s3-spoolss: use pidl for _spoolss_GetPrinterDataEx.Günther Deschner2-73/+28
Guenther
2009-02-11s3-spoolss: use SPOOLSS_PRINTER_CONTROL flags defined in IDL.Günther Deschner1-4/+4
Guenther
2009-02-11s3-spoolss: Fix uninitialised variable warning.Günther Deschner1-0/+2
Guenther
2009-02-11s3-spoolss: fix rpc_server stub names for opnum 0x42 and 0x43.Günther Deschner1-6/+6
Guenther
2009-02-10s3-spoolss: use rpccli_spoolss_ReplyOpenPrinter.Günther Deschner1-8/+10
Guenther
2009-02-10Add queueing to np_writeVolker Lendecke1-9/+38
2009-02-10Add queueing to np_read_state, simulate message-type named pipes.Volker Lendecke1-25/+100
The problem with msg-type pipes is that we have to return short reads when a message ends before the read request. When reading from the unix domain socket, the message limits are lost. So we would happily return more than a message, which confuses for example the s4 rpc client horribly. I'd expect other np rpc clients also to blow up over this. The real solution is to properly implement a two-byte length field per message on the unix domain socket, but this requires more changes there. And as we right now only serve DCE/RPC over the named pipes, this implements a hack that looks into the fragment headers to figure out hdr.frag_len.
2009-02-10s3-spoolss: use pidl for _spoolss_OpenPrinter.Günther Deschner2-81/+20
Guenther
2009-02-10s3-spoolss: remove old spoolss_OpenPrinterEx.Günther Deschner1-86/+0
Guenther
2009-02-10s3-spoolss: use pidl for _spoolss_OpenPrinterEx.Günther Deschner2-68/+35
Guenther
2009-02-10s3-spoolss: use pidl for _spoolss_SetJob.Günther Deschner2-38/+9
Guenther
2009-02-10s3-spoolss: use pidl for _spoolss_StartDocPrinter.Günther Deschner2-52/+21
Guenther
2009-02-10s3-spoolss: add temporary convert_devicemode_new function.Günther Deschner1-0/+75
Guenther
2009-02-10s3-spoolss: use SPOOLSS_JOB_CONTROL bits defined in IDL.Günther Deschner1-5/+5
Guenther
2009-02-09s3 spoolss: arch needs to be set before it's passed to get_version_id.Tim Prouty1-3/+3
7717ad688099860fa0989ed3582435404fd6d4fa left arch unitialized. Guenther, please check.
2009-02-09s3-spoolss: use pidl for _spoolss_ScheduleJob.Günther Deschner2-35/+6
Guenther
2009-02-09s3-spoolss: use pidl for _spoolss_AddJob.Günther Deschner2-44/+10
Guenther
2009-02-09s3-spoolss: use rpccli_spoolss_ReplyClosePrinter.Günther Deschner1-5/+5
Guenther
2009-02-09s3-spoolss: use pidl for _spoolss_AddPrintProcessor.Günther Deschner2-36/+17
Guenther
2009-02-09s3-spoolss: use PRINTER_ENUM_NAME and remove double enum define.Günther Deschner1-1/+1
Guenther
2009-02-09s3-spoolss: use pidl for _spoolss_FindClosePrinterNotify.Günther Deschner2-37/+9
Guenther
2009-02-09s3-spoolss: remove whitespace in printing code.Günther Deschner1-1/+1
Guenther
2009-02-09Fix count in _srvsvc_NetDiskEnum()Volker Lendecke1-0/+2
Without this, remotely adding a share via MMC fails
2009-02-09s3-spoolss: use pidl for _spoolss_DeletePrinterDriverEx.Günther Deschner2-42/+12
Guenther