summaryrefslogtreecommitdiff
path: root/source3/rpc_server
AgeCommit message (Collapse)AuthorFilesLines
2011-06-20tdb_traverse/tdb_traverse_read: check returns for negative, not -1.Rusty Russell1-1/+1
TDB2 returns a negative error number on failure. This is compatible if we always check for < 0 instead of == -1. Also, there's no tdb_traverse_read in TDB2: we don't try to make traverse reliable any more, so there are no write locks anyway. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2011-06-16s3:rpc_server/svcctl: fix valgrind bug in _svcctl_QueryServiceObjectSecurity()Stefan Metzmacher1-1/+1
r->out.buffer needs to stay in its size, as it will be marshalled completely. As it's preallocated and initialized with zeros, we just need to copy the payload into it, even if it's smaller than the offered buffer size. metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Thu Jun 16 14:15:47 CEST 2011 on sn-devel-104
2011-06-16s3:rpc_server/svcctl: fix valgrind bugs in _svcctl_QueryServiceConfig2W()Stefan Metzmacher1-9/+5
r->out.buffer needs to stay in its size, as it will be marshalled completely. As it's preallocated and initialized with zeros, we just need to copy the payload into it. If we always marshall the return buffer, we already have the needed buffer size and don't need to call ndr_size_* functions. metze
2011-06-16s3:rpc_server/svcctl: don't allocate return values on a temporary stackframeStefan Metzmacher1-5/+3
And always initialize the whole return structure. This caused samba3.posix_s3.rpc.svcctl to be flakey. metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Thu Jun 16 11:34:34 CEST 2011 on sn-devel-104
2011-06-09s3-param Remove special case for global_myname(), rename to lp_netbios_name()Andrew Bartlett7-26/+26
There is no reason this can't be a normal constant string in the loadparm system, now that we have lp_set_cmdline() to handle overrides correctly. Andrew Bartlett
2011-06-09s3-talloc Change TALLOC_MEMDUP() to talloc_memdup()Andrew Bartlett1-1/+1
Using the standard macro makes it easier to move code into common, as TALLOC_MEMDUP isn't standard talloc.
2011-06-09s3-talloc Change TALLOC_ZERO_ARRAY() to talloc_zero_array()Andrew Bartlett3-35/+35
Using the standard macro makes it easier to move code into common, as TALLOC_ZERO_ARRAY isn't standard talloc.
2011-06-09s3-talloc Change TALLOC_ZERO_P() to talloc_zero()Andrew Bartlett9-54/+54
Using the standard macro makes it easier to move code into common, as TALLOC_ZERO_P isn't standard talloc.
2011-06-09s3-talloc Change TALLOC_P() to talloc()Andrew Bartlett2-14/+14
Using the standard macro makes it easier to move code into common, as TALLOC_P isn't standard talloc.
2011-06-09s3-talloc Change TALLOC_ARRAY() to talloc_array()Andrew Bartlett8-27/+27
Using the standard macro makes it easier to move code into common, as TALLOC_ARRAY isn't standard talloc.
2011-06-09s3-talloc Change TALLOC_REALLOC_ARRAY() to talloc_realloc()Andrew Bartlett3-18/+18
Using the standard macro makes it easier to move code into common, as TALLOC_REALLOC_ARRAY isn't standard talloc. Andrew Bartlett
2011-06-08s3-spoolss: fix -Wunused-but-set-variable build warning in ↵Günther Deschner1-0/+4
_spoolss_EnumPrintProcDataTypes(). We were in fact ignoring the error code here. Guenther
2011-06-05s3: Fix a valgrind errorVolker Lendecke1-2/+2
For me this fixes ==1950== Invalid read of size 4 ==1950== at 0x81EBED5: GUID_equal (uuid.c:239) ==1950== by 0x81E51AB: ndr_syntax_id_equal (ndr_misc.c:35) ==1950== by 0x82EB0D1: get_iface_from_syntax (rpc_common.c:160) ==1950== by 0x82EB25E: get_pipe_name_from_syntax (rpc_common.c:179) ==1950== by 0x8509E4F: close_policy_by_pipe (rpc_handles.c:322) ==1950== by 0x8507941: close_internal_rpc_pipe_hnd (rpc_ncacn_np.c:109) ==1950== by 0x468270: _talloc_free_internal (talloc.c:826) ==1950== by 0x467EE0: _talloc_free_internal (talloc.c:1268) ==1950== by 0x467EE0: _talloc_free_internal (talloc.c:1268) ==1950== by 0x467EE0: _talloc_free_internal (talloc.c:1268) ==1950== by 0x467EE0: _talloc_free_internal (talloc.c:1268) ==1950== by 0x80E6487: sam_trusted_domains (winbindd_samr.c:406) ==1950== Address 0x687ea4 is 20 bytes inside a block of size 40 free'd ==1950== at 0x58CDC: free (in /usr/local/lib/valgrind/vgpreload_memcheck-x86-freebsd.so) ==1950== by 0x8507812: free_pipe_rpc_context_internal (rpc_ncacn_np.c:74) ==1950== by 0x8507936: close_internal_rpc_pipe_hnd (rpc_ncacn_np.c:106) ==1950== by 0x468270: _talloc_free_internal (talloc.c:826) ==1950== by 0x467EE0: _talloc_free_internal (talloc.c:1268) ==1950== by 0x467EE0: _talloc_free_internal (talloc.c:1268) ==1950== by 0x467EE0: _talloc_free_internal (talloc.c:1268) ==1950== by 0x467EE0: _talloc_free_internal (talloc.c:1268) ==1950== by 0x80E6487: sam_trusted_domains (winbindd_samr.c:406) ==1950== by 0x80C2F85: trusted_domains (winbindd_cache.c:2820) ==1950== by 0x80D5188: winbindd_dual_list_trusted_domains (winbindd_misc.c:162) ==1950== by 0x80E987F: wb_child_request_trigger (winbindd_dual.c:437) ==1950== Andreas, Guenther, please check! Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Sun Jun 5 13:19:39 CEST 2011 on sn-devel-104
2011-06-01Fix bug where format arguments were reversed. Please compile with -Wall !Jeremy Allison1-2/+2
2011-06-01s3-epmapper: Register ports on IPv4 too.Andreas Schneider2-2/+2
Autobuild-User: Andreas Schneider <asn@cryptomilk.org> Autobuild-Date: Wed Jun 1 13:14:53 CEST 2011 on sn-devel-104
2011-06-01s3-rpc_server: Remove unused variable pipes_open.Andreas Schneider1-4/+2
2011-06-01s3-rpc_server: Remove syntax from pipes_struct.Andreas Schneider2-2/+0
2011-06-01s3-rpc_server: Fixed debug messages of srv_pipe_hnd.Andreas Schneider1-5/+5
2011-06-01s3-rpc_server: Fixed debug messages for rpc_handles.Andreas Schneider1-6/+7
2011-06-01s3-rpc_server: Fix debug messages.Andreas Schneider1-46/+20
2011-06-01s3-rpc_server: Don't segfault if there are not handles to free.Andreas Schneider1-0/+4
2011-06-01s3-rpc_server: Remove guessing of the syntax id.Andreas Schneider5-51/+11
This is only a wild guess. We don't know to which rpc service the client wants to talk until we read the the rpc bind packet.
2011-06-01s3-rpc_server: Use the correct syntax id for debugging.Andreas Schneider1-8/+11
2011-06-01s3-rpc_server: Migrate init_pipe_handles() to new syntax.Andreas Schneider1-8/+21
2011-06-01s3-rpc_server: Use the context syntax id in api_pipe_request().Andreas Schneider1-7/+7
2011-06-01s3-rpc_server: Use the correct syntax id in api_pipe_bind_req().Andreas Schneider1-19/+14
2011-06-01s3-rpc_server: Use the correct context syntax.Andreas Schneider1-2/+20
2011-06-01s3-rpc_server: Move the context functions to own file.Andreas Schneider4-21/+70
2011-06-01s3-rpc_server: Store the ndr syntax id in the pipe context.Andreas Schneider1-5/+6
The client tell us in the rpc bind to which rpc service it wants to connect. We did set the p->syntax earlier by guessing to which pipe name it connects, but we don't know to which rpc service it wants to bind until we read the first packet.
2011-06-01s3: fix more -Wunused-but-set-variable build warnings.Günther Deschner1-2/+1
Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Wed Jun 1 00:29:30 CEST 2011 on sn-devel-104
2011-05-31s3:rpc_server: add _RPC_SERVER_SRV_ACCESS_CHECK_H_ guard to srv_access_check.hMichael Adam1-0/+5
2011-05-31s3:rpc_server: add GPL/Copyright header to rpc_server/srv_access_check.hMichael Adam1-0/+29
2011-05-31libcli/security: move secdesc.c to the top level libcli/securityAndrew Bartlett1-0/+1
This code does not rely on lp_ or other source3 only functions, so can be part of the common library. Andrew Bartlett
2011-05-31s3-smbd provide struct smbd_server_connection * to conn_snum_usedAndrew Bartlett3-2/+6
This provides the 'sconn' parameter to this key functions, that is currently duplicated in dummysmbd.c, which causes duplicate symbol issues in the waf build. This has natrually caused a number of consequential changes across the codebase, includning not passing a messaging context into initial reload_services(): This causes problems because the global smbd_server_connection isn't yet set up, as there isn't a connection here, just the initial process. Andrew Bartlett
2011-05-25Fix numerous missing dependencies in WAF build scriptsSean Finney1-5/+17
With the recent consolidation of code between s3 and s4, a number of new dependencies have been implicitly introduced. For example, previous s3 code gained an implicit dependency on talloc after the charset related consolidation (lib/util/charset/charset.h now includes talloc.h). When building against the embedded version of talloc this isn't a problem since the paths are automatically added to the search path, but when building against the external libraries build failures will occur for all components that don't directly or indirectly include talloc as a dependency. Since charset.h is included from util.h, which in turn is included from includes.h, this means most of the codebase (s3 and s4) has such an undeclared dependency. Therefore, samba-util-common and samba-util have been added as dependencies to the s3 and s4 code respectively, for all cases where the source would otherwise fail to build. Additionally, a few other dependencies are added in specific wscript_build files to address similar dependency-related problems. https://bugzilla.samba.org/show_bug.cgi?id=8128 Signed-off-by: Sean Finney <seanius@seanius.net> Signed-off-by: Matthias Dieter Wallnöfer <mdw@samba.org> Signed-off-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org> Autobuild-Date: Wed May 25 19:22:13 CEST 2011 on sn-devel-104
2011-05-24Fix bug #7054 - X account flag does not work when pwdlastset is 0.Jeremy Allison1-1/+10
Don't allow pass_last_set_time to be set to zero (which means "user must change password on next logon") if user object doesn't allow password change. Don't automatically allow user object password change if "user must change password on next logon" is set. Jim please check. Jeremy.
2011-05-20s3-epmapper: Fixed endpoint registration.Andreas Schneider1-4/+4
Autobuild-User: Andreas Schneider <asn@cryptomilk.org> Autobuild-Date: Fri May 20 12:03:18 CEST 2011 on sn-devel-104
2011-05-18s3-lib Replace StrCaseCmp() with strcasecmp_m()Andrew Bartlett5-52/+52
strcasecmp_m() never needs to call to talloc, and via next_codepoint() still has an ASCII fast-path bypassing iconv() calls. Andrew Bartlett
2011-05-18build: Add depenencies needed by Samba3 subsystemsAndrew Bartlett1-2/+3
2011-05-17s3:rpc_server: create lp_ncalrpc_dir() with 0755 before lp_ncalrpc_dir()/np ↵Stefan Metzmacher1-0/+11
with 0700 metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Tue May 17 13:01:14 CEST 2011 on sn-devel-104
2011-05-17Revert "s3-rpc_server: Force ncalrpc dir to be mode 755."Stefan Metzmacher1-1/+13
This reverts commit a032c9c8fe8aff455407485169b9445860f89606.
2011-05-16s3-rpc_server: Force ncalrpc dir to be mode 755.Andreas Schneider1-13/+1
This completes aae9353ecf56323b63da66aa84d8a0a4f219d94d. directory_create_or_exist() is not needed cause create_pipe_sock() takes care of setting up the directory correctly. Andrew please check! Autobuild-User: Andreas Schneider <asn@cryptomilk.org> Autobuild-Date: Mon May 16 17:54:20 CEST 2011 on sn-devel-104
2011-05-16s3-spoolss: Get the printer location from cups.Andreas Schneider1-2/+33
Signed-off-by: Günther Deschner <gd@samba.org>
2011-05-13rpc_server: Always use rpc_pipe_open_interface()Simo Sorce2-28/+31
This way we can configure which rpc service we actually want to connect to. By default it uses an "embedded" interface and calls rpc_pipe_open_internal() Signed-off-by: Günther Deschner <gd@samba.org> Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Fri May 13 14:40:26 CEST 2011 on sn-devel-104
2011-05-08ncalrpc: Force ncalrpc dir to be mode 755 in all usersAndrew Bartlett1-2/+2
This allows this directory to be shared between Samba3 and Samba4 in a Franky-style setup easily. Andrew Bartlett
2011-05-06s3-libsmb: move protos to libsmb/proto.hGünther Deschner1-0/+1
Guenther
2011-05-06s3-spoolss: remove unused struct in construct_notify_printer_info().Günther Deschner1-2/+1
Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Fri May 6 12:07:17 CEST 2011 on sn-devel-104
2011-05-06s3: only include tdb headers where needed.Günther Deschner2-0/+2
Guenther
2011-05-06More const fixes. Remove CONST_DISCARD.Jeremy Allison4-10/+10
2011-05-05s3-rpc_server: run minimal_includes.pl.Günther Deschner7-8/+0
Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Thu May 5 03:04:38 CEST 2011 on sn-devel-104
generated by cgit (git 2.34.1) at 2024-06-29 23:12:12 +0000