Age | Commit message (Collapse) | Author | Files | Lines |
|
This patch makes Samba compile cleanly with -Wwrite-strings.
- That is, all string literals are marked as 'const'. These strings are
always read only, this just marks them as such for passing to other functions.
What is most supprising is that I didn't need to change more than a few lines of code (all
in 'net', which got a small cleanup of net.h and extern variables). The rest
is just adding a lot of 'const'.
As far as I can tell, I have not added any new warnings - apart from making all
of tdbutil.c's function const (so they warn for adding that const string to
struct).
Andrew Bartlett
(This used to be commit 92a777d0eaa4fb3a1c7835816f93c6bdd456816d)
|
|
(This used to be commit 101727335fffd4011659bfa9f7f8ab24b641fc4e)
|
|
(This used to be commit f20de1f9b0dcac15fbf968e6d5d5af2fdd5fbda1)
|
|
(This used to be commit 6d1d2849a7b2f99d927ba168ed2d01a879b09e69)
|
|
(This used to be commit a22fdf26fef0cd58c84ca13891a762e3fdc6af8b)
|
|
(This used to be commit a2e17d4344f996b64cd9c4f01b6b15c069fde41b)
|
|
from APP_HEAD
(This used to be commit 38c9e4299845fd77cc8629945ce2d259489f7437)
|
|
function. Also fixed crash bug - I don't think anyone uses this
command anymore...
(This used to be commit 82c9bf2a6f03c801e701636aff726090483cea25)
|
|
pointers.
(This used to be commit e9b71b354d923b2cd0f028dd197e7ca81339ec3a)
|
|
(This used to be commit 4e142ba3749d2eb45687425ff87c153fb6147056)
|
|
(This used to be commit e09007dd5d17d5f84aea3c2fed16ce79ba7be1f2)
|
|
server name and everything works as advertised. See the MSDN doco for details.
(This used to be commit d6b10fe9691bfc96d5933c029990c60fd292bdc9)
|
|
(This used to be commit fe43c2ac2d2e1dd3b3a25c807d4dd379c5ac4960)
|
|
Now let's keep this in sync !
Jeremy.
(This used to be commit 3603cd4947df2c10df604447dc542932cb9e5d5a)
|
|
(This used to be commit 79d7bcf42e568b8fe75818c1d2344bff738afd70)
|
|
The semantics of the src_len argument to rpcstr_pull() seem to have changed
breaking most of the spoolss commands in rpcclient. Changed a bunch of
0's to -1's to fix it.
(This used to be commit f32e3f2087c44f27bcfc8a8b1c76ee2b29f01dea)
|
|
This is an intermediate check-in. More to come....
(This used to be commit 5b9b152971aa635d484cde45413a7880424ee22d)
|
|
shouldn't matter for logic...if anyone disagrees whack me over the head and explain why...
(This used to be commit 4081ce40dda886aeb01f590f00bfe50e0e4e8ae4)
|
|
(This used to be commit bb0ef8bc305da7490a19a6f4efd2aa60bf14aef1)
|
|
(This used to be commit d9df00e2b1764619491900b7dbd7d5af34feed1b)
|
|
enumforms.
(This used to be commit e69222f0816878e3211e3dedb049de50ca90fed0)
|
|
I couldn't test some of these because I didn't know the right magic
arguments to pass to rpcclient (familiar anyone? (-:) so there may be some
bugs lurking.
(This used to be commit 029e2b307d91171168040e71d2e5d5e0d01b7633)
|
|
(This used to be commit fccfa034e92bca145b8e0639e405f6af5bb1a50b)
|
|
cli_spoolss_enumprinterdrivers() function.
(This used to be commit ae38fcf62c4b9503d4df02761dadb1bb7d166a9c)
|
|
to actually work was addform. )-:
Removed a whole bunch of calls to werror_to_ntstatus() because there isn't
a one-to-one mapping of NTSTATUS values to WERROR values. This function
maps WERR_ACCESS_DENIED to NTSTATUS_INVALID_LOCK_SEQUENCE or something
silly like that.
(This used to be commit 825b5c8bd6d0f114faf3b0fd91eb374cbfb8c8b7)
|
|
Changed "SMB/Netbios" to "SMB/CIFS" in file header.
(This used to be commit 6a58c9bd06d0d7502a24bf5ce5a2faf0a146edfa)
|
|
(This used to be commit 6b123adda901ff05b0271eeda060297448f64eec)
|
|
(invalid handle) though. )-:
(This used to be commit 7bfd1f35e4e194f8a2f07046e4a6c005c256c05b)
|
|
values returned from cli functions. They are converted to NTSTATUS codes
using the error map functions.
Do buffer size loop checks by setting offered = 0 and using the return
value of needed in the next call.
(This used to be commit 4efbdda3fcfd1fad2f2b8909d250735382497836)
|
|
- converted OpenPrinterEx and ClosePrinter to WERROR instead of NT_STATUS
- doc
(This used to be commit 248d114f856f1adb76c903b683e0927530771443)
|
|
(This used to be commit b70f870cd98e30d0ce74d322391cc79d65c5f838)
|
|
(This used to be commit d1564fbf1f4950c12516470d4566efeca3ad79e5)
|
|
(This used to be commit 6b7e9d03cf6093f1108642deddb0f8cc42e59067)
|
|
- added lsaquerysecobj to rpcclient
- renamed querysecobj to samquerysecobj
- removed duplicated display_sec_acl() code from cmd_spoolss.c and
cmd_samr.c and moved it into display_sec.c
(This used to be commit 59b2e3f408a5ff22f2d81a927d010a7df5f19f7f)
|
|
rpc. This was supposed to fix a printer driver download bug but it didn't
but it seemed a shame to trash all this code so I'm commiting it #ifdef'ed
out in case someone needs it one day.
(This used to be commit bef43656471741c6c10b12e7516c15de9ae76394)
|
|
definitions.
(This used to be commit 9712d3f15a47155f558d0034ef71fd06afb11301)
|
|
(This used to be commit 7c6529c081abe051055be5fbf3016fbea2474752)
|
|
rpcclient code. Refactored cmd_* functions to move common mem_ctx and pipe
opening stuff up one level. Moved rpcclient.h into rpcclient directory and
out of includes/smb.h
(This used to be commit a40facba9651f9fb1dcc9e143f92ca298a324312)
|
|
(This used to be commit 2d0922b0eabfdc0aaf1d0797482fef47ed7fde8e)
|
|
the build farm
(This used to be commit 5bb7e4f0f65edf1db20245f403cbe81833134240)
|
|
- added WERROR for win32 error codes
- added a configure test for immediate structures
still lots to do, so its not enabled by default, but the main
structure is there
(This used to be commit 24f9ab683dec52587ee56717e821b49c0fa3d70f)
|
|
(This used to be commit 1d36250e338ae0ff9fbbf86019809205dd97d05e)
|
|
- ported two rpc back from TNG (WINREG: shutdown and abort shutdown)
- some optimizations and changed some DEBUG statement in loadparm.c
- changed rpcclient a bit moved from non reentrant next_token_nr to next_token
- in cmd_reg.c not sure if getopt will work ok on all platforms only setting optind=0
(This used to be commit fd54412ce9c3504a547e232602d6129e08dd9d4d)
|
|
emphasise the fact that the spoolss pipe returns DOS error codes instead of
32-bit nt status codes.
(This used to be commit 5f5ed41ee872d842e944cd2e84a80de714ad4385)
|
|
According to the incorruptible judges find and grep, the latter won.
Mmm - procrastination. (-:
(This used to be commit 2e339403605177b15d5185a8fdd1b06f3f043168)
|
|
(This used to be commit 37052a1bcc5cd049918c3d5ac4c41c3a669290af)
|
|
This commit gets rid of all our old codepage handling and replaces it with
iconv. All internal strings in Samba are now in "unix" charset, which may
be multi-byte. See internals.doc and my posting to samba-technical for
a more complete explanation.
(This used to be commit debb471267960e56005a741817ebd227ecfc512a)
|
|
(This used to be commit 7e23ed48908cf396610d26efda9f54d5f5f0e83c)
|
|
(This used to be commit 6e0805c191d7434366e4a8d752b6e34656232371)
|
|
(This used to be commit 515caaf7b448e55206433a9ca04fb5078f91cde2)
|