Age | Commit message (Collapse) | Author | Files | Lines |
|
The goal is to move all this variables into a big context structure.
metze
|
|
This is the one where I found the problem that led to 3.2.5. So if there is one
checkin in the last year that I would like others to review and *understand*,
it is this one :-)
Volker
|
|
This converts the range checks for the setup[] array to rely on req->wct being
set correctly in init_smb_request. As that already verifies the vwv array to be
in the range of the smb_request inbuf, we don't have to do overflow checks here
anymore.
Jeremy, please check thoroughly! :-)
Thanks,
Volker
|
|
This fixes a potential crash bug, a client can make us read memory we
should not read. Luckily I got the disp checks right...
Volker
(cherry picked from commit 64a1d80851da5b05e70ec6c96f6e9bd473748369)
(cherry picked from commit f04c5650a3aeca23591ddc781c4b297caaf9bb3f)
|
|
Instead, fix up the outbuf in send_xx_reply. In those routines, we know
what we are returning.
|
|
|
|
|
|
|
|
|
|
Now that "req" is available everywhere, use it. Rename srvstr_pull_buf_talloc()
to srvstr_pull_req()
|
|
|
|
|
|
|
|
|
|
It does not really need the whole smb_request
(This used to be commit d3facf4cbdb2915168e91d64c2d8320f67524df8)
|
|
(This used to be commit 559180f7d30606d1999399d954ceedc798c669a4)
|
|
Karolin, please pull once Volker has reviewed. Thanks.
Jeremy.
(This used to be commit 09852899cadc48abe2f2651ecbceaf881198e648)
|
|
an extra parameter. This cleans up quite a few places
we were passing it around without needing it.
Jeremy.
(This used to be commit 8f36def18e9f980e8db522e1de41e80cfd5f466e)
|
|
with Volker. Mostly making sure we have data on the incoming
packet type, not stored in the smb header.
Jeremy.
(This used to be commit c4e5a505043965eec77b5bb9bc60957e8f3b97c8)
|
|
Jeremy.
(This used to be commit 3f6cc826378729c9157ea68e7cf5c7b584bbb585)
|
|
calls. Make this look like the (working) transs2 handling
(replace inbuf, not write to outbuf - outbuf isn't allocated
yet so you get a null deref).
Jeremy.
(This used to be commit f04e37a630f8e7538d670d34db4ea7fc7c0b50a3)
|
|
bugs in various places whilst doing this (places that assumed
BOOL == int). I also need to fix the Samba4 pidl generation
(next checkin).
Jeremy.
(This used to be commit f35a266b3cbb3e5fa6a86be60f34fe340a3ca71f)
|
|
Jeremy.
(This used to be commit b3f0d39d11fa18b7bfef6cec88efaf4a2be2d6e0)
|
|
No idea what I've been smoking here.
Thanks to Stefan for closely looking
(This used to be commit 708f5af2e8c10d9a0d0027e3c31fa23689e746b8)
|
|
Remove reply_prep/post_legacy from send_trans_replies
(This used to be commit c08366f840ead5aba7199cf0b058587055b4d98e)
|
|
(This used to be commit b01664b43b0bd94bb59dec57480d2be954a7298a)
|
|
(This used to be commit 160f65946af9b3e1609b0efb211edc81514fb36f)
|
|
(This used to be commit 8702450e91943b1097ae3c8979d60b6962a69632)
|
|
(This used to be commit 0bb95639d6b49b18f2a7f1131f54239355097119)
|
|
(This used to be commit e2a96497928ab959e36639fef2d493640bb6e951)
|
|
(This used to be commit a6a2d97facf95c7997f3d12457f2811b3b7bde1b)
|
|
(This used to be commit f0598b3ca0ee04e31855c3e54f3198e6fd968737)
|
|
(This used to be commit b38f9347e81364d224e5ca00609099a74410e99c)
|
|
(This used to be commit 06d0c74b74754c55f4c8ef0899bda08476e7dd4b)
|
|
(This used to be commit 040d6d5db6d929f1612b1b0dc762b7f55c956740)
|
|
(This used to be commit dc27c3c668f86d008c27b8a749f5726287ba54a5)
|
|
(This used to be commit 511f8bc030a9a16c2e793ce5d06577608e101de4)
|
|
(This used to be commit 74ae19cca6dd15b65deffbf464cfd0e485da8611)
|
|
The last checkin was for reply_trans, not reply_transs
(This used to be commit 50a2bfd9e04d51aa5e3ae9d6620a98eeb158b6ea)
|
|
(This used to be commit 39a7809aa4c34bb26178589245c419df44796e22)
|
|
(This used to be commit fc8759e63ccec7f1cfb9f1d0ecd0f19a496e4153)
|
|
Thanks!
Volker
(This used to be commit 17b875ae5bab9473f0f896e63fff4a65588c2fb8)
|
|
(This used to be commit b0132e94fc5fef936aa766fb99a306b3628e9f07)
|
|
Jeremy.
(This used to be commit 407e6e695b8366369b7c76af1ff76869b45347b3)
|
|
checkin will pull this up to srvstr_get_path. At that point we can get more
independent of the inbuf, the base_ptr in pull_string will only be used
to satisfy UCS2 alignment constraints.
(This used to be commit 836782b07bf133e9b2598c4a089f1c810e4c7754)
|
|
to all callers of smb_setlen (via set_message()
calls). This will allow the server to reflect back
the correct encryption context.
Jeremy.
(This used to be commit 2d80a96120a5fe2fe726f00746d36d85044c4bdb)
|
|
Volker
(This used to be commit 0eea6b84cec7e2a3fc1f784d5a9b162f71cc8a02)
|
|
send_smb failures should be clean exits. All times when we exit as
a matter of policy should also be clean exits.
(This used to be commit d6382092e72120a3c89ffe81975e8898d454bf06)
|
|
off conn->mem_ctx, not the null context so we can
safefy free everything on conn close. Should fix
possible memleak.
Jeremy.
(This used to be commit b33bde7b39953e171f05cdb53b6345ee3a9ec6e7)
|
|
(This used to be commit 1e4ee728df7eeafc1b4d533240acb032f73b4f5c)
|