summaryrefslogtreecommitdiff
path: root/source3/smbd/nttrans.c
AgeCommit message (Collapse)AuthorFilesLines
2008-11-30Set PRESENT flag when returning NULL [SD]ACL like Windows does.Steven Danneman1-1/+9
This could also be handled inside each ACL VFS module, by setting the PRESENT flag when a NULL [SD]ACL is created.
2008-11-28Remove "conn" parameter from np_open, smb_request contains itVolker Lendecke1-1/+1
2008-11-28Consolidate the buffer checks for the reply_trans style functionsVolker Lendecke1-57/+18
This is the one where I found the problem that led to 3.2.5. So if there is one checkin in the last year that I would like others to review and *understand*, it is this one :-) Volker
2008-11-28Remove the variable "size" from reply_nttransVolker Lendecke1-10/+13
This converts the range checks for the setup[] array to rely on req->wct being set correctly in init_smb_request. As that already verifies the vwv array to be in the range of the smb_request inbuf, we don't have to do overflow checks here anymore. Jeremy, please check thoroughly! :-) Thanks, Volker
2008-11-27Fix the offset checks in the trans routinesVolker Lendecke1-3/+3
This fixes a potential crash bug, a client can make us read memory we should not read. Luckily I got the disp checks right... Volker (cherry picked from commit 64a1d80851da5b05e70ec6c96f6e9bd473748369) (cherry picked from commit f04c5650a3aeca23591ddc781c4b297caaf9bb3f)
2008-11-23Fix to allow setting of NULL DACL/SACLSteven Danneman1-11/+2
This is a modification of Jeremy's 7522ef15aca2429ef57c75d8297dd8121e79c9da commit. If no DACL/SACL is present in the packet, the SEC_INFO field should still be passed down as is to the VFS layer to signal the creation of a NULL DACL/SACL. As seen in metze RAW-ACL test_nttrans_create_null_dacl(), a NULL DACL is set regardless of the SEC_DESC_DACL_PRESENT bit being set.
2008-11-12Fix build breakTim Prouty1-1/+1
2008-11-12Pretty print out SD's on get/set.Jeremy Allison1-0/+10
Jeremy.
2008-11-08Do not write into inbuf for the transs requestVolker Lendecke1-6/+5
Instead, fix up the outbuf in send_xx_reply. In those routines, we know what we are returning.
2008-11-08Remove a direct inbuf reference from reply_nttrans()Volker Lendecke1-2/+1
2008-11-08Converting notify.c to store a request, not an inbufVolker Lendecke1-1/+2
2008-11-06Final fix to make us pass NULL SD test in RAW-ACLs. Not sure if this is 100% ↵Jeremy Allison1-0/+3
right. Only inheritance left to fix. Jeremy.
2008-11-02Use "vwv" in trans parsingVolker Lendecke1-35/+30
2008-11-02Remove a bunch of direct inbuf references by adding "vwv" to smb_requestVolker Lendecke1-2/+2
2008-11-02Simplify params of srvstr_pull_buf_talloc()Volker Lendecke1-2/+1
Now that "req" is available everywhere, use it. Rename srvstr_pull_buf_talloc() to srvstr_pull_req()
2008-11-02Add srvstr_get_path_req[_wcard]Volker Lendecke1-8/+6
2008-11-01Remove a bunch of direct inbuf references by adding "buf" to smb_requestVolker Lendecke1-4/+4
2008-10-25Move the is_known_pipename check into np_openVolker Lendecke1-10/+5
2008-10-22Fix a debug message in send_nt_replies()Volker Lendecke1-3/+6
2008-10-14Use {u,}int64_t instead of SMB_BIG_{U,}INT.Jelmer Vernooij1-25/+25
2008-10-13Use "struct files_struct" for pipes instead of smb_np_structVolker Lendecke1-11/+6
2008-10-13Pass struct smb_request to file_freeVolker Lendecke1-3/+3
on the way to get rid of chain_fsp
2008-10-13Pass struct smb_request to file_fspVolker Lendecke1-7/+7
The goal is to get rid of the chain_fsp global variable
2008-10-11Fix a "nexted extern declaration" warningVolker Lendecke1-1/+1
2008-10-08For the vfs_acl_xattr.c module, make sure we map GENERIC file and directory bitsJeremy Allison1-0/+5
to specific bits every time a security descriptor is set. The S4 torture suite proves that generic bits are not returned when querying an ACL set using them (ie. only the specific bits are stored on disk). Jeremy.
2008-09-09Add some debug to reply_nttransVolker Lendecke1-0/+11
(This used to be commit 23e9fed28cf9998534b3c55f4b20a562da507552)
2008-09-08Fix calculation of useable_space for trans2 and nttrans repliesVolker Lendecke1-12/+10
When alignment was in place, we pretended to send more data/params according to the param_offset/param_length and data_offset/data_length parameters than would actually fit into the SMB according to the NBSS length field. (This used to be commit ef3c132b8455c6fe4d0bb9f0be881040a806a4ed)
2008-08-20smbd: fix the handling of create_options to pass RAW-OPENStefan Metzmacher1-0/+12
Some of the bits generate INVALID_PARAMETER and some bits are ignored when they come from a client, that's why we need to use bits from the ignored range for our internal usage. metze (This used to be commit 7b4c8a4e39f310eb450918fa841b0ea1b4af19f7)
2008-07-19Introduce is_known_pipenameVolker Lendecke1-35/+1
This scans the list of pipes registered via rpc_pipe_register_commands instead of using static tables. (This used to be commit 283e6039989adea1c8921b3600b410cb67b6492a)
2008-06-19Remove current_user references from nttrans.cVolker Lendecke1-3/+2
(This used to be commit 5f8a5e68ea166fbeda3af6e5ec381ec09d06f0f6)
2008-06-19Remove current_user references from trans2.cVolker Lendecke1-2/+2
This involved replacing the CHECK_NTQUOTA_HANDLE_OK macro by a function. (This used to be commit 5595cdf837edb82db69a3e57bcf3108be7feeeb8)
2008-06-19Remove the "current_user" arg from fsp_belongs_connVolker Lendecke1-3/+3
fsp_belongs_conn only used the vuid struct member anyway, and this is available in the smb_request structure as well. (This used to be commit 64e9372ab997739d46669c0cc4a4c6edb11d5e64)
2008-06-19Remove the "current_user" arg from check_fspVolker Lendecke1-1/+1
check_fsp only used the vuid struct member anyway, and this is available in the smb_request structure as well. (This used to be commit 8d364c4c3311b406847158fc37e9208d298cf8ba)
2008-05-16Simplify fake_file logicVolker Lendecke1-1/+1
(This used to be commit 93111ea0a1191e8547ad6cf112e2699d3bb3799b)
2008-05-10Remove "user" from connection_structVolker Lendecke1-4/+6
(This used to be commit 368454a27cb53a408ec416cbf37235b304592fb5)
2008-05-09Remove a couple of uses of SMB_VFS_GET_NT_ACL(), useJeremy Allison1-8/+2
SMB_VFS_FGET_NT_ACL instead. I'd like to ultimately remove SMB_VFS_GET_NT_ACL. Jeremy. (This used to be commit 4221937b68e2414295279b27c5f12a80f826ed4b)
2008-05-08Yay ! Remove a VFS entry. Removed the set_nt_acl() call,Jeremy Allison1-7/+1
this can only be done via fset_nt_acl() using an open file/directory handle. I'd like to do the same with get_nt_acl() but am concerned about efficiency problems with "hide unreadable/hide unwritable" when doing a directory listing (this would mean opening every file in the dir on list). Moving closer to rationalizing the ACL model and maybe moving the POSIX calls into a posix_acl VFS module rather than having them as first class citizens of the VFS. Jeremy. (This used to be commit f487f742cb903a06fbf2be006ddc9ce9063339ed)
2008-05-05Remove connection_struct->mem_ctx, connection_struct is its own parentVolker Lendecke1-1/+1
(This used to be commit 559180f7d30606d1999399d954ceedc798c669a4)
2008-04-14Remove two pointless else branchesVolker Lendecke1-7/+5
(This used to be commit ed343114cd0844a7fd14b45f95c0f43a6d172a42)
2008-04-07Rewrite the wrap checks to deal with gcc 4.x optimisations.Jeremy Allison1-38/+51
Karolin, please pull once Volker has reviewed. Thanks. Jeremy. (This used to be commit 09852899cadc48abe2f2651ecbceaf881198e648)
2008-04-07smbd: implement the strange write time update logicStefan Metzmacher1-1/+1
We now never call file_ntimes() directly, every update is done via smb_set_file_time(). This let samba3 pass the BASE-DELAYWRITE test. The write time is only updated 2 seconds after the first write() on any open handle to the current time (not the time of the first write). Each handle which had write requests updates the write time to the current time on close(). If the write time is set explicit via setfileinfo or setpathinfo the write time is visible directly and a following close on the same handle doesn't update the write time. metze (This used to be commit 2eab212ea2e1bfd8fa716c2c89b2c042f7ba12ea)
2008-04-01smbd: ignore nttrans renames as w2k3 doesStefan Metzmacher1-24/+3
This lets us pass the RAW-RENAME test. metze Signed-off-by: Michael Adam <obnox@samba.org> (This used to be commit 2d50a1fef022023588e9963131951f8f3e4c7c23)
2008-03-11Using Metze's S4 nttrans rename test, the nttrans renameJeremy Allison1-1/+1
behaves the same as the trans2 one. Jeremy. (This used to be commit c4fa4917dad97c5047f7336c6675739b44da256b)
2008-03-11Try and fix bug #5315, as well as S4 torture tests RAW-OPLOCK BATCH19,Jeremy Allison1-2/+3
BATCH20 and RAW-RENAME. Jeremy. (This used to be commit 9065792d4bc42522f12f9732de3c0ad82c72a2d3)
2008-02-22Don't use fname after create_file has been calledVolker Lendecke1-5/+5
create_file calls unix_convert internally, so modifies fname. So we can't use "fname" after create_file has returned. Use fsp->fsp_name instead. Found during a lengthy debugging session with Karolin testing the xattr_tdb module... (This used to be commit 183fe570469963923864b732817a87f8660341ed)
2008-01-19Add "split_ntfs_stream_name()" together with a torture testVolker Lendecke1-0/+3
(This used to be commit d813bd9e02d9baf916eb96c478be89f0c435e07c)
2008-01-09Make use of talloc_pool in the main codepaths. Remove the sub-contexts.Jeremy Allison1-8/+0
Jeremy. (This used to be commit bc932b8ad4396f76b71c43efe9a6346f89c3632c)
2008-01-06Remove superfluous parameter fd from SMB_VFS_FSET_NT_ACL().Michael Adam1-2/+1
Michael (This used to be commit 4f2d139a186048f08180378a877b69d2f80ad51f)
2008-01-06Remove superfluous fd parameter from SMB_VFS_FGET_NT_ACL().Michael Adam1-1/+1
Michael (This used to be commit c0c7c1223da29c68359dac64a340c1c710d5f3d2)
2008-01-04Now conn is part of smb_request, we don't need it asJeremy Allison1-5/+9
an extra parameter. This cleans up quite a few places we were passing it around without needing it. Jeremy. (This used to be commit 8f36def18e9f980e8db522e1de41e80cfd5f466e)
generated by cgit (git 2.34.1) at 2024-11-01 14:35:38 +0000