summaryrefslogtreecommitdiff
path: root/source3/smbd/open.c
AgeCommit message (Collapse)AuthorFilesLines
2002-03-23Fix the mp3 rename bug - also tidy up our open code and remove the specialJeremy Allison1-167/+164
cases for rename and unlink. Had to add desired_access into the share mode record. Jeremy. (This used to be commit 3b1b8ac43535fb0839c5474fa55bf7150f6cde31)
2002-03-21Fix stupid typo !Jeremy Allison1-2/+2
Jeremy. (This used to be commit d0b58f66edeac516bde2dff79ab5cf529c37954b)
2002-03-20Remove the "stat open" code - make it inline. This should fix theJeremy Allison1-74/+27
bugs with opening and renaming mp3 files, also the word rename problems that people have had for a while. Needs a make clean :-) make. Also added JohnR's printing fix. Jeremy. (This used to be commit 504e5ef0494c54efbd0357e334cb2aa5a9eb9c14)
2002-03-12Added POSIX ACL layer into the vfs.Jeremy Allison1-1/+1
Jeremy. (This used to be commit 7d59445b6962547a8938928a9371651a09e26516)
2002-03-11Implemented default ACL patch (set inherit acls = true on a per share basis).Jeremy Allison1-2/+12
Based on code donated by Olaf Fr±czyk <olaf@cbk.poznan.pl>. Further commit will change to sending via vfs interface. Jeremy. (This used to be commit d85133e2697eb22f1573c78447b57791ae63dd6b)
2002-03-07Fixed delete on close semantics - preparing for share mode rewrite.Jeremy Allison1-0/+2
Jeremy. (This used to be commit 25dd73be29bbf0a080fe0bcbe5c478545d1e8db7)
2002-02-26This is a nasty hack to fix "xcopy /o" from win2000 on a Samba shareAndrew Tridgell1-13/+46
The hack passes the true ntcreate desired_access down to open_file_shared1() from the ntcreatex function. This is used to determine if share modes should be used in denying this open. This hack will become unnecessary when we redo open.c to use the proper NTCreateX semantics rather than trying to jam the ntcreate semantics into openX semantics. (This used to be commit d09ae0c667a94fcf870c0fc7f97119266a650d45)
2002-02-15Merge of smbclient print crash bug fix from app head.Tim Potter1-2/+4
(This used to be commit a56298d56ae67a764e9b9a43c1c568b7125e1c18)
2002-01-30Removed version number from file header.Tim Potter1-2/+1
Changed "SMB/Netbios" to "SMB/CIFS" in file header. (This used to be commit 6a58c9bd06d0d7502a24bf5ce5a2faf0a146edfa)
2002-01-25Fixed display of "remote downlevel document" in old print job submissionJeremy Allison1-1/+1
case. Jeremy. (This used to be commit 248770d73072e36fd9812ec5986dce5380dfab33)
2002-01-17don't use O_NONBLOCK in open(). This was added erroneously for kernelAndrew Tridgell1-4/+0
oplocks and really shouldn't be used (This used to be commit c3a83002cfc2e0b5158cae1898eda8bafcb41e48)
2002-01-12Added the O_NOFOLLOW flag if follow symlinks is set off.Jeremy Allison1-0/+6
Jeremy. (This used to be commit 4f1f5f28b514dda86f6f49465bd5887357e37bc6)
2001-12-16Moved fchown_acl change to the point where we *really* know if weJeremy Allison1-10/+10
created the file or not. Jeremy. (This used to be commit 32dffa0ba792a81d89d06b527d82820b89507efd)
2001-11-28Spelling pedents strike again :-).Jeremy Allison1-1/+1
Jeremy. (This used to be commit 0187d4ba16c794faa372bf1a50261b8f47482064)
2001-11-28Ensure the CAN_WRITE is checked and prevents O_CREAT and O_TRUNC fromJeremy Allison1-2/+2
being set. Also prevent an open on a file on a readonly share from setting delete on close. Jeremy. (This used to be commit 1f3dcd99bdd36cd3ff492394e80c3e2037a9aa48)
2001-11-28Re-added "Share modes" meaning don't allow deny mode conflict. Due toJeremy Allison1-2/+10
user demand (don't talk to me about removing parameters.... :-). Jeremy. (This used to be commit b69127391b322d81cc648f73a601ed61e79c8a44)
2001-11-27Fix for the logic bug wrt. existant oplocks. See long messageJeremy Allison1-5/+2
in samba-technical for explaination. Jeremy. (This used to be commit 8150f0f3f72957e77a1e6ca06760c87c516792eb)
2001-11-27nsswitch/winbindd_group.c nsswitch/winbindd_user.c: formatting fixups.Jeremy Allison1-1/+1
smbd/open.c: Fix "delete on close" for directories. Jeremy. (This used to be commit 014b0973a3b3b9eb22cce3053171fa55f5c16a63)
2001-11-23Fixed delete on close bug. Added core dump code to winbindd.Jeremy Allison1-1/+22
Jeremy. (This used to be commit a58d0f91f9ee7354c01a9c20cfe178d5dc02142d)
2001-10-20Move from timestamp to gen count file id's for finding oplocked filesJeremy Allison1-7/+2
in a tdb. Jeremy. (This used to be commit 058ae6b58f61ef46013dd076af3a84de5fbaaab1)
2001-10-02Removed 'extern int DEBUGLEVEL' as it is now in the smb.h header.Tim Potter1-2/+0
(This used to be commit 2d0922b0eabfdc0aaf1d0797482fef47ed7fde8e)
2001-09-24Change log message to 2 from zero when failing to create directory.Jeremy Allison1-1/+1
Stops spurious profile creation messages. Jeremy. (This used to be commit fa74d07207fa9024b6ebdb10686b032ef6673d18)
2001-09-17move to SAFE_FREE()Simo Sorce1-9/+8
(This used to be commit a95943fde0ad89ae3f2deca2f7ba9cb5ab612b74)
2001-09-15use variables _before_ freeing them!Simo Sorce1-3/+2
thanks to Andreas Moroder for spotting these two. (This used to be commit 01f30ca0ad472eaab8f80ec4278b1d391be3a1ae)
2001-09-05fixed formatting to make the code vaguely readable. It's still a dogsAndrew Tridgell1-142/+143
breakfast, but at least you can follow the indents (This used to be commit 9955ea0aaa299c6c946b4e7b7e98017c39b60bc8)
2001-08-27converted smbd to use NTSTATUS by defaultAndrew Tridgell1-4/+1
major changes include: - added NSTATUS type - added automatic mapping between dos and nt error codes - changed all ERROR() calls to ERROR_DOS() and many to ERROR_NT() these calls auto-translate to the client error code system - got rid of the cached error code and the writebmpx code We eventually will need to also: - get rid of BOOL, so we don't lose error info - replace all ERROR_DOS() calls with ERROR_NT() calls but that is too much for one night (This used to be commit 83d9896c1ea8be796192b51a4678c2a3b87f7518)
2001-08-22Missed '\' at eol...Jeremy Allison1-1/+1
Jeremy. (This used to be commit 0dbd1be704209c1a66280148b40f7b7437d47242)
2001-08-22Tidyup fixes for fcntl spin problem.Jeremy Allison1-3/+13
Jeremy. (This used to be commit 27d3dd0e7cb777ef6b21d6966c07045c2940fd37)
2001-08-22Fixed the (incorrect) paranioa fix I put in for the fcntl lock spin.Jeremy Allison1-9/+35
Don't delete a share mode that failed to remove the oplock (doh!), just set the oplock entry to zero.... Jeremy. (This used to be commit fe4aa720181a43f7a636ca029680fab0c836b968)
2001-08-21This is Jeremy pretending to be Volker, 'cos theVolker Lendecke1-0/+10
link from Seattle is having problems. I've added 3 things here to work on the fcntl spin problem. 1). Check *all* tdb return codes... :-). 2). If we're asking ourselves to break an oplock, and we can't find a fsp pointer that matches the entry, this is a *logic bug* and we should abort and panic so someone with gdb can pick up the pieces. 3). After we've broken an oplock, ensure that the entry itself has been removed, and if not remove it ourselves. This should not be neccessary in a correctly working environmen,t, but will provide an added layer of robustness in error situations. 4). I hate german keyboards :-) :-). Jeremy. (This used to be commit 1c94fa80646f9e31377fbb41332fe4780f550cab)
2001-07-24We were making an assumption in the oplockJeremy Allison1-1/+0
break code path that was invalid (ie. we were assuming we could infer a non-levelII oplock when such an oplock was detected - this may no longer be valid once we've processed the break process dealing with the break will change the state of it anyway. This prevents the state where we get the following packet trace : client server NTcreate -> <- NTcreate resp NTcreate -> <- break to level II ok - broken -> <- break to none Thanks to Alan Romeril for providing the trace that allowed me to track this down. Jeremy. (This used to be commit c343e4f49070011986fc2ed4acd4ce690d5f1d71)
2001-07-05Fix race where wrong action (created or opened) could be returned.Jeremy Allison1-0/+8
Jeremy. (This used to be commit af5b649b017f703a14a69f77a9067efb9c6a8269)
2001-07-04strchr and strrchr are macros when compiling with optimisation in gcc, so we ↵Andrew Tridgell1-2/+2
can't redefine them. damn. (This used to be commit c41fc06376d1a2b83690612304e85010b5e5f3cf)
2001-07-04The big character set handling changeover!Andrew Tridgell1-24/+2
This commit gets rid of all our old codepage handling and replaces it with iconv. All internal strings in Samba are now in "unix" charset, which may be multi-byte. See internals.doc and my posting to samba-technical for a more complete explanation. (This used to be commit debb471267960e56005a741817ebd227ecfc512a)
2001-06-30Fixed the first locking error (test #8 found by locktest code fromJeremy Allison1-1/+1
Clarion locktest. Jeremy. (This used to be commit 5c42845b5bb6fafd0ebf93fbdd23d9bf861da865)
2001-06-19Extra debug in open.c, fix for bad debug message in reply.cJeremy Allison1-2/+2
Jeremy. (This used to be commit 2c2fc8513699eb39721ac1d65fa1fdaecde526a8)
2001-04-18Removed mktemp from HEAD - same as done in 2.2.Jeremy Allison1-1/+1
Jeremy. (This used to be commit 121b59669fbcd1aaedb08011ff36169fc6561c55)
2001-04-16Finally got the semantics right (hurrah!).Jeremy Allison1-6/+14
Jeremy. (This used to be commit 362574c5a32005d4247c7ac75a5aa9e35e894db0)
2001-04-16Correct fix for open readonly with truncate.Jeremy Allison1-17/+18
Jeremy. (This used to be commit 6706e258e17c3d69d617b95feb3407124f50852d)
2001-04-14This little piece of insanity is inspired by theJeremy Allison1-3/+18
fact that an NT client can open a file for O_RDONLY, but set the create disposition to FILE_EXISTS_TRUNCATE. If the client *can* write to the file, then it expects to truncate the file, even though it is opening for readonly. Quicken uses this stupid trick in backup file creation... Thanks *greatly* to "David W. Chapman Jr." <dwcjr@inethouston.net> for helping track this one down. It didn't bite us in 2.0.x as we always opened files read-write in that release. Jeremy. (This used to be commit 5baef56831f9bc4fa10a851abd5f9305b974fb3b)
2001-04-14configure:Jeremy Allison1-7/+47
configure.in: include/config.h.in: include/profile.h: smbd/vfs-wrap.c: smbd/vfs.c: Added fchmod and fchown to VFS (sorry Gerald - but we needed them anyway). smbd/dosmode.c: smbd/files.c: printing/printfsp.c: smbd/close.c: smbd/open.c: Fixed "dos filemode" correctly so there are no race conditions. Forces test of open of file O_WRONLY before allowing fchmod as root. Afterwards, calls standard close function that preserves POSIX locks due to POSIX-me-harder braindamage. :-). Andrew please review this code. Also - in removing the tmpdir param in smbrun an extra NULL parameter was missed in each print_run_command() call (which is a varargs fn.). Now fixed. Jeremy. (This used to be commit 32397e5bc6d995ce7ca37c82d6aedc1e5b1b6fbd)
2001-04-13Fixed potential file descriptor leak with MS-Access fix.Jeremy Allison1-1/+9
Jeremy. (This used to be commit 192887fe72157a141b8df1977085f479e5204782)
2001-03-30This is a big, rather ugly patch. Whilst investigating the files not truncatedJeremy Allison1-6/+39
when copying to a full disk problem, I discovered that we were not allowing the delete on close flag to be set properly, this led to other things, and after investigation of the proper delete on close semantics and their relationship to the file_share_delete flag I discovered there were some cases where we weren't doing the deny modes properly. And this after only 5 years working on them..... :-) :-). So here's the latest attempt. I realised the delete on close flag needs to be set across all smbds with a dev/ino pair open - in addition, the delete on close flag, allow share delete and delete access requested all need to be stored in the share mode tdb. The "delete_on_close" entry in the fsp struct is now redundant and should really be removed. This may also mean we can get rid of the "iterate_fsp" calls that I didn't like adding in the first place. Whilst doing this patch, I also discovered we needed to do the se_map_generic() call for file opens and POSIX ACL mapping, so I added that also. This code, although ugly, now passes the deny mode torture tests plus the delete on close tests I added. I do need to add one more multiple connection delete on close test to make sure I got the semantics exactly right, plus we should also (as Andrew suggested) move to random testing here. The good news is that NT should now correctly delete the file on disk full error when copying to a disk :-). Jeremy. (This used to be commit 51987684bd231c744da2e5f3705fd236d5616173)
2001-03-26smbd/posix_acls.c: Saving and restoring errno here is the wrong place. Moved itJeremy Allison1-3/+6
to the places where [f]chmod_acl is called instead. Jeremy. (This used to be commit 641ada44ae6429761c1fd0dbcafabc69f897fac7)
2001-03-11Merge of new 2.2 code into HEAD (Gerald I hate you :-) :-). Allows new SAMRJeremy Allison1-4/+0
RPC code to merge with new passdb code. Currently rpcclient doesn't compile. I'm working on it... Jeremy. (This used to be commit 0be41d5158ea4e645e93e8cd30617c038416e549)
2001-01-24Sync up with POSIX ACL code from 2.2.Jeremy Allison1-0/+7
Jeremy. (This used to be commit e0431672cc54ed09d6c5cf083054db12ccd9dcf6)
2001-01-23include/vfs.h:Jeremy Allison1-2/+2
smbd/vfs-wrap.c: smbd/vfs.c: Added fchmod_acl and chmod_acl. lib/substitute.c: smbd/lanman.c: smbd/open.c: smbd/process.c: smbd/reply.c: smbd/service.c: Removed sessetup_user variable. Added current_user_info struct which conatins domain info etc. Added '%D' for client domain parameter. Jeremy. (This used to be commit 2844ec3d511680609d6794b8718001a1bda9e89f)
2000-12-11Fixed very subtle bug returning correct error on an open, when we haveJeremy Allison1-8/+22
a choice of invalid share mode and access denied. We must return the access denied by preference, but also remember to break the oplocks... This is needed for multi-user MS-Access. Jeremy. (This used to be commit 7eb7241442ea0f1e065b009c3cccd5821b89a8b6)
2000-10-20Fix for vfs_fstat() crash with new stat code.Jeremy Allison1-0/+3
Jeremy. (This used to be commit 979aa01e011d433328af0ead7644f47d0cfadf13)
2000-10-19Ok - this is a big patch - and it may break smbd a bit (althoughJeremy Allison1-52/+64
I hope not). If you encounter strange file-serving behavior after this patch then back it out. I analysed our stat() usage and realised we were doing approx. 3 stat calls per open, and 2 per getattr/setattr. This patch should fix all that. It causes the stat struct returned from unix_convert() (which now *must* be passed a valid SMB_STRUCT_STAT pointer) to be passed through into the open code. This should prevent the multiple stats that were being done so as not to violate layer encapsulation in the API's. Herb - if you could run a NetBench test with this code and do a padc/par syscall test and also run with the current 2.2.0 code and test the padc/par syscalls I'd appreciate it - you should find the number of stat calls reduced - not sure by how much. The patch depends on unix_convert() actually finding the file and returning a stat struct, or returning a zero'd out stat struct if the file didn't exist. I believe we can guarentee this to be the case - I just wasn't confident enough to make this an assertion before. Ok ok - I did write this whilst at the Miami conference..... sometimes you get a little free time at these things :-). Jeremy. (This used to be commit 66a5c05ec46b641224fbe01b30bd7e83571a2a1b)
generated by cgit (git 2.34.1) at 2024-12-24 16:01:25 +0000