summaryrefslogtreecommitdiff
path: root/source3/smbd/process.c
AgeCommit message (Collapse)AuthorFilesLines
2011-02-11s3: Avoid a select call per smbVolker Lendecke1-1/+1
Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Fri Feb 11 12:13:54 CET 2011 on sn-devel-104
2011-02-06s3: Fix some nonempty blank linesVolker Lendecke1-3/+3
2011-01-31s3:smbd: let smbd_server_connection_loop_once() check for select errorsStefan Metzmacher1-0/+4
metze
2011-01-31Revert "s3: Fix starving the echo responder"Stefan Metzmacher1-17/+0
This reverts commit d5cf6482ed0cd9a11448ca04944b2e01200a7c89. I'll add a more generic fix for this problem. metze
2011-01-31Revert "s3:events: Call all ready fd event handlers on each iteration of the ↵Stefan Metzmacher1-18/+21
main loop" This reverts commit 455fccf86b6544cd17a2571c63a88f8aebff3f74. I'll add a more generic fix for this problem. metze
2011-01-26Allow "security = share" with SMB2. We already handle this in smb2/smb2_server.cJeremy Allison1-1/+0
Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Wed Jan 26 20:37:29 CET 2011 on sn-devel-104
2011-01-14s3: Fix bug 7917: Yet another bug in chain_replyVolker Lendecke1-2/+2
Found by Michael Hanscho <samba@micha.priv.at> with a WinCE client. Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Fri Jan 14 17:42:05 CET 2011 on sn-devel-104
2011-01-07s3-printing: Initiate pcap reload from parent smbdDavid Disseldorp1-36/+9
Since commit 7022554, smbds share a printcap cache (printer_list.tdb), therefore ordering of events between smbd processes is important when updating printcap cache information. Consider the following two process example: 1) smbd1 receives HUP or printcap cache time expiry 2) smbd1 checks whether pcap needs refresh, it does 3) smbd1 marks pcap as refreshed 4) smbd1 forks child1 to obtain cups printer info 5) smbd2 receives HUP or printcap cache time expiry 6) smbd2 checks whether pcap needs refresh, it does not (due to step 3) 7) smbd2 reloads printer shares prior to child1 completion (stale pcap) 8) child1 completion, pcap cache (printer_list.tdb) is updated by smbd1 9) smbd1 reloads printer shares based on new pcap information In this case both smbd1 and smbd2 are reliant on the pcap update performed on child1 completion. The prior commit "reload shares after pcap cache fill" ensures that smbd1 only reloads printer shares following pcap update, however smbd2 continues to present shares based on stale pcap data. This commit addresses the above problem by driving pcap cache and printer share updates from the parent smbd process. 1) smbd0 (parent) receives a HUP or printcap cache time expiry 2) smbd0 forks child0 to obtain cups printer info 3) child0 completion, pcap cache (printer_list.tdb) is updated by smbd0 4) smbd0 reloads printer shares 5) smbd0 notifies child smbds of pcap update via message_send_all() 6) child smbds read fresh pcap data and reload printer shares This architecture has the additional advantage that only a single process (the parent smbd) requests printer information from the printcap backend. Use time_mono in housekeeping functions As suggested by Björn Jacke.
2011-01-07s3-printing: reload shares after pcap cache fillDavid Disseldorp1-1/+2
Since commit eada8f8a, updates to the cups pcap cache are performed asynchronously - cups_cache_reload() forks a child process to request cups printer information and notify the parent smbd on completion. Currently printer shares are reloaded immediately following the call to cups_cache_reload(), this occurs prior to smbd receiving new cups pcap information from the child process. Such behaviour can result in stale print shares as outlined in bug 7836. This fix ensures print shares are only reloaded after new pcap data has been received. Pair-Programmed-With: Lars Müller <lars@samba.org>
2010-12-23All calls to event_add_to_select_args() call GetTimeOfDay() andJeremy Allison1-7/+2
pass this in as the &now parameter. Push this call inside of event_add_to_select_args() to the correct point so it doesn't get called unless needed. Jeremy. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Thu Dec 23 01:08:11 CET 2010 on sn-devel-104
2010-10-20s3: Add some DEBUGVolker Lendecke1-0/+2
Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Wed Oct 20 11:58:20 UTC 2010 on sn-devel-104
2010-10-20s3: Cope with EINTR in smbd_[un]lock_socketVolker Lendecke1-2/+10
2010-10-19Add deadtime detection for SMB2. Correctly update lastused timestamp across ↵Jeremy Allison1-13/+1
all active tcons. Should fix dfree cache not updating bug.
2010-10-14s3: Remove smbd_server_conn from construct_replyVolker Lendecke1-4/+6
Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Thu Oct 14 12:35:07 UTC 2010 on sn-devel-104
2010-10-14s3: Lift smbd_server_conn from receive_smb_tallocVolker Lendecke1-10/+9
2010-10-14s3: Lift smbd_server_conn from receive_smb_raw_tallocVolker Lendecke1-8/+10
2010-10-14s3: Lift smbd_server_conn from receive_smb_raw_talloc_partial_readVolker Lendecke1-10/+10
2010-10-14s3: Remove some explicit smbd_server_conn refs in process_smb()Volker Lendecke1-2/+2
2010-10-14s3: Rename "conn" to the more used "sconn" in process_smb()Volker Lendecke1-7/+7
2010-10-07s3: Fix the async echo responder for netbios keepalivesVolker Lendecke1-10/+23
This fixes a crash in the echo responder when the client started to send the NetBIOS-Level 0x85-style keepalive packets. We did not correctly check the packet length, so the code writing the signing seqnum overwrote memory after the malloc'ed area for the 4 byte keepalive packet. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Thu Oct 7 19:47:35 UTC 2010 on sn-devel-104
2010-10-06s3: Make the write end of the echo responder pipe non-blockingVolker Lendecke1-0/+1
Without this, we can get a writable pipe end, but the writev call on the pipe will block. Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Wed Oct 6 13:57:30 UTC 2010 on sn-devel-104
2010-10-01s3:events: Call all ready fd event handlers on each iteration of the main loopSteven Danneman1-19/+16
Previously, only one fd handler was being called per main message loop in all smbd child processes. In the case where multiple fds are available for reading the fd corresponding to the event closest to the beginning of the event list would be run. Obviously this is arbitrary and could cause unfairness. Usually, the first event fd is the network socket, meaning heavy load of client requests can starve out other fd events such as oplock or notify upcalls from the kernel. In this patch, I have changed the behavior of run_events() to unset any fd that it has already called a handler function, as well as decrement the number of fds that were returned from select(). This allows the caller of run_events() to iterate it, until all available fds have been handled. I then changed the main loop in smbd child processes to iterate run_events(). This way, all available fds are handled on each wake of select, while still checking for timed or signalled events between each handler function call. I also added an explicit check for EINTR from select(), which previously was masked by the fact that run_events() would handle any signal event before the return code was checked. This required a signature change to run_events() but all other callers should have no change in their behavior. I also fixed a bug in run_events() where it could be called with a selrtn value of -1, doing unecessary looping through the fd_event list when no fds were available. Also, remove the temporary echo handler hack, as all fds should be treated fairly now.
2010-10-01samba: share select wrappers.Günther Deschner1-0/+1
Guenther
2010-09-28s3: Attempt to fix bug 7518Volker Lendecke1-6/+6
If select returns -1, we can't rely on the fd sets. The current code might loop endlessly because when putting an invalid fd (the closed socket?) on the read set, a select implementation might choose not to touch it but directly return with EINVAL. Thus run_events will see the socket readable, which leads to a "return true", and thus a NT_STATUS_RETRY -> same game again. We should never get into this situation, but to me the logfiles given in bug 7518 do not reveal enough information to understand how this can happen.
2010-09-28s3: Increase the debuglevel for connection termination msgsVolker Lendecke1-2/+2
2010-09-28s3: Remove two calls to procid_self()Volker Lendecke1-2/+4
2010-09-28s3: Remove "server_fd" global variableVolker Lendecke1-7/+4
2010-09-26Fix bug #7698 - Assert causes smbd to panic on invalid NetBIOS session request.Jeremy Allison1-1/+1
Found by the CodeNomicon test suites at the SNIA plugfest. http://www.codenomicon.com/ If an invalid NetBIOS session request is received the code in name_len() in libsmb/nmblib.c can hit an assert. Re-write name_len() and name_extract() to use "buf/len" pairs and always limit reads. Jeremy.
2010-09-20s3-build: only include ctdbd_conn.h where needed.Günther Deschner1-0/+1
Guenther
2010-09-20s3-build: only include async headers where needed.Günther Deschner1-0/+1
Guenther
2010-09-05s3: On Solaris, iov_len is an intVolker Lendecke1-1/+3
We can't use &iov.iov_len passing it to a size_t *
2010-08-31s3: messaging_ctdbd_connection() was only called with procid_self()Volker Lendecke1-1/+1
Eventually we'll get this right...
2010-08-29s3: Fix an uninitialized variableVolker Lendecke1-1/+1
2010-08-29s3: Fix the build without clusterVolker Lendecke1-0/+4
2010-08-29s3: Remove two uses of smbd_server_fd()Volker Lendecke1-1/+1
Actually, this is a bit cheating. But those two files depend on smbd_server_conn anyway, it does not make things worse.
2010-08-29s3: Remove smbd_server_fd() from smbd_register_ipsVolker Lendecke1-3/+4
2010-08-29s3: Lift smbd_server_fd() from msg_release_ip()Volker Lendecke1-4/+4
2010-08-29s3: Lift smbd_server_fd() from release_ip()Volker Lendecke1-11/+27
2010-08-29s3: Pass sconn to check_reloadVolker Lendecke1-4/+4
This removes a use of smbd_server_fd()
2010-08-29s3: Pass sconn instead of msg_ctx to housekeeping_fnVolker Lendecke1-6/+5
2010-08-28s3:smbd: s/sa_len/sa_socklen , because sa_len is a macro on IRIXStefan Metzmacher1-7/+7
metze
2010-08-24s3: Move "trans_num" to smbd_server_connectionVolker Lendecke1-4/+3
2010-08-24s3: Make srv_send_smb take an sconn instead of a sock fdVolker Lendecke1-11/+11
2010-08-22s3: Replace calls to check_access by allow_accessVolker Lendecke1-4/+6
We already have both the name and address of the client stored now
2010-08-18s3: Lift smbd_server_fd from reload_services()Volker Lendecke1-3/+3
2010-08-17s3: Lift smbd_server_fd() from receive_smb_raw_tallocVolker Lendecke1-5/+5
2010-08-17s3: Lift smbd_server_fd() from read_smb_length_return_keepaliveVolker Lendecke1-1/+5
2010-08-17s3: Lift smbd_server_fd() from read_fd_with_timeout()Volker Lendecke1-1/+16
2010-08-17s3: Remove smbd_server_fd() from write_data()Volker Lendecke1-3/+20
This completely removes the DEBUG(0, ..) error message from write_data(). I've gone through all callers of write_data() and made sure that they have their own equivalent error message printing.
2010-08-16s3: Remove smbd_server_fd() from smbd_processVolker Lendecke1-8/+8
generated by cgit (git 2.34.1) at 2024-12-30 16:48:45 +0000