summaryrefslogtreecommitdiff
path: root/source3/smbd/reply.c
AgeCommit message (Collapse)AuthorFilesLines
2004-03-17Remove excess logging when probing for the length of the next mb char.Jeremy Allison1-13/+17
Jeremy. (This used to be commit 6339c4690aef7692571dd4c65dd0a12d56a7ffab)
2004-03-17Change check_path_syntax() to use the new next_mb_char_size() functionJeremy Allison1-23/+13
to make it generic. Remove the mb-codepage "blacklist". Alexander, please check this fix as it reverts your blacklist changes, but I'm hoping it fixes the problem in a more generic way for all charsets. I'm not trying to trample on your (excellent!) work here, just make things more generic without special cases. Jeremy. (This used to be commit 5a9324525acc02e6bf14528679816b35929a564e)
2004-03-16Add function next_mb_char_size() that returns a size_t of the number ofJeremy Allison1-0/+1
bytes in the mb character at a pointer. Will be useful in fixing check_path_syntax() to not use a "blacklist". Also re-added my (C) to reply.c. I mean, really - I've been adding code to the file for over 10 years and I recognise many of the fuctions as mine ! :-). Jeremy. (This used to be commit d2b2a39fd2f2e06cc4aebf081876985f0b28b477)
2004-03-16Fix check_path_syntax() for multibyte encodings which have no '\' as second ↵Alexander Bokovoy1-1/+3
byte. This is intermediate fix as discussed with Jeremy until we move check_path_syntax() to UCS2 internally where all ambiguity is resolved. Please add other encodings into charcnv.c with such property.' ' (This used to be commit 2c404f6ba988d68c6f44df9409c0de319553de10)
2004-03-13First part of patch from moriyama@miraclelinux.com (MORIYAMA Masayuki) toJeremy Allison1-1/+1
fix up netbios names with mb strings. Includes reformat of libsmb/nmblib.c so it's readable. Jeremy. (This used to be commit 966e49a48c352563cdd7f75fe2768f2d6612ec7e)
2004-03-12Fix problems with very long filenames in both smbd and smbclient.Alexander Bokovoy1-10/+18
It appears that we pass filename through resolve_wildcards() as pstring and use fstring temporary buffer there. As result, a long filename in unix charset (UTF-8 by default) can easily expand over 255 bytes while Windows is able to send to us such names (e.g. Japanese name of ~190 mb chars) which we unable to process through this small fstring buffer. Tested with W2K and smbclient, Japanese and Cyrillics. (This used to be commit 83dac6571f99b854ac607d4313cc3f742c1fae2e)
2004-03-11Restore the contract on all convert_stringXX() interfaces. Add a ↵Jeremy Allison1-22/+6
"allow_bad_conv" boolean parameter that allows broken iconv conversions to work. Gets rid of the nasty errno checks in mangle_hash2 and check_path_syntax and allows correct return code checking. Jeremy. (This used to be commit 7b96765c23637613f079d37566d95d5edd511f05)
2004-03-11Fix processing of pathnames with embedded '\\' characters (0x5c) in CP932Jeremy Allison1-5/+23
character set. Because of the allowing of "broken conversions" for people who have broken iconv libraries we can't rely on the return from convert_string() to be valid - we must check errno instead. This is ripe for revisiting at some stage. I prefer adding a bool parameter to all convert_string_XX varients to specify if we will allow broken conversions or not. With "allow_broken_conversions" set to false we could then rely on the return from convert_string rather than checking errno. Jeremy. (This used to be commit 74722f28659ac369676e898fda48d3d9ab265045)
2004-03-09fix build with gcc 2.96 and --with-developerGerald Carter1-1/+1
(This used to be commit 11fc4da07f232c38e04c6443e5d0f829e16b0a18)
2004-03-08Fix assumption about following directory sep in check_path_syntax(). WeJeremy Allison1-5/+11
need to try and convert 1 byte, then 2 bytes if that fails. Fixes bug reported by Simo. Jeremy. (This used to be commit 8702d0089619c7321b93e59d35f43ef32dce7b78)
2004-03-04Fix build farm, older compilers won't let you declare variablesJim McDonough1-1/+1
right in the middle of the code. I just love catching jra on stuff like this, after all the crap I've done. :-) (This used to be commit dc7dc5175847243d821dd33c1678af1b785dfaf7)
2004-03-03Use a common function to parse all pathnames from the wire. This allowsJeremy Allison1-64/+189
much closer emulation of Win2k3 error return codes. Jeremy. (This used to be commit c9f31fafeda6ad79e590276f36e03ecd2e93f818)
2004-02-28More gentest fixes. Fix up regression in IS_NAME_VALID and renames.Jeremy Allison1-11/+30
Jeremy. (This used to be commit 367f5c3bc27aafb04f7589b3d4ac5b58189909fb)
2004-02-26Interesting fact found by IFSTEST /t LockOverlappedTest...Jeremy Allison1-1/+8
Even if it's our own lock context, we need to wait here as there may be an unlock on the way. So I removed a "&& !my_lock_ctx" from the following if statement. if ((lock_timeout != 0) && lp_blocking_locks(SNUM(conn)) && ERROR_WAS_LOCK_DENIED(status)) { Jeremy. (This used to be commit 3f35e3975f1c46daad1456bc82163acd049d7be8)
2004-02-25Fixup strange rename error case (gentest).Jeremy Allison1-1/+2
Jeremy. (This used to be commit d448fb801e175e11cfc0118325043eef836103f0)
2004-02-25More gentest fun :-). NB. I'm not fixing OpenX breakage 'cos if you lookJeremy Allison1-5/+27
at what W2K3 accepts here it's COMPLETELY BROKEN ! :-). Jeremy. (This used to be commit 5107f6ee70a9300678ccb7b3c812e23ddf795c22)
2004-02-25More gentest fixes.Jeremy Allison1-6/+17
Jeremy. (This used to be commit d34785194cbd7132fc3ca1f4d5561c2eee6009ab)
2004-02-24Ensure '.' and '..' don't match in delete requests.Jeremy Allison1-1/+4
Jeremy. (This used to be commit 1b0d54170a2e3e61fc9bdedec6b10c8b7728a395)
2004-02-24More gentest error fixups.Jeremy Allison1-0/+4
Jeremy. (This used to be commit 00f71fc8361919b87b62389ada8bd9a73f9f98b5)
2004-02-24Fixup correct timeout values for blocking lock timeouts (tested at connectathonJeremy Allison1-1/+1
by Herb). Jeremy. (This used to be commit b38b3a554221a234127c740e6432048e69b7f5a3)
2004-01-31* BUG 101: patch from j.lu@tiesse.com to set the SV_TYPE_PRINTQ_SERVER;Gerald Carter1-11/+4
* don't set the unix_ERR_XX code in mkdir_internal, let the error mapping handle it. (This used to be commit 87343fc15a385153c2205bd8bfe876504d38d9a1)
2003-10-29Fixes to check for wraps which could cause coredumps.Jeremy Allison1-4/+6
Jeremy. (This used to be commit ad06edd1bb58cc5e2c38a364b1af96a933b770af)
2003-10-16Fix buggy data_len calculation in echo. Add paranoia debug message.Jeremy Allison1-1/+5
Jeremy. (This used to be commit 5332af1124077f49e84836f5cedfbde98336b142)
2003-10-10Make us pass Samba4 lock tester (with one different error message).Jeremy Allison1-0/+3
Jeremy. (This used to be commit 7622a9dbbded8d07f976ec965adca5e92de3d2b0)
2003-10-09Match W2K insanty w.r.t. writelock and writeclose. Samba4 torture tester.Jeremy Allison1-9/+20
Jeremy. (This used to be commit c682fae16a2fa18f951c69ba29b1a576f4e27d6b)
2003-10-09At least give a message if we're returning a short read for W2K compatibility.Jeremy Allison1-2/+12
Jeremy. (This used to be commit 84c993d9cd0bc57a8b8b9aa716af1336620e2c87)
2003-10-09Changes to allow Samba3 to pass the Samba4 RAW-READ tests.Jeremy Allison1-8/+39
Jeremy. (This used to be commit e7565dbba696adbb0fd8cca6b86a1a7e5a655f2e)
2003-10-08Fixup error code returns from Samba4 tester. Ensure invalid paths areJeremy Allison1-32/+128
validated the same way. Jeremy. (This used to be commit 6ad2f0ba27566ab3928ccbbbb3c3a64b09ca139c)
2003-09-29Take care of condition where DOS and NT error codes must differ. Found byJeremy Allison1-1/+1
DOS program test by Amir Hardon <hardon@actcom.co.il>. Jeremy. (This used to be commit c11a7e5846002b16d0cb2991b5a7df0636b070d5)
2003-09-08Protect against core dump if ioctl for print job sends invalid fid. FoundJeremy Allison1-1/+5
by Iskantharajah T <is@tracetec.com.my>. Jeremy. (This used to be commit a9f9dd71da41801c975303a385ff229788c9498a)
2003-08-19Implement SMBexit properly. Found by Samba4 tester. You must do a makeJeremy Allison1-0/+3
clean proto all; after this commit. Jeremy. (This used to be commit 27af1f9feab12542dc538bfceac4593e644ba3b4)
2003-08-19Fix flush of 0xFFFF - found by Samba4 tester.Jeremy Allison1-2/+4
Jeremy. (This used to be commit 8a5c97fa07eacd4cecb5afd9c197352dfa613b9f)
2003-08-19Don't return DOS error on SMBsearch return if using NT error codes (NT1Jeremy Allison1-8/+10
protocol level). Fix for Samba4 tester. Jeremy. (This used to be commit 74486ab9efbb555f830b0e5d1c88f7bf065ae039)
2003-08-16Implemented the level 1010 NT rename level. Many fixes for Samba4 testJeremy Allison1-18/+152
correctness. Jeremy. (This used to be commit f57429befa43d63ed9a6e19b854e22fd4151db40)
2003-08-14Fix changing of attributes via setattr. Samba4 test fixes.Jeremy Allison1-6/+11
Jeremy. (This used to be commit 97e1d5c9573513c9c9be9a709341bda54fbe44be)
2003-08-14Fix SMBseek and get/set position information SMBs. Works againstJeremy Allison1-24/+9
Samba4 tester. You will need a make clean; make all after this ! Jeremy. (This used to be commit 10d90171ed58bee3e5ab6476341059b585034134)
2003-08-13Better path checking for chkpth. We now pass Samba4 chkpath and unlink.Jeremy Allison1-4/+25
Jeremy. (This used to be commit 00a57b0953c40a0ad6780eae84b4c558e21dbcfd)
2003-08-13More chkpth fixes from Samba4 tests.Jeremy Allison1-2/+15
Jeremy. (This used to be commit a62cf6bf16e2f435f504e936c31992f5697a309a)
2003-08-13Ensure we pass the Samba4 unlink test !Jeremy Allison1-1/+9
Jeremy. (This used to be commit 73aaf8094c2fed76b6650afbd8ff4f050f5e52d2)
2003-08-12Fix another error code return against Samba4 test suite... Don't allowJeremy Allison1-0/+4
a path above root. Jeremy. (This used to be commit 9bc0e4fe04c4134add428c889d316bd5ee4fb6e9)
2003-08-12Test invalid map system, map hidden, create mask, force create maskJeremy Allison1-1/+1
parameters. Fix return code for Samba 4 torture tester. Jeremy. (This used to be commit c043835c878ff062cb6eede02334f9e0ebb01050)
2003-07-29Fix bug #226. Stop unmangle of name into a wildcard name from deleting moreJeremy Allison1-9/+20
than was intended. Jeremy. (This used to be commit e2742e0d897a35820a7d8f184292c32a4c3952e3)
2003-07-27Try again to fix up 'session request' name exchange. This time we actualyAndrew Bartlett1-11/+4
get the names... Andrew Bartlett (This used to be commit 7c9e204f7eb15139532f2cc522ed87d0ac34d118)
2003-07-18make sure we don't allow the creation of directories containingAndrew Tridgell1-1/+5
wildcard characters. I've only put this in mkdir at the moment, but I suspect this will apply to all places that can create new filenames. We need to allow the opening of existing filenames that contain wildcards, but not allow the creation of new ones. (This used to be commit 2fd5569938b8970f3e9d761eecad5bc0b8bb267e)
2003-07-18Signing so far... the client code fails on a SMBtrans2 secondary transactionJeremy Allison1-2/+2
I think (my changes haven't affected this I believe). Initial support on the server side for smbclient. Still doesn't work for w2k clients I think... Work in progress..... (don't change). Jeremy. (This used to be commit e5714edc233424c2f74edb6d658f32f8e0ec9275)
2003-07-17Don't allow read/write raw when signing is active.Jeremy Allison1-0/+8
Jeremy. (This used to be commit 8d2a848052df03dad7bfeb5e7be96f8e9a509bbf)
2003-06-13Fix an spelling mistake.Richard Sharpe1-1/+1
(This used to be commit 8e37c1d579ed801fd602d698174f981deff435d9)
2003-06-06SMBlockingX timeouts are in units of 2 milliseconds, not 1Andrew Tridgell1-1/+1
(This used to be commit 999cde3227210c90132ade3812e964087f04e541)
2003-06-06make the allocation_size consistent between trans2 QFILEINFO and SMBgetattrEAndrew Tridgell1-1/+2
(This used to be commit 59f1a5e6fd783b977f787dae4ba4bb8b65c41e43)
2003-05-14Prefix VFS API macros with SMB_ for consistency and to avoid problems with ↵Alexander Bokovoy1-27/+27
VFS_ macros at system side. We currently have one clash with AIX and its VFS_LOCK. Compiled and tested -- no new functionality or code, just plain rename of macros for yet-unreleased VFS API version. Needs to be done before a24 is out (This used to be commit c2689ed118b490e49497a76ed6a2251262018769)