summaryrefslogtreecommitdiff
path: root/source3/smbd/reply.c
AgeCommit message (Collapse)AuthorFilesLines
2007-10-10r24085: Convert reply_rmdir to the new APIVolker Lendecke1-15/+24
(This used to be commit 7689048d71cc4adbdaee5521cc57890518e7090a)
2007-10-10r24084: Convert reply_mkdir to the new APIVolker Lendecke1-15/+24
(This used to be commit e93f3996fcdde6f0fbba3fb9e1e97407e9ccdd62)
2007-10-10r24079: Convert reply_dskattr to the new APIVolker Lendecke1-14/+14
(This used to be commit c8e0aa5752fde34f7271a4fad758dfae0991722d)
2007-10-10r24077: Convert reply_tdis to the new APIVolker Lendecke1-10/+7
(This used to be commit bd0cb48dde401f48dec98fa7ca794a912e0244f1)
2007-10-10r24071: Fix a missing END_PROFILE callVolker Lendecke1-0/+1
(This used to be commit c9f12326dd1c090bd0ef9bb97c82926c2efd6ae8)
2007-10-10r24004: Convert reply_checkpath to the new APIVolker Lendecke1-16/+23
(This used to be commit e5c7c6406af5552b3060f03a09b5e6c9a42e531c)
2007-10-10r24003: Convert reply_tcon_and_X to the new APIVolker Lendecke1-44/+72
(This used to be commit 9422385d9c018a0b1f2a0b2edd82dc574a9fb403)
2007-10-10r23999: Convert reply_open_and_XVolker Lendecke1-49/+78
This is an example of chained code that is executed in make test (This used to be commit e3a10e9ffb06f429208f8b8e8482bbfd56dace91)
2007-10-10r23998: Convert reply_close to the new APIVolker Lendecke1-12/+19
(This used to be commit dbf74cb747d34dac571d85d6bae9398558086456)
2007-10-10r23997: Check in the infrastructure for getting rid of the global ↵Volker Lendecke1-14/+29
InBuffer/OutBuffer The complete history of this patch can be found under http://www.samba.org/~vlendec/inbuf-checkin/. Jeremy, Jerry: If possible I would like to see this in 3.2.0. I'm only checking into 3_2 at the moment, as it currently will slow down operations for all non-converted (i.e. all at this moment) operations, as it will copy the talloc'ed inbuf over the global InBuffer. It will need quite a bit of effort to convert everything necessary for the normal operations an XP box does. I have patches for negprot, session setup, tcon_and_X, open_and_X, close. More to come, but I would appreciate some help here. Volker (This used to be commit 5594af2b208c860d3f4b453af6a649d9e4295d1c)
2007-10-10r23992: Some constVolker Lendecke1-2/+2
(This used to be commit bc106cf50732ed6c169dcf593797501fcb3ae675)
2007-10-10r23913: Revert back to Volker's original logic to fix theJeremy Allison1-1/+1
RAW-SFILEINFO-RENAME until I can figure out what is different from the way CIFSFS drives this in the cthon tests and the way smbtorture drives it. Jeremy. (This used to be commit 99f72dd9af82921de4827b9b9d90d75127332295)
2007-10-10r23911: Revert r23910 to try and fix the build farm. IJeremy Allison1-9/+0
need to look at this more closely tomorrow. Stevef's cthon tests definately show we're not matching Windows behaviour (as his tests pass against Windows but not SAMBA_3_2) but this isn't the fix. Jeremy. (This used to be commit 90bbc077e15de0493dccda50be9bcdf6e2649137)
2007-10-10r23910: We used to deny renames on theJeremy Allison1-0/+9
source open for non-delete open. Turns out this is not the case. VL please test but this matches Windows behaviour. (I'll add a torture test tomorrow). Jeremy. (This used to be commit 03e3d587468ce66044814a8a58308b2fe9ab5499)
2007-10-10r23909: Get closer to passing the cthon tests for delete open file.Jeremy Allison1-3/+6
It matters how the target is open. Jeremy. (This used to be commit 0989877fd191f7c9e195dc6e45dda5fd026f09dd)
2007-10-10r23904: Remove an unused variable referenceVolker Lendecke1-1/+0
(This used to be commit 7f4ceb1bf0c7aad50d93bb963c49dbc405e9524a)
2007-10-10r23902: Fix uninitialized read in devicetype noticed by Volker.Jeremy Allison1-1/+1
Jeremy (This used to be commit 98c23939731654440d2f008e44e11371eaddf014)
2007-10-10r23858: Added srvstr_pull_buf_talloc() and srvstr_pull_talloc()Jeremy Allison1-42/+73
calls and converted reply_tcon and reply_tconX to use them - to show the boilerplate usage (valgrind tested). In conjunction with Volker's srvstr_get_path_talloc() work this should allow us to start eliminating all pstrings/fstrings out of the main path processing code. I'll watch the build farm tonight... Jeremy. (This used to be commit b4eff3f68089f082781afcf90d43faa317949566)
2007-10-10r23784: use the GPLv3 boilerplate as recommended by the FSF and the license textAndrew Tridgell1-2/+1
(This used to be commit b0132e94fc5fef936aa766fb99a306b3628e9f07)
2007-10-10r23779: Change from v2 or later to v3 or later.Jeremy Allison1-1/+1
Jeremy. (This used to be commit 407e6e695b8366369b7c76af1ff76869b45347b3)
2007-10-10r23752: Fix bug introduced by checkin 22920, allow largeJeremy Allison1-3/+1
readX. Fix from Dmitry Shatrov <dhsatrov@linux.vnet.ibm.com>. "In send_file_readX(), if startpos > sbuf.st_size, then smb_maxcnt is set to an invalid large value due to integer overflow. As for me, this resulted in MS Word hanging while trying to save a 1.5Mb document." This isn't in shipping code. Jeremy. (This used to be commit af715c602a8ef6038e6272c7cc6a08501617ae67)
2007-10-10r23731: Forgot one reference to inbufVolker Lendecke1-1/+1
(This used to be commit b02115f2ca6aca8655a4ebd1bd0adaa1e50578ce)
2007-10-10r23727: Explicitly pass down FLAGS2 to srvstr_get_path.Volker Lendecke1-25/+55
Next step is to remove the bug that in the trans2 code we use the inbuf as the base pointer to decide whether we need ucs2 alignment where we need to use the beginning of the params buffer Jeremy, last one for today to reviw :-) (This used to be commit 18078b9faa3820fb34604063c9079c1ebe3ad47f)
2007-10-10r23726: Explicitly pass down the FLAGS2 field to srvstr_pull_buf. The nextVolker Lendecke1-9/+18
checkin will pull this up to srvstr_get_path. At that point we can get more independent of the inbuf, the base_ptr in pull_string will only be used to satisfy UCS2 alignment constraints. (This used to be commit 836782b07bf133e9b2598c4a089f1c810e4c7754)
2007-10-10r23724: Reduce access to the global inbuf a tiny bit. Add a struct smb_requestVolker Lendecke1-22/+42
that contains some of the fields from the SMB header, removing the need to access inbuf directly. This right now is used only in the open file code & friends, and creating that header is only done when needed. This needs more work, but it is a start. Jeremy, I'm only checking this into 3_0, please review before I merge it to _26. Volker (This used to be commit ca988f4e79e977160d82e86486972afd15d4acf5)
2007-10-10r23538: Fix for wild-card rename: We can't return directly on error, we need toVolker Lendecke1-2/+2
CloseDir. (This used to be commit 48cdafc10a0eb615d79057ec9e235ffe9a85e016)
2007-10-10r23523: Gaa -- had renamed "name" to "path" and apparently not compiled afterVolker Lendecke1-1/+1
that.... Volker (This used to be commit 1a45ea28ced3775acd6127e05e844873ed23d40b)
2007-10-10r23522: Save us a kilobyte stack space in a hot code path: I can't see a reasonVolker Lendecke1-30/+23
why check_path_syntax should not be able to run in-line. The destination pointer either walks side by side with the source pointer or is decremented. So as far as I can see s>=d is true throughout the whole routine. Jeremy, I'm checking this only into 3_0 for now. Please review and ack or directly merge this to 3_0_26. Thanks, Volker (This used to be commit 34a13c82a3b72d6900614b57c58fbaefeeca8fa7)
2007-10-10r23517: After Jeremy has given is ack on irc:Volker Lendecke1-179/+61
Change rename_internals to open the file/directory and then call rename_internals_fsp. Two reasons: Remove code duplication and remove a race condition. The race condition was due to the fact that in can_rename the share mode check closed the file and then after that did the rename. (This used to be commit aa16d8a649d1a38593edd5ca94ed2c7d4291911b)
2007-10-10r23508: Fix sync_file() to return NTSTATUS and return thisJeremy Allison1-8/+50
on failure in the write path. Jeremy. (This used to be commit cd3f7dbee809fb40194af0e7509142166e02b252)
2007-10-10r23501: Move notify_rename before rename_internals_fsp and call it from there.Volker Lendecke1-42/+44
(This used to be commit 8d3828871c561cd05e6461e157db4c0ccddd5f22)
2007-10-10r23500: Two changes to survive the now activated test for rename_internals_fsp:Volker Lendecke1-2/+13
With the target being open we have to return NT_STATUS_ACCESS_DENIED and root_fid != 0 leads to NT_STATUS_INVALID_PARAMETER (This used to be commit b599e5b1e10bdf825b2ce53de4a6ec35726d00f6)
2007-10-10r23486: Ok, this time with a hopefully successful make test in the right place:Volker Lendecke1-18/+33
Remove two local variables (This used to be commit 575e594e936c3cb197945063309f0b424dcdefc8)
2007-10-10r23483: Revert 23482, I must have run 'make test' in the wrong subdir.Volker Lendecke1-14/+18
(This used to be commit 1ce0c582bccc90e54a69b1e70973ed7ccb47cbbb)
2007-10-10r23482: Slightly simplify the rename code: Remove two local variables that areVolker Lendecke1-18/+14
not really needed. (This used to be commit e068e38ef3b364f2c6477f9d8d6ef3b81a6207ca)
2007-10-10r23469: Fix a commentVolker Lendecke1-1/+1
(This used to be commit 47cc9359aa1b4d5fcd9469be0b1378030ac388fc)
2007-10-10r23467: Next little simplification: In rename_internals it's a bit pointless toVolker Lendecke1-38/+13
first ask for existence of a file when we do the open_file_ntcreate in can_rename later on anyway. That also gets us the right error message in case the file is not there automatically. (This used to be commit f3d582cb908f95c1b557bda5d41b5a8aff75b124)
2007-10-10r23466: Fix RAW-NOTIFY: by using delete on close the notify is triggered deepVolker Lendecke1-6/+0
inside close_file() already. (This used to be commit 0b29e3ad0f2b1759eb195fb37f1f8667d87f5670)
2007-10-10r23457: After Jeremy's ack:Volker Lendecke1-24/+29
The attached patch removes a little race condition for people with real kernel oplock support, and reduces some code paths. It changes reply_unlink to open_file_ntcreate, set_delete_on_close and close_file. The race condition happens if we break the oplock in can_delete via open_file_ntcreate, we close the file, someone else gets a batch oplock and we try to unlink. It reduces code paths by calling SMB_VFS_UNLINK in 2 fewer places. (This used to be commit 0342ce7057045a362134281bcc7030111276dea0)
2007-10-10r23445: Fix suggested by Volker. Don't call rename_open_filesJeremy Allison1-2/+0
if the name wasn't changed. Jeremy. (This used to be commit 7a9629365eb4eb2829982fe2b2bfffd840648e6f)
2007-10-10r23299: Fix the build for !WITH_SENDFILE.James Peach1-4/+3
(This used to be commit 87b92e7ebda018f1d6a588748e282dc1a2c50613)
2007-10-10r23183: Check in a change made by Tridge:Volker Lendecke1-20/+19
This replaces the internal explicit dev/ino file id representation by a "struct file_id". This is necessary as cluster file systems and NFS don't necessarily assign the same device number to the shared file system. With this structure in place we can now easily add different schemes to map a file to a unique 64-bit device node. Jeremy, you might note that I did not change the external interface of smb_share_modes.c. Volker (This used to be commit 9b10dbbd5de8813fc15ebbb6be9b18010ffe8139)
2007-10-10r23107: Fix renames on file descriptors that are supposed to overwrite theJeremy Allison1-3/+4
target. Needs merging for 3.0.25a (sorry). Jeremy. (This used to be commit a56bce3d44e89b4fd7806cc5b464c7481ec0197f)
2007-10-10r23100: Implement the delete on close semantics I've just tested forJeremy Allison1-7/+47
in Samba4 smbtorture. Fix rename on an open file handle. Needed for 3.0.25a. Jeremy. (This used to be commit a301467d5f645dada27093ddfd74890b88bb4ce8)
2007-10-10r23088: Fix rename for cifsfs client. This may be needed forJeremy Allison1-2/+2
3.0.25a. Jeremy. (This used to be commit 02e4f6b0f1f1a1cc6bfe5fed7866eb5b18ab87e0)
2007-10-10r23016: Remove extra & - thanks to Volker for spotting this.Jeremy Allison1-1/+1
Jeremy. (This used to be commit c2c970fd50b293031390358d72aaa7bd94da6e6d)
2007-10-10r23014: For all branches, ensure that if we're blocked on a POSIXJeremy Allison1-4/+9
lock we know nothing about that we retry the lock every 10 seconds instead of waiting for the standard select timeout. This is how we used to (and are supposed to) work. Jeremy. (This used to be commit fa18fc25a50cf13c687ae88e7e5e2dda1120e017)
2007-10-10r23007: Ensure we don't allow large read over the possibleJeremy Allison1-0/+4
packet size. Jeremy. (This used to be commit 5d465dd2d559df29d18a844137c8e14ffbb1a269)
2007-10-10r22925: Sync read_and_X with 3.0.26 code (use setup_readX_header()).Jeremy Allison1-6/+1
Jeremy. (This used to be commit e1052c0e3d50473a9ded6092b6a85d78590a00e7)
2007-10-10r22922: Move "normal_read:" label out of ifdef guard. Fix the build.Jeremy Allison1-2/+2
Jeremy. (This used to be commit 3c1ccc68f03b02d2223ec745e241129766e0c15e)