summaryrefslogtreecommitdiff
path: root/source3/smbd/reply.c
AgeCommit message (Collapse)AuthorFilesLines
2007-11-07Constrain "min receivefile size" to max of BUFFER_SIZEJeremy Allison1-2/+20
(128k). Add debug error messages so we can see why writeX large is denied. Ensure we don't allow recvfile writes on IPC$. Jeremy. (This used to be commit 6bf053a6a17749a3bc73c8cc5fd490aa5f93b763)
2007-11-05Remove the horror that was the global smb_rw_error.Jeremy Allison1-2/+3
Each cli struct has it's own local copy of this variable, so use that in client code. In the smbd server, add one static to smbd/proccess.c and use that inside smbd. Fix a bunch of places where smb_rw_error could be set by calling read_data() in places where we weren't reading from the SMB client socket (ie. winbindd). Jeremy. (This used to be commit 255c2adf7b6ef30932b5bb9f142ccef4a5d3d0db)
2007-11-02Change the client library to write directly out ofJeremy Allison1-5/+10
the incoming buffer in the non-signed case. Speeds up writes by over 10% or so. Complete the server recvfile implementation. Jeremy. (This used to be commit 81ca5853b2475f123faab3b550f0a7b24ae3c208)
2007-11-02Argggh. smblen doesn't include the +4, so my smb_doff calculationsJeremy Allison1-4/+4
shouldn't either :-). Jeremy. (This used to be commit c3de44b6b063e126095b30536fdcb643c70e395e)
2007-11-01Ensure we can't accidently do a pipe write withJeremy Allison1-0/+5
unread bytes in the socket buffer. Jeremy (This used to be commit 84d22f7747126608b9460f9591bb5967d871b82d)
2007-11-01Be careful and take care of the correct lengths in largeJeremy Allison1-9/+7
writeX calls. Jeremy. (This used to be commit 2d3ff9c502105f92720131355b41e48be8d656c2)
2007-11-01Ensure we detect a large writeX when using recvfile.Jeremy Allison1-1/+2
More changes needed to make the UNIX_LARGE_WRITEX_CAP writes work (I'll add these tomorrow). Jeremy. (This used to be commit 1c71546b6152d2930b98f766311bbd161ee0ee4e)
2007-10-31Fix some cases where file_set_dosmode was being passedJeremy Allison1-1/+1
False instead of NULL. Fix more of the notifications to be correct for Samba4 RAW-NOTIFY torture (we had missed one when calling set_ea_dos_attribute(). Jeremy. (This used to be commit 39d265375cf55eedddef2c4faa65398df73d5ed2)
2007-10-30Handle the disk full error case correctly.Jeremy Allison1-1/+1
Jeremy. (This used to be commit b7088bb9c2a00d4717b9a7efa4bddc0c005f4efb)
2007-10-30Add new parameter, "min receivefile size" (by default setJeremy Allison1-14/+81
to zero). If non-zero, writeX calls greater than this value will be left in the socket buffer for later handling with recvfile (or userspace equivalent). Definition of recvfile for your system is left as an exercise for the reader (I'm working on getting splice working :-). Jeremy. (This used to be commit 11c03b75ddbcb6e36b231bb40a1773d1c550621c)
2007-10-18RIP BOOL. Convert BOOL -> bool. I found a few interestingJeremy Allison1-52/+52
bugs in various places whilst doing this (places that assumed BOOL == int). I also need to fix the Samba4 pidl generation (next checkin). Jeremy. (This used to be commit f35a266b3cbb3e5fa6a86be60f34fe340a3ca71f)
2007-10-10[GLUE] Rsync SAMBA_3_2_0 SVN r25598 in order to create the v3-2-test branch.Gerald (Jerry) Carter1-15/+13
(This used to be commit 5c6c8e1fe93f340005110a7833946191659d88ab)
2007-10-10r25502: Fix bug 5006Volker Lendecke1-1/+1
Thanks to Joerg.Bernau at web.de (This used to be commit 492977016fa66ce0e98a5bdd1c0f00eacdf13f0c)
2007-10-10r25138: More pstring elimination. Add a TALLOC_CTX parameterJeremy Allison1-17/+20
to unix_convert(). Jeremy. (This used to be commit 39c211a702e91c34c1a5a689e1b0c4530ea8a1ac)
2007-10-10r25117: The mega-patch Jerry was waiting for. Remove all pstrings fromJeremy Allison1-181/+288
the main server code paths. We should now be able to cope with paths up to PATH_MAX length now. Final job will be to add the TALLOC_CTX * parameter to unix_convert to make it explicit (for Volker). Jeremy. (This used to be commit 7f0db75fb0f24873577dcb758a2ecee74fdc4297)
2007-10-10r25111: Move to talloced pathnames on most code paths.Jeremy Allison1-103/+146
There are now ony 17 pstrings left in reply.c, and these will be easy to remove (and I'll be doing that shortly). Had to fix an interesting bug in pull_ucs2_base_talloc() when a source string is not null terminated :-). Jeremy. (This used to be commit 0c9a8c4dff10974dbffd2a302ae982896122fcc0)
2007-10-10r25102: Rewrite msdfs code to use talloced filenames. Passes make testJeremy Allison1-90/+123
and make valgrindtest. Final step will be to change srvstr_get_path() to return talloced memory in the major codepaths. Jeremy. (This used to be commit cf6b6f9c3a38b68d2671c753f412772344506742)
2007-10-10r25055: Add file_id_string_tosVolker Lendecke1-2/+2
This removes file_id_string_static and file_id_string_static2 (This used to be commit 638c848c9afe374feb30e34c494f89b2a6c64f7b)
2007-10-10r25009: Large patch discussed with Volker. Move unix_convert to a talloc-basedJeremy Allison1-177/+312
interface. More development will come on top of this. Remove the "mangled map" parameter. Jeremy. (This used to be commit dee8beba7a92b8a3f68bbcc59fd0a827f68c7736)
2007-10-10r24702: Remove the old API pointersVolker Lendecke1-9/+6
(This used to be commit 17df313db42199e26d7d2044f6a1d845aacd1a90)
2007-10-10r24659: Some formatting changes helping to minimize the 3_2_0 diffVolker Lendecke1-8/+8
(This used to be commit c5caea43af154671448df82881efe09a5c982386)
2007-10-10r24548: Fix the case-changing renamesVolker Lendecke1-14/+9
This was broken when I changed reply_mv to wrap in a open_file_ntcreate call, unix_convert on the destination was called twice (This used to be commit fddc9db91175bdb0b7ac6a636f8bef918bd7c1b4)
2007-10-10r24501: Added bcc test for reply_tcon & removed Vl's comment :-).Jeremy Allison1-6/+5
Jeremy. (This used to be commit 9d9ed41f2139051578c35f80112640cffb5f7608)
2007-10-10r24498: More extra code into a function, reply_openerror.Jeremy Allison1-38/+5
Jeremy. (This used to be commit 43ddfb8c918bd27e2efd3b54077db815da80a53a)
2007-10-10r24476: Fix the mappings in reply_opeXXX calls. Now to test renames.Jeremy Allison1-7/+24
Jeremy. (This used to be commit 74d10b09a68f5c06d6b3ceffe0a40818dc84106e)
2007-10-10r24461: Fix Bug 4852, thank to anto <sistemac@prosoft.ba> for reporting it.Volker Lendecke1-0/+14
(This used to be commit 0fecd8a0c3aaa64e137d2efd3f9cc7705837ea2a)
2007-10-10r24457: Convert reply_tcon to the new APIVolker Lendecke1-29/+25
Jeremy, I really apologize for doing this, but I just wanted to enjoy converting the last SMB call :-) I've left one little task for you there, I'm not certain that checking the inbuf length is correct here. Volker (This used to be commit 1e08fddafda11961f8855423b29c1f8a9a6b4457)
2007-10-10r24453: Remove the read and write bmpx callsVolker Lendecke1-256/+28
Talked to both Tridge and Jeremy about this, Tridge said that there is a special error message persuading OS/2 to fall back to other methods. The calls now checked in always return the error message we used to return when "read bmpx = False" was set (the default): ERRSRV, ERRuseSTD. If someone has a reproducable test case where this is really needed, we can always dig it up from version control and convert it to the new API. But that time without that silly parameter, and with a torture test case for "make test" please :-) Volker (This used to be commit d941aae2dfd11609e807bf4ce712571a2e354627)
2007-10-10r24445: Convert SMBwritebraw. No test suite unfortunately.... I need to ↵Jeremy Allison1-61/+150
write one for this. Jeremy (This used to be commit edc17dfcbd21cccaffb76f4ae67fe4b06520f1a9)
2007-10-10r24443: Convert reply_search/fclose to the new APIVolker Lendecke1-57/+95
(This used to be commit a8a33c377e38046b4103cf1d59032b97ab6bac9a)
2007-10-10r24442: Convert reply_copy to the new APIVolker Lendecke1-38/+84
(This used to be commit 0cb00c54750837ab2d2dc12e4947fedb7d38e878)
2007-10-10r24441: Convert reply_ioctl to the new APIVolker Lendecke1-20/+36
(This used to be commit a5af7ebb7f1d869659fbab187652e68ec4fafbb8)
2007-10-10r24439: Convert reply_get/setattrE to the new APIVolker Lendecke1-25/+50
(This used to be commit 6b0ad071d85ddd8fbf24386db11688bde49baf81)
2007-10-10r24436: Convert reply_lockread/writeunlock to the new APIVolker Lendecke1-40/+78
(This used to be commit 1b6add251ca1db565a03407db30884132dd93e7d)
2007-10-10r24431: Convert the reply_printXX calls to the new APIVolker Lendecke1-47/+107
(This used to be commit e528479f56bc936cc60eb95c9738a48de48dbd05)
2007-10-10r24430: Convert reply_writeclose to the new APIVolker Lendecke1-18/+36
(This used to be commit 6def2ee03bb3510f000b1977c4d5293cad4ae364)
2007-10-10r24429: reply_setdir is not used...Volker Lendecke1-53/+0
(This used to be commit ca27a718b07949959efaeb49f310123de76af9a0)
2007-10-10r24428: Convert reply_unlock to the new APIVolker Lendecke1-11/+24
(This used to be commit 01c7426fc0e2af6a955dcb37111ca439fc913d5f)
2007-10-10r24427: Convert reply_lock to the new APIVolker Lendecke1-10/+22
(This used to be commit 212f43ddeaa6369e5437ed3915eb066a37bc9014)
2007-10-10r24426: Convert reply_read to the new APIVolker Lendecke1-19/+40
(This used to be commit 30aada0ef8e16ce94035039b63ab140d158009d9)
2007-10-10r24425: Convert reply_write to the new APIVolker Lendecke1-21/+40
(This used to be commit 244965f7b67becb85774311e6ce84318d554384d)
2007-10-10r24423: Convert reply_lseek to the new APIVolker Lendecke1-12/+25
(This used to be commit bd228853863ce5b4b9b974347c50c956d7f2e055)
2007-10-10r24422: Convert reply_ctemp to the new APIVolker Lendecke1-33/+52
(This used to be commit 3cc22fd74f0ffc72f4340a963b4eca7178be2192)
2007-10-10r24417: Convert reply_setatr to the new APIVolker Lendecke1-19/+34
(This used to be commit 56bab5ea4cbcf8e46101053bd68f66691fd737c5)
2007-10-10r24415: Convert reply_getatr to the new APIVolker Lendecke1-20/+30
(This used to be commit 1a08b97a933e25362707cb0d8ba09d733af4cbbf)
2007-10-10r24414: Convert reply_mv to the new APIVolker Lendecke1-26/+45
(This used to be commit fa341e4840d422cee389c06112e0b2df43a31f45)
2007-10-10r24412: Convert reply_open to the new APIVolker Lendecke1-37/+50
(This used to be commit 394987f5224086cb379ea8d0364924679b8a0214)
2007-10-10r24409: Check wct in reply_openVolker Lendecke1-2/+8
(This used to be commit ee6f212ed0b332e6886056e6d254d0c0da7c5046)
2007-10-10r24408: Remove reply_prep_legacy from reply_lockingXVolker Lendecke1-24/+22
(This used to be commit e0db5fd11bd5e0a3aca801a14509fddd6a625a84)
2007-10-10r24406: Push reply_prep_legacy into reply_lockingXVolker Lendecke1-17/+48
(This used to be commit bce87ebdc00b9086dcdcc55442b57b92345971ac)