summaryrefslogtreecommitdiff
path: root/source3/smbd/reply.c
AgeCommit message (Collapse)AuthorFilesLines
2007-10-10r22391: Looks bigger than it is. Make "inbuf" availableJeremy Allison1-62/+62
to all callers of smb_setlen (via set_message() calls). This will allow the server to reflect back the correct encryption context. Jeremy. (This used to be commit 2d80a96120a5fe2fe726f00746d36d85044c4bdb)
2007-10-10r22389: Start preparing for multiple encryption contexts in theJeremy Allison1-4/+4
server. Allow server to reflect back to calling client the encryption context that was sent. Jeremy. (This used to be commit b49e90335d1e589916b5ab4992e3c4a2d221ca7e)
2007-10-10r22291: Fix off-by-one in tconX parsing.Jeremy Allison1-2/+11
Jeremy. (This used to be commit bc6ac4feac8c62cda2b6151eb648d3d5979e8a95)
2007-10-10r22145: Fix bug #4494 - reported by Kevin Jamieson <bugzilla@kevinjamieson.com>.Jeremy Allison1-1/+3
If returning a mapped UNIX error from sendfile, don't call chain_reply. Jeremy. (This used to be commit 38404c990db1436241c3a774c51196bc058d7576)
2007-10-10r22122: Start to fix csc issue with Vista. Make smbd supportJeremy Allison1-1/+22
the extended 7 word response for tconX rather than the 3 word one we supported previously. Jeremy. (This used to be commit 137953226a2d691259e7e84d6ae0dc24755e5a3a)
2007-10-10r21801: Fix Coverity ID # 342Volker Lendecke1-0/+1
(This used to be commit 8700cd71bb3af3a55f025b34b61062aa5b66b6bc)
2007-10-10r21800: Check-in the DFS rewrite. I am still testing this but itJeremy Allison1-45/+135
works from smbclient and Windows, and I am promising to support and fix both client and server code moving forward. Still need to test the RPC admin support but I haven't changed that code. Jeremy. (This used to be commit 7a7862c01d07796ef206b255c676ad7dc2cc42fc)
2007-10-10r21770: For old DOS style searches we must remember ifJeremy Allison1-0/+5
the initial search had a wildcard in order to correctly return no error on end of search. Found by Samba4 torture tester. Jeremy. (This used to be commit c74bcf7677123f273d44181ca053ba49b8c7ddae)
2007-10-10r21769: Attempt to fix bug #4384 in old search code.Jeremy Allison1-14/+4
We were accessing a pathname that hadn't gone through unix_convert ! That's a big no-no... Jeremy. (This used to be commit 33a67fd39e1a51944bf0783350aa6ef95dfafb84)
2007-10-10r21754: Volker is completely correct. There's no need forJeremy Allison1-16/+64
the RESOLVE_DFSPATH macros and their varients any more. Fix reporting profile bug with all error returns. Jeremy. (This used to be commit cdf0fdb1049fd68b46885cbea887dc0e595fa524)
2007-10-10r21714: Change the VFS interface to use struct timespecJeremy Allison1-21/+22
for utimes - change the call to ntimes. This preserves nsec timestamps we get from stat (if the system supports it) and only maps back down to usec or sec resolution on time set. Looks bigger than it is as I had to move lots of internal code from using time_t and struct utimebuf to struct timespec. Jeremy. (This used to be commit 8f3d530c5a748ea90f42ed8fbe68ae92178d4875)
2007-10-10r21672: The cannonical file access pattern should look like this :Jeremy Allison1-161/+256
srvstr_get_path(inbuf, name, smb_buf(inbuf) + 1, sizeof(name), 0, STR_TERMINATE, &status); if (!NT_STATUS_IS_OK(status)) { return ERROR_NT(status); } RESOLVE_DFSPATH(name, conn, inbuf, outbuf); status = unix_convert(conn, name, False, NULL, &sbuf); if (!NT_STATUS_IS_OK(status)) { return ERROR_NT(status); } status = check_name(conn, name); if (!NT_STATUS_IS_OK(status)) { return ERROR_NT(status); } Make sure that every access pattern (including the wildcard generated paths from unlink, rename, and copy) do the same. Tidy things up a bit.... Jeremy. (This used to be commit b8327b21ddf518d34c6cd6c01bd7fc0fd3f63c0c)
2007-10-10r21191: Add in the POSIX open/mkdir/unlink calls.Jeremy Allison1-31/+23
Move more error code returns to NTSTATUS. Client test code to follow... See if this passes the build-farm before I add it into 3.0.25. Jeremy. (This used to be commit 83dbbdff345fa9e427c9579183f4380004bf3dd7)
2007-10-10r21093: Remove the hash and dnotify backends. Disabling FAM for this ↵Volker Lendecke1-3/+3
checkin, I'm working on that right now. Volker (This used to be commit 01c9fb17281e99300b339d2cfc0acac7ca94843c)
2007-10-10r21089: Do notifies on renameVolker Lendecke1-0/+44
(This used to be commit 2aadb95a7e58777ee7ff024cc9e14f4334970d50)
2007-10-10r21087: Make the param list of notify_fname match notify_triggerVolker Lendecke1-6/+8
(This used to be commit defa28f9c3eda85a072b972fffd2d5de8bcf01f7)
2007-10-10r21080: ReformattingVolker Lendecke1-37/+68
(This used to be commit 705f866a78ec3f1169543bf82fb48ea6580160a9)
2007-10-10r21079: Minimizing diff: Adopt the Samba4 style ChangeNotify flags.Volker Lendecke1-2/+2
Volker (This used to be commit a3c1069b0c3da914e2ac7337fd9e924b1c811d39)
2007-10-10r21057: More refactoring into functions.Jeremy Allison1-2/+2
Jeremy. (This used to be commit fe2d7cb2dcd7c4d25d71f196aa557ce3e287bb4c)
2007-10-10r20931: This changes the notify infrastructure from a polling-based to an ↵Volker Lendecke1-11/+0
event-driven based approach. The only remaining hook into the backend is now void *(*notify_add)(TALLOC_CTX *mem_ctx, struct event_context *event_ctx, files_struct *fsp, uint32 *filter); (Should we put this through the VFS, so that others can more easily plug in?) The trick here is that the backend can pick filter bits that the main smbd should not handle anymore. Thanks to tridge for this idea. The backend can notify the main smbd process via void notify_fsp(files_struct *fsp, uint32 action, char *name); The core patch is not big, what makes this more than 1800 lines are the individual backends that are considerably changed but can be reviewed one by one. Based on this I'll continue with inotify now. Volker (This used to be commit 9cd6a8a82792b7b6967141565d043b6337836a5d)
2007-10-10r20877: Random notify fixesVolker Lendecke1-13/+8
(This used to be commit 2f1bfc53733ac3debc6a8b51642ab191869cd792)
2007-10-10r20873: Some correctness fixes w.r.t. Samba4 torture BASE-DELETE.Jeremy Allison1-1/+10
Allow us to correctly refuse to set delete on close on a non-empty directory. There are still some delete-on-close wrinkles to be fixed, but I understand how to do that better now. I'll fix this tomorrow. Jeremy. (This used to be commit 029635885825a5562e7974a6f5675cce3bf1b5dc)
2007-10-10r20854: Ok, now I think we're at a point where looking at notify starts to ↵Volker Lendecke1-2/+21
make sense again :-) Volker (This used to be commit 5533cdeec1b0cdee39b1d89e2320587dc9281ee6)
2007-10-10r20844: Somewhat radical change - this may break the build (I willJeremy Allison1-177/+212
watch carefully - so I'm doing it in one transaction so I can roll back). Change check_name(), reduce_name() and dptr_create() to return NTSTATUS. This helps a lot in error path processing and especially in reduce_name() allows us to ditch the flaky and error-prone saving of errno and return errors directly. Jeremy. (This used to be commit 6133a694aa429d638320e39ffe1c49d172583ccf)
2007-10-10r20843: Get rid of last BOOL ok.Jeremy Allison1-58/+59
Jeremy. (This used to be commit a36d446fb612f87654c645f6507d413b95efaf21)
2007-10-10r20842: Only one more BOOL ok to go...Jeremy Allison1-12/+6
Jeremy. (This used to be commit de0bf477dab1d57b5f7bc6bf70d8e76f9bfac63f)
2007-10-10r20841: Remove more BOOL ok.Jeremy Allison1-6/+6
Jeremy. (This used to be commit c6b651966039b1c21facd4c4789bf873b5b49426)
2007-10-10r20840: Keep removing the old BOOL ok logic.Jeremy Allison1-5/+9
Jeremy. (This used to be commit 224ff059915b2c92ec86d2c3c4b10c3bc552ffa2)
2007-10-10r20796: Fix the same problem Jeremy has fixed (improper handling of deferred ↵Volker Lendecke1-6/+10
opens) for delete_driver_files. Proper fix pending... :-) Jeremy, please check. Volker (This used to be commit 21b8f15dd5ad567efeacf5ba22dc4d8c64b09b76)
2007-10-10r20759: Dummy checkin to let the build farm pick up the new smbtorture4Volker Lendecke1-1/+2
(This used to be commit 14c88b560e5c8fd59b84333e92337805620ccd7c)
2007-10-10r20743: Remove another BOOL ok from reply_getatr.Jeremy Allison1-20/+15
Jeremy. (This used to be commit c154f430710a4646fac42774817dfed7b936b087)
2007-10-10r20742: Rename chkpth -> checkpath for sanity's sake :-).Jeremy Allison1-35/+35
Start removing unneeded "BOOL ok" from this reply.c (this logic is old, old, old..... :-). Jeremy. (This used to be commit 3d52268095c605a80dfcd371769198a332baa0a5)
2007-10-10r20740: Get rid of some if-statementsVolker Lendecke1-14/+10
(This used to be commit db93c1b98d5445071ad0af229afed1f11ab0a862)
2007-10-10r20721: Fix the search unix_convert error returns. Only openJeremy Allison1-1/+1
to go... Jeremy. (This used to be commit 89f03a8db40365f99c6755ff19a4bfbf8d1bd316)
2007-10-10r20720: Fix the chkpath problem, still looking at findfirst.Jeremy Allison1-0/+7
Jeremy. (This used to be commit c5be0082ef60cd041121a9c36f4af934cd60562d)
2007-10-10r20718: Sync up the filename path parsing changes from SAMBA_3_0_24.Jeremy Allison1-466/+219
The only difference between the two trees now w.r.t file serving are the changes to smbd/open.c in this branch I need to review. Jeremy. (This used to be commit f4474edf6a0c71001dbd01429ef70bafad6abd74)
2007-10-10r20635: Add placeholder to ensure we don't go into theJeremy Allison1-0/+11
wcard unlink if bad_path was set. The error returned here is almost certainly incorrect and will need testing properly with smbtorture, but I don't want to forget about this path (yes Volker I know this is currently incorrect :-). Jeremy. (This used to be commit 06e20c287898d21e437ab117eb5eeeaf2420ba78)
2007-10-10r20634: A *LOT* more work is necessary before touching notify remotely ↵Volker Lendecke1-17/+0
starts to make sense. Until then, remove it from the tree to keep the diff between 3_0_24 and 3_0 small. Volker (This used to be commit f146a85e74c84e78a11e616a1cbeaeef4693a0e0)
2007-10-10r20632: The extended RAW-SAMBA3BADPATH test led me to some wrong assumptions, inVolker Lendecke1-53/+59
particular the NT_STATUS_INVALID_PARAMETER thing was badly wrong. Remove the changes based on it. Using gentest is much more effective in this respect, but it will take a while to figure out the wildcard error handling of W2k3. Volker (This used to be commit 58b8a242a7f08c1292d24fc73df170dbcd68c10d)
2007-10-10r20628: Looks bigger than it is. This is just re-indenting the if (dirname) ↵Volker Lendecke1-40/+38
that we've taken care of above. Volker (This used to be commit 5e1da363bb3f2675beb9fd9240301bb432e5239b)
2007-10-10r20627: orig_name is not needed anymore, and slightly simplify logic by ↵Volker Lendecke1-9/+8
doing early returns. Volker (This used to be commit 614651c6a72742173de5fa8723403880acc37c09)
2007-10-10r20619: bad_path is handled somewhere else, so can_delete does not need it ↵Volker Lendecke1-11/+3
anymore (This used to be commit 1798987128be579a1a4574294a7c3094040ebaf2)
2007-10-10r20618: Fix a bug in bad_path handling that also exists in 3.0.23: For ↵Volker Lendecke1-0/+5
reply_unlink under Linux we returned NT_STATUS_NOT_A_DIRECTORY. This is because in the bad_path==True condition lstat(2) returns ENOTDIR and not ENOENT. Not sure if we want to necessarily replicate the INVALID_PARAMETER here, but this is what W2k3 does. Jeremy, I tried to call you, but you were not around. So I'll leave it up to you to merge this. Volker (This used to be commit b1edc3d053104204b966eed67d070ad5da40f17b)
2007-10-10r20617: Do not notify if the delete failedVolker Lendecke1-5/+7
(This used to be commit c86fbdf8cc8f6f17b23e647bd1f4714c6095b860)
2007-10-10r20612: A checkin I've wanted to do for ages: For bad_path==False ↵Volker Lendecke1-9/+8
set_bad_path_error is equivalent to UNIX_ERROR. Expand the last reference. Lets see if I can kill that as well :-) Volker (This used to be commit 794d5d38f19601bb5b30b965b41b844aacf1caeb)
2007-10-10r20611: All but one callers to set_bad_path_error have had the ↵Volker Lendecke1-2/+4
bad_path==True argument being handled further up. Volker (This used to be commit 358673c36697a16aa87f9cebbace34abf16ed28e)
2007-10-10r20607: Next micro-step for reply_setatrVolker Lendecke1-8/+6
(This used to be commit cea9a01434490fb8a17c3f12db7a092efda21186)
2007-10-10r20606: bad_path == True has been covered further up in reply_setatr.Volker Lendecke1-1/+2
I'm checking in micro-steps to make them independently checkable. This code just very severely needs cleanup, but I don't want to break anything. So, be patient with me, please :-) Volker (This used to be commit c16775486baa89901f0d5126cb926c9e5a807743)
2007-10-10r20605: Simplify logic in reply_setatr slightlyVolker Lendecke1-4/+2
(This used to be commit f19db8f33ed3749f6b72ae3a4cee83574c606e88)
2007-10-10r20597: Survive some of the notify mask tests.Volker Lendecke1-9/+1
(This used to be commit e4a2e63272dc5b20413597179d06b0185c4a6817)