summaryrefslogtreecommitdiff
path: root/source3/smbd/smb2_server.c
AgeCommit message (Collapse)AuthorFilesLines
2012-07-03s3: Fix Coverity ID 709217 Dereference after null checkVolker Lendecke1-2/+10
A few lines before we did check for x != NULL. I think this might fix a potential remote crash. Signed-off-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Tue Jul 3 15:30:17 CEST 2012 on sn-devel-104
2012-07-03s3:smbd:smb2: change smbXsrv_tcon0 to smbXsrv_tcon in ↵Michael Adam1-1/+1
smbd_smb2_request_check_tcon() smbXsrv_tcon0 is the internal name for the (current) version0 of the structure. Externally, only smbXsrv_tcon should be used.
2012-06-29s3:smb2_server: remove max_charge check in ↵Stefan Metzmacher1-16/+0
smbd_smb2_request_verify_creditcharge() The client can send any credit charge value, it's ok to send more than needed. metze Signed-off-by: Michael Adam <obnox@samba.org>
2012-06-29s3:smb2_server: make the logic in smbd_smb2_request_verify_creditcharge() ↵Stefan Metzmacher1-11/+23
simpler We just need a max_charge variable to make the algorithm independent of multi_credit support. metze
2012-06-29s3:smb2_server: simplify smbd_smb2_request_verify_creditcharge() a bit.Stefan Metzmacher1-6/+1
A credit charge of 0 is really not a special case, it just means the same as 1. metze
2012-06-29s3:smb2_server: grant extra credits for multi-credit requestsStefan Metzmacher1-2/+10
metze
2012-06-29s3:smb2_server: implement credit granting similar to windowsStefan Metzmacher1-19/+50
This makes it much easier to compare traces. metze
2012-06-29s3:smb2_server: make sure sequence numbers don't wrap at UINT64_MAXStefan Metzmacher1-2/+17
metze
2012-06-29s3:smb2_server: make sure we don't grant more credits than we allowStefan Metzmacher1-31/+53
If the client hasn't consumed the lowest seqnum, but the distance between lowest and highest seqnum has reached max credits. In that case we should stop granting credits. metze
2012-06-29s3:smb2_server: check the credit_charge against the already granted creditsStefan Metzmacher1-7/+12
metze
2012-06-29s3:smb2_server: split out a smb2_validate_sequence_number() functionStefan Metzmacher1-40/+77
metze
2012-06-29s3:smb2_server: clear sequence window if we got the lowest sequence idStefan Metzmacher1-2/+2
Otherwise we'll never consume sequence id '0'. metze
2012-06-29s3:smb2_server: fix calculation of the next bitmap_offsetStefan Metzmacher1-1/+1
metze
2012-06-29s3:smb2_server: remove unused and confusing ↵Stefan Metzmacher1-7/+4
DEFAULT_SMB2_MAX_CREDIT_BITMAP_FACTOR metze
2012-06-29s3:smb2_server: call smbd_smb2_request_validate() also in ↵Stefan Metzmacher1-0/+6
smbd_smb2_first_negprot() We need to consume message_id 0, for SMB1 negprot starts. metze
2012-06-29s3:smb2_server: start the connection with one credit granted to the clientStefan Metzmacher1-1/+1
metze
2012-06-25s3:smb2_sesssetup: implement dynamic re-authentication and expire sessionsStefan Metzmacher1-5/+44
metze
2012-06-25s3:smbd: make use of smbXsrv_tcon and smbXsrv_session for smb2Stefan Metzmacher1-25/+23
The removes the protocol specific smbd_smb2_session and smbd_smb2_tcon. Pair-Programmed-With: Michael Adam <obnox@samba.org> metze
2012-06-25s3:smb2_sesssetup: make use of the smbXsrv_session infrastructureStefan Metzmacher1-22/+38
We still have smbd_smb2_session as primary structure, but that will went away once we got rid of smbd_smb2_tcon. metze
2012-06-15s3:smb2_server: remember the request_time on an incoming requestStefan Metzmacher1-0/+2
metze Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Fri Jun 15 09:17:33 CEST 2012 on sn-devel-104
2012-03-14s3:smb2_server: fix a compiler warningChristian Ambach1-2/+2
Autobuild-User: Christian Ambach <ambi@samba.org> Autobuild-Date: Wed Mar 14 16:06:48 CET 2012 on sn-devel-104
2012-03-10s3: Fix a 64-bit warningVolker Lendecke1-1/+1
Autobuild-User: Volker Lendecke <vl@samba.org> Autobuild-Date: Sat Mar 10 15:27:09 CET 2012 on sn-devel-104
2012-03-09Fix up Christian Ambach's multi-credit code - the CreditCharge field is a ↵Jeremy Allison1-2/+2
16-bit int read, not a 32-bit one.
2012-03-09s3:smb2_server validate message ids with largemtuChristian Ambach1-27/+56
Signed-off-by: Jeremy Allison <jra@samba.org>
2012-03-09s3:smb2_server add function to verify creditchargeChristian Ambach1-0/+39
Signed-off-by: Jeremy Allison <jra@samba.org>
2012-03-02s3:smb2_server fix a typoChristian Ambach1-1/+1
2012-02-27libcli/smb/smb2_signing: pass down 'protocol' to smb2_signing_[sign|check]_pdu()Stefan Metzmacher1-0/+4
metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Mon Feb 27 14:26:32 CET 2012 on sn-devel-104
2012-02-18Fix a bunch of "unused variable" warnings.Jeremy Allison1-2/+0
Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Sat Feb 18 06:22:40 CET 2012 on sn-devel-104
2011-12-12s3:smb2_server: use sconn->ev_ctx instead of sconn->smb2.event_ctxStefan Metzmacher1-9/+7
metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Mon Dec 12 16:08:59 CET 2011 on sn-devel-104
2011-12-12s3:smbd: remember the event context on smbd_server_connectionStefan Metzmacher1-1/+1
metze
2011-11-15Ensure we correctly calculate reply credits over all returnedJeremy Allison1-4/+13
SMB2 replies, and do as Windows does and return the total in the last SMB2 reply. Fixes an issue found by Christian M Ambach <christian.ambach@de.ibm.com> (and thanks to Christian for the initial patch this was based on).
2011-11-15s3:smb2_server: pass explicit defer_times to smbd_smb2_request_pending_queue()Stefan Metzmacher1-2/+2
metze
2011-11-15s3:smb2_server: always send STATUS_PENDING responses, but delayed by 0.5 ↵Stefan Metzmacher1-105/+120
milliseconds In future we'll pass the delay from the caller. metze
2011-11-09s3:smb2_server: grant credits in async interim responses (bug #8357)Stefan Metzmacher1-1/+3
The first fix for bug #8357 intruduced a regression, so that we no longer grant credits for real async interim responses with STATUS_PENDING. metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Wed Nov 9 11:56:29 CET 2011 on sn-devel-104
2011-11-02s3:smb2_server: remove unused outhdr variablesDavid Disseldorp1-2/+0
2011-10-31s3:smb2_server: FLAG_CHAINED means we always use the last session_id and tidStefan Metzmacher1-33/+18
metze
2011-10-31s3:smb2_server: don't reset the tid and session id in the out hdr of ↵Stefan Metzmacher1-14/+0
compound requests Windows also leaves tid (0xFFFFFFFF) and session id (0xFFFFFFFFFFFFFFFF) as the client requested them. metze
2011-10-31s3:smb2_server: echo the SMB2_HDR_CREDIT_CHARGE and SMB2_HDR_SIGNATURE fieldsStefan Metzmacher1-2/+4
Windows just echos back the given values by default. metze
2011-09-29s3-smb2_server: SMB2_OP_IOCTL doesn't require at least 1 dyn byteDavid Disseldorp1-0/+1
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-09-29s3:smb2_server: SMB2_OP_CANCEL requests don't have to be signedStefan Metzmacher1-0/+2
metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Thu Sep 29 02:58:41 CEST 2011 on sn-devel-104
2011-09-23s3:smbd: disconnect the socket if we got an unexpected requestStefan Metzmacher1-0/+20
If we got a SMB2_OP_NEGPROT after the protocol is already negotiated or if we got a non SMB2_OP_NEGPROT before the protocol was negotiated we should close the connection (as windows does). metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Fri Sep 23 12:30:50 CEST 2011 on sn-devel-104
2011-09-23s3:smbd: don't call smbd_terminate_connection in smb2_validate_message_id() ↵Stefan Metzmacher1-2/+3
(bug #8476) Only return false and the caller will terminate the connection. metze
2011-09-22Fix bug #8476 - Samba asserts when SMB2 client breaks the crediting rules.Jeremy Allison1-1/+6
Just drop the connection, not SMB_ASSERT. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Thu Sep 22 19:41:31 CEST 2011 on sn-devel-104
2011-09-14s3:smb2_server: SMB2_OP_GETINFO doesn't require at least 1 dyn byteStefan Metzmacher1-1/+13
metze
2011-09-07s3:smb2_server: add smbd_smb2_request_verify_sizes()Stefan Metzmacher1-0/+42
metze
2011-08-31Fix bug 8429 - Compound SMB2 requests on an IPC connection can corrupt the ↵Jeremy Allison1-12/+17
reply stream. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Wed Aug 31 21:18:11 CEST 2011 on sn-devel-104
2011-08-31Based on metze's fix for Bug 8407 - SMB2 server can return requests ↵Jeremy Allison1-2/+38
out-of-order when processing a compound request. (cherry picked from commit 19db1c98c6ba3cb5e883e16e865c44900ce17444)
2011-08-31s3:smb2_server: keep compound_related on struct smbd_smb2_requestStefan Metzmacher1-4/+3
metze (cherry picked from commit cda93f04eb4e7e975b192a5fd33275ec638140ac)
2011-08-12s3:smb2_server: make sure we prefer responses over requests on the client socketStefan Metzmacher1-12/+52
metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Fri Aug 12 16:46:43 CEST 2011 on sn-devel-104
2011-08-07s3:smb2_server: make sure we grant credits on async read/write operations ↵Stefan Metzmacher1-6/+15
(bug #8357) Currently we skip, the "gone async" interim response on read and write, this caused the aio code path to grant 0 credits to the client in the read/write responses. metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Sun Aug 7 22:23:57 CEST 2011 on sn-devel-104