Age | Commit message (Collapse) | Author | Files | Lines |
|
Jeremy.
(This used to be commit 02b18f2cca6d6d046d2d8fd7375b207d44031ddc)
|
|
the fstype must not be null terminated or win98 doesn't recognise it
(This used to be commit c8a040f2aa733e926280af010513849b6406741d)
|
|
being set. Also prevent an open on a file on a readonly share from
setting delete on close.
Jeremy.
(This used to be commit 1f3dcd99bdd36cd3ff492394e80c3e2037a9aa48)
|
|
Jeremy.
(This used to be commit a58d0f91f9ee7354c01a9c20cfe178d5dc02142d)
|
|
Jeremy.
(This used to be commit 9148bb9eaa67de60c3b0b4709a9c05a840c20c66)
|
|
Jeremy.
(This used to be commit 9ff6b0c20cc88ef0bcd62a596fcb96f898b5b29d)
|
|
Jeremy.
(This used to be commit d20949fe509c1496bc434f0fbf403f0b69ab9954)
|
|
Jeremy.
(This used to be commit c339a99a891c9e4bbad59ee1243908c91f048834)
|
|
Jeremy.
(This used to be commit 36ea09d3a041fab0854dfdc20f6ea8db7ccbec2e)
|
|
Jeremy.
(This used to be commit eba8204bfadb176fafb686a35295a09f0f35b894)
|
|
(This used to be commit dfb8566220c3e90ca2b757ea124f53aed103269e)
|
|
Jeremy.
(This used to be commit ebba334c15619610475a5c8242a55ed4fcdedf7c)
|
|
(This used to be commit 2d0922b0eabfdc0aaf1d0797482fef47ed7fde8e)
|
|
(This used to be commit a95943fde0ad89ae3f2deca2f7ba9cb5ab612b74)
|
|
Jeremy.
(This used to be commit 7816f79075132350c910f75f9b757477a319bbae)
|
|
fsp->share_mode otherwise the check to see if the fsp share mode
matches the one in the db will fail when you come to delete it,
thus leaving us with a share mode on a file that isn't even open!
(This used to be commit 2020738b889d8d508cf787e5c5d380af817b92f9)
|
|
major changes include:
- added NSTATUS type
- added automatic mapping between dos and nt error codes
- changed all ERROR() calls to ERROR_DOS() and many to ERROR_NT()
these calls auto-translate to the client error code system
- got rid of the cached error code and the writebmpx code
We eventually will need to also:
- get rid of BOOL, so we don't lose error info
- replace all ERROR_DOS() calls with ERROR_NT() calls
but that is too much for one night
(This used to be commit 83d9896c1ea8be796192b51a4678c2a3b87f7518)
|
|
(This used to be commit cb8b21f71dbacc7ee658bef7011cd147fbe34101)
|
|
Jeremy.
(This used to be commit faae7512e059456db2450f878c435fd402839146)
|
|
(This used to be commit 00703d306f14a5977df75cb04ee34ae8628ed40e)
|
|
Changed alignment offset to 1 to allow netmon to parse ok.
Jeremy.
(This used to be commit fd89261a2c74910bd1cf8271d862a7b050b49f32)
|
|
Jeremy.
(This used to be commit 3bf2419f4b7a9d46a1d48062212a6a6579c22b92)
|
|
allocation
to be done. Without it just does the ftruncate.
Jeremy.
(This used to be commit 0b052f103e82369088bc30724b86d8892c395cdb)
|
|
Jeremy.
(This used to be commit 82f81c830db53ce507c2a8e65db962f931141afd)
|
|
(This used to be commit d5097b2f20c55ddcf4ae8da4d1d0a2fe91938a6b)
|
|
can't redefine them. damn.
(This used to be commit c41fc06376d1a2b83690612304e85010b5e5f3cf)
|
|
This commit gets rid of all our old codepage handling and replaces it with
iconv. All internal strings in Samba are now in "unix" charset, which may
be multi-byte. See internals.doc and my posting to samba-technical for
a more complete explanation.
(This used to be commit debb471267960e56005a741817ebd227ecfc512a)
|
|
set for a share.
Jeremy.
(This used to be commit 8f57233c0f871763bc3657d754c894dbd29ae501)
|
|
Jeremy.
(This used to be commit e033f758914f6631545af17041b4e49c1ff885d9)
|
|
An-embrace-and-extending we will go...
Jeremy.
(This used to be commit 43bf9b2c7aad15d65bac3a9c4f799be050a074cd)
|
|
cleaned on clients abending connections. Thanks Andrew !
Jeremy.
(This used to be commit 1b3977c5367a0b713b194f369abd9872ae01ac2a)
|
|
Jeremy.
(This used to be commit 30cffea8fa813a7448648b496a19e751441e436e)
|
|
when copying to a full disk problem, I discovered that we were not allowing
the delete on close flag to be set properly, this led to other things, and
after investigation of the proper delete on close semantics and their relationship
to the file_share_delete flag I discovered there were some cases where we
weren't doing the deny modes properly. And this after only 5 years working
on them..... :-) :-).
So here's the latest attempt. I realised the delete on close flag needs to
be set across all smbds with a dev/ino pair open - in addition, the delete
on close flag, allow share delete and delete access requested all need to
be stored in the share mode tdb.
The "delete_on_close" entry in the fsp struct is now redundant and should
really be removed. This may also mean we can get rid of the "iterate_fsp"
calls that I didn't like adding in the first place. Whilst doing this patch,
I also discovered we needed to do the se_map_generic() call for file opens
and POSIX ACL mapping, so I added that also.
This code, although ugly, now passes the deny mode torture tests plus the
delete on close tests I added. I do need to add one more multiple connection
delete on close test to make sure I got the semantics exactly right, plus we
should also (as Andrew suggested) move to random testing here.
The good news is that NT should now correctly delete the file on disk
full error when copying to a disk :-).
Jeremy.
(This used to be commit 51987684bd231c744da2e5f3705fd236d5616173)
|
|
Jeremy.
(This used to be commit 3f9cf2e07bb6d429858e47ab6989ea8cf30d0217)
|
|
Jeremy.
(This used to be commit 1391aa6a6fbe8391a4421f5770da40556f011bb8)
|
|
First one adds a new info level into the lanman printing and an ioctl to the trans2 code.
Andrew - this uses ASCII only. It looks ok to me but please check !
Second one adds a parameter "os2 driver map" that allows OS/2 driver names to be mapped.
Jeremy.
(This used to be commit da79b519e0b6b4317d7fb5260d74e0e74a7e0b46)
|
|
(This used to be commit 899ca6e832c72ea68b0ac76205d18a80c87b34d9)
|
|
(This used to be commit 1d145a37860f7256a081c893e3640f5e18943518)
|
|
(This used to be commit ddee55087756db2a2ac0ee92471d9fea53f38bee)
|
|
it now uses outbuf not inbuf for the unicode flag, which
allows for some server fns to be ascii and means one less
parameter in push calls
(This used to be commit a6dd6662267eeddf368ff0ffba76b45761bf4eeb)
|
|
(This used to be commit 84fc5a7795fe6e3b993649ecc05f6685f8295c02)
|
|
- removes SMB_ALIGNMENT. That macro caused all sorts of problems with
getting unicode aligned right in sub-protocols (such as SMBtrans and
SMBtrans2). I believe the performance reasons for having
SMB_ALIGNMENT has gone away with the new variants of the SMB
protocol anyway, as newer commands tend to have their own internal
alignment.
- fix the locations where we set smb_flg2 to absolute values. We must
never do this if we want a hope of coping with unicode.
- add initial support for unicode on the wire in smbd. Currently
enabled using SMBD_USE_UNICODE environment variable.
(This used to be commit b98b1435e9d8f8622444c9ff33082977e661f16b)
|
|
RPC code to merge with new passdb code.
Currently rpcclient doesn't compile. I'm working on it...
Jeremy.
(This used to be commit 0be41d5158ea4e645e93e8cd30617c038416e549)
|
|
NT sends "delete on close" to cancel a print job copied from the command line.
Deal with this. Merged JohnR's fixes for print job errors.
Jeremy.
(This used to be commit 2060d74e48d62c99a1689ee02ac435b71918ddf0)
|
|
that requires this.
i _know_ that this isn't the right solution and it breaks things,
which is why I am reverting now.
(This used to be commit c2a82a33da1b717b16fb71e597587c806bcf68b3)
|
|
(This used to be commit 9347121ce6888afeae3cdf256b5f0c5b9c58b0bc)
|
|
Jeremy.
(This used to be commit 6e568332254cf60d6a1f411df960ac2ec5f4bf8e)
|
|
Jeremy.
(This used to be commit bcf0a5c316ee8cf333d9d838b041e44a11cb5f1b)
|
|
a byte range lock (write lock only, but Win2k breaks on read lock also so I
do the same) - if you think about why, this is obvious. Also fixed our client
code to do level II oplocks, if requested, and fixed the code where we would
assume the client wanted level II if it advertised itself as being level II
capable - it may not want that.
Jeremy.
(This used to be commit 213cd0b5192307cd4b0026cae94b2f52fb1b0c02)
|
|
I hope not). If you encounter strange file-serving behavior after this
patch then back it out. I analysed our stat() usage and realised we
were doing approx. 3 stat calls per open, and 2 per getattr/setattr.
This patch should fix all that. It causes the stat struct returned
from unix_convert() (which now *must* be passed a valid SMB_STRUCT_STAT
pointer) to be passed through into the open code. This should prevent
the multiple stats that were being done so as not to violate layer
encapsulation in the API's.
Herb - if you could run a NetBench test with this code and do a
padc/par syscall test and also run with the current 2.2.0 code
and test the padc/par syscalls I'd appreciate it - you should
find the number of stat calls reduced - not sure by how much.
The patch depends on unix_convert() actually finding the file
and returning a stat struct, or returning a zero'd out stat
struct if the file didn't exist. I believe we can guarentee this
to be the case - I just wasn't confident enough to make this
an assertion before.
Ok ok - I did write this whilst at the Miami conference.....
sometimes you get a little free time at these things :-).
Jeremy.
(This used to be commit 66a5c05ec46b641224fbe01b30bd7e83571a2a1b)
|