| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
realloc can return NULL in one of two cases - (1) the realloc failed,
(2) realloc succeeded but the new size requested was zero, in which
case this is identical to a free() call.
The error paths dealing with these two cases should be different,
but mostly weren't. Secondly the standard idiom for dealing with
realloc when you know the new size is non-zero is the following :
tmp = realloc(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
However, there were *many* *many* places in Samba where we were
using the old (broken) idiom of :
p = realloc(p, size)
if (!p) {
return error;
}
which will leak the memory pointed to by p on realloc fail.
This commit (hopefully) fixes all these cases by moving to
a standard idiom of :
p = SMB_REALLOC(p, size)
if (!p) {
return error;
}
Where if the realloc returns null due to the realloc failing
or size == 0 we *guarentee* that the storage pointed to by p
has been freed. This allows me to remove a lot of code that
was dealing with the standard (more verbose) method that required
a tmp pointer. This is almost always what you want. When a
realloc fails you never usually want the old memory, you
want to free it and get into your error processing asap.
For the 11 remaining cases where we really do need to keep the
old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR,
which can be used as follows :
tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the
pointer p, even on size == 0 or realloc fail. All this is
done by a hidden extra argument to Realloc(), BOOL free_old_on_error
which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR
macros (and their array counterparts).
It remains to be seen what this will do to our Coverity bug count :-).
Jeremy.
(This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
|
|
artificial RO bit on directories in user profiles when
profile acls = yes.
(This used to be commit b698e83a82f96db4a4a6ffa4b61af50c943deff0)
|
|
trans2findfirst recognises two info levels *not* recognised
by trans2findnext. Add them. Needed for 3.0.21c.
Jeremy.
(This used to be commit bcb87271d60acd4efe666dd061ea2c09b72fd497)
|
|
by saving the UNIX token used to set a delete on close flag,
and using it when doing the delete. libsmbsharemodes.so still
needs updating to cope with this change.
Samba4 torture tests to follow.
Jeremy.
(This used to be commit 23f16cbc2e8cde97c486831e26bcafd4ab4a9654)
|
|
always linearize into little-endian. Should fix all
Solaris issues with this, plus provide a cleaner base
moving forward for cluster-aware Samba where smbd's
can communicate across different compilers/architectures
(eventually these message will have to go cross-machine).
Jeremy.
(This used to be commit d01824b78576a034428e1cef73868d1169057991)
|
|
for #3287.
Jeremy.
(This used to be commit 8680eebbba220eea257c9ea093d5a463afe7bd94)
|
|
to make the dev/inode numbers match what SFU expects.
If we're using 8 byte inodes we'll lose the top 4 bytes
and replace them with a dev_t instead, but this seem
reasonable to ensure uniqueness.
Jeremy.
(This used to be commit e53574d0b43e5525029c89e56331701399013d91)
|
|
revving the minor version number for libsmbsharemodes (we
now have a new _ex interface that takes the share path
as well as the filename). Needed for #3303. Some code written
by SATOH Fumiyasu <fumiya@samba.gr.jp> included in the changes
to locking/locking.c. The smbstatus output is a bit of a mess
and needs overhauling...
Jeremy.
(This used to be commit 9d93af713f8520ca506730dd32aa2b994937eaba)
|
|
of the Samba4 timezone handling code back into Samba3.
Gets rid of "kludge-gmt" and removes the effectiveness
of the parameter "time offset" (I can add this back
in very easily if needed) - it's no longer being
looked at. I'm hoping this will fix the problems people
have been having with DST transitions. I'll start comprehensive
testing tomorrow, but for now all modifications are done.
Splits time get/set functions into srv_XXX and cli_XXX
as they need to look at different timezone offsets.
Get rid of much of the "efficiency" cruft that was
added to Samba back in the day when the C library
timezone handling functions were slow.
Jeremy.
(This used to be commit 414303bc0272f207046b471a0364fa296b67c1f8)
|
|
function. Oops.
Jeremy.
(This used to be commit 7edb26e7657fc01710abe563b941779749409ef2)
|
|
only tell at parse time from the wire if an incoming name
has wildcards or not. If it's a mangled name and we demangle
the demangled name may contain wildcard characters. Ensure
these are ignored.
Jeremy.
(This used to be commit 4cd8e2a96b98ff711905e8c6f416b22440c16062)
|
|
trans2_mkdir/trans2_open/trans2_setfilepathingo.
Jeremy.
(This used to be commit 71c037dfbb0b51e750f2e14533b03d9932778cb0)
|
|
Jeremy.
(This used to be commit af8545806770a7530eecc184bdd230ca14999884)
|
|
(This used to be commit 1599fc38ab2f2beb5d1a240941b879603ce27ae6)
|
|
* \PIPE\unixinfo
* winbindd's {group,alias}membership new functions
* winbindd's lookupsids() functionality
* swat (trunk changes to be reverted as per discussion with Deryck)
(This used to be commit 939c3cb5d78e3a2236209b296aa8aba8bdce32d3)
|
|
More to follow.
Jeremy.
(This used to be commit aa882646854325aa201b66d0ba27026946ce8dcb)
|
|
reply bugs.
Jeremy.
(This used to be commit 3ec6fc8d1e34c344f59b8c1a22f3bab556e7fa07)
|
|
Jeremy.
(This used to be commit 076023df8ea7c0f03baf8102e55d347e05542c7b)
|
|
Jeremy.
(This used to be commit 8558001b38786b7ff16d90d80d183b0277d74e16)
|
|
tests on this as it's very late NY time (just wanted to get this work
into the tree). I'll test this over the weekend....
Jerry - in looking at the difference between the two trees there
seem to be some printing/ntprinting.c and registry changes we might
want to examine to try keep in sync.
Jeremy.
(This used to be commit c7fe18761e2c753afbffd3a78abff46472a9b8eb)
|
|
Jeremy.
(This used to be commit 1de27da47051af08790317f5b48b02719d6b9934)
|
|
directory/insane app
problem. Rev vfs version. Doesn't change the normal codepath.
Jeremy.
(This used to be commit 0f03a6bdcdbdf60da81e0aeffa84ac6e48fc6a04)
|
|
pathnames.
ie. files containing : and \ can be accessed from Linux.
Jeremy.
(This used to be commit e9b8d23d6138d909a65ea70b2e801881e8333b38)
|
|
Jeremy.
(This used to be commit 06b40024f3784778a81ae7c69881a516d183a1c3)
|
|
Jeremy.
(This used to be commit aea58e6bb60565430aec69598c47b2a8f4667e89)
|
|
the wire. Jerry do not merge this please. New SMB_SET_FS_INFO - level
0x200 as was discussed on the mailing list.
Jeremy.
(This used to be commit 55029b1a0c9ae5b941eecd699dd905ea3d42b99c)
|
|
Jeremy.
(This used to be commit 0d303ab2f30f6047fc3f2f6fc4916e93704959d2)
|
|
code :-).
Getting medieval on our ass about memset....
Jeremy.
(This used to be commit d0c804bc353afa1712de3885071712af1daffb11)
|
|
By removing unneeded memsets in qfilepathinfo I just improved our netbench performance
by *********15%**********. Check it out :-).
Jeremy.
(This used to be commit c20a7b10b6a82db6df349fa5e6f2fcf3eeefec58)
|
|
Jeremy.
(This used to be commit 619d0aeebba66624ea0f5c7cff1c637738275b84)
|
|
as they'll just return ENOSYS if we don't. Add new CAP for
POSIX pathnames, prepare to allow FSINFO set for client POSIX
caps.
Jeremy.
(This used to be commit 4d99b57aedba8431ef5827d1e75413a10b35e1ce)
|
|
Jeremy.
(This used to be commit 2673ccd19f194d1f7756a154afe4200e386ca1b3)
|
|
char).
Jeremy.
(This used to be commit b1bfa9cb37deb22d1d08bc60ba44d61334f6446e)
|
|
mangled names
if mangled names is off.
Jeremy.
(This used to be commit b2330c38881baceaafe1ef6b7ce00d1b5cd8d5c7)
|
|
trans2 call info from the primary trans2 packet as it isn't present
in secondary transs packets. We only need to do this for functions that
satisfy more than one case in the switch statement. Found by Marcel Müller <mueller@maazl.de>.
Jeremy.
(This used to be commit 62edc3d5dc68fbfe6cd77c588791453e29274dd9)
|
|
bug,
fix trans2 and nttrans secondary packet processing. We were being too strict checking
the incoming packet (by 1 byte).
Jeremy.
(This used to be commit 3eea1ff4b7428325c7f304bcac61d6297209a4b8)
|
|
Jeremy.
(This used to be commit 6c9f227ef400f32def85268f411691b569d29889)
|
|
terminate
once we've done that and not "break" into the generic file metadata set code.
Jeremy.
(This used to be commit f1e12be9ed0ca0077bac8e5f32051758e1d84ad7)
|
|
the 2 BOOL flags in dfs_redirect() down to one since
they both are used in essentially the same context
(from what we can tell).
Tested Win98SE, WinXP sp 1 & 2, Win2k3 sp1, and WIn2k Sp4.
All dfs operations still seem to work.
(This used to be commit 59ffacf59c98f2f8277d76ec22712e438fd40618)
|
|
We did need the special case for RESOLVE_DFSPATH
in the findfirst() code.
Jeremy, please verify I haven't broken the allow_wcard
code you added to resolve_dfs_path()
(This used to be commit 29983398e2f7f1dc609d4d981e20f594918243bb)
|
|
(This used to be commit efea76ac71412f8622cd233912309e91b9ea52da)
|
|
Fix strange allocation semantics of openX.
Jeremy.
(This used to be commit da5a8b539d39d2765de22c3e55e9f284992ff966)
|
|
Jeremy.
(This used to be commit 65970dfc5b8f174fe29201789d6ddcf8802ad48c)
|
|
Jeremy.
(This used to be commit 0c7de7615bf0edbb36a3afee445db13a71e26d2e)
|
|
nastyness.
Jeremy.
(This used to be commit d3379fe61bb934082b51a37adac232a96bafcf46)
|
|
oplock requests and no one noticed. Hmmm. Don't think this is a commonly
used codepath :-).
Jeremy.
(This used to be commit 75a0c11de4b7baf693e5c62e690e4bb26554f8e2)
|
|
nttrans_create.
Jeremy.
(This used to be commit 989fcb4c084c63f1e3b114af68ef5bc0a2fbc09e)
|
|
Jeremy.
(This used to be commit 106f91ff65acd23a7dda4d0ec89ae41ecb28153e)
|
|
external to buffer. Needed to add EA code to create calls.
Jeremy.
(This used to be commit 7c4262d6ba48695c2622ea2eba8da6ac889ce543)
|
|
I believe. Reported as fixed by Marcel Müller <mueller@maazl.de>.
Jeremy.
(This used to be commit 14eab937a54dd9f02f289d7e2f47c78c834714a3)
|
