Age | Commit message (Collapse) | Author | Files | Lines |
|
(This used to be commit b64df8a3c504ab7749c21ffb26e4771a9a0a328f)
|
|
Found by Metze's code review (thanks Metze !).
Jeremy.
(This used to be commit a7370eea6be29c0e2adf5ae62aa6182b9165e744)
|
|
to unix_convert().
Jeremy.
(This used to be commit 39c211a702e91c34c1a5a689e1b0c4530ea8a1ac)
|
|
the main server code paths. We should now be able to cope with
paths up to PATH_MAX length now.
Final job will be to add the TALLOC_CTX * parameter to
unix_convert to make it explicit (for Volker).
Jeremy.
(This used to be commit 7f0db75fb0f24873577dcb758a2ecee74fdc4297)
|
|
There are now ony 17 pstrings left in reply.c,
and these will be easy to remove (and I'll be
doing that shortly). Had to fix an interesting
bug in pull_ucs2_base_talloc() when a source
string is not null terminated :-).
Jeremy.
(This used to be commit 0c9a8c4dff10974dbffd2a302ae982896122fcc0)
|
|
and make valgrindtest. Final step will be to change srvstr_get_path()
to return talloced memory in the major codepaths.
Jeremy.
(This used to be commit cf6b6f9c3a38b68d2671c753f412772344506742)
|
|
interface. More development will come on top of this. Remove the
"mangled map" parameter.
Jeremy.
(This used to be commit dee8beba7a92b8a3f68bbcc59fd0a827f68c7736)
|
|
This adds the two functions talloc_stackframe() and talloc_tos().
* When a new talloc stackframe is allocated with talloc_stackframe(), then
* the TALLOC_CTX returned with talloc_tos() is reset to that new
* frame. Whenever that stack frame is TALLOC_FREE()'ed, then the reverse
* happens: The previous talloc_tos() is restored.
*
* This API is designed to be robust in the sense that if someone forgets to
* TALLOC_FREE() a stackframe, then the next outer one correctly cleans up and
* resets the talloc_tos().
The original motivation for this patch was to get rid of the
sid_string_static & friends buffers. Explicitly passing talloc context
everywhere clutters code too much for my taste, so an implicit
talloc_tos() is introduced here. Many of these static buffers are
replaced by a single static pointer.
The intended use would thus be that low-level functions can rather
freely push stuff to talloc_tos, the upper layers clean up by freeing
the stackframe. The more of these stackframes are used and correctly
freed the more exact the memory cleanup happens.
This patch removes the main_loop_talloc_ctx, tmp_talloc_ctx and
lp_talloc_ctx (did I forget any?)
So, never do a
tmp_ctx = talloc_init("foo");
anymore, instead, use
tmp_ctx = talloc_stackframe()
:-)
Volker
(This used to be commit 6585ea2cb7f417e14540495b9c7380fe9c8c717b)
|
|
Jeremy, please check ;-)
(This used to be commit 85b64bde7df10ade5ba0abd493d433a7688f0979)
|
|
This was broken when I changed reply_mv to wrap in a open_file_ntcreate
call, unix_convert on the destination was called twice
(This used to be commit fddc9db91175bdb0b7ac6a636f8bef918bd7c1b4)
|
|
Jeremy.
(This used to be commit 43ddfb8c918bd27e2efd3b54077db815da80a53a)
|
|
Jeremy.
(This used to be commit 74d10b09a68f5c06d6b3ceffe0a40818dc84106e)
|
|
Jeremy.
(This used to be commit 6dac315ba1d9b9582c2b573e0785b2f6d627f846)
|
|
to DOS error ERRDOS, ERRfilexists on open calls.
Jeremy.
(This used to be commit 4674486450bbe79ec9b22bcbc23c534365d6798a)
|
|
(This used to be commit 6af85953465789594342f2d199ef5d29462cf34f)
|
|
(This used to be commit 03c5e960a21ae78cdd832a5c760015f7fbd83bd9)
|
|
No idea what I've been smoking here.
Thanks to Stefan for closely looking
(This used to be commit 708f5af2e8c10d9a0d0027e3c31fa23689e746b8)
|
|
This changes send_trans2_replies to not depend on large buffers anymore
and finishes the trans2 conversion.
(This used to be commit b1d133e4ffa8c9b8219ba6e7b83e23ca4bdd1616)
|
|
(This used to be commit 47261fb6fecc036cb1605f46bbe24e9b3661ff8c)
|
|
reply_transs2
(This used to be commit ca26b43e02f25d75e7439c6130f32dc322acd327)
|
|
Fake a struct smb_request here.
Volker
(This used to be commit f712d1c92bee024a165b5facabdac1e2c866d9b1)
|
|
(This used to be commit a55a4d71ffe9ff1395e02f8bb3ad88fe5132fe99)
|
|
(This used to be commit a9c2d75b42be8b0d89ed1e1a2ce2c6ab4284f5ea)
|
|
(This used to be commit e0a708c79b4db4aab84022d568b5e7bf519e4b5a)
|
|
(This used to be commit 8eb016a91e3ec8d1d9d5ae1ec6f92e1e0657d593)
|
|
This *might* break the transport encryption stuff. I need to check that.
(This used to be commit 82b34d7bdbe5c5038810c11540b6b7bc04290653)
|
|
(This used to be commit db4e6781c4d1a9755a3ec45556be8dd935f15bae)
|
|
(This used to be commit 642c58648b2468544e9488cbffe1a8b236949bcc)
|
|
(This used to be commit cdd86497b9830ba5fbc5b4511ed39ca44167faab)
|
|
(This used to be commit 50aa149cefc1da587f110eb0bf0344c737500f5b)
|
|
(This used to be commit 09ed6537b39f72e61043a93fadea33562b07c6c6)
|
|
(This used to be commit a13c42be7548fc0de3e1f6f1eaacbad3046af0d0)
|
|
In a function returning void the "return;" needs to stand alone on some
compilers
(This used to be commit 28affcca8e22b9a147876a60fec28551256bcaa8)
|
|
(This used to be commit 0b84e29120b87bf6fc86df10102f1c4d4f98cdb6)
|
|
(This used to be commit c9c0133d5512e68fcaf22b2abd3343ae944ddb9d)
|
|
(This used to be commit 46d9c51631d099af0f8696d3942eb51b0cb09865)
|
|
(This used to be commit d0b7f409e1ec88bcd695474aa77e75cb50dce013)
|
|
(This used to be commit af1855e4cebb6df3415ca5389b10aaa5a956adc2)
|
|
(This used to be commit 238edebab71ed1596af82f4c8611432f9156bd18)
|
|
It did not use inbuf anyway. Outbuf was used for alignment and to the
flags2. The alignment works ok if we align relative to base_data because this
and outbuf are both malloc'ed, and we put send_trans2_replies aligns out_data
properly relative to the start of the outbuf.
I don't know if the explicit align_string() calls in get_lanman2_dir_entry are
really necessary. I think that srvstr_push also does the same.
Please also note that this changes dst_len in srvstr_push from -1 to the real
length remaining.
Volker
(This used to be commit 9b1614f8cb415c15032e6a34f2da5df026f92e6e)
|
|
This itself won't help much, because send_trans2_replies_new still allocates
the big buffers, but stay tuned :-)
Also add/update my copyright on stuff I recently touched.
Volker
(This used to be commit 248f15ff143474db2493cef89ba446892342a361)
|
|
When starting to convert the individual trans2 subcalls, I need the new
API conventions to be present there. This means that those calls fill in
req->outbuf when there's something to ship
(This used to be commit d9eef977dc80d6ee71898efc1ff736afb75eba0c)
|
|
This is in preparation of the trans2 conversion: srvstr_push should not
look at inbuf directly.
(This used to be commit 5fd7e6a3821bea26d352e3edc23b7a216b1200e5)
|
|
it's needed for some cluster filesystems to
overload this function.
metze
(This used to be commit cdaa24e8047399002e4b287a31a8340a665e580f)
|
|
(This used to be commit eb353412c60fc21a31530d9678505470ffbf11ce)
|
|
This removes the buf==NULL condition in file_fsp(), but wherever it is called
we do have a buffer anyway.
Volker
(This used to be commit d70a1f82fed64fa332f16407bea7c6671f48c59a)
|
|
Minor cleanup
(This used to be commit 04879717229d5b74b94b79a962cca5e9624648bc)
|
|
invalid names sent as a resume name were incorrectly mapped into
. and .. Ensure they really *are . and ..
Jeremy.
(This used to be commit 78d0c5194fe42ad4f096657e2210a15541303a2a)
|
|
if a Windows client had the file open. We were setting
delete on close and returning "ok". The POSIX client then
believed the file was gone (and it wasn't). Fix this to
return SHARING_VIOLATION if there is an existing NTcreateX
open on the file and someone calls POSIX_UNLINK. Still one
more Cthon test to fix but getting closer now. Should
be in 3.0.25c also.
Jeremy.
(This used to be commit 24e625a615447c025b73fed2d3db03c1f11ae596)
|
|
checker.
(This used to be commit 33068885e62f3681644c128e381822d48298ea05)
|