summaryrefslogtreecommitdiff
path: root/source3/smbd
AgeCommit message (Collapse)AuthorFilesLines
2008-04-28Fix bug found by Igor Mammedov <niallain@gmail.com> where we areJeremy Allison1-14/+42
not returning a directory value for a QPATHINFO on a msdfs link with a non-dfs path. Windows does this. Jeremy. (This used to be commit fbd99071f99cadd21aa2b8971f745a323a9cda13)
2008-04-23Fix CLEAR_IF_FIRST handling of messages.tdbVolker Lendecke1-2/+3
We now open messages.tdb even before we do the become_daemon. become_daemon() involves a fork and an immediate exit of the parent, thus the parent_is_longlived argument must be set to false in this case. The parent is not really long lived :-) (This used to be commit 4f4781c6d17fe2db34dd5945fec52a7685448aec)
2008-04-21Remove redundant parameter fd from SMB_VFS_CLOSE().Michael Adam1-1/+1
Now all those redundant fd's have vanished from the VFS API. Michael (This used to be commit 14294535512a7f191c5008e622b6708e417854ae)
2008-04-21Move the posix pending close functionality down into the VFS layer.Michael Adam1-1/+9
This hides the pending close fds from the outside. Call order of SMB_VFS_CLOSE is reversed. Originally, it was: fd_close -> fd_close_posix -> SMB_VFS_CLOSE -> close And now it is: fd_close -> SMB_VFS_CLOSE -> fd_close_posix -> close This is in preparation of removing the fd parameter from the SMB_VFS_CLOSE function. But it is also the right place for the pending close calls anyways. Michael (This used to be commit 3cf56b124a2886c6260455bba4bf77d08e9a4f77)
2008-04-20Refactoring: Make struct rpc_pipe_client its own talloc parentVolker Lendecke1-1/+2
(This used to be commit a6d74a5a562b54f0b36934965f545fdeb1e8b34a)
2008-04-19Fix bug 5398Volker Lendecke1-3/+3
Thanks to Jason Mader for sending the compiler output :-) Volker (This used to be commit 7a57c2da1a6cc0fcea0b4d949c696219f1822694)
2008-04-18smbd: create the messaging conntext earlierStefan Metzmacher1-11/+16
metze (This used to be commit 658d8475336c4397e0dad341f216baf9e1eb6aaf)
2008-04-18smbd: call reinit_after_fork() in the needed placesStefan Metzmacher1-16/+6
metze (This used to be commit 425b3513a45cf98b53235470a3536be86d56d1c2)
2008-04-18smbd: merge "smbd:backgroundqueue=no" option from the v3-0-ctdb treeStefan Metzmacher1-2/+4
metze (This used to be commit 16d295d466eb18e3bccce6fb26d53012d5f2c3e8)
2008-04-14Remove two pointless else branchesVolker Lendecke1-7/+5
(This used to be commit ed343114cd0844a7fd14b45f95c0f43a6d172a42)
2008-04-14Fix some "ignoring asprintf result" warningsVolker Lendecke2-20/+21
(This used to be commit 155d62ddfd3584d44a493c2aa1ea7f096bcff432)
2008-04-14Use more error-prone form of testing dm_destroy_session() return code after ↵Alexander Bokovoy1-1/+1
discussing with Tridge (This used to be commit 4abdbad52e456764bca1b17ead04edee1e2a2a64)
2008-04-13registry: rename init_registry() to registry_init_full() for consistency.Michael Adam1-1/+1
Michael (This used to be commit 14d82708d4499b48830d3dd25a0133f00a39d030)
2008-04-13registry: change init_registry() to return WERROR instead of bool.Michael Adam1-1/+1
Michael (This used to be commit 0b196095dbbc29c796cb0742fe6e57a421e9596b)
2008-04-12dbwrap: wait for tdb2 change notifies in smbd, nmbd and winbinddStefan Metzmacher1-1/+5
metze (This used to be commit 64450cc1e441355aa8925b7183e90872eeab20b1)
2008-04-11Cleanup size_t return values in convert_string_allocateTim Prouty1-4/+3
This patch is the first iteration of an inside-out conversion to cleanup functions in charcnv.c returning size_t == -1 to indicate failure. (This used to be commit 59124382d2894a1b194b48dd82bc5f956959eb48)
2008-04-11Fix bug 5366Volker Lendecke1-1/+6
(This used to be commit 448a8fe6c15bc4e85149d1ae821f0ebc2e3edde5)
2008-04-08Fix the build of reply_setattrE().Günther Deschner1-2/+2
How ever could this compile ? Guenther (This used to be commit 02f5f35e5ed3b061cfd020d0b13014c72fced5f4)
2008-04-08Destroy DMAPI session when main smbd daemon exits.Alexander Bokovoy2-0/+33
DMAPI session is precious resource maintained at kernel level. We open one of them and use across multiple smbd daemons but once last of them exits, DMAPI session needs to be destroyed. There are some HSM implementations which fail to shutdown when opened DMAPI sessions left. Ensure we shutdown our session when it is really not needed anymore. This is what recommended by DMAPI specification anyway. (This used to be commit a0cefd44009d414fa00ec6e08c70d21b74acdbcb)
2008-04-07Rewrite the wrap checks to deal with gcc 4.x optimisations.Jeremy Allison3-101/+142
Karolin, please pull once Volker has reviewed. Thanks. Jeremy. (This used to be commit 09852899cadc48abe2f2651ecbceaf881198e648)
2008-04-07Remove unused variable.James Peach1-1/+0
(This used to be commit 3ed2c65bde0c2e5ad10cf777dae8a2d3e626a42c)
2008-04-07Fix Kerberos interop with Mac OS X 10.5 clients.Bill Ricker2-23/+33
Ignore optional req_flags. Use the Kerberos mechanism OID negotiated with the client rather than hardcoding OID_KERBEROS5_OLD. (This used to be commit 59a2bcf30fef14ecc826271862b645dd3a61cb48)
2008-04-07smbd: make it possible to change the write time delay for testingStefan Metzmacher1-1/+7
metze (This used to be commit df8c100c2b53575a0d425a2daf52e2d59904746a)
2008-04-07smbd: make it possible to disable get_file_infos() on searchesStefan Metzmacher3-14/+36
metze (This used to be commit 404a865a34c3a7c67131b3f99e92c11b2abe3e39)
2008-04-07locking: combine get_delete_on_close_flag() and get_write_time() into ↵Stefan Metzmacher3-14/+19
get_file_infos() This means we need to fetch the record only once. metze (This used to be commit 4130b873291d39e363184fe4e38dc1f24ebe5056)
2008-04-07smbd: implement the strange write time update logicStefan Metzmacher8-130/+235
We now never call file_ntimes() directly, every update is done via smb_set_file_time(). This let samba3 pass the BASE-DELAYWRITE test. The write time is only updated 2 seconds after the first write() on any open handle to the current time (not the time of the first write). Each handle which had write requests updates the write time to the current time on close(). If the write time is set explicit via setfileinfo or setpathinfo the write time is visible directly and a following close on the same handle doesn't update the write time. metze (This used to be commit 2eab212ea2e1bfd8fa716c2c89b2c042f7ba12ea)
2008-04-07locking: store the write time in the locking.tdbStefan Metzmacher5-12/+24
This is needed to implement the strange write time update logic later. We need to store 2 time timestamps to distinguish between the time the file system had before the first client opened the file and a forced timestamp update. metze (This used to be commit 6aaa2ce0eeb46f6735ec984a2e7aadde7a7f456d)
2008-04-02Fix MSDFS bug noticed by Ofir Azoulay <Ofir.Azoulay@expand.com>.Jeremy Allison1-30/+0
There is no reason to ensure the target host is ourselves, and this breaks MS clients in some cases. Jeremy. (This used to be commit c19fdf43d16ce9fba3e8e12e6192bac31837715e)
2008-04-01smbd: always close the base_fsp even if the real close returned an errorStefan Metzmacher1-4/+0
Otherwise we may end up with share mode entry without an open file. Volker, Jeremy: please check... metze (This used to be commit 547eacf6058d2bc5b41b266b70f8f4747aca4eae)
2008-04-01smbd: ignore nttrans renames as w2k3 doesStefan Metzmacher1-24/+3
This lets us pass the RAW-RENAME test. metze Signed-off-by: Michael Adam <obnox@samba.org> (This used to be commit 2d50a1fef022023588e9963131951f8f3e4c7c23)
2008-03-31Ok, final move of this code :-). I think I've found the correctJeremy Allison1-9/+9
place for it now where it will cause minimal disruption (only call the extra message_dispatch just before reading the next smb off the wire). Jeremy. (This used to be commit da2c19c481d0041872b4ce2f5105052077f3d3b8)
2008-03-31Move the message_dispatch() call after the check for errno onJeremy Allison1-11/+11
the select return. We don't want the call to message_dispatch to mess up the errno value. Jeremy. (This used to be commit 26a74d01bb2b53ffa5d296ff1c7d8b2b0d17831a)
2008-03-31Reduce the race condition in Samba4 in RAW-RENAME test. We rename a fileJeremy Allison1-0/+9
using trans2 setfileinfo on one connection, and then check the file name has changed on the other. In Samba we achieve this by sending a local message to the other process. This change causes us to re-scan for incoming messages after we've woken up from the select (which is cheap if there are no pending messages). This reduces the race significantly. Volker please review. Jeremy. (This used to be commit a7499e994aef743ea9c443f9a1618b262f6eda93)
2008-03-28Fix missing '&&'.Jeremy Allison1-1/+1
Jeremy. (This used to be commit 251df53811e4272b629575a4b50c29a99715ccf9)
2008-03-28Only allow sendfile on non-stream fsp's. Should fix make test for streamsJeremy Allison1-2/+2
as sendfile isn't implemented in the streams vfs modules yet. Jeremy. (This used to be commit eef53e9603d4f3d892ffe00b061def5d717ca481)
2008-03-28Add a talloc context parameter to current_timestring() to fix memleaks.Michael Adam1-1/+1
current_timestring used to return a string talloced to talloc_tos(). When called by DEBUG from a TALLOC_FREE, this produced messages "no talloc stackframe around, leaking memory". For example when used from net conf. This also adds a temporary talloc context to alloc_sub_basic(). For this purpose, the exit strategy is slightly altered: a common exit point is used for success and failure. Michael (This used to be commit 16b5800d4e3a8b88bac67b2550d14e0aaaa302a9)
2008-03-28printclose has only 1 vwvVolker Lendecke1-1/+1
(This used to be commit 99d980125054cbfef8ec85a31e83aa18a6e0bce3)
2008-03-27Fix up the comments on security=share to explain we'reJeremy Allison1-1/+5
ignoring passwords. Jeremy. (This used to be commit e7b6ea46532a26611dfd9d9e2727d52ba6a9cf50)
2008-03-27posix_acls: clarify loop condition code, removing unneeded counter variable.Michael Adam1-7/+2
Coverity ID 545 falsely classified this as a NULL dereferencing bug. By putting the loop of walking the list of aces more naturely not using additional counters, it becomes much more obvious that it is not entered when dir_ace == NULL. The same modifications are done for the file_ace loop. Michael (This used to be commit 6dab6cf0647d7db01e5e472f8b5cf21395b7dbf0)
2008-03-24Missing HAVE_UPDWTMPX check before using updwtmpx().Eric Cronin1-0/+4
In 10.5 Mac OS X added enough utmpx support to make it past the first two preprocessor checks around line 390 of src/smbd/utmp.c and on to the utmpx block which uses updwtmpx(). Unfortunately, as ./configure correctly surmised, 10.5 doesn't have that. https://bugzilla.samba.org/show_bug.cgi?id=5184 (This used to be commit f19d1e3d93d0d9dfe80372c6c5635f1047f9aa88)
2008-03-20smbd: fix session setup with security = share.Michael Adam1-1/+1
Broken by pstring removal in 9ed12bfc48fe7f9b1863a9dd88e881974083053c. Jeremy, please check. Thanks to Yannick Bergeron <yaberger@ca.ibm.com> for noting this. Michael (This used to be commit 008c4bdbe5de064b4469fc1f7c7173290f35b3ef)
2008-03-20Port 3c1f1f0797e from 3-0-ctdbroot1-3/+57
We need to inform ctdb about the client's TCP connection so that after a fail over ctdbd can trigger the client to reconnect very quickly (This used to be commit ddc989886deff173b8a2a2a753a896770efe7545)
2008-03-18[samba-3-0-ctdb.tridge @ tridge@samba.org-20070602053809-kpw5kjkcyjs8yjbl]Andrew Tridgell1-1/+1
suppress that darn message (cherry picked from commit 542e46a21898f6fcc8a0aeb63925607a60e0b99f) (This used to be commit 5e8c624c9c9775f255632717e6898d5f190ba51b)
2008-03-17Some simplificationsVolker Lendecke1-2/+3
(This used to be commit b59b436997fba47afd02ffb6f1194dfaef229d44)
2008-03-17Coverity fixesMarc VanHeyningen2-2/+7
(This used to be commit 3fc85d22590550f0539215d020e4411bf5b14363)
2008-03-12Add a debug message.Michael Adam1-0/+1
Michael (This used to be commit a39807044879ad9df7614e010db6ea16b51000a0)
2008-03-11Using Metze's S4 nttrans rename test, the nttrans renameJeremy Allison1-1/+1
behaves the same as the trans2 one. Jeremy. (This used to be commit c4fa4917dad97c5047f7336c6675739b44da256b)
2008-03-11Metze pointed out this we don't need FILE_ATTRIBUTE_READ here.Jeremy Allison1-1/+1
Jeremy. (This used to be commit 923aa9f330cb370221af6b66cf0f237a9bd06f8e)
2008-03-11Allow us to pass RAW-RENAME by testing that the connection structJeremy Allison1-1/+1
connection paths are equal, not just the conn structs themselves. Jeremy. (This used to be commit 632f3fe66fbcbe3cc25d070c3885177264f5ad65)
2008-03-11Try and fix bug #5315, as well as S4 torture tests RAW-OPLOCK BATCH19,Jeremy Allison3-10/+13
BATCH20 and RAW-RENAME. Jeremy. (This used to be commit 9065792d4bc42522f12f9732de3c0ad82c72a2d3)