Age | Commit message (Collapse) | Author | Files | Lines | |
---|---|---|---|---|---|
2010-04-06 | fix a segfault in the notify subsystem | Christian Ambach | 1 | -5/+16 | |
When the notify_array cannot be loaded correctly, do not keep the half-baked parsing results in the global variable. This can lead to segfaults next time notify_load is entered and the seqnum has not changed. This has been seen in a case where mixed smbd versions were running in a CTDB cluster (versions with and w/o commit c216d1e6 that changed the notify_entry structure). There will be missed notifications until all smbds are at the same software level, but this should be acceptable and is better than crashing and interrupting client operations. This fix cleans up the notify_array, removes the unparseable data from the TDB and returns a fresh notify_array that can be worked with. The NDR_PRINT_DEBUG had to be moved to only be called when the parsing succeeded, it was seen to cause additional segfaults. The status variable is intentionally left to NT_STATUS_OK to not make callers abort and report errors to the clients and make them disconnect. Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com> | |||||
2010-04-05 | Add FSCTL_QUERY_ALLOCATED_RANGES to the list of Windows ioctls we support. | Jeremy Allison | 1 | -0/+52 | |
Based on a patch reported and tested by Ira Cooper <samba@ira.wakeful.net>. Jeremy. | |||||
2010-04-05 | Fix issue with aio where r/w lock wasn't kept across aio read operations. | Jeremy Allison | 2 | -49/+108 | |
Change schedule_aio_read_and_X/schedule_aio_write_and_X to return NTSTATUS. Move the grant and release of the lock into the aio code. Jeremy | |||||
2010-04-01 | Move initialize_async_io_handler() inside of smbd/aio.c. | Jeremy Allison | 2 | -37/+42 | |
Call from actual aio read or write. No reason to call this globally on startup. Jeremy. | |||||
2010-03-31 | Make smbd_lock_socket/smbd_unlock_socket recursive with a ref_count. | Jeremy Allison | 6 | -56/+68 | |
As these always call exit_server, make that part of the function. Use _internal functions for the echo client. Metze please check ! Jeremy. | |||||
2010-03-31 | Fix bug 7310 - DOS attribute inconsistency with MS Office | Jeremy Allison | 1 | -0/+15 | |
On rename we need to set the archive bit on the renamed file. Jeremy | |||||
2010-03-31 | Merge branch 'master' of ssh://git.samba.org/data/git/samba | Jeremy Allison | 1 | -1/+13 | |
2010-03-31 | s3:smbd: handle SMB2 in deadtime_fn() and avoid disconnecting non idle clients | Stefan Metzmacher | 1 | -1/+13 | |
metze | |||||
2010-03-30 | Second part of fix for bug #6494 - Incorrect FileStatus returned in ↵ | Jeremy Allison | 1 | -1/+19 | |
NT_CREATE_ANDX. Ensure we do this in nttrans create too. Jeremy. | |||||
2010-03-30 | Fix for bug #7233 - print fails with jobs >4GB from Win7 clients. | Jeremy Allison | 1 | -4/+12 | |
Contains for by Sebastian Kloska <oncaphillis@snafu.de>. Submitter confirms this fixes the problem. Jeremy. | |||||
2010-03-29 | s3: Attempt to fix the build on AIX, shm_ptr seems to be a macro there | Volker Lendecke | 1 | -5/+6 | |
2010-03-28 | s3: Use bitmap_talloc for smb1 server tcons | Volker Lendecke | 1 | -3/+3 | |
2010-03-28 | s3: Use bitmap_talloc in init_dptrs | Volker Lendecke | 1 | -1/+2 | |
2010-03-28 | s3: Use bitmap_talloc in files.c | Volker Lendecke | 1 | -1/+2 | |
2010-03-28 | s3: Fix typos in a debug message in vfs_init_custom | Volker Lendecke | 1 | -1/+2 | |
2010-03-26 | Revert the part of bug fix #7233 - print fails with jobs >4GB from Win7 clients. | Jeremy Allison | 1 | -22/+4 | |
Submitter reports print file corruption after 2GB when SMBwrite etc. always write at EOF. Still working on the fix. Jeremy. | |||||
2010-03-26 | s3-smbd: Don't close stdout if we want to log to stdout. | Andreas Schneider | 1 | -1/+1 | |
2010-03-25 | Fix bug 7297 - smbd crashes with CUPS printers and no [printers] share defined. | Jeremy Allison | 1 | -1/+1 | |
Ensure we don't dereference an array with an index of -1. Jeremy. | |||||
2010-03-25 | s3: Add a comment to notify_internal_parent_init, this is pretty confusing | Volker Lendecke | 1 | -0/+6 | |
2010-03-25 | s3: Make sure our CLEAR_IF_FIRST optimization works for serverid.tdb | Volker Lendecke | 1 | -0/+4 | |
In the child, we fully re-open serverid.tdb, which leads to one fcntl lock for CLEAR_IF_FIRST detection per smbd. This opens the tdb in the parent and holds it, so that tdb_reopen_all correctly catches the CLEAR_IF_FIRST bit. | |||||
2010-03-25 | s3: Make sure our CLEAR_IF_FIRST optimization works for the notify tdbs | Volker Lendecke | 2 | -0/+31 | |
The notify tdb files are opened at tconX time, which leads to one fcntl lock for CLEAR_IF_FIRST detection per smbd. This opens the tdbs in the parent and holds it, so that tdb_reopen_all correctly catches the CLEAR_IF_FIRST bit. | |||||
2010-03-25 | s3: Make sure our CLEAR_IF_FIRST optimization works for messaging.tdb | Volker Lendecke | 1 | -0/+4 | |
In the child, we fully re-open messaging.tdb, which leads to one fcntl lock for CLEAR_IF_FIRST detection per smbd. This opens the tdb in the parent and holds it, so that tdb_reopen_all correctly catches the CLEAR_IF_FIRST bit. | |||||
2010-03-24 | Fix bug #7233 - print fails with jobs >4GB from Win7 clients. | Jeremy Allison | 1 | -25/+53 | |
Ensure we always write at end-of-file for older write calls. Jeremy. | |||||
2010-03-24 | Fix valgrind warning when source and dest stat are identical. | Jeremy Allison | 1 | -1/+3 | |
Jeremy. | |||||
2010-03-22 | s3: Implement an asynchronous echo responder process | Volker Lendecke | 1 | -19/+478 | |
This replies to echo requests when the main smbd is stuck somewhere Signed-off-by: Stefan Metzmacher <metze@samba.org> | |||||
2010-03-22 | s3:smbd: don't allow SMB2 if the async echo handler is active | Stefan Metzmacher | 1 | -1/+2 | |
metze | |||||
2010-03-22 | s3:smbd: disable SMB encryption when the echo handler is active | Stefan Metzmacher | 1 | -0/+10 | |
metze | |||||
2010-03-22 | s3:smbd: disallow readbraw and writebraw if the echo handler is active | Stefan Metzmacher | 1 | -0/+17 | |
metze | |||||
2010-03-22 | s3:smbd: disable sendfile if the echo handler is active | Stefan Metzmacher | 1 | -0/+4 | |
metze | |||||
2010-03-22 | s3:smbd: don't use recvfile if the echo handler is active | Stefan Metzmacher | 1 | -1/+2 | |
metze | |||||
2010-03-22 | s3:smbd: setup a shared memory area for the signing state | Stefan Metzmacher | 1 | -0/+80 | |
metze | |||||
2010-03-22 | s3:smbd: add echo handler information to struct smbd_server_connection | Stefan Metzmacher | 2 | -0/+22 | |
metze | |||||
2010-03-22 | s3:smbd: pass down trusted_channel via receive_smb_talloc() | Stefan Metzmacher | 1 | -3/+5 | |
metze | |||||
2010-03-22 | s3:smbd: let reply_readbraw_error use the locked socket | Stefan Metzmacher | 1 | -0/+11 | |
metze | |||||
2010-03-22 | s3:smbd: send keepalive packets under the socket lock | Stefan Metzmacher | 1 | -1/+16 | |
metze | |||||
2010-03-22 | s3:smbd: smbd_[un]lock_socket() while accessing the socket to the client | Stefan Metzmacher | 1 | -1/+24 | |
metze | |||||
2010-03-22 | s3:smbd: add smbd_[un]lock_socket() dummies | Stefan Metzmacher | 2 | -0/+13 | |
metze | |||||
2010-03-22 | s3:smbd: add an option to skip signings checks srv_check_sign_mac for ↵ | Stefan Metzmacher | 2 | -2/+24 | |
trusted channels metze | |||||
2010-03-22 | s3: Add "log writeable files on exit" parameter | Volker Lendecke | 1 | -0/+31 | |
This boolean option controls whether at exit time the server dumps a list of files with debug level 0 that were still open for write. This is an administrative aid to find the files that were potentially corrupt if the network connection died. | |||||
2010-03-22 | s3: file_walk_table -> files_forall | Volker Lendecke | 1 | -1/+1 | |
This is more in line with the rest of the Samba code, like connections_forall etc. | |||||
2010-03-22 | s3: Fix some nonempty blank lines | Volker Lendecke | 2 | -7/+6 | |
2010-03-15 | s3: Fix an uninitialized variable read | Volker Lendecke | 1 | -1/+1 | |
Found by Laurent Gaffie <laurent.gaffie@gmail.com> Thanks for that, Volker | |||||
2010-03-15 | Remove the bool admin_user from conn struct. We no longer look at this to ↵ | Jeremy Allison | 2 | -6/+5 | |
make access decisions. Jeremy. | |||||
2010-03-15 | Fix bug #7188 - Logic error in check of total_data for call_trans2mkdir() | Jeremy Allison | 1 | -16/+13 | |
Make ea data checks identical for trans2open and trans2mkdir. Jeremy. | |||||
2010-03-15 | Remove reference to conn->admin_user in preparation for removal. | Jeremy Allison | 1 | -9/+13 | |
We use (uid_t)0 here not sec_initial_uid() as make test uses a single user context. I will revisit this when all the uid check changes are complete. Jeremy. | |||||
2010-03-15 | Simplify processing of "admin user". If a user is an admin_user ensure their ↵ | Jeremy Allison | 1 | -15/+14 | |
conn token is uid 0. This simplifies change_to_user() and removes special processing of the assignments we pass to set_sec_ctx(). Jeremy. | |||||
2010-03-15 | Switch over to using get_currect_XXX() accessor functions. | Jeremy Allison | 5 | -33/+38 | |
Jeremy. | |||||
2010-03-15 | Pass "connection_struct *conn" into functions that currently use ↵ | Jeremy Allison | 1 | -18/+20 | |
"current_user.XXX" Will allow me to replace them with accessor functions. Jeremy. | |||||
2010-03-15 | Add accessor functions for current uid, gid, unix token, NT token and vuid. | Jeremy Allison | 1 | -0/+43 | |
Jeremy. | |||||
2010-03-15 | Rever e80ceb1d7355c8c46a2ed90d5721cf367640f4e8 "Remove more uses of "extern ↵ | Jeremy Allison | 7 | -122/+66 | |
struct current_user current_user;"." As requested by Volker, split this into smaller commits. Jeremy. |