summaryrefslogtreecommitdiff
path: root/source3/smbd
AgeCommit message (Collapse)AuthorFilesLines
2011-08-31Fix bug 8429 - Compound SMB2 requests on an IPC connection can corrupt the ↵Jeremy Allison1-12/+17
reply stream. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Wed Aug 31 21:18:11 CEST 2011 on sn-devel-104
2011-08-31Based on metze's fix for Bug 8407 - SMB2 server can return requests ↵Jeremy Allison2-2/+39
out-of-order when processing a compound request. (cherry picked from commit 19db1c98c6ba3cb5e883e16e865c44900ce17444)
2011-08-31s3:smb2_server: keep compound_related on struct smbd_smb2_requestStefan Metzmacher2-4/+4
metze (cherry picked from commit cda93f04eb4e7e975b192a5fd33275ec638140ac)
2011-08-31s3: Fix bug 8334, do not fork the echo handler for smb2Volker Lendecke1-1/+2
If a smb1 negprot negotiated smb2 we forked the echo responder. This will eventually lead to a panic from [2011/08/30 10:33:29.212578, 0, pid=3846917] smbd/smb2_server.c:243(smbd_smb2_request_create) Invalid SMB packet: first request: 0x0009 because from the echo responder we always read using the normal smb1 protocol handling routine. If that is a bit down the smb2 stream, we get a non-negprot packet and panic. BTW, the echo responder is not required for smb2 anyway, Microsoft confirmed that it probes the server liveness using TCP keepalives and not smb2 echo requests. Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Wed Aug 31 17:58:48 CEST 2011 on sn-devel-104
2011-08-30s3:smb2 fix Bug 8428 - wrong reply to DHnC (durable handle reconnect)Christian Ambach1-6/+6
According to [MS-SMB2] 3.3.5.9.7 (http://msdn.microsoft.com/en-us/library/cc246784%28v=PROT.13%29.aspx), smbd must reply with NT_STATUS_OBJECT_NAME_NOT_FOUND as it does not support durable file-handles yet. I have seen w2k8r2 running xcopy /C ending up in an endless loop trying to get back the original file handle from smbd sending the same requests over and over. Metze, Jeremy, please check! Signed-off-by: Jeremy Allison <jra@samba.org> Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Tue Aug 30 22:20:36 CEST 2011 on sn-devel-104
2011-08-29Fix bug 8412 - Microsoft Office 2007 (Microsoft Word) fails to save as on a ↵Jeremy Allison2-6/+46
Samba share with SMB2.
2011-08-25s3:smbd: remove an unused variable in dptr_create()Michael Adam1-1/+0
2011-08-25s3: Pass smbd_server_connection to (unused) server_encryption_shutdownVolker Lendecke2-2/+2
2011-08-25s3: Pass smbd_server_connection to srv_encrypt_bufferVolker Lendecke3-3/+5
2011-08-25s3: Pass smbd_server_connection to srv_decrypt_bufferVolker Lendecke3-4/+3
2011-08-25s3: Pass smbd_server_connection to srv_free_enc_bufferVolker Lendecke3-4/+4
2011-08-25s3: Pass smbd_server_connection to is_encrypted_packetVolker Lendecke4-8/+11
2011-08-25s3: Pass sconn to valid_smb_headerVolker Lendecke1-4/+5
2011-08-25s3: Explicitly pass smb_srv_trans_enc_ctx to srv_enc_ctxVolker Lendecke1-3/+3
2011-08-21s3-id_cache: Use better names for id cache management opsAndreas Schneider3-6/+6
The IDMAP term is normally associated with Winbind's idmap stuff. These functions deal with id caching not id mapping. Signed-off-by: Simo Sorce <idra@samba.org>
2011-08-21s3-id_cache: Move id caches mgmt out of smbdAndreas Schneider3-101/+13
We must leave the MSG_IDMAP_KILL operation in SMBD as it uses smbd specific internal globals and makes sense only in the context of a smbd daemon. The rest is moved under lib/ as we need to deal with id cache cleanups in other daemons too (like lsasd). Signed-off-by: Simo Sorce <idra@samba.org>
2011-08-21s3-rpc_server: Replace RPC_SERVICE_MODE_DAEMON checksSimo Sorce1-7/+7
Use rpc_daemon_type() macros where appropriate instead. Signed-off-by: Andreas Schneider <asn@samba.org> Signed-off-by: Simo Sorce <idra@samba.org>
2011-08-21s3-smbd: Start lsasd as deamon.Andreas Schneider1-4/+15
Signed-off-by: Andreas Schneider <asn@samba.org> Signed-off-by: Simo Sorce <idra@samba.org>
2011-08-19Fix bug #8370 - vfs_chown_fsp broken -- returns in the wrong directoryJeremy Allison1-3/+7
Ensure we always use vfs_ChDir() to keep the singleton cache coherent. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Fri Aug 19 00:43:05 CEST 2011 on sn-devel-104
2011-08-14s3: Fix bug 8360Volker Lendecke1-7/+16
OS/2 sends an unexpected write&x/read&x chain Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Sun Aug 14 08:48:58 CEST 2011 on sn-devel-104
2011-08-13s3-smbd Avoid races creating 'ncaclrpc dir' with epmd in a child processAndrew Bartlett1-0/+9
2011-08-12s3:smb2_server: make sure we prefer responses over requests on the client socketStefan Metzmacher1-12/+52
metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Fri Aug 12 16:46:43 CEST 2011 on sn-devel-104
2011-08-10s3: Adapt msg_idmap.c to Samba coding conventionsVolker Lendecke1-5/+5
2011-08-10s3: Fix some nonempty blank linesVolker Lendecke1-1/+1
2011-08-10s3-printing: Do not try to force reload.Simo Sorce1-2/+2
Be more correct in load printers at startup. If async process have already started we do not need to force a reload, but we just need to load the printers. If other process have not finished initializing it makes no sense to try to force them as they are masking SIGHUP unitl init is done anyway. Signed-off-by: Andreas Schneider <asn@samba.org>
2011-08-10s3-printing: Force pcap reload when all readySimo Sorce2-2/+6
This way we are sure the cache is primed properly and messages can be sent to processes if necessary as all messaging has been set up. Signed-off-by: Andreas Schneider <asn@samba.org>
2011-08-10s3:spoolssd Start spoolssd from printing_subsystem_initSimo Sorce1-22/+8
Use a child for the background updater process Forward printer update messages from spoolss to background update process. Signed-off-by: Andreas Schneider <asn@samba.org>
2011-08-10s3-printing: Rework how the background process is startedSimo Sorce2-0/+3
Signed-off-by: Andreas Schneider <asn@samba.org>
2011-08-10lib-util: Make useful function a common utility.Simo Sorce1-26/+0
Signed-off-by: Andreas Schneider <asn@samba.org>
2011-08-09s3-smbd: Pass tevent context to smbd_server_connection_loop_once().Andreas Schneider3-16/+17
Signed-off-by: Simo Sorce <idra@samba.org>
2011-08-07s3:smb2_server: make sure we grant credits on async read/write operations ↵Stefan Metzmacher1-6/+15
(bug #8357) Currently we skip, the "gone async" interim response on read and write, this caused the aio code path to grant 0 credits to the client in the read/write responses. metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Sun Aug 7 22:23:57 CEST 2011 on sn-devel-104
2011-08-05s3: Make srv_enc_ctx staticVolker Lendecke2-2/+1
Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Fri Aug 5 18:29:24 CEST 2011 on sn-devel-104
2011-08-05s3: Fix a debug messageVolker Lendecke1-1/+1
2011-08-05s3: Fix some nonempty blank linesVolker Lendecke1-3/+3
2011-08-03ntlmssp: Add ntlmssp_blob_matches_magic()Andrew Bartlett2-2/+2
This avoids having the same check in 3 different parts of the code Andrew Bartlett Autobuild-User: Andrew Bartlett <abartlet@samba.org> Autobuild-Date: Wed Aug 3 12:45:04 CEST 2011 on sn-devel-104
2011-08-03s3-auth rename auth_ntlmssp_steal_session_info()Andrew Bartlett2-7/+7
There is no longer any theft of memory as the underlying routines now produce a new auth_session_info for this caller, allocating it on the supplied memory context. Andrew Bartlett
2011-08-03s3-smbd Be consistent with %U subs on guest loginsAndrew Bartlett1-1/+1
The NTLMSSP code always specified "" as the username, and this makes guest logins via the old-style session setup do the same. Andrew Bartlett
2011-08-03s3-auth use auth_generic_start to get full GENSEC in Samba3 session setupAndrew Bartlett4-30/+80
This tests if the auth_generic_start() hook is available on the auth context during the negprot, and if so it uses auth_generic_start() to hook to GENSEC to handle the full SPNEGO blob. Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-08-03s3-smbd clarify behaviour by not passing an OID that will not be usedAndrew Bartlett1-1/+1
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-08-03s3-smbd Ensure we do not read past the end of a possible NTLMSSP blobAndrew Bartlett2-2/+2
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-08-03s3-auth set session_info->sanitized_username in create_local_token()Andrew Bartlett4-33/+6
Rather than passing this value around the callers, and eventually setting it in register_existing_vuid(), we simply pass it to create_local_token(). This also removes the need for auth_ntlmssp_get_username(). Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-08-03s3-ntlmssp Split auth_ntlmssp_start into two functionsAndrew Bartlett3-10/+67
This helps map on to the GENSEC semantics better, and ensures that the full set of desired features are set before the mechanism starts. Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-08-03s3-ntlmssp Remove calls to auth_ntlmssp_and_flags from the serverAndrew Bartlett3-1/+7
This is changed so that the callers ask for the additional flags that they need, starting with no additional flags. This helps to create a proper abstraction layer in ntlmssp_wrap/auth_ntlmssp. Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-08-03s3-ntlmssp Add mem_ctx argument to auth_ntlmssp_updateAndrew Bartlett3-23/+17
This clarifies the lifetime of the returned token. Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-08-03s3-ntlmssp Use auth_ntlmssp_*() functions in more placesAndrew Bartlett1-2/+2
This allows auth_ntlmssp_get_ntlmssp_state() to be removed. Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-08-03s3-auth Move map to guest to directly after the check_password callsAndrew Bartlett2-97/+9
This means we no longer need two different map to guest functions and have consistent logic with fewer layering violations. Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-08-03We don't need check_name() here. All possible paths to dptr_create()Jeremy Allison1-4/+0
have already called check_name. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Wed Aug 3 03:00:55 CEST 2011 on sn-devel-104
2011-08-02s3: Fix smb2 handling error returns from aioVolker Lendecke1-0/+2
Found when reading with aio_fork beyond the end of file. Metze, Jeremy, please check! Without this we get [2011/08/02 21:02:54.082661, 0] lib/util.c:778(smb_panic_s3) PANIC (pid 2302): smbd/smb2_read.c:593: Type mismatch: name[NULL] expected[struct smbd_smb2_read_state] [2011/08/02 21:02:54.094316, 0] lib/util.c:882(log_stack_trace) BACKTRACE: 23 stack frames: #0 bin/smbd(log_stack_trace+0x2d) [0xb72873d8] #1 bin/smbd(smb_panic_s3+0x7c) [0xb7287529] #2 bin/smbd(smb_panic+0x2f) [0xb7277e1f] #3 /root/git/s3-work/source3/bin/libtalloc.so.2 [0xb6c6bc48] #4 /root/git/s3-work/source3/bin/libtalloc.so.2 [0xb6c6ec79] #5 /root/git/s3-work/source3/bin/libtalloc.so.2(_talloc_get_type_abort+0x34) [0xb6c6ecb3] #6 bin/smbd [0xb6fbc405] #7 bin/smbd(_tevent_req_notify_callback+0x4a) [0xb729a85a] #8 bin/smbd [0xb729a888] #9 bin/smbd(_tevent_req_done+0x19) [0xb729aa73] #10 bin/smbd [0xb6fae517] #11 bin/smbd [0xb6fad258] #12 bin/smbd(smbd_aio_complete_aio_ex+0xf5) [0xb6fad6e8] #13 /root/git/inst/modules/vfs/aio_fork.so [0xb66d4992] #14 bin/smbd(run_events_poll+0x400) [0xb7297df2] #15 bin/smbd(smbd_process+0xd75) [0xb6f9d3a7] #16 bin/smbd [0xb756f07b] #17 bin/smbd(run_events_poll+0x400) [0xb7297df2] #18 bin/smbd [0xb7298254] #19 bin/smbd(_tevent_loop_once+0x9e) [0xb72986ac] #20 bin/smbd(main+0x185c) [0xb7570e59] #21 /lib/i686/cmov/libc.so.6(__libc_start_main+0xe5) [0xb6b08455] #22 bin/smbd [0xb6f14e01] Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Tue Aug 2 22:33:15 CEST 2011 on sn-devel-104
2011-08-02s3: Move deferred_open_queue to smbd_server_connectionVolker Lendecke3-10/+12
2011-08-02s3: Pass sconn explicitly to get_deferred_open_message_smbVolker Lendecke1-4/+6