summaryrefslogtreecommitdiff
path: root/source3/smbd
AgeCommit message (Collapse)AuthorFilesLines
2007-10-10r23731: Forgot one reference to inbufVolker Lendecke1-1/+1
(This used to be commit b02115f2ca6aca8655a4ebd1bd0adaa1e50578ce)
2007-10-10r23728: First part of bugfix for #4763. Limit notify responsesJeremy Allison1-0/+12
to client max buf size. Jeremy. (This used to be commit 6113f56919a3cd7fd753808dbbe473603851bc3c)
2007-10-10r23727: Explicitly pass down FLAGS2 to srvstr_get_path.Volker Lendecke3-44/+111
Next step is to remove the bug that in the trans2 code we use the inbuf as the base pointer to decide whether we need ucs2 alignment where we need to use the beginning of the params buffer Jeremy, last one for today to reviw :-) (This used to be commit 18078b9faa3820fb34604063c9079c1ebe3ad47f)
2007-10-10r23726: Explicitly pass down the FLAGS2 field to srvstr_pull_buf. The nextVolker Lendecke7-33/+65
checkin will pull this up to srvstr_get_path. At that point we can get more independent of the inbuf, the base_ptr in pull_string will only be used to satisfy UCS2 alignment constraints. (This used to be commit 836782b07bf133e9b2598c4a089f1c810e4c7754)
2007-10-10r23725: Remove get_current_mid()Volker Lendecke2-26/+33
Jeremy, next one to review :-) (This used to be commit a50555dda7db5e848e337185ed91c41c2557f7be)
2007-10-10r23724: Reduce access to the global inbuf a tiny bit. Add a struct smb_requestVolker Lendecke7-98/+189
that contains some of the fields from the SMB header, removing the need to access inbuf directly. This right now is used only in the open file code & friends, and creating that header is only done when needed. This needs more work, but it is a start. Jeremy, I'm only checking this into 3_0, please review before I merge it to _26. Volker (This used to be commit ca988f4e79e977160d82e86486972afd15d4acf5)
2007-10-10r23683: Check ports are in the correct range (1-65535)Simo Sorce1-2/+2
(This used to be commit 84b193a7d95aa8c00da2a3720ee87a7231e0fc6e)
2007-10-10r23682: Old patch I forgot in one of my 3.0.25 trees.Simo Sorce1-0/+16
Make sure we honour the directive not to allow machine password changes. (This used to be commit 436555f05ceae34d8df2356d1066b6b5e0a07c41)
2007-10-10r23664: Fix incorrect index - should be j not i. How did we everJeremy Allison1-1/+1
live without valgrind :-). Jeremy. (This used to be commit 9b231149c78c8bbfb70c5675cffb652705ba2cd2)
2007-10-10r23663: Fix bug #4308 - Excel save operation corrupts file ACLs.Jeremy Allison1-28/+255
You don't want to know what I discovered about Windows ACLs to make this work :-(. See : http://www.codeproject.com/win32/accessctrl2.asp Search for "Q. How does Inheritance come into this?" for details. Jeremy. (This used to be commit e1d3a80d2bff2e3540637fd741fc149eeca5fb9d)
2007-10-10r23640: When we support the SeSecurity privilage, this is whereJeremy Allison1-0/+21
we'll check it. Jeremy. (This used to be commit 1b73bf79f4f8a2bc408d52a1ce9df47f33fb3a87)
2007-10-10r23620: Convert set_nt_acl to return NTSTATUS. Also fix the chownJeremy Allison2-65/+36
return to correctly return NT_STATUS_INVALID_OWNER if it should be disallowed. Matches better what W2K3R3 does. NFSv4 ACL module owners, please examine these changes. Jeremy. (This used to be commit fc6899a5506b272f8cd5f5837ca13300b4e69a5f)
2007-10-10r23589: Ensure we will always release any timeout handlerJeremy Allison2-6/+7
on fsp close or removal of oplock. Mulitple removals are safe. Jeremy. (This used to be commit 6de0970704b3eff2b71e6bf499c6dda45d4d5e2d)
2007-10-10r23538: Fix for wild-card rename: We can't return directly on error, we need toVolker Lendecke1-2/+2
CloseDir. (This used to be commit 48cdafc10a0eb615d79057ec9e235ffe9a85e016)
2007-10-10r23537: Revert the inbuf/outbuf part of r23528: This caused the Solaris CC ↵Volker Lendecke1-10/+54
make test to break. The Solaris CC put the static char InBuffer[TOTAL_BUFFER_SIZE] on an odd address, the malloc'ed one is always aligned. The problem showed up in pull_ucs2, ucs2_align uses the address of InBuffer as an indication whether to bump up the src of the string by one. Unfortunately in the trans calls the data portion is malloced and thus has different alignment guarantees than a static variable. This one is bigger.... Volker (This used to be commit 6affd7818f6981be2a9f44fcf302e7fddb468347)
2007-10-10r23528: Two changes to make the valgrind massif (heap profiler) output readable:Volker Lendecke1-54/+10
Remove the allocated inbuf/output. In async I/O we copy the buffers explicitly now, so NewInBuffer is called exactly once. This does not reduce memory footprint, but removes one of the larger chunks that clobber the rest of the massif output In getgroups_unix_user on Linux 2.6 we allocated 64k groups x 4 bytes per group x 2 (once in the routine itself and once in libc) = 512k just to throw it away directly again. This reduces it do a more typical limit of 32 groups per user. We certainly cope with overflow fine if 32 is not enough. Not 100% sure about this one, a DEVELOPER only thing? (This used to be commit 009af0909944e0f303c5d496b56fb65ca40a41d5)
2007-10-10r23523: Gaa -- had renamed "name" to "path" and apparently not compiled afterVolker Lendecke1-1/+1
that.... Volker (This used to be commit 1a45ea28ced3775acd6127e05e844873ed23d40b)
2007-10-10r23522: Save us a kilobyte stack space in a hot code path: I can't see a reasonVolker Lendecke2-33/+28
why check_path_syntax should not be able to run in-line. The destination pointer either walks side by side with the source pointer or is decremented. So as far as I can see s>=d is true throughout the whole routine. Jeremy, I'm checking this only into 3_0 for now. Please review and ack or directly merge this to 3_0_26. Thanks, Volker (This used to be commit 34a13c82a3b72d6900614b57c58fbaefeeca8fa7)
2007-10-10r23518: Remove the silly assumption that string_replace requires a pstring.Volker Lendecke1-5/+5
Jeremy, I am always very confused about the different length arguments in convert_string and friends. Can you take a look at the change in string_replace and verify it's ok? Thanks! While at it, remove the pstring limit for strhasupper and strhaslower. (This used to be commit e6e5703658aeaeb0cca5d7281095e17553001d4b)
2007-10-10r23517: After Jeremy has given is ack on irc:Volker Lendecke1-179/+61
Change rename_internals to open the file/directory and then call rename_internals_fsp. Two reasons: Remove code duplication and remove a race condition. The race condition was due to the fact that in can_rename the share mode check closed the file and then after that did the rename. (This used to be commit aa16d8a649d1a38593edd5ca94ed2c7d4291911b)
2007-10-10r23510: Tidy calls to smb_panic by removing trailing newlines. Print theJames Peach9-15/+15
failed expression in SMB_ASSERT. (This used to be commit 171dc060e2a576d724eed1ca65636bdafffd7713)
2007-10-10r23508: Fix sync_file() to return NTSTATUS and return thisJeremy Allison3-13/+69
on failure in the write path. Jeremy. (This used to be commit cd3f7dbee809fb40194af0e7509142166e02b252)
2007-10-10r23502: Restore exit-on-idle. Small refactoring for clarity. Exit ifJames Peach1-17/+26
we are idle and we timed out waiting for something to do. (This used to be commit b4ab1a0cd992cf9e966b8edb9796d1eae53db744)
2007-10-10r23501: Move notify_rename before rename_internals_fsp and call it from there.Volker Lendecke1-42/+44
(This used to be commit 8d3828871c561cd05e6461e157db4c0ccddd5f22)
2007-10-10r23500: Two changes to survive the now activated test for rename_internals_fsp:Volker Lendecke2-5/+16
With the target being open we have to return NT_STATUS_ACCESS_DENIED and root_fid != 0 leads to NT_STATUS_INVALID_PARAMETER (This used to be commit b599e5b1e10bdf825b2ce53de4a6ec35726d00f6)
2007-10-10r23486: Ok, this time with a hopefully successful make test in the right place:Volker Lendecke1-18/+33
Remove two local variables (This used to be commit 575e594e936c3cb197945063309f0b424dcdefc8)
2007-10-10r23483: Revert 23482, I must have run 'make test' in the wrong subdir.Volker Lendecke1-14/+18
(This used to be commit 1ce0c582bccc90e54a69b1e70973ed7ccb47cbbb)
2007-10-10r23482: Slightly simplify the rename code: Remove two local variables that areVolker Lendecke1-18/+14
not really needed. (This used to be commit e068e38ef3b364f2c6477f9d8d6ef3b81a6207ca)
2007-10-10r23474: Here's a small patch that disables the libkrb5.so replay cacheGerald Carter1-1/+3
when verifying a ticket from winbindd_pam.c. I've found during multiple, fast, automated SSH logins (such as from a cron script) that the replay cache in MIT's krb5 lib will occasionally fail the krb5_rd_req() as a replay attack. There seems to be a small window during which the MIT krb5 libs could reproduce identical time stamps for ctime and cusec in the authenticator since Unix systems only give back milli-seconds rather than the micro-seconds needed by the authenticator. Checked against MIT 1.5.1. Have not researched how Heimdal does it. My thinking is that if someone can spoof the KDC and TDS services we are pretty hopeless anyways. (This used to be commit cbd33da9f78373e29729325bbab1ae9040712b11)
2007-10-10r23469: Fix a commentVolker Lendecke1-1/+1
(This used to be commit 47cc9359aa1b4d5fcd9469be0b1378030ac388fc)
2007-10-10r23467: Next little simplification: In rename_internals it's a bit pointless toVolker Lendecke1-38/+13
first ask for existence of a file when we do the open_file_ntcreate in can_rename later on anyway. That also gets us the right error message in case the file is not there automatically. (This used to be commit f3d582cb908f95c1b557bda5d41b5a8aff75b124)
2007-10-10r23466: Fix RAW-NOTIFY: by using delete on close the notify is triggered deepVolker Lendecke1-6/+0
inside close_file() already. (This used to be commit 0b29e3ad0f2b1759eb195fb37f1f8667d87f5670)
2007-10-10r23457: After Jeremy's ack:Volker Lendecke1-24/+29
The attached patch removes a little race condition for people with real kernel oplock support, and reduces some code paths. It changes reply_unlink to open_file_ntcreate, set_delete_on_close and close_file. The race condition happens if we break the oplock in can_delete via open_file_ntcreate, we close the file, someone else gets a batch oplock and we try to unlink. It reduces code paths by calling SMB_VFS_UNLINK in 2 fewer places. (This used to be commit 0342ce7057045a362134281bcc7030111276dea0)
2007-10-10r23450: max_params_return is complete fiction when getting a changenotifyJeremy Allison2-18/+6
request. Ignore it. Should fix bug #4689 but more tests and valgrinding will follow. Jeremy. (This used to be commit c23e08cc09b8de860ab9c7ac9d0e7c2502dfccd9)
2007-10-10r23445: Fix suggested by Volker. Don't call rename_open_filesJeremy Allison1-2/+0
if the name wasn't changed. Jeremy. (This used to be commit 7a9629365eb4eb2829982fe2b2bfffd840648e6f)
2007-10-10r23410: Merge the core of the cluster code.Volker Lendecke2-0/+13
I'm 100% certain I've forgotten to merge something, but the main code should be in. It's mainly in dbwrap_ctdb.c, ctdbd_conn.c and messages_ctdbd.c. There should be no changes to the non-cluster case, it does survive make test on my laptop. It survives some very basic tests with ctdbd enables, I did not do the full test suite for clusters yet. Phew... Volker (This used to be commit 15553d6327a3aecdd2b0b94a3656d04bf4106323)
2007-10-10r23398: Support membership of >16 groups on Darwin by making sure we opt in ↵James Peach1-0/+49
to the dynamic group resolution mechanism when switching UNIX credentials. (This used to be commit b5cb21e951550fe836b0ef5febc037af9a7f51ec)
2007-10-10r23393: Support BSD group semantics by making sure that the effective GID is ↵James Peach1-1/+1
always passed as the first GID when calling setgroups(2). (This used to be commit 6ebaf856c1d27f2fbfa0444a5c6c17c4331d2780)
2007-10-10r23391: Second part of the patch for Apple.Jeremy Allison1-14/+22
Change the sequence : gain_root(); sys_setgroups(ngroups, groups); become_id(uid, gid); to a function call : set_unix_security_ctx(uid_t uid, gid_t gid, int ngroups, gid_t *groups) James - should be safe for you to create a Darwin-specific version of this function now. Jeremy. (This used to be commit 8ee982b3678be41ce8b4f4c1df428dcbf897ccbe)
2007-10-10r23390: First part of the patch to make Apple's life easier.Jeremy Allison1-6/+6
Doing this in two stages to make it very easy to review. Context switching must look like : gain_root(); sys_setgroups(ngroups, groups); become_id(uid, gid); Re-arrange order so these three calls are always seen together. Next will be to turn these into a function. Jeremy. (This used to be commit eb537185ee4a3f460709267c843c9303a9bb61b5)
2007-10-10r23375: Fix a 64-bit warningVolker Lendecke1-1/+1
(This used to be commit c592b562fa793c9fb3bd0d84074d4ffaa8f63b64)
2007-10-10r23346: Fix offline caching with XP/Vista. It was an off-by-oneJeremy Allison1-4/+4
in storing the access mask. I shouldn't have made this mistake. Damn. Fixes bug #4673. Jeremy (This used to be commit 84801d4e83786b9de3d0875a317ca9ed8ff5b3e4)
2007-10-10r23299: Fix the build for !WITH_SENDFILE.James Peach1-4/+3
(This used to be commit 87b92e7ebda018f1d6a588748e282dc1a2c50613)
2007-10-10r23272: Fix main event loop - reviewed by Volker.Jeremy Allison1-2/+4
Jeremy. (This used to be commit dfb4cb5d2bd6c50ad2ecfa729d76daccfc43925a)
2007-10-10r23241: In preparation for the cluster messaging import the parent smbd needs toVolker Lendecke1-5/+19
respond to events.c style events. (This used to be commit 476080df3ff19c3c4742928ff50293935e171f99)
2007-10-10r23236: Another bad merge: Correctly free and unlock the session record inVolker Lendecke1-1/+2
session_claim. Jerry, this fixes the hanging smbstatus. Sorry for that, Volker (This used to be commit 86ff82a5df998045185682cf09b2db3d37f01004)
2007-10-10r23221: Fix a bad merge, avoid a memory leak and tdb lock problemVolker Lendecke1-0/+1
(This used to be commit 2e2415655d352708b9799ae5ff4d9276c49cfb3b)
2007-10-10r23220: Add traverse_read to dbwrapVolker Lendecke1-1/+1
(This used to be commit b38dc5ffdfe9fdc2879c57dc181815f06b4747fe)
2007-10-10r23206: remove unreachable codeGerald Carter1-3/+0
(This used to be commit 6e2bb4836fab5e548429613dea431007af3a7995)
2007-10-10r23204: Add MSG_SMB_BRL_VALIDATE. Tridge, this is a bit different from your bzrVolker Lendecke1-0/+2
branch, please check if it fulfils your needs. Two changes: The validation is not done inside the brlock.c traverse_fn, it's done as a separate routine. Secondly, this patch does not call the checker routines in smbcontrol directly but depends on a running smbd. (This used to be commit 7e39d77c1f90d9025cab08918385d140e20ca25b)
generated by cgit (git 2.34.1) at 2024-12-03 14:41:54 +0000