Age | Commit message (Collapse) | Author | Files | Lines |
|
where we meant int. Fix this. Thanks to metze for
pointing this out.
Jeremy.
(This used to be commit 793a9d24a163cb6cf5a3a0aa5ae30e9f8cf4744a)
|
|
jra: POPT_ARG_VAL arguments need int values.
I assume there're more places like this
in the cmdline tools.
Please fix this properly, as my commit is just
a hack to get make test working again.
in samba4 we have a workaround for this see
smbd/server.c
metze
(This used to be commit 9cb1937fe8601e526b5c924930500e0a3b52abd5)
|
|
bugs in various places whilst doing this (places that assumed
BOOL == int). I also need to fix the Samba4 pidl generation
(next checkin).
Jeremy.
(This used to be commit f35a266b3cbb3e5fa6a86be60f34fe340a3ca71f)
|
|
calls. Use the IPv6 varient for get_peer_addr().
Jeremy.
(This used to be commit baf1f52e34ae2465a7a34be1065da29ed97e7bea)
|
|
IPv6 in winbindd, but moves most of the socket functions that were
wrongly in lib/util.c into lib/util_sock.c and provides generic
IPv4/6 independent versions of most things. Still lots of work
to do, but now I can see how I'll fix the access check code.
Nasty part that remains is the name resolution code which is
used to returning arrays of in_addr structs.
Jeremy.
(This used to be commit 3f6bd0e1ec5cc6670f3d08f76fc2cd94c9cd1a08)
|
|
(This used to be commit 183df4754b5f18419f4d8fca2c0fa19919174556)
|
|
(This used to be commit 5c6c8e1fe93f340005110a7833946191659d88ab)
|
|
Why? It moves these structs from the data into the text segment, so they
will never been copy-on-write copied. Not much, but as in German you say
"Kleinvieh macht auch Mist...."
(This used to be commit 0141e64ad4972232de867137064d0dae62da22ee)
|
|
Thanks to Joerg.Bernau at web.de
(This used to be commit 492977016fa66ce0e98a5bdd1c0f00eacdf13f0c)
|
|
(This used to be commit 2f2bdfa0df758104a9a2fcafe49d6215d8753536)
|
|
the ripple effects this causes. utmp has to change etc. Remove some
global varables and store address/port in the unexpected db.
Jeremy.
(This used to be commit 18c6a2211d9e25233d01715b3f78977edcd6d869)
|
|
Jeremy.
(This used to be commit 713277391ae7f81f8545723c919865ff8c07ed86)
|
|
We now accept both \\server\tmp and \server\tmp. There are other places
where this might be necessary, but at least the functionality is a bit
easier now.
(This used to be commit 25cc27df97e9eecb470f99ea934de12f2a0f4df9)
|
|
Jeremy, please check!
(This used to be commit d4eddf88d20b09c450d4358d2ef1bc35736501ff)
|
|
quotas.
Heinrich, I trust you on that, I don't even have compiled this :-)
Volker
(This used to be commit a8312a1d7b7e3ad00265279dd0640261beaa287d)
|
|
to follow. Ensure we don't prepend "./" as a root
directory - this is an invalid pathname for unix_convert().
Jeremy.
(This used to be commit f70ac2e25847e41ecf54ae9d66e3247e1996b152)
|
|
in -1 for maxlen.
Michael
(This used to be commit cd3d652d0d7609fc369ed0743c1fc54c87558438)
|
|
(This used to be commit b64df8a3c504ab7749c21ffb26e4771a9a0a328f)
|
|
Jeremy.
(This used to be commit 37cf2c272751065245dd46708af0a78f1f0c47df)
|
|
new name if unmangling succeeded, not if it
failed. Jerry - please re-test, this should
fix your bug.
Jeremy.
(This used to be commit c215d6e84929b70e4472e19f32ec4f1db7449d90)
|
|
Found by Metze's code review (thanks Metze !).
Jeremy.
(This used to be commit a7370eea6be29c0e2adf5ae62aa6182b9165e744)
|
|
(This used to be commit ea226c5ed97d47649833546d5499213093d1925e)
|
|
contexts. Patch from Tim Prouty <tim.prouty@isilon.com>.
(This used to be commit a136de663f122603e8d34e06027896ff39b35e11)
|
|
Jeremy.
(This used to be commit cfcf7cf03e1be34e6839c1a659c4e8c1b5358c37)
|
|
to unix_convert().
Jeremy.
(This used to be commit 39c211a702e91c34c1a5a689e1b0c4530ea8a1ac)
|
|
which
appears to be a leftover. Should fix the build with profiling enabled.
Jeremy, please check.
Guenther
(This used to be commit 98f2e10e3f7a86b1b30619a25ee15a489ad10d43)
|
|
Jeremy.
(This used to be commit 7632f8fb4003657591778d2b55f546d1737859d1)
|
|
the main server code paths. We should now be able to cope with
paths up to PATH_MAX length now.
Final job will be to add the TALLOC_CTX * parameter to
unix_convert to make it explicit (for Volker).
Jeremy.
(This used to be commit 7f0db75fb0f24873577dcb758a2ecee74fdc4297)
|
|
There are now ony 17 pstrings left in reply.c,
and these will be easy to remove (and I'll be
doing that shortly). Had to fix an interesting
bug in pull_ucs2_base_talloc() when a source
string is not null terminated :-).
Jeremy.
(This used to be commit 0c9a8c4dff10974dbffd2a302ae982896122fcc0)
|
|
Jeremy.
(This used to be commit b3f0d39d11fa18b7bfef6cec88efaf4a2be2d6e0)
|
|
and make valgrindtest. Final step will be to change srvstr_get_path()
to return talloced memory in the major codepaths.
Jeremy.
(This used to be commit cf6b6f9c3a38b68d2671c753f412772344506742)
|
|
This removes file_id_string_static and file_id_string_static2
(This used to be commit 638c848c9afe374feb30e34c494f89b2a6c64f7b)
|
|
Jeremy.
(This used to be commit 2e0999c1df33c192fee5f739070a0e4c3d22dff8)
|
|
interface. More development will come on top of this. Remove the
"mangled map" parameter.
Jeremy.
(This used to be commit dee8beba7a92b8a3f68bbcc59fd0a827f68c7736)
|
|
(This used to be commit df648d47ff3c4e24f439fda839653bda98323100)
|
|
Jeremy.
(This used to be commit c6c8f5a897602d53876fe75e86283d97a394037d)
|
|
Jeremy.
(This used to be commit 0cdf046dae8ba0741bb7786aa4e85c34fc35dade)
|
|
This adds the two functions talloc_stackframe() and talloc_tos().
* When a new talloc stackframe is allocated with talloc_stackframe(), then
* the TALLOC_CTX returned with talloc_tos() is reset to that new
* frame. Whenever that stack frame is TALLOC_FREE()'ed, then the reverse
* happens: The previous talloc_tos() is restored.
*
* This API is designed to be robust in the sense that if someone forgets to
* TALLOC_FREE() a stackframe, then the next outer one correctly cleans up and
* resets the talloc_tos().
The original motivation for this patch was to get rid of the
sid_string_static & friends buffers. Explicitly passing talloc context
everywhere clutters code too much for my taste, so an implicit
talloc_tos() is introduced here. Many of these static buffers are
replaced by a single static pointer.
The intended use would thus be that low-level functions can rather
freely push stuff to talloc_tos, the upper layers clean up by freeing
the stackframe. The more of these stackframes are used and correctly
freed the more exact the memory cleanup happens.
This patch removes the main_loop_talloc_ctx, tmp_talloc_ctx and
lp_talloc_ctx (did I forget any?)
So, never do a
tmp_ctx = talloc_init("foo");
anymore, instead, use
tmp_ctx = talloc_stackframe()
:-)
Volker
(This used to be commit 6585ea2cb7f417e14540495b9c7380fe9c8c717b)
|
|
Ronnie. If a lock timeout expires, we must check we can get the
lock before responding with failure. Volker is writing a torture test.
Jeremy.
(This used to be commit 45380f356b99d575645873b05af17c504b091dc8)
|
|
(This used to be commit 17df313db42199e26d7d2044f6a1d845aacd1a90)
|
|
Jeremy, please check ;-)
(This used to be commit 85b64bde7df10ade5ba0abd493d433a7688f0979)
|
|
Jeremy, there are two remaining diffs in sesssetup.c which I don't really
know which one is right. Can you take a look?
Thanks,
Volker
(This used to be commit d82f35448763eacd564836f34c9aa450b15ea582)
|
|
(This used to be commit c5caea43af154671448df82881efe09a5c982386)
|
|
use of directory name cache, 100 by default. Will be needed
to turn this off for *BSD systems.
Jeremy.
(This used to be commit bea8e9840fd65268e649f813eba10502b0c4d721)
|
|
Jeremy
(This used to be commit fd682c3f397714ebdaf4af3f6d1cbcbab6a2f572)
|
|
- use poptPrintUsage() to give the user more info
metze
(This used to be commit a95d9d1ef99d6a2f77a289f8d2011cae482821b1)
|
|
the first
statement will return positively but prefix_cache_hashes would be NULL
(This used to be commit fdc20894a0deb3c68b834e5d9d466873ca634bed)
|
|
smbd, nmbd and winbindd can be started with invalid options currently.
The first patch attached would be a possible solution.
It contains an exit if an invalid option has been used. The main problem
is, that existing setups with wrong options or missing arguments in start
scripts will break (which is the right behaviour from my point of view).
metze
(This used to be commit 8532e3182ab44d4ac84823e9798293f156192aaf)
|
|
In this error case we would have used "start" not having it initialized
(This used to be commit 751834fff92e85a424152c1642b238daa3060dbd)
|
|
should
have been :-).
Jeremy.
(This used to be commit 41611a22ed852bb74e2ef3f45766c0580ffd3a18)
|