Age | Commit message (Collapse) | Author | Files | Lines |
|
(This used to be commit 48798b5e57fcb2ee7debfe9d5178adef37907f92)
|
|
Jeremy.
(This used to be commit b8d5faac69f3a0c2620a34f9026b4018ebd48bb8)
|
|
wcards. I had forgotten this and had refused to allow
dest to contain wcards. We now pass all the normal
Samba4 smbtorture RAW-RENAME tests.
Jeremy
(This used to be commit 4183c1b49fd5a6107aa87249b7be236af092ed8b)
|
|
from open_file_ntcreate make sure we return it on rename
error.
Jeremy.
(This used to be commit 633f02fb860223585f388e64c1a2d770db52d4f0)
|
|
being returned (false positive). Up debug
level on "open_directory" message.
Jeremy.
(This used to be commit 71a8b8863f8bdcce082c5971d6489a2da3ff4b2c)
|
|
by ensuring we pass in a valid src_len (or zero when appropriate).
Volker is correct in that this is a *horrible* interface and he is
now free to generally clean it up everywhere :-). Go for it Volker !
Jeremy.
(This used to be commit cd991fb839994dd29dc790b655f5597fa1e12843)
|
|
before checking length. Found by Volker.
Jeremy.
(This used to be commit 683c5fce6896236a60145f6d3970566503c39163)
|
|
This involved passing the dirname as argument to a few routines instead of
calling parent_dirname() deep down.
Volker
(This used to be commit 7977fd78652897bb7d4db1c21c5749043428f911)
|
|
(This used to be commit df6362baa0928616c6934950fb9c1264cb27106e)
|
|
together.
Jeremy, I'm 100% sure you watch me closely here, I count on you :-)
Volker
(This used to be commit 02f85265f21607c950639da33bc8fe5d5ffd3cf9)
|
|
name-based (for
directory opens) routines.
Volker
(This used to be commit 4ca921d9aa90bc68d21d40ccf4b1ca0b1d2cbcb1)
|
|
open_directory
we want to follow symlinks.
Volker
(This used to be commit c20bdd219d16abcc60d67f4a21b4fcd661473835)
|
|
(This used to be commit cce911780fc52ea56dccde1879b0891cdf9ea320)
|
|
(This used to be commit 6dd0886b49969d0edfe16861f19d35275217b2af)
|
|
regarding
error messages: We relied upon a stat that a directory did not exist to later
on then do the mkdir or not. This does the mkdir directly and copes with a
potential error.
The second one is more important: It's possible with Samba 3 to do a
ntcreate&x with NTCREATEX_OPTIONS_DIRECTORY and we happily do a NT_STATUS_OK.
Also move up the use_nt_status() logic a bit. I think this does not belong
into the core routines, the smb server as such should take care of it.
Jeremy, do you think this should go to 3.0.24?
I'll update samba4torture when the build farm has picked up this checkin.
Volker
(This used to be commit 472fb11f4968d30cedc9851215c63acd3132f3db)
|
|
now have
tmp_talloc_ctx().
Volker
(This used to be commit 165d28f03a82a1a07d0f86c0d5de4a785ea5c7f0)
|
|
Fixes parts of
raw-open.
Volker
(This used to be commit e4e766c092e19f78a593c08f22ea1d7521be18e7)
|
|
inherit_acl
stuff & friends.
Survives raw-mkdir. I'll activate that tomorrow when all build farm machines
have picked up the changed samba4 torture test.
Volker
(This used to be commit 37e7a3f35f48f5689591c75d41d32c43d3b9b853)
|
|
(This used to be commit 20d3bc3549ef89a6405e186b87b50027d2321ac0)
|
|
Volker
(This used to be commit 9c00ce0bbc809903b5516ef9ea62db13233ea2d4)
|
|
(This used to be commit 88ab54b3b7ec6c0ac1958fca435880e29eeefd69)
|
|
(This used to be commit 4090bc4bca77edafcafa52ecb7dc75ead2779cb5)
|
|
code paths
ncreate does. This is a bit slower (about 10-20%), because it goes touches the
share mode db, but I think not having to call change_owner_to_parent and
friends in fewer places outweighs this. And, mkdir is not the way current
Windows boxes create directories, they do it via the ncreate call.
Volker
(This used to be commit ddae494fbe36e4a74776f71c212b00cce61fbf81)
|
|
send_smb failures should be clean exits. All times when we exit as
a matter of policy should also be clean exits.
(This used to be commit d6382092e72120a3c89ffe81975e8898d454bf06)
|
|
look at
errno, all go straight to ERROR_NT(status).
Volker
(This used to be commit 9d8b48c0ef0af5792b879565915832ee141c853c)
|
|
change_owner_to_parent
a bit closer together: Move the lp_inherit_perms() check into the callers.
Volker
(This used to be commit 0874093e5fff480d8ec442072318525079add633)
|
|
(This used to be commit b24cf79e9ec914ac33f1a20524e5ffa7fe1cba5e)
|
|
(This used to be commit ab45c50da36be316773f9332925dee7dc3eec025)
|
|
off conn->mem_ctx, not the null context so we can
safefy free everything on conn close. Should fix
possible memleak.
Jeremy.
(This used to be commit b33bde7b39953e171f05cdb53b6345ee3a9ec6e7)
|
|
(This used to be commit e710a7d39a662a1a339f3f71c4b051fde1bb5a16)
|
|
(This used to be commit ac3eb7813e33b9a2e78c9158433f7ed62c3b62bb)
|
|
reported by James. Ensure that this function allocates
everything on the temporary context except the return
memory. Never call this with a null mem context, and
now use conn->mem_ctx instead in smbd/service.c.
Remove separate free functions for conn->ngroups
and conn->nt_user_token as they are now always
talloc'ed off the conn->mem_ctx. Future optimization
will be to remove conn->mem_ctx and make all objects
pointed to in the conn struct talloc'ed off conn itself.
Easy to free then :-).
Jeremy.
(This used to be commit f83b6de44f1058811ff94ac72a8a71bd8e49e4e8)
|
|
talloced on the null context.
Jeremy.
(This used to be commit 2c59c4dddceb9cb12848d7ee48257c5e93ea2667)
|
|
we never mix malloc and talloc'ed contexts in the
add_XX_to_array() and add_XX_to_array_unique()
calls. Ensure that these calls always return
False on out of memory, True otherwise and always
check them. Ensure that the relevent parts of
the conn struct and the nt_user_tokens are
TALLOC_DESTROYED not SAFE_FREE'd.
James - this should fix your crash bug in both
branches.
Jeremy.
(This used to be commit 0ffca7559e07500bd09a64b775e230d448ce5c24)
|
|
(This used to be commit a4862f48d085d1f518389f86a410722e91449755)
|
|
(This used to be commit 66e889bbabde6dfd05df46937635a6d3e606cb27)
|
|
on write-only files. Jim please check. Should not affect
Windows clients - I ensured all the relevent Samba4
torture tests still pass.
Jeremy.
(This used to be commit 6df3cac44fb1eafa84f9fc0ce4485242b4cce111)
|
|
The main thing here is a rewrite of srv_winreg_nt.c. The core functionality
has moved to registry/reg_api.c which is then usable by the rest of Samba as
well.
On that way it fixes creating keys with more than one element in the
path. This did not work before.
Two things that sneaked in (sorry :-) is the change of some routines from
NTSTATUS to WERROR the removed "parent" argument to regkey_open_internal.
Volker
(This used to be commit fea52801de8c7b85c578d200c599475680c5339f)
|
|
(This used to be commit 97f150fbbbee4837c15de121b418881241f321e2)
|
|
Freeing memctx is all we need, fix double free stupidity
(This used to be commit 2a7454959e93e5bd11161707d0bd16a431b92351)
|
|
It was missing for security=server/domain/ads
Simo.
(This used to be commit 550f651499c22c3c11594a0a39061a8a9b438d82)
|
|
(This used to be commit defa0a352b32469984126ec5d47aab9ef8d6b61c)
|
|
(This used to be commit 6cab254c49e07b11c170511ec613f0f33914c3e6)
|
|
that don't have capability support. Patch by J Raynor <raynorj@mn.rr.com>.
(This used to be commit 53fe047f35534afc4b56fcbaf135a3ca13df65bd)
|
|
because of this. Probably a show-stopper for 3.0.23d.
Thanks to Alain GORLIER <alain.gorlier@altissemiconductor.com>
for the fix.
Jeremy.
(This used to be commit b167785cbd7911940e16fd2a54ec665857feef5e)
|
|
return an uninitialized sid.
Jeremy.
(This used to be commit 57c60103e7dd8f9907bc2954369ea8db8b3b69ff)
|
|
the vfs layer, since gpfs supports it. Thanks to Volker, Christian,
Mathias, Chetan, and Peter.
(This used to be commit 0620658890fa9c68a9848538728023192319c81a)
|
|
function. Fix from Jim Wang of Wesoft.
Jeremy.
(This used to be commit eb78ce1f550377bfb1fd43f550641cf8a606e973)
|
|
in core dump path.
(This used to be commit 9a51fba71c5fa7082c331e1a78a98638d9aa06cf)
|
|
(This used to be commit 9f0518e0b0d4add7cceac6d4d797edddb0080aaa)
|