Age | Commit message (Collapse) | Author | Files | Lines |
|
(This used to be commit df648d47ff3c4e24f439fda839653bda98323100)
|
|
Jeremy.
(This used to be commit c6c8f5a897602d53876fe75e86283d97a394037d)
|
|
Jeremy.
(This used to be commit 0cdf046dae8ba0741bb7786aa4e85c34fc35dade)
|
|
This adds the two functions talloc_stackframe() and talloc_tos().
* When a new talloc stackframe is allocated with talloc_stackframe(), then
* the TALLOC_CTX returned with talloc_tos() is reset to that new
* frame. Whenever that stack frame is TALLOC_FREE()'ed, then the reverse
* happens: The previous talloc_tos() is restored.
*
* This API is designed to be robust in the sense that if someone forgets to
* TALLOC_FREE() a stackframe, then the next outer one correctly cleans up and
* resets the talloc_tos().
The original motivation for this patch was to get rid of the
sid_string_static & friends buffers. Explicitly passing talloc context
everywhere clutters code too much for my taste, so an implicit
talloc_tos() is introduced here. Many of these static buffers are
replaced by a single static pointer.
The intended use would thus be that low-level functions can rather
freely push stuff to talloc_tos, the upper layers clean up by freeing
the stackframe. The more of these stackframes are used and correctly
freed the more exact the memory cleanup happens.
This patch removes the main_loop_talloc_ctx, tmp_talloc_ctx and
lp_talloc_ctx (did I forget any?)
So, never do a
tmp_ctx = talloc_init("foo");
anymore, instead, use
tmp_ctx = talloc_stackframe()
:-)
Volker
(This used to be commit 6585ea2cb7f417e14540495b9c7380fe9c8c717b)
|
|
Ronnie. If a lock timeout expires, we must check we can get the
lock before responding with failure. Volker is writing a torture test.
Jeremy.
(This used to be commit 45380f356b99d575645873b05af17c504b091dc8)
|
|
(This used to be commit 17df313db42199e26d7d2044f6a1d845aacd1a90)
|
|
Jeremy, please check ;-)
(This used to be commit 85b64bde7df10ade5ba0abd493d433a7688f0979)
|
|
Jeremy, there are two remaining diffs in sesssetup.c which I don't really
know which one is right. Can you take a look?
Thanks,
Volker
(This used to be commit d82f35448763eacd564836f34c9aa450b15ea582)
|
|
(This used to be commit c5caea43af154671448df82881efe09a5c982386)
|
|
use of directory name cache, 100 by default. Will be needed
to turn this off for *BSD systems.
Jeremy.
(This used to be commit bea8e9840fd65268e649f813eba10502b0c4d721)
|
|
Jeremy
(This used to be commit fd682c3f397714ebdaf4af3f6d1cbcbab6a2f572)
|
|
- use poptPrintUsage() to give the user more info
metze
(This used to be commit a95d9d1ef99d6a2f77a289f8d2011cae482821b1)
|
|
the first
statement will return positively but prefix_cache_hashes would be NULL
(This used to be commit fdc20894a0deb3c68b834e5d9d466873ca634bed)
|
|
smbd, nmbd and winbindd can be started with invalid options currently.
The first patch attached would be a possible solution.
It contains an exit if an invalid option has been used. The main problem
is, that existing setups with wrong options or missing arguments in start
scripts will break (which is the right behaviour from my point of view).
metze
(This used to be commit 8532e3182ab44d4ac84823e9798293f156192aaf)
|
|
In this error case we would have used "start" not having it initialized
(This used to be commit 751834fff92e85a424152c1642b238daa3060dbd)
|
|
should
have been :-).
Jeremy.
(This used to be commit 41611a22ed852bb74e2ef3f45766c0580ffd3a18)
|
|
vuid that was allocated whilst the connection is
being constructed and after the connection has been set up.
This is what Windows does and at least one client
(and HP printer) depends on this behaviour. As it
depends on the req struct not yet ported to SAMBA_3_2_0
(Volker, hint hint.... :-) I am not yet adding this
to that branch, but will investigate that tomorrow.
Jeremy.
(This used to be commit a54f2805df92c67e74a6764568eedebe394fd500)
|
|
This API will change anyway when moving away from pstrings.
It took so long to fix, because that rename bug I just fixed gave make
test failures that had nothing to do with this one.
I have samba4 tests for both bugs, will check them in when the build
farm has caught up
(This used to be commit d4f442ed9b145990af4db26859663954ddd70926)
|
|
This was broken when I changed reply_mv to wrap in a open_file_ntcreate
call, unix_convert on the destination was called twice
(This used to be commit fddc9db91175bdb0b7ac6a636f8bef918bd7c1b4)
|
|
With the inbuf consistency checks we have to more correctly fake the
inbuf
(This used to be commit 2b8ecda30fc57bb4027b7208d22d85d213074158)
|
|
Jeremy.
(This used to be commit 9d9ed41f2139051578c35f80112640cffb5f7608)
|
|
Jeremy.
(This used to be commit 267a0ac48d358e1bd10d92238352ca3d867a58d4)
|
|
Jeremy.
(This used to be commit 43ddfb8c918bd27e2efd3b54077db815da80a53a)
|
|
(This used to be commit 01f701ba1ea9859b090aaf8f4ae9722c5502316c)
|
|
part of the string to the caller.
(This used to be commit 301ae3d68bc64c9526eb7d4458584a5ebb151137)
|
|
Jeremy.
(This used to be commit 74d10b09a68f5c06d6b3ceffe0a40818dc84106e)
|
|
Jeremy.
(This used to be commit 6dac315ba1d9b9582c2b573e0785b2f6d627f846)
|
|
to ERRDOS, ERRfilexists for NTCreateX and NTTransCreate.
Jeremy.
(This used to be commit 5b2316d1734765ef6c31ff09beea974d9629d17f)
|
|
to DOS error ERRDOS, ERRfilexists on open calls.
Jeremy.
(This used to be commit 4674486450bbe79ec9b22bcbc23c534365d6798a)
|
|
Jeremy.
(This used to be commit 4d01e0b7443aa4e4d450d705df5762d801172809)
|
|
Jeremy.
(This used to be commit dbd58dd647279def1681d88701e41d8a738c680a)
|
|
Jeremy.
(This used to be commit 9256ec0a20f532c7dd7ddc2d3534336a47e6c2d2)
|
|
(This used to be commit 0fecd8a0c3aaa64e137d2efd3f9cc7705837ea2a)
|
|
Jeremy, I really apologize for doing this, but I just wanted to enjoy
converting the last SMB call :-)
I've left one little task for you there, I'm not certain that checking
the inbuf length is correct here.
Volker
(This used to be commit 1e08fddafda11961f8855423b29c1f8a9a6b4457)
|
|
Talked to both Tridge and Jeremy about this, Tridge said that there is a
special error message persuading OS/2 to fall back to other methods.
The calls now checked in always return the error message we used to
return when "read bmpx = False" was set (the default): ERRSRV, ERRuseSTD.
If someone has a reproducable test case where this is really needed, we
can always dig it up from version control and convert it to the new API.
But that time without that silly parameter, and with a torture test case
for "make test" please :-)
Volker
(This used to be commit d941aae2dfd11609e807bf4ce712571a2e354627)
|
|
write one for this.
Jeremy
(This used to be commit edc17dfcbd21cccaffb76f4ae67fe4b06520f1a9)
|
|
(This used to be commit 6af85953465789594342f2d199ef5d29462cf34f)
|
|
(This used to be commit a8a33c377e38046b4103cf1d59032b97ab6bac9a)
|
|
(This used to be commit 0cb00c54750837ab2d2dc12e4947fedb7d38e878)
|
|
(This used to be commit a5af7ebb7f1d869659fbab187652e68ec4fafbb8)
|
|
(This used to be commit a64bc31098de8694b79eeafd3a226cf519700707)
|
|
(This used to be commit 6b0ad071d85ddd8fbf24386db11688bde49baf81)
|
|
(This used to be commit 1b6add251ca1db565a03407db30884132dd93e7d)
|
|
(This used to be commit 42b07a52b9f4fe147426e9156958cb4d33691678)
|
|
(This used to be commit e528479f56bc936cc60eb95c9738a48de48dbd05)
|
|
(This used to be commit 6def2ee03bb3510f000b1977c4d5293cad4ae364)
|
|
(This used to be commit ca27a718b07949959efaeb49f310123de76af9a0)
|
|
(This used to be commit 01c7426fc0e2af6a955dcb37111ca439fc913d5f)
|
|
(This used to be commit 212f43ddeaa6369e5437ed3915eb066a37bc9014)
|
|
(This used to be commit 30aada0ef8e16ce94035039b63ab140d158009d9)
|