summaryrefslogtreecommitdiff
path: root/source3/smbd
AgeCommit message (Collapse)AuthorFilesLines
2010-09-28s3: Attempt to fix bug 7518Volker Lendecke1-6/+6
If select returns -1, we can't rely on the fd sets. The current code might loop endlessly because when putting an invalid fd (the closed socket?) on the read set, a select implementation might choose not to touch it but directly return with EINVAL. Thus run_events will see the socket readable, which leads to a "return true", and thus a NT_STATUS_RETRY -> same game again. We should never get into this situation, but to me the logfiles given in bug 7518 do not reveal enough information to understand how this can happen.
2010-09-28s3: Increase the debuglevel for connection termination msgsVolker Lendecke1-2/+2
2010-09-28s3: Lift smbd_messaging_context() from open_sockets_smbd()Volker Lendecke1-16/+14
2010-09-28s3: Remove two calls to procid_self()Volker Lendecke1-2/+4
2010-09-28s3: Remove some remaining files.c globals to sconnVolker Lendecke3-53/+49
2010-09-28s3: Remove talloc_autofree_context() from files.cVolker Lendecke2-6/+9
2010-09-28s3: Lift smbd_server_conn from file_find_fdVolker Lendecke2-4/+4
2010-09-28s3: Remove smbd_server_conn from file_fspVolker Lendecke1-1/+1
2010-09-28s3: Slightly simplify file_fnumVolker Lendecke1-2/+15
req==NULL should never happen, see the comment
2010-09-28s3: Remove smbd_server_conn from file_sync_allVolker Lendecke1-1/+1
2010-09-28s3: Remove smbd_server_conn from file_find_subpathVolker Lendecke1-1/+1
2010-09-28s3: Lift smbd_server_conn from file_find_di_firstVolker Lendecke4-8/+11
2010-09-28s3: Lift smbd_server_conn from file_find_difVolker Lendecke4-6/+7
2010-09-28s3: Remove smbd_server_conn from files_forallVolker Lendecke2-6/+6
2010-09-28s3: Remove smbd_server_conn from file_close_userVolker Lendecke2-3/+3
2010-09-28s3: Remove smbd_server_conn from file_close_pidVolker Lendecke2-3/+4
2010-09-28s3: Remove smbd_server_conn from file_close_connVolker Lendecke1-1/+1
2010-09-28s3: Remove smbd_server_conn from file_new and file_freeVolker Lendecke1-2/+2
2010-09-28s3: Lift smbd_server_conn from file_fnumVolker Lendecke1-4/+5
2010-09-28s3: Move "Files" to smbd_server_connectionVolker Lendecke3-17/+16
2010-09-28s3: Remove "server_fd" global variableVolker Lendecke3-9/+4
2010-09-27Small tweak to bugfix for 7698 - Assert causes smbd to panic on invalid ↵Jeremy Allison1-3/+3
NetBIOS session request. Don't just fail to reply on a bad NBT name, just don't do the internal action. Jeremy.
2010-09-27Change to using TDB_INCOMPATIBLE_HASH (the jenkins hash) on allJeremy Allison1-4/+4
TDB_CLEAR_IF_FIRST tdb's. For tdb's like gencache where we open without CLEAR_IF_FIRST and then with CLEAR_IF_FIRST if corrupt this is still safe to use as if opening an existing tdb the new hash will be ignored - it's only used on creating a new tdb not opening an old one. Jeremy.
2010-09-27s3: Make file_fnum staticVolker Lendecke1-1/+1
2010-09-27s3: Remove some unused codeVolker Lendecke1-50/+0
2010-09-27s3: Fix some commentsVolker Lendecke1-2/+2
2010-09-26s3: Remove talloc_autofree_context() from notify_internal_parent_init()Volker Lendecke2-5/+4
2010-09-26Fix bug #7698 - Assert causes smbd to panic on invalid NetBIOS session request.Jeremy Allison2-12/+31
Found by the CodeNomicon test suites at the SNIA plugfest. http://www.codenomicon.com/ If an invalid NetBIOS session request is received the code in name_len() in libsmb/nmblib.c can hit an assert. Re-write name_len() and name_extract() to use "buf/len" pairs and always limit reads. Jeremy.
2010-09-26s3: Remove talloc_autofree_context() from change_to_guest()Volker Lendecke1-1/+1
pass is freed at the exit of this routine
2010-09-26s3: Remove talloc_autofree_context() from serverid_parent_init()Volker Lendecke1-1/+1
2010-09-26s3: Remove talloc_autofree_context() from messaging_tdb_parent_init()Volker Lendecke1-1/+1
2010-09-26s3: Avoid an explicit ZERO_STRUCTVolker Lendecke1-3/+1
2010-09-26s3: Lift talloc_autofree_context() from make_auth_context_fixed()Volker Lendecke1-2/+2
2010-09-26s3: Lift talloc_autofree_context() from make_auth_context_subsystem()Volker Lendecke2-2/+2
2010-09-23Fix bug 7694 - Crash bug with invalid SPNEGO token.Jeremy Allison1-1/+2
Found by the CodeNomicon test suites at the SNIA plugfest. http://www.codenomicon.com/ If an invalid SPNEGO packet contains no OIDs we crash in the SMB1/SMB2 server as we indirect the first returned value OIDs[0], which is returned as NULL. Jeremy.
2010-09-22Thank goodness for code reviews. Volker caught - this should be ↵Jeremy Allison1-1/+1
lp_posix_pathnames() not lp_unix_extensions(). Jeremy.
2010-09-22Fix bug #7693 - smbd changing mode of files on renameJeremy Allison2-8/+10
When using "map archive", don't change the archive bit on renames or writes with UNIX extensions turned on. Jeremy.
2010-09-21s3:registry: move prototype from reg_init_full.c to its own header.Michael Adam1-0/+1
2010-09-20s3-util_sid: use shared dom_sid_compare_auth and dom_sid_equal_X functions.Günther Deschner1-17/+18
Guenther
2010-09-20s3-build: only include ctdbd_conn.h where needed.Günther Deschner2-0/+2
Guenther
2010-09-20s3-build: only include async headers where needed.Günther Deschner1-0/+1
Guenther
2010-09-16libcli/auth/ntlmssp Be clear about talloc parents for session keysAndrew Bartlett1-0/+1
The previous API was not clear as to who owned the returned session key. This fixes a valgrind-found use-after-free in the NTLMSSP key derivation code, and avoids making allocations - we steal and zero instead. Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>
2010-09-15Fix all sid_parse returns to be checked. Tidy up some checks and errorJeremy Allison1-5/+12
messages. Jeremy.
2010-09-16s3-smbd: prevent call_nt_transact_ioctl() crash in FSCTL_FIND_FILES_BY_SID case.Günther Deschner1-1/+4
Jeremy, please check. Guenther
2010-09-15Add check for invalid data size.Jeremy Allison1-1/+8
Jeremy.
2010-09-15s3-rpc_server: Moved ncacn_np declarations in common header file.Simo Sorce2-0/+2
Signed-off-by: Andreas Schneider <asn@samba.org>
2010-09-15s3-rpc_server: Convert rpc_connect_spoolss_pipe into a generic interface.Simo Sorce2-10/+60
This way we have one common way to open internal pipes whether they are shortcircuited or piped to an external process.
2010-09-13Fix bug 7409 - Thousands of reduce_name: couldn't get realpath.Jeremy Allison1-1/+1
Don't log this at level 1 - every EACCES will generate one. Thanks to muehlfeld@medizinische-genetik.de for pointing this out. Jeremy.
2010-09-11s3-privs Convert from user_has_privileges() -> security_token_has_privilege()Andrew Bartlett1-4/+2
This new call is available in the merged privileges code, and takes an enum as the parameter, rather than a bitmask. Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>
2010-09-11s3:auth Remove NT_USER_TOKENAndrew Bartlett4-4/+4
The all UPPER case typedef is no longer the preferred Samba style and this makes it easier to see that this is the IDL-derivied structure Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>